On Mon, Jun 17, 2019 at 7:20 PM Emily Shaffer wrote:
> On Fri, Jun 07, 2019 at 02:21:07AM -0400, Eric Sunshine wrote:
> > On Thu, Jun 6, 2019 at 9:08 PM Emily Shaffer
> > wrote:
> > > +int cmd_walken(int argc, const char **argv, const char *prefix)
> > > +{
> > > + struct option options[]
On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
wrote:
> With this patch, Git can be built using the Microsoft toolchain, via:
>
> make MSVC=1 [DEBUG=1]
>
> Third party libraries are built from source using the open source
> "vcpkg" tool set. See https://github.com/Microsof
On Tue, Jun 18, 2019 at 8:53 AM Jeff King wrote:
>
> Thanks, this looks good to me. I fixed the system headers in xinclude.h,
> but didn't think to check for individual C files including them.
also noticed that after the refactoring some files will include a couple
of headers twice (not an issue,
In multiple remotes mode, git-fetch is launched for n-1 remotes and the
last remote is handled by the current process. Each of these processes
will in turn run 'gc' at the end.
This is not really a problem because even if multiple 'gc --auto' is run
at the same time we still handle it correctly. I
This is probably just my itch. Every time I have to do something with
the index, I need to add a little bit code here, a little bit there to
get a better "view" of the index.
This solves it for me. It allows me to see pretty much everything in the
index (except really low detail stuff like pathnam
Signed-off-by: Nguyễn Thái Ngọc Duy
---
json-writer.c | 14 ++
json-writer.h | 2 ++
split-index.c | 13 -
3 files changed, 28 insertions(+), 1 deletion(-)
diff --git a/json-writer.c b/json-writer.c
index 281bc50b39..70403580ca 100644
--- a/json-writer.c
+++ b/json-write
Signed-off-by: Nguyễn Thái Ngọc Duy
---
fsmonitor.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/fsmonitor.c b/fsmonitor.c
index 1dee0aded1..f6ba437255 100644
--- a/fsmonitor.c
+++ b/fsmonitor.c
@@ -3,6 +3,7 @@
#include "dir.h"
#include "ewah/ewok.h"
#include "fsmonitor.h"
+#in
Signed-off-by: Nguyễn Thái Ngọc Duy
---
read-cache.c | 2 +-
resolve-undo.c | 36 +++-
resolve-undo.h | 4 +++-
3 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/read-cache.c b/read-cache.c
index eec030b3bb..3b5c63f53a 100644
--- a/read-cache.c
++
Signed-off-by: Nguyễn Thái Ngọc Duy
---
read-cache.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/read-cache.c b/read-cache.c
index 3b5c63f53a..04863c3853 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1914,7 +1914,7 @@ struct index_entry_o
Signed-off-by: Nguyễn Thái Ngọc Duy
---
cache-tree.c | 41 -
cache-tree.h | 5 -
read-cache.c | 2 +-
3 files changed, 41 insertions(+), 7 deletions(-)
diff --git a/cache-tree.c b/cache-tree.c
index b13bfaf71e..fc44016fe8 100644
--- a/cache-tree.c
++
The big part of UNTR extension is dumped at the end instead of dumping
as soon as we read it, because we actually "patch" some fields in
untracked_cache_dir with EWAH bitmaps at the end.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
dir.c | 56 ++
So far we don't have a command to basically dump the index file out,
with all its glory details. Checking some info, for example, stat
time, usually involves either writing new code or firing up "xxd" and
decoding values by yourself.
This --json is supposed to help that. It dumps the index in a hu
Signed-off-by: Nguyễn Thái Ngọc Duy
---
read-cache.c | 34 +-
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/read-cache.c b/read-cache.c
index 04863c3853..200834e77e 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1911,7 +1911,7 @@ struct index_ent
Continue the work started in c45af94dbc ("gc: run pre-detach
operations under lock", 2017-07-11).
Now we'll take the lock before we print out "Auto packing the
repository[...]", and we'll optimistically tolerate a locking failure
at that point instead of dying.
This (mostly) solves two issues:
On Wed, Jun 19 2019, Nguyễn Thái Ngọc Duy wrote:
> + die(_("--show-json cannot be used with other --show- options,
> or --with-tree"));
Should be --json, not --show-json, right? I assume --show-json is left
over from an earlier version.
Hi Carlo,
On Tue, 18 Jun 2019, Carlo Arenas wrote:
> shouldn't this also be a problem with builtin/blame.c?
Sharp eyes!
It does not *really* matter as much here, as that file defines that
`DEBUG` constant if it has not yet been defined, but yes, it assumes that
*if* it is defined, then it is se
Hi Eric,
On Tue, 18 Jun 2019, Eric Sunshine wrote:
> On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
> wrote:
> > In MSVC, the DEBUG constant is set automatically whenever compiling with
> > debug information.
> >
> > This is clearly not what was intended in cache-tree.c, so let'
Hi Eric & Hannes,
On Wed, 19 Jun 2019, Eric Sunshine wrote:
> On Wed, Jun 19, 2019 at 2:19 AM Johannes Sixt wrote:
> > Am 19.06.19 um 01:12 schrieb Eric Sunshine:
> > > On Tue, Jun 18, 2019 at 8:24 AM Johannes Schindelin via GitGitGadget
> > > wrote:
> > >> printf ".git\nfatal: Needed a
Hi Eric,
On Wed, 19 Jun 2019, Johannes Schindelin wrote:
> On Wed, 19 Jun 2019, Eric Sunshine wrote:
>
> > On Wed, Jun 19, 2019 at 2:19 AM Johannes Sixt wrote:
> > > Am 19.06.19 um 01:12 schrieb Eric Sunshine:
> > > > On Tue, Jun 18, 2019 at 8:24 AM Johannes Schindelin via GitGitGadget
> > > >
On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:
> This is probably just my itch. Every time I have to do something with
> the index, I need to add a little bit code here, a little bit there to
> get a better "view" of the index.
>
> This solves it for me. It allows me to see pretty much everythi
On Wed, Jun 19, 2019 at 6:58 PM Derrick Stolee wrote:
>
> On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:
> > This is probably just my itch. Every time I have to do something with
> > the index, I need to add a little bit code here, a little bit there to
> > get a better "view" of the index.
> >
On 6/19/2019 8:42 AM, Duy Nguyen wrote:
> On Wed, Jun 19, 2019 at 6:58 PM Derrick Stolee wrote:
>>
>> On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:
>>> This is probably just my itch. Every time I have to do something with
>>> the index, I need to add a little bit code here, a little bit there
Hi Carlo,
On Tue, 18 Jun 2019, Carlo Arenas wrote:
> On Tue, Jun 18, 2019 at 5:26 AM Jeff Hostetler via GitGitGadget
> wrote:
> > diff --git a/compat/mingw.c b/compat/mingw.c
> > index d14d33308d..667285887a 100644
> > --- a/compat/mingw.c
> > +++ b/compat/mingw.c
> > @@ -2388,6 +2388,12 @@ stat
On Wed, Jun 19, 2019 at 5:26 PM Ævar Arnfjörð Bjarmason
wrote:
> This patch is part of a WIP branch I have that's a bit of a mess. It's
> more-gc-detach-under-lock on github.com/avar/git.git. It doesn't apply
> on master because it relies on some previous test work, but for RFC
> purposes I figure
On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:
> So far we don't have a command to basically dump the index file out,
> with all its glory details. Checking some info, for example, stat
> time, usually involves either writing new code or firing up "xxd" and
> decoding values by yourself.
>
> Th
On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:
> + if (jw) {
> + jw_object_inline_begin_object(jw, "resolve-undo");
> + jw_object_intmax(jw, "ext-size", size);
> + jw_object_inline_begin_array(jw, "entries");
> + }
While reading this block, I noticed
On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:> @@ -2266,7 +2271,7 @@ int
do_read_index(struct index_state *istate, const char *path, int must_exist)
>* to multi-thread the reading of the cache entries.
>*/
> if (extension_offset && nr_threads > 1)
> - ieot = r
On Wed, Jun 19, 2019 at 8:18 PM Derrick Stolee wrote:
>
> On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:> @@ -2266,7 +2271,7 @@ int
> do_read_index(struct index_state *istate, const char *path, int must_exist)
> >* to multi-thread the reading of the cache entries.
> >*/
> >
Hello,
I'm trying to configure my git client to update local tags with the
remote ones. Prior to git 2.20 the following option in ~/.gitconfig did
the job:
[remote "origin"]
tagopt = --tags
So the following commands worked as expected and the local tag gets updated:
# Create remote
Emily Shaffer writes:
> Since v3, added a corresponding "--object-names" arg to pair with
> "--no-object-names", and "last-one-wins" logic. Also added a test to
> validate this new arg and the logic.
Thanks for a quick turnaround (unfortunately, I was OOO yesterday
and I am half-sick today, so p
Jeff King writes:
> Subject: [PATCH] interpret-trailers: load default config
>
> The interpret-trailers program does not do the usual loading of config
> via git_default_config(), and thus does not respect many of the usual
> options. In particular, we will not load core.commentChar, even though
On 6/19/2019 9:24 AM, Duy Nguyen wrote:
> On Wed, Jun 19, 2019 at 8:18 PM Derrick Stolee wrote:
>>
>> On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:> @@ -2266,7 +2271,7 @@ int
>> do_read_index(struct index_state *istate, const char *path, int must_exist)
>>>* to multi-thread the readin
Johannes Schindelin writes:
> What I *tried* to suggest is to take my minimal `kwset: allow building
> with GCC 8` together with the other three, as it fixes the build. Without
> it, the build is not fixed under `DEVELOPER=1`, it is still broken.
Ah, of course, we can do that.
Whether we are
Derrick Stolee writes:
> On 6/14/2019 4:50 PM, Junio C Hamano wrote:
>> * ds/commit-graph-incremental (2019-06-12) 16 commits
>> - commit-graph: test --split across alternate without --split
>
> Please hold on this one. I've found multiple issues while integrating
> this with VFS for Git and the
On 6/19/2019 10:32 AM, Junio C Hamano wrote:
> Derrick Stolee writes:
>
>> On 6/14/2019 4:50 PM, Junio C Hamano wrote:
>>> * ds/commit-graph-incremental (2019-06-12) 16 commits
>>> - commit-graph: test --split across alternate without --split
>>
>> Please hold on this one. I've found multiple is
Carlo Marcelo Arenas Belón writes:
> 0620b39b3b ("compat: add a mkstemps() compatibility function", 2009-05-31)
> included a function based on code from libiberty which would result in
> undefined behaviour in platforms where timeval's tv_usec is a 32-bit signed
> type as shown by:
>
> wrapper.c
Jeff King writes:
> I think it _could_ actually just be part of the system /etc/gitconfig,
> though it is kind of big, and Git has a tendency to parse the config
> more than necessary. I wonder if would add a noticeable slowdown.
Yeah, that was what I was wondering too when somebody made a casua
Johannes Sixt writes:
> But /etc/gitconfig would be the wrong place, because it would not be
> updated when a new version ships with new patterns.
>
> I would suggest to install the file as $prefix/share/git-core/userdiff
> although the name "userdiff" sounds like an accident. How about
> .../fil
Hi Eric,
On Wed, 19 Jun 2019, Eric Sunshine wrote:
> On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
> wrote:
> > With this patch, Git can be built using the Microsoft toolchain, via:
> >
> > make MSVC=1 [DEBUG=1]
> >
> > Third party libraries are built from source using
From: Derrick Stolee
Several advanced config settings are highly recommended for clients
using large repositories. Power users learn these one-by-one and
enable them as they see fit. This could be made simpler, to allow
more users to have access to these almost-always beneficial features
(and mor
From: Derrick Stolee
If a repo is large, it likely has many paths in its working directory.
This means the index could be compressed using version 4. Set this as
a default when core.featureAdoptionRate is at least three.
Signed-off-by: Derrick Stolee
---
Documentation/config/core.txt | 3 +++
From: Derrick Stolee
If a repo is large, then it probably has a very large working
directory. In this case, a typical developer's edits usually impact
many fewer paths than the full path set. The sparse treewalk
algorithm is optimized for this case, speeding up 'git push' calls.
Use pack.useSpar
Here is a second run at this RFC, which aims to create a "meta" config
setting that automatically turns on other settings according to a user's
willingness to trade new Git behavior or new feature risk for performance
benefits. The new name for the setting is "core.featureAdoptionRate" and is
an in
Emily Shaffer writes:
> Maybe there's a case for storing them as a set of patch files that are
> revision-controlled somewhere within Documentation/? There was some
> discussion on the IRC a few weeks ago about trying to organize these
> tutorials into their own directory to form a sort of "Git C
Eric Sunshine writes:
> On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
> wrote:
>> In MSVC, the DEBUG constant is set automatically whenever compiling with
>> debug information.
>>
>> This is clearly not what was intended in cache-tree.c, so let's use a less
>> ambiguous constan
Matthew DeVore writes:
> ... By
> removing the parenthesis from the localizable text, we can share strings
> with wt-status.c and remove a cautionary comment to translators.
...
> - /*
> - * TRANSLATORS: make sure this matches "HEAD
> -
On Wed, Jun 19, 2019 at 11:58 AM Jeff King wrote:
>
> While having separate lines that get joined here does make the result
> easier to read, I think it creates some confusion. diff.*.xfuncname in a
> regular config file _doesn't_ behave this way (it's the usual
> last-one-wins, so we expect a sin
On Wed, Jun 19, 2019 at 12:37 PM Jeff King wrote:
>
> On Sat, Jun 15, 2019 at 10:41:44AM +0200, Christian Couder wrote:
>
> > On Fri, Jun 14, 2019 at 5:10 PM Jeff King wrote:
> > >
> > > On Fri, Jun 14, 2019 at 08:35:04PM +0900, Masahiro Yamada wrote:
> > >
> > > > Perhaps, 'git interpret-trailer
Hi Eric,
On Wed, 19 Jun 2019, Eric Sunshine wrote:
> On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
> wrote:
> > This special-cases various signals that are not supported on Windows,
> > such as SIGPIPE. These cause the UCRT to throw asserts (at least in
> > debug mode).
> >
> >
while those two changes (from DEBUG to DEBUG_$foo) are worth doing in
their own merit, I am more inclined to consider this as orthogonal
since by your own description[1] the right name to use would be _DEBUG
(with a preceding dash) and that would obviously not conflict here.
the only remaining cha
Am 19.06.19 um 13:30 schrieb Johannes Schindelin:
> Interesting side note: I just realized that t6050-replace.sh does indeed
> contain
>
> test_i18ngrep "Needed a single revision" err
>
> so I wonder why that works.
Why should it not work? If GIT_TEST_GETTEXT_POISON is on, it pretends
succ
Hello,
I have a question about sparse checkout. Git version 2.17.1
For some reason it checks out files from not specified folders.
My .git/info/sparse-checkout has two lines:
frontend/
common/
However backend/ is also created with some files in it (not all)
Is it a known bug?
Any workaround t
On Wed, Jun 19, 2019 at 07:24:10AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > Subject: [PATCH] interpret-trailers: load default config
> >
> > The interpret-trailers program does not do the usual loading of config
> > via git_default_config(), and thus does not respect many of the us
On Wed, Jun 19, 2019 at 02:12:30AM -0700, Carlo Arenas wrote:
> > I did a quick grep for similar cases, and didn't find any that I think
> > would be problematic. There were a few cleanups, below.
>
> would you mind if I add your 2 patches to a series and include that
> missing one?, that way I'l
On Wed, Jun 19 2019, Duy Nguyen wrote:
> On Wed, Jun 19, 2019 at 5:26 PM Ævar Arnfjörð Bjarmason
> wrote:
>> This patch is part of a WIP branch I have that's a bit of a mess. It's
>> more-gc-detach-under-lock on github.com/avar/git.git. It doesn't apply
>> on master because it relies on some pr
Hi Morian,
On Tue, 18 Jun 2019, Morian Sonnet wrote:
> "Morian Sonnet via GitGitGadget" wrote:
>
> > Calling
> >
> > git submodule foreach --recursive git reset --hard
> >
> > leads to an error stating that the option --hard is unknown to
> > submodule--helper.
> >
> > Reasons:
> >
> > . Abo
On Wed, Jun 19, 2019 at 08:30:25AM +0200, Johannes Sixt wrote:
> >> Why place this file in .git? To have per-repository diff drivers, we can
> >> already specify them via 'git config'. This file should be installed in
> >> the system.
> >
> > I think it _could_ actually just be part of the system
On Wed, Jun 19, 2019 at 11:32:19PM +0800, LI, BO XUAN wrote:
> > [diff "foo"]
> > xfuncname = "the pattern starts here...
> > and continues through newlines!"
> >
>
> If I recall correctly, the above version wouldn't work, but the
> following version would:
>
> [diff "foo"]
> xfuncname
On Wed, Jun 19, 2019 at 04:46:30PM +0700, Nguyễn Thái Ngọc Duy wrote:
> In multiple remotes mode, git-fetch is launched for n-1 remotes and the
> last remote is handled by the current process. Each of these processes
> will in turn run 'gc' at the end.
>
> This is not really a problem because eve
On Wed, Jun 19, 2019 at 07:51:00PM +0700, Duy Nguyen wrote:
> > Wheras mine fixes e.g. the same issue for:
> >
> > parallel 'git fetch {}' ::: $(git remote)
> >
> > Ditto for you running a "git" command and your editor running a
> > "fetch" at the same time.
>
> You could sort of avoid the pr
On Wed, Jun 19, 2019 at 08:01:55PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > You could sort of avoid the problem here too with
> >
> > parallel 'git fetch --no-auto-gc {}' ::: $(git remote)
> > git gc --auto
> >
> > It's definitely simpler, but of course we have to manually add
> > --no-auto-gc in
On Wed, Jun 19, 2019 at 04:58:50PM +0700, Nguyễn Thái Ngọc Duy wrote:
> This is probably just my itch. Every time I have to do something with
> the index, I need to add a little bit code here, a little bit there to
> get a better "view" of the index.
>
> This solves it for me. It allows me to see
On Wed, Jun 19, 2019 at 07:08:14AM -0700, Junio C Hamano wrote:
> Emily Shaffer writes:
>
> > Since v3, added a corresponding "--object-names" arg to pair with
> > "--no-object-names", and "last-one-wins" logic. Also added a test to
> > validate this new arg and the logic.
>
> Thanks for a quick
Hi Peff,
On Tue, 18 Jun 2019, Jeff King wrote:
> On Tue, Jun 18, 2019 at 06:15:46PM +0200, Johannes Schindelin wrote:
>
> > > And looking through this patch series, I see a gazillion of *new*
> > > process substitutions $(test_something...) and $(basename $whatever).
> > > Can't we do something a
Hi,
On Tue, 18 Jun 2019, SZEDER Gábor wrote:
> On Tue, Jun 18, 2019 at 06:15:46PM +0200, Johannes Schindelin wrote:
> > > Regardless of how it is implemented, I have another gripe with this
> > > helper: the way it must be used requires a process: $(test_out_to_path
> > > $foo)
> >
> > Indeed.
>
Hi,
On Mon, 10 Jun 2019, Junio C Hamano wrote:
> "brian m. carlson" writes:
>
> >> test_expect_success 'init with separate gitdir' '
> >>rm -rf newdir &&
> >>git init --separate-git-dir realgitdir newdir &&
> >>echo "gitdir: $(pwd)/realgitdir" >expected &&
> >> + downcase_on_case_i
Hi Martin,
On Sun, 9 Jun 2019, Martin Ågren wrote:
> On Sat, 8 Jun 2019 at 16:45, Johannes Schindelin via GitGitGadget
> wrote:
> >
> > From: Johannes Schindelin
> >
> > On a case-insensitive filesystem, such as HFS+ or NTFS, it is possible
> > that the idea Bash has of the current directory di
Allow easier parsing by cat-file by giving rev-list an option to print
only the OID of a non-commit object without any additional information.
This is a short-term shim; later on, rev-list should be taught how to
print the types of objects it finds in a format similar to cat-file's.
Before this co
Hi Hannes,
On Wed, 19 Jun 2019, Johannes Sixt wrote:
> Am 19.06.19 um 13:30 schrieb Johannes Schindelin:
> > Interesting side note: I just realized that t6050-replace.sh does indeed
> > contain
> >
> > test_i18ngrep "Needed a single revision" err
> >
> > so I wonder why that works.
>
> Why sh
Hi Carlo,
On Wed, 19 Jun 2019, Carlo Arenas wrote:
> while those two changes (from DEBUG to DEBUG_$foo) are worth doing in
> their own merit, I am more inclined to consider this as orthogonal
> since by your own description[1] the right name to use would be _DEBUG
> (with a preceding dash) and th
Philip Oakley and Jeff Hostetler worked quite a bit on getting Git to
compile with MS Visual C again, and this patch series is the culmination of
those efforts. With these patches, it is as easy as
make MSVC=1
Note: the patches went through quite the number of iterations. For example,
for a long
From: Johannes Schindelin
The msysGit project (i.e. Git for Windows 1.x' SDK) is safely dead for
*years* already. This is probably the reason why nobody caught this typo
until Carlo Arenas spotted a copy-edited version of it nearby.
It is probably about time to rip out the remainders of msysGit/
From: Johannes Schindelin
Just like the natural line ending for Unix shell scripts consist of a
single Line Feed, the natural line ending for (DOS) Batch scripts
consists of a Carriage Return followed by a Line Feed.
It seems that both Unix shell script interpreters and the interpreter
for Batch
From: Johannes Schindelin
When redirecting stdout/stderr to the same file, we cannot guarantee
that stdout will come first.
In fact, in this test case, it seems that an MSVC build always prints
stderr first.
In any case, this test case does not want to verify the *order* but
the *presence* of b
From: Johannes Schindelin
The file compat/msvc.c includes compat/mingw.c, which means that we have
to recompile compat/msvc.o if compat/mingw.c changes.
Signed-off-by: Johannes Schindelin
---
config.mak.uname | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config.mak.uname b/config.mak.u
From: Jeff Hostetler
VS2015 complains when using a const pointer in memcpy()/free().
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index 0d8713e515..d1
From: Philip Oakley
This constant is not defined in MSVC's headers.
In UCRT's fcntl.h, _O_RDONLY, _O_WRONLY and _O_RDWR are defined as 0, 1
and 2, respectively. Yes, that means that UCRT breaks with the tradition
that O_RDWR == O_RDONLY | O_WRONLY.
It is a perfectly legal way to define those co
From: Jeff Hostetler
It is quite common that MS Visual C++ is installed into a location whose
path contains spaces, therefore we need to quote it.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
From: Philip Oakley
On MSVC (VS2008) sigset_t is not defined.
Signed-off-by: Philip Oakley
Signed-off-by: Johannes Schindelin
---
compat/msvc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/msvc.h b/compat/msvc.h
index 29a8ce8204..04b4750b87 100644
--- a/compat/msvc.h
+++ b/com
From: Johannes Schindelin
Git for Windows has special code to retrieve the command-line parameters
(and even the environment) in UTF-16 encoding, so that they can be
converted to UTF-8. This is necessary because Git for Windows wants to
use UTF-8 encoded strings throughout its code, and the main(
From: Jeff Hostetler
VS2015's headers already declare that struct.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/mingw.h b/compat/mingw.h
index 210f1b01a8..a03e40e6e2 100644
--- a/compat/mingw.h
From: Jeff Hostetler
This special-cases various signals that are not supported on Windows,
such as SIGPIPE. These cause the UCRT to throw asserts (at least in
debug mode).
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 25 +
1 fil
From: Philip Oakley
MSVC can be overzealous about some warnings. Disable them.
Signed-off-by: Philip Oakley
Signed-off-by: Johannes Schindelin
---
compat/msvc.h | 4
1 file changed, 4 insertions(+)
diff --git a/compat/msvc.h b/compat/msvc.h
index d7525cf61d..1d7a8c6145 100644
--- a/comp
From: Jeff Hostetler
Ignore .dll files copied into the top-level directory.
Ignore MSVC incremental compiler output files.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
.gitignore | 5 +
1 file changed, 5 insertions(+)
diff --git a/.gitignore b/.gitignore
index 237
From: Jeff Hostetler
MS Visual C comes with a few neat features we can use to analyze the
heap consumption (i.e. leaks, max memory, etc).
With this patch, we introduce support via the build-time flag
`USE_MSVC_CRTDBG`.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
comp
From: Johannes Schindelin
MS Visual C suggests that the construct
condition ? (int) i : (ptrdiff_t) d
is incorrect. Let's fix this by casting to ptrdiff_t also for the
positive arm of the conditional.
Signed-off-by: Johannes Schindelin
---
compat/obstack.h | 2 +-
1 file changed, 1 i
From: Jeff Hostetler
It is just called differently in MSVC's headers.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/msvc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/msvc.h b/compat/msvc.h
index d336d80670..d7525cf61d 100644
--- a/compat/msvc.h
From: Jeff Hostetler
The ntstatus.h header is only available in MINGW.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/winansi.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/compat/winansi.c b/compat/winansi.c
index f4f08237f9..11cd9b82cc 1006
From: Jeff Hostetler
With this patch, Git can be built using the Microsoft toolchain, via:
make MSVC=1 [DEBUG=1]
Third party libraries are built from source using the open source
"vcpkg" tool set. See https://github.com/Microsoft/vcpkg
On a first build, the vcpkg tools and the third pa
From: Johannes Schindelin
For regular debugging, it is pretty helpful when a debug assertion in a
running application triggers a window that offers to start the debugger.
However, when running the test suite, it is not so helpful, in
particular when the debug assertions are then suppressed anywa
From: Jeff Hostetler
In MS Visual C, the `DEBUG` constant is set automatically whenever
compiling with debug information.
This is clearly not what was intended in `cache-tree.c` nor in
`builtin/blame.c`, so let's use a less ambiguous name there.
Signed-off-by: Jeff Hostetler
Signed-off-by: Joh
First of all, the man page for git hash-object doesn't specify whether
--path should be relative to the root of the tree or relative to the
current directory after git -C. Current behavior seems to be the
latter, which is sensible enough and usually works. While ..
components seem to be handled c
On Fri, Jun 14, 2019 at 03:56:54PM -0700, Emily Shaffer wrote:
> > Ah, I see. I don't consider "|" to indicate an exclusion to the point
> > that the options are rejected. Only that you wouldn't want to use both,
> > because one counteracts the other. So every "--no-foo" is mutually
> > exclusive
On Fri, Jun 14, 2019 at 04:29:46PM -0700, Emily Shaffer wrote:
> On Fri, Jun 14, 2019 at 12:07:28PM -0400, Jeff King wrote:
> > On Thu, Jun 13, 2019 at 02:51:03PM -0700, Emily Shaffer wrote:
>
> > > +test_expect_success 'rev-list --objects --oid-only is usable by
> > > cat-file' '
> > > + git re
On Wed, Jun 19, 2019 at 12:31:34PM -0700, Emily Shaffer wrote:
> > I noticed in range-diff, too. So now --object-names can be used
> > with --pretty (not that "rev-list --pretty --objects" makes much
> > sense in the first place, so no point in testing that it works).
>
> Yeah, it works. It look
On Wed, Jun 19, 2019 at 01:56:56PM -0700, Emily Shaffer wrote:
> Allow easier parsing by cat-file by giving rev-list an option to print
> only the OID of a non-commit object without any additional information.
> This is a short-term shim; later on, rev-list should be taught how to
> print the type
Hi all,
I am trying to understand how the DIRC section works, specifically the "index
entry" section. Can someone point to where in the code index files are
generated? I am having trouble locating the exact place.
The documentation (Documentation/technical/index-format.txt) suggests that the
c
On Sat, Jun 15, 2019 at 12:06:58PM +0200, Christian Couder wrote:
> Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh
> oidmap has no specific test. The goal of this small patch series is to
> change that and also improve oidmap a bit while at it.
>
> Changes compared to V3 a
On Wed, Jun 19, 2019 at 05:42:13PM -0400, Jeff King wrote:
> I do think that sha1hash() will eventually go away in favor of
> oidhash(), but we can approach that separately, and convert oidmap along
> with everyone else.
>
> It looks like we are close to being able to do that now. Grepping for
>
On Wed, Jun 19, 2019 at 05:21:59PM -0400, Jeff King wrote:
> On Fri, Jun 14, 2019 at 03:56:54PM -0700, Emily Shaffer wrote:
>
> > > Ah, I see. I don't consider "|" to indicate an exclusion to the point
> > > that the options are rejected. Only that you wouldn't want to use both,
> > > because one
1 - 100 of 119 matches
Mail list logo
