Matthew DeVore <matv...@google.com> writes:

> ... By
> removing the parenthesis from the localizable text, we can share strings
> with wt-status.c and remove a cautionary comment to translators.
...
> -                     /*
> -                      * TRANSLATORS: make sure this matches "HEAD
> -                      * detached at " in wt-status.c
> -                      */
> -                     strbuf_addf(&desc, _("(HEAD detached at %s)"),
> -                             state.detached_from);
> +                     strbuf_addstr(&desc, HEAD_DETACHED_AT);
>               else
> -                     /*
> -                      * TRANSLATORS: make sure this matches "HEAD
> -                      * detached from " in wt-status.c
> -                      */
> -                     strbuf_addf(&desc, _("(HEAD detached from %s)"),
> -                             state.detached_from);
> +                     strbuf_addstr(&desc, HEAD_DETACHED_FROM);

Very nice ;-)

> +             strbuf_addstr(&desc, state.detached_from);
>       }
>       else
> -             strbuf_addstr(&desc, _("(no branch)"));
> +             strbuf_addstr(&desc, _("no branch"));
> +     strbuf_addch(&desc, ')');
> +
>       free(state.branch);
>       free(state.onto);
>       free(state.detached_from);
>       return strbuf_detach(&desc, NULL);
>  }

> diff --git a/wt-status.h b/wt-status.h
> index 64f1ddc9fd..b0cfdc8011 100644
> --- a/wt-status.h
> +++ b/wt-status.h
> @@ -58,20 +58,23 @@ struct wt_status_change_data {
> ...
>  
> +#define HEAD_DETACHED_AT _("HEAD detached at ")
> +#define HEAD_DETACHED_FROM _("HEAD detached from ")
> +
>  struct wt_status_state {

These too.

Reply via email to