From: "Junio C Hamano"
Junio C Hamano writes:
Sivakumar Selvam writes:
... So
I thought of splitting the pack file into 4 GB chunks.
...
Hmmm, what is "this issue"? I do not see anything surprising.
While the explanation might have been enlightening, the knowledge
conveyed by the expla
On 2015-10-26 13:33, Junio C Hamano wrote:
> Call yours "http.proxyAuthmethod" in the documentation, and use
> strcmp("http.proxyauthmethod", var) in the options callback code.
[...]
> Strange indentation here...
[...]
> Along the same line as how we do sslversions[] instead of a long
> if/else if/
Hello Linus,
>> According to several tests on systems with different number of CPU cores
>> the hard-coded number of 8 threads is not optimal for all systems:
> Did you also compare cold-cache filesystem performance?
> One of the reasons for doing threaded grep is for CPU scaling. But another
Hi Junio,
On Mon, 26 Oct 2015, Junio C Hamano wrote:
> I asked Dscho if the shell is done correctly _for_ the platform.
This assumes that the platform is either CR/LF or LF. That is incorrect.
Windows does *not* dictate the line endings to be CR/LF. Certain
applications do.
The shell is an MSys
Hi Junio,
On Mon, 26 Oct 2015, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > A simple test with CR/LF line endings in a script reveals that it is
> > pretty solid:
> >
> > x=a
> > case "$x" in a) echo b;; esac
> >
> > prints out 'b', as expected.
>
> I do not see what this
Hi Jonathan,
On Mon, 26 Oct 2015, Jonathan Nieder wrote:
> Johannes Schindelin wrote:
>
> > --- a/wrap-for-bin.sh
> > +++ b/wrap-for-bin.sh
> > @@ -19,4 +19,11 @@ GIT_TEXTDOMAINDIR='@@BUILD_DIR@@/po/build/locale'
> > PATH='@@BUILD_DIR@@/bin-wrappers:'"$PATH"
> > export GIT_EXEC_PATH GITPERLLIB
Hi Junio,
On Mon, 26 Oct 2015, Junio C Hamano wrote:
> Subject: [PATCH] rebase-i: work around Windows CRLF line endings
>
> Editors on Windows can and do save text files with CRLF line
> endings, which is the convention on the platform. We are seeing
> reports that the "read" command in a port
Chad Boles reported that `git rebase -i` recently started producing
errors when the editor saves files with DOS line endings. The symptom
is:
Warning: the command isn't recognized in the following line:
-
You can fix this with 'git rebase --edit-todo'.
Or you can
Based on a bug report by Chad Boles.
Signed-off-by: Johannes Schindelin
---
t/t3404-rebase-interactive.sh | 12
1 file changed, 12 insertions(+)
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 3de0b1d..5dfa16a 100755
--- a/t/t3404-rebase-interactive
From: Junio C Hamano
Editors on Windows can and do save text files with CRLF line
endings, which is the convention on the platform. We are seeing
reports that the "read" command in a port of bash to the environment
however does not strip the CRLF at the end, not adjusting for the
same convention
Hi,
On Tue, 27 Oct 2015, Johannes Schindelin wrote:
> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
> index 5dfa16a..98eb49a 100755
> --- a/t/t3404-rebase-interactive.sh
> +++ b/t/t3404-rebase-interactive.sh
> @@ -1261,7 +1261,7 @@ test_expect_success 'static check of
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> Johannes Schindelin writes:
>>
>>> This is the correct thing to do, really: we already specify LF as
>>> field separator.
>>
>> I'm almost convinced that this is the right thing to do in the long run
>> ("almost" because I'm not sure, not becau
I too am interested in finding ways to automate working with submodules,
as it's a particular pain point with my colleagues. They frequently
shoot themselves in the foot trying to branch and merge a project with
submodules, resulting in a broken build and grumpy comments about git
(or possibly
Why not set alias(es) for that?
Best,
Davide
> On 27 Oct 2015, at 10:50, Nick wrote:
>
> I too am interested in finding ways to automate working with submodules, as
> it's a particular pain point with my colleagues. They frequently shoot
> themselves in the foot trying to branch and merge a p
On 27/10/15 10:56, Davide Fiorentino wrote:
Why not set alias(es) for that?
That counts as a hand-rolled (i.e. ad-hoc) solution. So not out of the
question, but I'd rather point my colleagues at something tried and
tested, rather than simply re-invent wheels, possibly badly.
I'd be interes
On Mon, Oct 26, 2015 at 10:25:41PM -0700, Victor Leschuk wrote:
> >> @@ -22,6 +22,7 @@ SYNOPSIS
> >> [--color[=] | --no-color]
> >> [--break] [--heading] [-p | --show-function]
> >> [-A ] [-B ] [-C ]
> >> +[--threads ]
>
> > Is this the best place for this option
On Tue, 27 Oct 2015 11:40:15 +
Nick wrote:
> > Why not set alias(es) for that?
[...]
> But oh yes, there is another difficulty with aliases. Eclipse users
> on Windows:
[...]
Not to counter your actual argument, but AFAIK EGit uses JGit which is
a Java implementation which does not call out
Hello John,
>> This thought also crossed my mind, however we already pass grep_opt to
>> start_threads() function, so I think passing it to wait_all() is not
>> that ugly, and kind of symmetric. And I do not like the idea of
>> duplicating same information in different places. What do you think?
On Tue, Oct 27, 2015 at 06:54:16AM -0700, Victor Leschuk wrote:
> Hello John,
>
> >> This thought also crossed my mind, however we already pass grep_opt to
> >> start_threads() function, so I think passing it to wait_all() is not
> >> that ugly, and kind of symmetric. And I do not like the idea of
On Tue, 27 Oct 2015 at 06:59:11, Lukas Fleischer wrote:
> [...]
> On second thought, it might be possible to overwrite the value of
> transfer.hiderefs using the -c command line option. If we combine that
> with the negative patterns supported by hiderefs, we might get a
> solution that is clean an
Hi,
On Mon, 26 Oct 2015, Junio C Hamano wrote:
> James McCoy writes:
>
> >> The code looks OK but the last paragraph makes _us_ worried. What
> >> is the licensing status of the original at SO?
> >
> > According to Stackoverflow[0],
> >
> > As noted in the Stack Exchange Terms of Service[1]
Hi,
On Tue, 27 Oct 2015, Johannes Schindelin wrote:
> On Mon, 26 Oct 2015, Junio C Hamano wrote:
>
> > James McCoy writes:
> >
> > >> The code looks OK but the last paragraph makes _us_ worried. What
> > >> is the licensing status of the original at SO?
> > >
> > > According to Stackoverflow[
Johannes Schindelin writes:
>> Most TEST_ environment variables that git respects are under
>> GIT_TEST_* --- e.g., GIT_TEST_OPTS. Should this match that pattern
>> as well, for easier debugging with commands like 'env | grep GIT_'?
>
> I dunno. This variable is most useful when inserted into th
Johannes Schindelin writes:
> On Tue, 27 Oct 2015, Johannes Schindelin wrote:
>
>> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
>> index 5dfa16a..98eb49a 100755
>> --- a/t/t3404-rebase-interactive.sh
>> +++ b/t/t3404-rebase-interactive.sh
>> @@ -1261,7 +1261,7 @@ tes
Johannes Schindelin writes:
> On second thought... Junio, could you please sanity-check my claim that
> this patch:
>
> -- snip --
> ...
> -- snap --
>
> cannot be copyrighted because it is pretty much the only way to implement
> said functionality?
I am not a lawyer, so...
> Still, Pat, if yo
Johannes Schindelin writes:
> This assumes that the platform is either CR/LF or LF. That is incorrect.
> Windows does *not* dictate the line endings to be CR/LF. Certain
> applications do.
>
> The shell is an MSys2 shell, and MSys2 convention is to use LF. Hence the
> shell is done correctly for
Jeff King writes:
> But these days, people often have several simultaneous sessions open.
> They may have multiple ssh sessions to a single machine, or they may
> have a bunch of terminal windows open, each of which has a login shell
> and will send HUP to its children when it exits. In that case
Max Kirillov writes:
>> The explanation of the first paragraph needs to be rewritten to make
>> it understandable, but I am not sure what relevance it has with this
>> change.
> ...
> So the history looks rather like (the interesting line is removed
> in B1, line removal is practically more inter
On Mon, Oct 26, 2015 at 2:15 PM, Johannes Schindelin
wrote:
> When prefixing a Git call in the test suite with 'TEST_GDB_GIT=1 ', it
> will now be run with GDB, allowing the developer to debug test failures
> more conveniently.
I'm very slowly catching up with git traffic. Apologies if it's
alrea
We need the submodule update strategies in a later patch.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
submodule-config.c | 11 +++
submodule-config.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/submodule-config.c b/submodule-config.c
index afe0ea8..8b8c7d1
This introduces a new helper function in git submodule--helper
which takes care of cloning all submodules, which we want to
parallelize eventually.
Some tests (such as empty URL, update_mode=none) are required in the
helper to make the decision for cloning. These checks have been
moved into the C
By inlining `name_and_item_from_var` it is easy to add later options
which are not required to have a submodule name.
Signed-off-by: Stefan Beller
---
submodule-config.c | 46 +-
1 file changed, 17 insertions(+), 29 deletions(-)
diff --git a/submodule
Just pass it along to "git submodule update", which may pick reasonable
defaults if you don't specify an explicit number.
Signed-off-by: Stefan Beller
---
Documentation/git-clone.txt | 5 -
builtin/clone.c | 26 --
t/t7406-submodule-update.sh | 15 +++
Expose possible parallelism either via the "--jobs" CLI parameter or
the "submodule.jobs" setting.
By having the variable initialized to -1, we make sure 0 can be passed
into the parallel processing machine, which will then pick as many parallel
workers as there are CPUs.
Signed-off-by: Stefan Be
This allows to configure fetching and updating in parallel
without having the command line option.
This moved the responsibility to determine how many parallel processes
to start from builtin/fetch to submodule.c as we need a way to communicate
"The user did not specify the number of parallel proc
Many components in if/else if/... cascade jumped to a shared
clean-up with "goto release_return", but we can restructure the
function a bit and make them disappear, which reduces the line count
as well. Also reformat overlong lines and poorly indented ones
while at it.
The order of rules to verif
This commit serves 2 purposes. First this may help the user who
tries to diagnose intermixed process calls. Second this may be used
in a later patch for testing. As the output of a command should not
change visibly except for going faster, grepping for the trace output
seems like a viable testing s
This rewrites parse_config to distinguish between configs specific to
one submodule and configs which apply generically to all submodules.
We do not have generic submodule configs yet, but the next patch will
introduce "submodule.jobs".
Signed-off-by: Stefan Beller
# Conflicts:
# submodule
Where does it apply?
---
This applies on 376d400f4c (run-command: fix missing output from late callbacks,
which is the latest commit in origin/sb/submodule-parallel-fetch which was
merged to origin/next)
The first patch is a duplicate of origin/sb/submodule-config-parse, so
it may make sense to dro
Lukas Fleischer writes:
> 2. transfer.hideRefs and receive.hideRefs do not seem to work with Git
>namespaces in general. show_ref_cb() replaces each ref outside the
>current namespace with ".have" before passing it to show_ref() which
>in turn performs the ref_is_hidden() check. This
On Mon, Oct 26, 2015 at 08:50:10PM -0400, Noam Postavsky wrote:
> On Mon, Oct 26, 2015 at 5:50 PM, Jeff King wrote:
> > But these days, people often have several simultaneous sessions open.
> > They may have multiple ssh sessions to a single machine, or they may
> > have a bunch of terminal window
On Tue, Oct 27, 2015 at 10:52:52AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > But these days, people often have several simultaneous sessions open.
> > They may have multiple ssh sessions to a single machine, or they may
> > have a bunch of terminal windows open, each of which has a
In ref-filter.c the comparison of refs while sorting is handled by
cmp_ref_sorting() function. When sorting as per numerical values
(e.g. --sort=objectsize) there is no fallback comparison when both
refs hold the same value. This can cause unexpected results (i.e. the
order of listing refs with equ
Jeff King writes:
> So I dunno. I think it would be reasonable to provide a config option to
> tell the cache-daemon to just ignore SIGHUP (or alternatively, a general
> option to try harder to dissociate itself from the caller). But I'm not
> sure I'd agree with making it the default. I'd want t
Stefan Beller writes:
> Where does it apply?
> ---
> This applies on 376d400f4c (run-command: fix missing output from late
> callbacks,
> which is the latest commit in origin/sb/submodule-parallel-fetch which was
> merged to origin/next)
Thanks for a detailed description. I'd do this:
$ g
Junio C Hamano writes:
> Johannes Schindelin writes:
>
>> On second thought... Junio, could you please sanity-check my claim that
>> this patch:
>>
>> -- snip --
>> ...
>> -- snap --
>>
>> cannot be copyrighted because it is pretty much the only way to implement
>> said functionality?
>
> I am n
Please view the attached file for your code payment.
UNITED NATIONS ORGANIZATION.pdf
Description: Adobe PDF document
Karthik Nayak writes:
> In ref-filter.c the comparison of refs while sorting is handled by
> cmp_ref_sorting() function. When sorting as per numerical values
> (e.g. --sort=objectsize) there is no fallback comparison when both
> refs hold the same value. This can cause unexpected results (i.e. th
Stefan Beller writes:
> Just pass it along to "git submodule update", which may pick reasonable
> defaults if you don't specify an explicit number.
>
> Signed-off-by: Stefan Beller
> ---
> Documentation/git-clone.txt | 5 -
> builtin/clone.c | 26 --
> t
Stefan Beller writes:
> @@ -374,6 +374,10 @@ for linkgit:git-clone[1]'s `--reference` and `--shared`
> options carefully.
> clone with a history truncated to the specified number of revisions.
> See linkgit:git-clone[1]
>
> +-j::
> +--jobs::
This probably should be
-j
Stefan Beller writes:
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 315f271..0b733d7 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2575,6 +2575,13 @@ submodule..ignore::
> "--ignore-submodules" option. The 'git submodule' command
Junio C Hamano writes:
> Analyzing copyrightability is often more costly than the risk.
Misspelled, obviously: "more costly than the other ways to mitigate
the risk" is what I meant.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kern
Make number of git-grep worker threads a configuration parameter.
According to several tests on systems with different number of CPU cores
the hard-coded number of 8 threads is not optimal for all systems:
tuning this parameter can significantly speed up grep performance.
Signed-off-by: Victor Les
difftool's dir-diff should never reuse a symlink, regardless of
what it points to. Tighten use_wt_file() so that it rejects all
symlinks.
Helped-by: Junio C Hamano
Signed-off-by: David Aguilar
---
git-difftool.perl | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Hi,
Stefan Beller wrote:
> Subject: submodule-config: "goto" removal in parse_config()
>
> Many components in if/else if/... cascade jumped to a shared
> clean-up with "goto release_return", but we can restructure the
> function a bit and make them disappear,
Not having read the patch yet, the a
Am 26.10.2015 um 20:23 schrieb Stefan Beller:
On Mon, Oct 26, 2015 at 11:43 AM, Junio C Hamano wrote:
René Scharfe writes:
Avoid duplication by moving the code to release allocated memory for
arguments and environment to its own function, child_process_clear().
Export it to provide a counter
Am 26.10.2015 um 22:33 schrieb Junio C Hamano:
René Scharfe writes:
Instead of open-coding the function pop_commit() just call it. This
makes the intent clearer and reduces code size.
Signed-off-by: Rene Scharfe
---
builtin/fmt-merge-msg.c | 9 +++--
builtin/merge.c | 12 +++
On Tue, Oct 27, 2015 at 2:29 PM, René Scharfe wrote:
> Am 26.10.2015 um 20:23 schrieb Stefan Beller:
>>
>> On Mon, Oct 26, 2015 at 11:43 AM, Junio C Hamano
>> wrote:
>>>
>>> René Scharfe writes:
>>>
Avoid duplication by moving the code to release allocated memory for
arguments and envi
Jonathan Nieder writes:
> Not having read the patch yet, the above makes me suspect this is
> going to make the code worse. A 'goto' for exception handling can
> be a clean way to ensure everything allocated gets released, and
> restructuring to avoid that can end up making the code more error
>
On Thu, Oct 22, 2015 at 11:23:54AM -0700, Junio C Hamano wrote:
> David Aguilar writes:
>
> > difftool's dir-diff feature was blindly feeding worktree paths
> > to hash-object without checking whether the path was indeed a
> > file, causing the feature to fail when repositories contain
> > symlin
Hello,
When a ".git" file points to another repo, a ".git/gitdir" file is
created in that repo.
For example, running
$ mkdir repo-a repo-b
$ cd repo-a
$ git init
$ cd ../repo-b
$ echo "gitdir: ../repo-a/.git" > .git
$ git status
results in a file "repo-a/.git/gitdir" tha
On Tue, Oct 27, 2015 at 3:04 PM, Kyle Meyer wrote:
> Hello,
>
> When a ".git" file points to another repo, a ".git/gitdir" file is
> created in that repo.
>
> For example, running
>
> $ mkdir repo-a repo-b
> $ cd repo-a
> $ git init
> $ cd ../repo-b
> $ echo "gitdir: ../repo-a/
David Aguilar writes:
> difftool's dir-diff should never reuse a symlink, regardless of
> what it points to. Tighten use_wt_file() so that it rejects all
> symlinks.
>
> Helped-by: Junio C Hamano
> Signed-off-by: David Aguilar
> ---
Sorry. I do recall saying "it is wrong to feed the contents
David Aguilar writes:
> - if (! -f "$workdir/$file") {
> - return (0, $null_sha1);
> + my $workfile = "$workdir/$file";
> + if (-f $workfile && ! -l $workfile) {
I still don't know if return (0, $null) is the right thing to do,
but in any case, I find the original flow ea
-Original Message-
On Tue, October-27-15 6:23 PM, Stefan Beller wrote:
>On Tue, Oct 27, 2015 at 3:04 PM, Kyle Meyer wrote:
>> When a ".git" file points to another repo, a ".git/gitdir" file is
>> created in that repo.
>>
>> For example, running
>>
>> $ mkdir repo-a repo-b
>> $ cd
On Tue, Oct 27, 2015 at 3:42 PM, Randall S. Becker
wrote:
> Slightly OT: Is there any way of avoiding having that file in the first
> place? I'm hoping to have a git repository in a normal file system (Posix)
> and a working area in a rather less-than-normal one where dots in file names
> are b
Kyle Meyer writes:
> When a ".git" file points to another repo, a ".git/gitdir" file is
> created in that repo.
>
> For example, running
>
> $ mkdir repo-a repo-b
> $ cd repo-a
> $ git init
> $ cd ../repo-b
> $ echo "gitdir: ../repo-a/.git" > .git
> $ git status
>
> result
On Tue, Oct 27, 2015 at 6:54 PM, Junio C Hamano wrote:
> Kyle Meyer writes:
>
>> When a ".git" file points to another repo, a ".git/gitdir" file is
>> created in that repo.
>>
>> For example, running
>>
>> $ mkdir repo-a repo-b
>> $ cd repo-a
>> $ git init
>> $ cd ../repo-b
>>
On Tue, Oct 27, 2015 at 09:34:48AM -0700, Junio C Hamano wrote:
> Yeah, that was my first reaction when I saw this patch. Instead of
> having to munge that line to "gdb -whatever-args git", you can do a
> single-shot debugging in a convenient way. And quite honestly,
> because nobody sane will r
Dear magic git bug solver,
I've encountered a problem and I haven't had any success with my own
troubleshooting or googling so I'd appreciate some help. I noticed the
issue originally when I changed a file name in windows explorer. I was
working on a website and I named my Public folder with a cap
On Tue, Oct 27, 2015 at 4:28 PM, Jeff King wrote:
> I agree doing so would be crazy. But would:
>
> ./t1234-frotz.sh --gdb=17
>
> be sane to run gdb only inside test 17?
OT:
We have two ways of addressing tests, by number and by name.
Usually when a test fails ("Foo gobbles the bar correctly" f
On Tue, Oct 27, 2015 at 02:04:23AM +, Sivakumar Selvam wrote:
>When I finished git repacking, I found 12 pack files with each 4 GB and
> the total size is 48 GB. Again I ran the same git repack command by just
> removing only --max-pack-size= parameter, the size of the single pack file
> i
On Sun, Oct 25, 2015 at 11:41:23PM -0700, Junio C Hamano wrote:
> Also it has to write more data to disk (see below), it has to find a
> good place to split, it has to adjust bookkeeping data at the pack
> boundary, in general it has to do more, not less, to produce split
> packs. It would be sur
On Thu, 2015-10-22 at 07:59 +0200, Christian Couder wrote:
> Hi everyone,
>
> I am starting to investigate ways to speed up git status and other git
> commands for Booking.com (thanks to AEvar) and I'd be happy to discuss
> the current status or be pointed to relevant documentation or mailing
> l
On Tue, Oct 27, 2015 at 04:39:37PM -0700, Stefan Beller wrote:
> On Tue, Oct 27, 2015 at 4:28 PM, Jeff King wrote:
> > I agree doing so would be crazy. But would:
> >
> > ./t1234-frotz.sh --gdb=17
> >
> > be sane to run gdb only inside test 17?
>
> OT:
> We have two ways of addressing tests, b
From: Ronnie Sahlberg
Move delete_pseudoref() and delete_ref() to the refs.c file since
these functions do not contain any backend specific code. We can't
move delete_refs yet because it depends on the files-backend-specific
repack_without_refs.
Based on a patch by Ronnie Sahlberg.
Signed-off-
Rename copy_msg to copy_reflog_msg and make it public.
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
Signed-off-by: Michael Haggerty
---
refs-be-files.c | 28 +---
refs.c | 21 +
refs.h | 7 +++
3 files changed, 29
From: Ronnie Sahlberg
These functions do not contain any backend specific code so we move
them to the common code and share across all backends.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 203
From: Ronnie Sahlberg
Create a new refs.c file that will be used to hold all the refs
code that is backend agnostic and will be shared across all backends.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: Junio C Hamano
---
Makefile | 1 +
refs.c | 3 +++
2 files changed, 4 insertions(+)
crea
From: Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg
Signed-off-by: Junio C Hamano
Signed-off-by: David Turner
---
refs-be-files.c | 82 -
refs.c | 81
2 files changed, 81
From: Ronnie Sahlberg
Rename refs.c to refs-be-files.c to indicate that this file now
holds the implementation for the files based refs backend.
A smaller portion of the code in this file is backend agnostic and will
be moved to a new refs.c file that will hold all the common refs code
that is sh
The common ref code will build up a ref transaction. Backends will
then commit it. So the transaction creation and update functions should
be in the common code. We also need to move the ref structs into
the common code so that alternate backends can access them.
Later, we will modify struct re
From: Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 5 -
refs.c | 5 +
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/refs-be-files.c b/refs-be-files.c
index ec6efd7..8eb4b93 1006
is_branch was already non-static, but this patch declares it in the
header.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/refs.h b/refs.h
index 7367a7f..8408bef 100644
--- a/refs.h
+++ b
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
Signed-off-by: Michael Haggerty
---
refs-be-files.c | 10 --
refs.c | 10 ++
refs.h | 2 ++
3 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/refs-be-files.c b/refs-be-files.c
index 23c2f
From: Ronnie Sahlberg
Create a public version of verify_refname_available that backends can
provide.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs.c | 65 ++---
refs.h | 20 +++
In a moment, we'll create initdb functions for ref backends, and code
from initdb that calls this function needs to move into the files
backend. So this function needs to be public.
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
Signed-off-by: Michael Haggerty
---
builtin/init-db.c
From: Ronnie Sahlberg
This function does not contain any backend specific code so we
move it to the common code.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 109
refs.c
This version of the series makes some minor changes from v4:
refs.c: move refname_is_safe to the common code: clarify a comment
initdb: move safe_create_dir into common code: add a caveat on safe_create_dir
refs.c: move update_ref to refs.c: update commit message to include
write_pseudoref
refs.c
From: Ronnie Sahlberg
Move read_ref_at() to the refs.c file since this function does not
contain any backend specific code.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 118 -
From: Jeff King
Normally we try to avoid bumps of the whole-repository
core.repositoryformatversion field. However, it is
unavoidable if we want to safely change certain aspects of
git in a backwards-incompatible way (e.g., modifying the set
of ref tips that we must traverse to generate a list of
Because HEAD and stash are per-worktree, refs.c needs to go through
the files backend to write these refs.
In this patch, we make one files_log_ref_write public. Later, we will
use this to handle reflog updates for per-worktree symbolic refs
(HEAD).
Signed-off-by: David Turner
Signed-off-by: Jun
Create new function verify_no_descendants, to hold one of the ref
conflict checks used in verify_refname_available. Multiple backends
will need this function, so it goes in the common code.
rename_ref_available also moves to the common code, because alternate
backends might need it and it has no
From: Ronnie Sahlberg
These functions do not depend on the backend implementation so we
move them to the common code.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 18 --
refs.c | 18 ++
From: Ronnie Sahlberg
These functions do not use any backend specific code so we move
them to the common code.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 52
refs.c
From: Ronnie Sahlberg
This function can be shared across all refs backends so move it
to the common code.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 7 ---
refs.c | 7 +++
2 files changed, 7 insertions(+), 7
This function does not contain any backend specific code so we
move it to the common code.
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
Signed-off-by: Michael Haggerty
---
refs-be-files.c | 53 -
refs.c | 23
This function does not contain any backend specific code so we move it
to the common code. This function might be used by other refs backends.
While we are doing so, we improve the comment's grammar and clarify a
safety rule.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off
From: Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 9 -
refs.c | 9 +
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/refs-be-files.c b/refs-be-files.c
index 8eb4b93..c5cc7e7 100644
--- a/refs-be-file
From: Ronnie Sahlberg
Move the hidden refs functions to the refs.c file since these
functions do not contain any backend specific code.
Signed-off-by: Ronnie Sahlberg
Signed-off-by: David Turner
Signed-off-by: Junio C Hamano
---
refs-be-files.c | 51 --
1 - 100 of 105 matches
Mail list logo
