Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-11 Thread Junio C Hamano
Jeff King writes: > On Tue, Jan 10, 2017 at 02:15:11PM -0800, Junio C Hamano wrote: > >> Richard Hansen writes: >> ... >> > I think so. (For bare repositories anyway; non-bare should be >> > relative to GIT_WORK_TREE.) Perhaps git_config_pathname() itself >> > should convert relative paths to

Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-11 Thread Jeff King
On Tue, Jan 10, 2017 at 02:15:11PM -0800, Junio C Hamano wrote: > Richard Hansen writes: > > >> A related tangent. > >> > >> I wonder if anything that uses git_config_pathname() should be > >> relative to GIT_DIR when it is not absolute. > > > > I think so. (For bare repositories anyway; non-ba

Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-10 Thread Junio C Hamano
Richard Hansen writes: >> A related tangent. >> >> I wonder if anything that uses git_config_pathname() should be >> relative to GIT_DIR when it is not absolute. > > I think so. (For bare repositories anyway; non-bare should be > relative to GIT_WORK_TREE.) Perhaps git_config_pathname() itself

Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-10 Thread Richard Hansen
On 2017-01-10 15:23, Junio C Hamano wrote: Junio C Hamano writes: Richard Hansen writes: On 2017-01-10 01:58, Jeff King wrote: ... What happens in a bare repository? I'm guessing it's relative to the top-level of the repository, I just tried it out and it's relative to $PWD. That is u

Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-10 Thread Junio C Hamano
Junio C Hamano writes: > Richard Hansen writes: > >> On 2017-01-10 01:58, Jeff King wrote: >> ... >>> What happens in a bare repository? >>> >>> I'm guessing it's relative to the top-level of the repository, >> >> I just tried it out and it's relative to $PWD. > > That is understandable. When t

Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-10 Thread Junio C Hamano
Richard Hansen writes: > On 2017-01-10 01:58, Jeff King wrote: > ... >> What happens in a bare repository? >> >> I'm guessing it's relative to the top-level of the repository, > > I just tried it out and it's relative to $PWD. That is understandable. When the user says $ cmd -O $file with

Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-10 Thread Richard Hansen
On 2017-01-10 01:58, Jeff King wrote: On Mon, Jan 09, 2017 at 07:40:30PM -0500, Richard Hansen wrote: Document that a relative pathname for diff.orderFile is interpreted as relative to the top-level work directory. Signed-off-by: Richard Hansen --- Documentation/diff-config.txt | 2 ++ 1 fil

Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-09 Thread Jeff King
On Mon, Jan 09, 2017 at 07:40:30PM -0500, Richard Hansen wrote: > Document that a relative pathname for diff.orderFile is interpreted as > relative to the top-level work directory. > > Signed-off-by: Richard Hansen > --- > Documentation/diff-config.txt | 2 ++ > 1 file changed, 2 insertions(+)

[PATCH 1/2] diff: document behavior of relative diff.orderFile

2017-01-09 Thread Richard Hansen
Document that a relative pathname for diff.orderFile is interpreted as relative to the top-level work directory. Signed-off-by: Richard Hansen --- Documentation/diff-config.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt ind