Richard Hansen <hans...@google.com> writes: >> A related tangent. >> >> I wonder if anything that uses git_config_pathname() should be >> relative to GIT_DIR when it is not absolute. > > I think so. (For bare repositories anyway; non-bare should be > relative to GIT_WORK_TREE.) Perhaps git_config_pathname() itself > should convert relative paths to absolute so that every pathname > setting automatically works without changing any calling code.
Yes, that was what I was alluding to. We might have to wait until major version boundary to do so, but I think that it is the sensible way forward in the longer term to convert relative to absolute in git_config_pathname(). Thanks.
