[GIT PULL] gitk update

2019-09-15 Thread Paul Mackerras
lines for submodule changes Paul Mackerras (1): gitk: Make web links clickable Paul Wise (1): gitk: Use right colour for remote refs in the "Tags and heads" dialog YanKe (1): gitk: Add Chinese (zh_CN) translation gitk| 64 ++- po/

Re: [PATCH] gitk: Do not mistake unchanged lines with submodule changes

2019-09-15 Thread Paul Mackerras
On Sat, Mar 23, 2019 at 06:00:36PM +0100, Gabriele Mazzotta wrote: > Unchanged lines are prefixed with a white-space, thus unchanged lines > starting with either " <" or " >" are mistaken for submodule changes. > Check if a line starts with either " <" or " >" only if we listing > the changes of

Re: [PATCH v2] gitk: Make web links clickable

2019-09-13 Thread Paul Mackerras
On Fri, Aug 30, 2019 at 12:02:07AM +0530, Pratyush Yadav wrote: > On 29/08/19 11:27AM, Paul Mackerras wrote: > > This makes gitk look for http or https URLs in the commit description > > and make the URLs clickable. Clicking on them will invoke an external > > web

[PATCH v2] gitk: Make web links clickable

2019-08-28 Thread Paul Mackerras
n Windows. The command can be changed in the preferences window, and it can include parameters as well as the command name. If it is set to the empty string then URLs will no longer be made clickable. Signed-off-by: Paul Mackerras --- v2: Match URLs anywhere, not just

Re: [PATCH] gitk: Make web links clickable

2019-08-28 Thread Paul Mackerras
Hi Junio, On Tue, Aug 27, 2019 at 01:32:30PM -0700, Junio C Hamano wrote: > Paul Mackerras writes: > > > This makes gitk look for lines in the commit message which start with > > "Link:" or "BugLink:" followed by a http or https URL, and make the > >

[PATCH] gitk: Make web links clickable

2019-08-26 Thread Paul Mackerras
uot; on Linux, "open" on MacOS, and "cmd /c start" on Windows. The command can be changed in the preferences window, and it can include parameters as well as the command name. If it is set to the empty string then URLs will no longer be made clickab

Re: [PATCH 1/1] gitk: Update Bulgarian translation (317t)

2019-03-14 Thread Paul Mackerras
On Wed, Mar 13, 2019 at 01:28:33PM +0100, Alexander Shopov wrote: > Signed-off-by: Alexander Shopov Thanks, applied. Paul.

Re: Update of Bulgarian translation of gitk

2019-03-14 Thread Paul Mackerras
ting merged? Perhaps I missed something or Paul > Mackerras, > maintaining gitk, is busy? I have been busy with work and life generally. I applied your patch and pushed it out. Thanks for your patience. Paul.

Re: [PATCH 1/2] gitk: refresh the colour scheme

2019-03-02 Thread Paul Mackerras
On Tue, Feb 26, 2019 at 12:05:34PM +0100, Andrej Shadura wrote: > The colours gitk is currently using are from the basic 16 colour > palette, and are a bit too intensive to be comfortable or pleasant > to work with. > > Adjust the main colours (commit nodes, remotes, tags and one branch > colour)

Re: [PATCH] gitk: remove translated message from comments

2017-01-18 Thread Paul Mackerras
On Tue, Jan 17, 2017 at 07:52:45PM -0800, David Aguilar wrote: > "make update-po" fails because a previously untranslated string > has now been translated: > > Updating po/sv.po > po/sv.po:1388: duplicate message definition... > po/sv.po:380: ...this is the location of the first

Re: gitk pull request // was: Re: gitk: "lime" color incompatible with older Tk versions

2017-01-15 Thread Paul Mackerras
Hi Junio, On Sat, Jan 14, 2017 at 06:35:43PM -0800, Junio C Hamano wrote: > David Aguilar writes: > > > On Fri, Jan 13, 2017 at 03:20:43AM -0800, David Aguilar wrote: > >> > >> Ping.. it would be nice to get this patch applied. > > > > Sorry for the noise, and thank you Paul for the fix. > > Th

Re: [PATCH 2/6] Add ability to follow a remote branch with a dialog

2016-12-31 Thread Paul Mackerras
On Thu, Dec 15, 2016 at 09:58:43PM +1030, Pierre Dumuid wrote: > A suggested name is provided when creating a new "following" branch. > > Signed-off-by: Pierre Dumuid > --- > gitk | 86 > > 1 file changed, 82 insertions(+), 4

Re: [PATCH 1/6] Enable ability to visualise the results of git cherry C1 C2

2016-12-31 Thread Paul Mackerras
On Thu, Dec 15, 2016 at 09:58:42PM +1030, Pierre Dumuid wrote: > It's a bit clunky but it works!! > > Usage: > - mark commit one (e.g. v45) > - Select commit two. > - Switch the gdttype to the option, "git-cherry between marked commit and:" This needs a better description. "Git-cherry between

Re: [PATCH 3/6] Add a tree view to the local branches, remote branches and tags, where / is treated as a directory seperator.

2016-12-31 Thread Paul Mackerras
On Thu, Dec 15, 2016 at 09:58:44PM +1030, Pierre Dumuid wrote: > Signed-off-by: Pierre Dumuid > --- > gitk | 117 > +++ > 1 file changed, 117 insertions(+) Nice idea in general... a few comments below. Also, please don't put the e

Re: [PATCH 00/13] gitk: tweak rendering of remote-tracking references

2016-12-20 Thread Paul Mackerras
On Tue, Dec 20, 2016 at 10:01:15AM -0500, Marc Branchaud wrote: > On 2016-12-19 11:44 AM, Michael Haggerty wrote: > >This patch series changes a bunch of details about how remote-tracking > >references are rendered in the commit list of gitk: > > Thanks for this! I like the new, compact look very

Re: [PATCH 0/3] gitk: memory consumption improvements

2016-12-12 Thread Paul Mackerras
On Mon, Nov 07, 2016 at 07:54:28PM +0100, Markus Hitter wrote: > > List, Paul, > > after searching for a while on why Gitk sometimes consumes exorbitant amounts > of memory I found a pair of minor issues and also a big one: the text widget > comes with an unlimited undo manager, which is turned

Re: [PATCH] gitk: Fix Japanese translation for "marked commit"

2016-12-12 Thread Paul Mackerras
On Tue, Oct 25, 2016 at 12:35:10AM +0900, Satoshi Yasushima wrote: > Signed-off-by: Satoshi Yasushima > --- > po/ja.po | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Applied, thanks, Paul.

Re: Proposal for an increased `gitk` cohesion with `git stash`.

2016-12-12 Thread Paul Mackerras
Hi Uxio, On Thu, Sep 08, 2016 at 03:41:29PM +0200, Uxío Prego wrote: > Hello, please forgive me for not introducing me. > > +---+ > |Description| > +---+ > > Patch for showing all stashes in `gitk`. > > +---+ > |The problem| > +---+ > > Being `gitk` one of the b

Re: [PATCH v4] gitk: Add Portuguese translation

2016-12-11 Thread Paul Mackerras
On Wed, May 11, 2016 at 08:01:33PM +, Vasco Almeida wrote: > Signed-off-by: Vasco Almeida > --- > > Oops, fix typo. Thanks, applied. Paul.

Re: [PATCH] Gitk Inotify support

2016-12-11 Thread Paul Mackerras
On Sat, Jun 11, 2016 at 04:06:36PM +0200, Florian Schüller wrote: > >From 74d2f4c1ec560b358fb50b8b7fe8282e7e1457b0 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Florian=20Sch=C3=BCller?= > Date: Thu, 9 Jun 2016 22:54:43 +0200 > Subject: [PATCH] first support for inotify > MIME-Version: 1.0 > Content-

Re: [PATCH v2 0/2] gitk: Two improvements to the branch context menu

2016-12-11 Thread Paul Mackerras
On Sat, Mar 19, 2016 at 07:31:32PM +0100, Rogier Goossens wrote: > Hi, > > Hereby the revised patches. > > Changes since v1: > - Rebased on latest master > - Made the changes you suggested > - Moved 'rename branch' menu option above 'delete branch' > - Cleaned up some code duplication that the pr

Re: [PATCH v3] gitk: Fix missing commits when using -S or -G

2016-12-11 Thread Paul Mackerras
On Sat, Jun 04, 2016 at 10:47:16AM +0200, Stefan Dotterweich wrote: > When -S or -G is used as a filter option, the resulting commit list > rarely contains all matching commits. Only a certain number of commits > are displayed and the rest are missing. > > "git log --boundary -S" does not return a

Re: [PATCH] gitk: Makefile: create install bin directory

2016-12-11 Thread Paul Mackerras
On Thu, May 05, 2016 at 05:46:32PM +, Vasco Almeida wrote: > Force creation of destination bin directory. Before this commit, gitk > would fail to install if this directory didn't already exist. > > Signed-off-by: Vasco Almeida Thanks, applied (with slight tweak to commit message). Paul.

Re: [PATCH v3 1/2] gitk: alter the ordering for the "Tags and heads" view

2016-12-11 Thread Paul Mackerras
On Sun, Mar 27, 2016 at 11:06:07AM -0400, Michael Rappazzo wrote: > In the "Tags and heads" view, the list of refs is globally sorted. > Because of this, the list of local refs (heads) can be interrupted by the > list of remote refs. This change re-orders the view to be: local refs, > remote refs

Re: gitk: avoid obscene memory consumption

2016-11-06 Thread Paul Mackerras
On Sun, Nov 06, 2016 at 11:28:37AM +0100, Markus Hitter wrote: > > Thanks for the positive comments. > > TBH, the more I think about the problem, the less I'm satisfied with the > solution I provided. Including two reasons: > > - The list of files affected to the right is still complete and cli

Re: gitk: avoid obscene memory consumption

2016-11-05 Thread Paul Mackerras
On Fri, Nov 04, 2016 at 03:45:09PM -0700, Stefan Beller wrote: > On Fri, Nov 4, 2016 at 12:49 PM, Markus Hitter wrote: > > > > Hello all, > > +cc Paul Mackeras, who maintains gitk. Thanks. > > > > after Gitk brought my shabby development machine (Core2Duo, 4 GB RAM, > > Ubuntu 16.10, no swap t

Re: [PATCH v2] gitk: Fix missing commits when using -S or -G

2016-05-08 Thread Paul Mackerras
On Fri, May 06, 2016 at 02:16:54PM +0200, Stefan Dotterweich wrote: > When -S or -G is used as a filter option, the resulting commit list > rarely contains all matching commits. Only a certain number of commits > are displayed and the rest are missing. > > "git log --boundary -S" does not return a

Re: [Q] updates to gitk, git-gui and git-svn for 2.8?

2016-03-19 Thread Paul Mackerras
Hi Junio, > If there are pending updates for the upcoming release, please let me > know and tell me what to pull. Please pull from my gitk repository. Thanks, Paul. The following changes since commit 0de75aafb66b22a04e6c90c0baf15dca11bddb3c: Merge branch 'ja.po' of https://github.com/qykth-g

Re: [PATCH v2 2/2] gitk: add an option to enable sorting the "Tags and heads" view by ref type

2016-03-19 Thread Paul Mackerras
On Fri, Mar 18, 2016 at 02:51:37PM -0400, Michael Rappazzo wrote: > Signed-off-by: Michael Rappazzo This looks to me like the kind of thing that could have a checkbox in the Preferences window and get saved on disk along with other preferences, rather than only being available via a command-line

Re: [PATCH 1/2] gitk: Add a 'rename' option to the branch context menu

2016-03-19 Thread Paul Mackerras
On Fri, Jan 15, 2016 at 10:38:49PM +0100, Rogier Goossens wrote: > > Signed-off-by: Rogier Goossens This is a nice idea; I just have some comments about the Tcl here: > @@ -9756,15 +9831,19 @@ proc headmenu {x y id head} { > stopfinding > set headmenuid $id > set headmenuhead $he

Re: [PATCH] gitk: Follow themed bgcolor in help dialogs

2016-03-19 Thread Paul Mackerras
On Thu, Feb 04, 2016 at 03:32:19AM +0100, Guillermo S. Romero wrote: > Make Help > About & Key bindings dialogs readable if theme > has changed font color to something incompatible with white. > > Signed-off-by: Guillermo S. Romero Thanks, applied. Paul. -- To unsubscribe from this list: send th

Re: [PATCH 1/2] gitk: fr.po: Update translation (311t)

2016-03-19 Thread Paul Mackerras
Thanks, applied both patches. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gitk: update German translation

2016-03-19 Thread Paul Mackerras
Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gitk: Update Bulgarian translation (311t)

2016-03-19 Thread Paul Mackerras
Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] gitk: alter the ordering for the "Tags and heads" view

2016-03-19 Thread Paul Mackerras
On Fri, Mar 18, 2016 at 02:51:36PM -0400, Michael Rappazzo wrote: > In the "Tags and heads" view, the list of refs is globally sorted. > Because of this, the list of local refs (heads) can be interrupted by the > list of remote refs. This change re-orders the view to be: local refs, > remote refs

Re: [RFPR] updates for 2.7?

2015-12-18 Thread Paul Mackerras
On Tue, Dec 15, 2015 at 03:09:44PM -0800, Junio C Hamano wrote: > Git 2.7-rc1 has just been tagged, and the remainder of the year will > be for the stabilization, fixes to brown-paper-bag bugs, reverts of > regressions, etc., but I haven't seen updates to the various > subsystems you guys maintain

Re: [PATCH 1/2] gitk: match ttk fonts to gitk fonts

2015-12-18 Thread Paul Mackerras
On Tue, Dec 08, 2015 at 08:05:50AM +0100, Giuseppe Bilotta wrote: > The fonts set in setoptions aren't consistently picked up by ttk, who > uses its own predefined fonts. This is noticeable when switching > between using and not using ttk with custom fonts or in HiDPI settings > (where the default

Re: [PATCH v3] gitk: add -C commandline parameter to change path

2015-12-18 Thread Paul Mackerras
On Mon, Nov 09, 2015 at 01:45:22PM +0200, Juha-Pekka Heikkila wrote: > This patch adds -C (change working directory) parameter to > gitk. With this parameter, instead of need to cd to directory > with .git folder, one can point the correct folder from > commandline. > > Signed-off-by: Juha-Pekka H

Re: [PATCH] gitk: sv.po: Update Swedish translation (311t)

2015-12-18 Thread Paul Mackerras
Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [gmane.comp.version-control.git] [PATCH 0/4] gitk crash fix and locale updates

2015-10-30 Thread Paul Mackerras
On Mon, Oct 26, 2015 at 05:16:20PM -0700, Junio C Hamano wrote: > Ping. What do you think of these? It appears that quite a many > people are getting bitten by the issues this series addresses. Yes, sorry about that. I have applied a patch from Beat Bolli fixing the basic issue, since his patch

Re: [PATCH 0/4] gitk crash fix and locale updates

2015-10-30 Thread Paul Mackerras
On Tue, Oct 20, 2015 at 02:33:00PM +0200, Takashi Iwai wrote: > Hi, > > the recent change in gitk to support the menu accelerator broke the > invocation with --all option in non-English locales. Also, the whole > menu translations are gone by this, too. This patchset tries to > address these iss

Re: [PATCH] gitk: add missing accelerators

2015-10-30 Thread Paul Mackerras
quot; were left > without the ampersand. > > Add the missing ampersand characters to unbreak our international > users. > > Signed-off-by: Beat Bolli > Cc: Paul Mackerras Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the

Re: [PATCH] gitk: l10n: Update Catalan translation

2015-10-30 Thread Paul Mackerras
On Mon, Oct 05, 2015 at 10:26:12PM -0600, Alex Henrie wrote: > The gitk included in git 2.6.0 crashes if run from a Catalan locale. > I'm hoping that a translation update will fix this. > > Signed-off-by: Alex Henrie Should actually be fixed by a patch from Beat Bolli that I just applied, but I

Re: [PATCH] gitk: accelerators for the main menu

2015-09-13 Thread Paul Mackerras
On Wed, Sep 09, 2015 at 03:20:53PM +0200, Giuseppe Bilotta wrote: > This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N to open a > new view). > > Signed-off-by: Giuseppe Bilotta Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of

Re: [PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry

2015-09-13 Thread Paul Mackerras
be > adjusted when their text or state is changed. > > Signed-off-by: Beat Bolli > Cc: Paul Mackerras Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gitk: Update Bulgarian translation (307t)

2015-08-13 Thread Paul Mackerras
On Sun, Jun 28, 2015 at 11:28:13PM +0300, a...@kambanaria.org wrote: > From: Alexander Shopov > > Signed-off-by: Alexander Shopov > --- > po/bg.po | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) Thanks, applied. Paul. -- To unsubscribe from this list: send the lin

Re: [PATCH v4] gitk: Add a "Copy commit summary" command

2015-08-13 Thread Paul Mackerras
On Sat, Jul 18, 2015 at 01:15:39PM +0200, Beat Bolli wrote: > When referring to earlier commits in commit messages or other text, one > of the established formats is > > ("", ) > > Add a "Copy commit summary" command to the context menu that puts this > text for the currently selected commit

Re: [PATCH] gitk: Alter the ordering for the "Tags and heads" view

2015-08-12 Thread Paul Mackerras
On Tue, Jun 02, 2015 at 07:11:10AM -0400, Michael Rappazzo wrote: > In the "Tags and heads" view, the list of refs is globally sorted. > The list of local refs (heads) is separated by the remote refs. This > change re-orders the view toi be: local refs, remote refs tracked by > local refs, remote

Re: [PATCH v4] gitk: Add a "Copy commit summary" command

2015-07-21 Thread Paul Mackerras
On Tue, Jul 21, 2015 at 12:19:23PM +0200, Beat Bolli wrote: > Guys, > > can I get a Yea or Nay for this patch? > > Does it go in via Paul's gitk repo or directly through Junio? I'll put it in. It goes into my repo and from there into Junio's. I'm on vacation and travelling this week, so please

Re: [PATCH v2] gitk: Add a "Copy commit summary" command

2015-07-18 Thread Paul Mackerras
On Fri, Jul 17, 2015 at 08:30:24AM -0700, Junio C Hamano wrote: > Paul Mackerras writes: > > > We have an item in the preferences menu to control the SHA1 length > > that is automatically selected when going to a new commit. It's > > stored in the variable $autosell

Re: [PATCH v2] gitk: Add a "Copy commit summary" command

2015-07-17 Thread Paul Mackerras
On Thu, Jul 16, 2015 at 05:29:25PM +0200, Beat Bolli wrote: > When referring to earlier commits in commit messages or other text, one > of the established formats is > > ("", ) > > Add a "Copy commit summary" command to the context menu that puts this > text for the currently selected commit

Re: gitk won't show notes?

2015-04-11 Thread Paul Mackerras
On Wed, Apr 08, 2015 at 01:51:40PM +0200, Michael J Gruber wrote: > Phillip Susi venit, vidit, dixit 07.04.2015 19:08: > > On 4/7/2015 10:13 AM, Michael J Gruber wrote: > >> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the > >> latter is the thorougher refreshment. > > > > Neith

Re: [RFC PATCH 2/2] gitk: Show the rev(s) the user specified on the command line in the window title.

2015-04-05 Thread Paul Mackerras
On Tue, Jan 06, 2015 at 12:52:00PM -0500, Marc Branchaud wrote: > Signed-off-by: Marc Branchaud > --- > > I often open multiple gitk windows in the same working directory to examine > other branches or refs in the repo. This change allows me to distinguish > which window is showing what. > > Th

Re: [PATCH] gitk: Fix bad English grammar "Matches none Commit Info"

2015-04-05 Thread Paul Mackerras
On Thu, Apr 02, 2015 at 03:05:06PM -0600, Alex Henrie wrote: > Signed-off-by: Alex Henrie > --- > gitk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gitk b/gitk > index 9a2daf3..30fcd30 100755 > --- a/gitk > +++ b/gitk > @@ -4066,7 +4066,7 @@ set known_view_options { >

Re: [PATCH 1/2] gitk: Rearrange window title to be more conventional.

2015-04-05 Thread Paul Mackerras
On Mon, Mar 23, 2015 at 10:18:16AM -0400, Marc Branchaud wrote: > Signed-off-by: Marc Branchaud Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: [PATCH] gitk: Remove mc parameter from proc show_error

2015-04-05 Thread Paul Mackerras
On Thu, Apr 02, 2015 at 03:05:35PM -0600, Alex Henrie wrote: > This partially reverts commit 8d849957d81fc0480a52570d66cc3c2a688ecb1b. ... and brings back the bug that 8d849957d81f solves, as far as I can see. If that's not the case then you need to explain that in the patch description. Paul. -

Re: [PATCH] gitk: sv.po: Update Swedish translation (305t0f0u)

2015-04-05 Thread Paul Mackerras
On Fri, Mar 27, 2015 at 10:34:25AM +0100, Peter Krefting wrote: > Please find attached (for text encoding reasons) an update to the Swedish > translation for gitk. Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.k

Re: gitk drawing bug

2015-04-05 Thread Paul Mackerras
On Fri, Apr 03, 2015 at 09:28:00PM -0400, Martin d'Anjou wrote: > On 15-04-03 07:05 PM, Alex Henrie wrote: > >2015-02-18 12:27 GMT-07:00 Martin d'Anjou : > >>It appears I have uncovered inconsistent behaviour in gitk. Looks like > >>a bug. I have a picture here: > >>https://docs.google.com/document

Re: A good time to pull from your gitk tree?

2015-03-24 Thread Paul Mackerras
On Mon, Mar 23, 2015 at 12:03:37PM -0700, Junio C Hamano wrote: > > Is it a good time for me to pull from you, or do you recommend me to > wait for a bit, expecting more? We'll go in the pre-release freeze > soon-ish, so I thought I should ping. Now is a good time to pull from the usual place, t

Re: [PATCH v2] l10n: gitk/ca.po: add Catalan translation

2015-03-21 Thread Paul Mackerras
On Sun, Feb 01, 2015 at 10:53:32PM -0700, Alex Henrie wrote: > Signed-off-by: Alex Henrie Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH 1/1] gitk: po/ru.po russian translation typo fixed

2015-03-21 Thread Paul Mackerras
On Fri, Nov 14, 2014 at 05:05:28PM +0600, 0xAX wrote: > Signed-off-by: 0xAX > --- > po/ru.po | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

2015-03-21 Thread Paul Mackerras
On Mon, Feb 09, 2015 at 01:55:23PM -0800, Junio C Hamano wrote: > Alex Henrie writes: > > > This is just a friendly reminder that this patch has been sitting in > > the mailing list archives for a couple of weeks, and it has not yet > > been accepted or commented on. > > I think that is because

Re: [PATCH] gitk: Enable mouse horizontal scrolling in diff pane

2015-03-21 Thread Paul Mackerras
On Sat, Nov 15, 2014 at 03:05:06PM +0100, Gabriele Mazzotta wrote: > Currently it's required to hold Shift and scroll up and down to move > horizontally. Listen to Button-6 and Button-7 events too to make > horizontal scrolling handier with touchpads and some mice. > > Signed-off-by: Gabriele Mazz

Re: [PATCH v5 0/3] gitk: save only changed configuration on exit

2015-03-21 Thread Paul Mackerras
On Wed, Mar 04, 2015 at 05:58:15AM +0200, Max Kirillov wrote: > The changes: > > * remove unused views_modified_names assignment > * use if {[catch...] to check saving error > * split error reporting from busy wait > > The busy wait parameters are unchanged, mostly because I did not have time >

Re: [PATCH] gitk: pass --invert-grep option down to "git log"

2015-03-21 Thread Paul Mackerras
On Sun, Feb 15, 2015 at 11:29:10PM -0800, Junio C Hamano wrote: > From: Christoph Junghans > Date: Mon, 12 Jan 2015 18:33:32 -0700 > > "git log --grep=" shows only commits with messages that > match the given string, but sometimes it is useful to be able to > show only commits that do *not* have

Re: [PATCH v4 2/2] gitk: synchronize config write

2015-03-01 Thread Paul Mackerras
On Mon, Nov 10, 2014 at 12:20:02AM +0200, Max Kirillov wrote: > If several gitk instances are closed simultaneously, safestuff procedure > can run at the same time, resulting in a conflict which may cause losing > of some of the instance's changes, failing the saving operation or even > corrupting

Re: [PATCH v4 1/2] gitk: write only changed configuration variables

2015-03-01 Thread Paul Mackerras
On Mon, Nov 10, 2014 at 12:20:01AM +0200, Max Kirillov wrote: > When gitk contains some changed parameter, and there is existing > instance of gitk where the parameter is still old, it is reverted to > that old value when the instance exits. > > Instead, store a parameter in config only it is has

Re: [PATCH v2 2/3] gitk: write only changed configuration variables

2014-10-30 Thread Paul Mackerras
On Sun, Sep 14, 2014 at 11:35:58PM +0300, Max Kirillov wrote: > When gitk contains some changed parameter, and there is existing > instance of gitk where the parameter is still old, it is reverted to > that old value when the instance exits. > > Instead, store a parameter in config only it is has

Re: [PATCH v2 1/3] gitk refactor: remove boilerplate for configuration variables

2014-10-30 Thread Paul Mackerras
On Sun, Sep 14, 2014 at 11:35:57PM +0300, Max Kirillov wrote: > Signed-off-by: Max Kirillov This is a nice simplification, applied, thanks. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-27 Thread Paul Mackerras
On Wed, Jun 18, 2014 at 07:53:14PM -0700, David Aguilar wrote: > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency > on mkdtemp, which is not available on Windows. > > Use the original temporary directory behavior when mkdtemp fails. > This makes the code use mkdtemp when available

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-27 Thread Paul Mackerras
On Thu, Jun 26, 2014 at 01:47:36PM -0700, Junio C Hamano wrote: > David Aguilar writes: > > > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency > > on mkdtemp, which is not available on Windows. > > > > Use the original temporary directory behavior when mkdtemp fails. > > This make

Re: [PATCH] gitk: use mktemp -d to avoid predictable temporary directories

2014-06-14 Thread Paul Mackerras
On Fri, Jun 13, 2014 at 02:43:48PM -0700, David Aguilar wrote: > gitk uses a predictable ".gitk-tmp.$PID" pattern when generating > a temporary directory. > > Use "mktemp -d .gitk-tmp.XX" to harden gitk against someone > seeding /tmp with files matching the pid pattern. > > Signed-off-by: Dav

Re: [PATCH] gitk: honor TMPDIR when viewing external diffs

2014-06-14 Thread Paul Mackerras
On Fri, Jun 13, 2014 at 02:13:37PM -0700, David Aguilar wrote: > gitk fails to show diffs when browsing a read-only repository. > This is due to gitk's assumption that the current directory is always > writable. > > Teach gitk to honor either the GITK_TMPDIR or TMPDIR environment > variables. Thi

Re: [PATCH] gitk: Allow displaying time zones from author and commit timestamps

2014-06-14 Thread Paul Mackerras
On Mon, May 12, 2014 at 07:25:58AM -0400, Anders Kaseorg wrote: > Now gitk can be configured to display author and commit dates in their > original timezone, by putting %z into datetimeformat in ~/.gitk. > > Signed-off-by: Anders Kaseorg Thanks, applied. Paul. -- To unsubscribe from this list:

Re: [PATCH] gitk: show staged submodules regardless of ignore config

2014-06-14 Thread Paul Mackerras
On Fri, Jun 06, 2014 at 02:08:29PM -0700, Junio C Hamano wrote: > From: Jens Lehmann > Date: Tue, 8 Apr 2014 21:36:08 +0200 > > Currently setting submodule..ignore and/or diff.ignoreSubmodules to > "all" suppresses all output of submodule changes for gitk. This is really > confusing, as even when

Re: [PATCH] gitk: switch to patch mode when searching for line origin

2014-06-14 Thread Paul Mackerras
On Sat, Apr 05, 2014 at 11:38:50PM +0300, Max Kirillov wrote: > If the "Show origin of this line" is started from tree mode, > it still shows the result in tree mode, which I suppose not > what user expects to see. Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] gitk: replace SHA1 entry field on keyboard paste

2014-06-14 Thread Paul Mackerras
On Thu, Mar 20, 2014 at 01:58:51AM -0700, Ilya Bobyr wrote: > We already replace old SHA with the clipboard content for the mouse > paste event. It seems reasonable to do the same when pasting from > keyboard. > > Signed-off-by: Ilya Bobyr Thanks, applied. Paul. -- To unsubscribe from this lis

Re: [PATCHv2] gitk: Replace "next" and "prev" buttons with down and up arrows.

2014-01-23 Thread Paul Mackerras
On Wed, Jan 22, 2014 at 12:18:27PM -0800, Junio C Hamano wrote: > Is this a good time for me to pull from you? I see these on your > 'master' branch. > > 8f86339 gitk: Comply with XDG base directory specification > 786f15c gitk: Replace "next" and "prev" buttons with down and up arrows >

Re: [PATCH v2] gitk: Comply with XDG base directory specification

2014-01-22 Thread Paul Mackerras
On Tue, Jan 21, 2014 at 07:10:16PM +, Astril Hayato wrote: > Write the gitk config data to $XDG_CONFIG_HOME/git/gitk > ($HOME/.config/git/gitk > by default) in line with the XDG specification. This makes it consistent with > git which also follows the spec. > > If $HOME/.gitk already exists u

Re: [PATCHv2] gitk: Replace "next" and "prev" buttons with down and up arrows.

2014-01-22 Thread Paul Mackerras
On Tue, Jan 21, 2014 at 10:33:02AM -0500, Marc Branchaud wrote: > On 13-12-18 11:04 AM, Marc Branchaud wrote: > > Users often find that "next" and "prev" do the opposite of what they > > expect. For example, "next" moves to the next match down the list, but > > that is almost always backwards in t

Re: [PATCH] gitk: chmod +x po2msg

2014-01-21 Thread Paul Mackerras
On Mon, Dec 02, 2013 at 11:12:43AM -0800, Junio C Hamano wrote: > From: Jonathan Nieder > Date: Mon, 25 Nov 2013 13:00:10 -0800 > > The Makefile only runs it using tclsh, but because the fallback po2msg > script has the usual tcl preamble starting with #!/bin/sh it can also > be run directly. >

Re: [PATCH] gitk i18n: Added Bulgarian translation (304t)

2014-01-21 Thread Paul Mackerras
On Wed, Jan 15, 2014 at 01:27:29PM +0200, al_sho...@yahoo.com wrote: > From: Alexander Shopov > > Signed-off-by: Alexander Shopov Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH] gitk: Comply with XDG base directory specification

2014-01-21 Thread Paul Mackerras
On Fri, Dec 13, 2013 at 07:46:36PM +, Astril Hayato wrote: > Write the gitk config data to $XDG_CONFIG_HOME/git/gitk > ($HOME/.config/git/gitk > by default) in line with the XDG specification. This makes it consistent with > git which also follows the spec. > > If $HOME/.gitk already exists u

Re: [PATCH] gitk: fix mistype

2014-01-21 Thread Paul Mackerras
On Sat, Jan 18, 2014 at 02:58:51PM +0200, Max Kirillov wrote: > Signed-off-by: Max Kirillov Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH v3 gitk 0/5] gitk -L

2013-12-01 Thread Paul Mackerras
On Sat, Nov 16, 2013 at 06:37:39PM +0100, Thomas Rast wrote: > These patches implement 'gitk -L'. They are exactly the same as the > gitk patches from v2 at > > http://thread.gmane.org/gmane.comp.version-control.git/227151/focus=236903 > > except that they apply to the gitk-git tree at > >

Re: [PATCH v2] gitk: make pointer selection visible in highlighted lines

2013-12-01 Thread Paul Mackerras
On Thu, Nov 28, 2013 at 11:20:18PM +0200, Max Kirillov wrote: > Custom tags have higher priority than `sel`, and when they define their > own background, it makes selection invisible. Especially inconvenient > for `filesep` (to select filenames), but also affects other tags. > Use `tag raise` to fi

Re: [PATCH v2] gitk: Add a horizontal scrollbar for commit history

2013-10-31 Thread Paul Mackerras
lay so that if there are more than 3 tags or they would take up more than a quarter of the width of the pane, we instead display a single tag icon with a legend inside it like "4 tags...". If the user clicks on the tag icon, gitk then displays all the tags in the diff display pane.

Re: [PATCH gitk 0/4] gitk support for git log -L

2013-08-18 Thread Paul Mackerras
Hi Thomas, On Wed, Jul 31, 2013 at 03:17:41PM +0200, Thomas Rast wrote: > Jens Lehmann writes: > > > Am 29.07.2013 21:37, schrieb Thomas Rast: > >> Thomas Rast writes: > >> > >>> Thomas Rast writes: > >>> > Now that git log -L has hit master, I figure it's time to discuss the > corr

Please pull one more gitk commit

2013-05-16 Thread Paul Mackerras
Junio, If there is still time to get stuff in for 1.8.3, please pull my gitk repository from the usual place to get the update to the Swedish translations that I just received from Peter Krefting. Thanks, Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mes

Re: [PATCH] gitk: Update Swedish translation (304t)

2013-05-16 Thread Paul Mackerras
On Thu, May 16, 2013 at 08:16:30AM +0100, Peter Krefting wrote: > The patch is attached gzipped to avoid character encoding issues. Thanks, applied. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] gitk: simplify file filtering

2013-05-13 Thread Paul Mackerras
On Mon, May 13, 2013 at 10:58:49AM +0200, Stefan Haller wrote: > > Would you also consider Tair Sabirgaliev's v2 patch for not launching > gitk in the background on Mac? This fixes a very serious usability > problem. > > Yes, I

Re: [PATCH] gitk: simplify file filtering

2013-05-13 Thread Paul Mackerras
On Sun, May 12, 2013 at 03:54:14PM -0700, Junio C Hamano wrote: > > Thanks; is this the last one for this cycle and is your usual branch > ready to be pulled? It is now; please pull from the usual place, git://ozlabs.org/~paulus/gitk.git. Thanks, Paul. -- To unsubscribe from this list: send the

Re: [PATCH] gitk: simplify file filtering

2013-05-12 Thread Paul Mackerras
On Sun, May 12, 2013 at 03:54:14PM -0700, Junio C Hamano wrote: > Paul Mackerras writes: > > > On Sat, Apr 27, 2013 at 05:01:39PM -0500, Felipe Contreras wrote: > >> git diff is perfectly able to do this with '-- files', no need for > >> manual fil

Re: [PATCH] gitk: simplify file filtering

2013-05-11 Thread Paul Mackerras
On Sat, Apr 27, 2013 at 05:01:39PM -0500, Felipe Contreras wrote: > git diff is perfectly able to do this with '-- files', no need for > manual filtering. > > Signed-off-by: Felipe Contreras Thanks, applied, with the commit message expanded to say that this makes gettreediffs do the same as getb

Re: [PATCH] gitk: Add menu item for reverting commits

2013-05-11 Thread Paul Mackerras
On Sat, Apr 27, 2013 at 04:36:13PM +0200, Knut Franke wrote: > Sometimes it's helpful (at least psychologically) to have this feature > easily accessible. Code borrows heavily from cherrypick. > > Signed-off-by: Knut Franke Thanks, applied, after undoing the linewrapping (done by your mailer?).

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-11 Thread Paul Mackerras
On Fri, May 10, 2013 at 11:13:22PM -0700, Jonathan Nieder wrote: > Paul Mackerras wrote: > > > I thought I had replied to this patch; maybe I only thought about it. > > > > Given that we already have a selector to choose between exact and > > regexp matching, it

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

2013-05-10 Thread Paul Mackerras
On Tue, May 07, 2013 at 01:17:18PM -0400, Martin Langhoff wrote: > I just did git rebase origin/master for the umpteenth time, which > reminded me this nice patch is still pending. > > ping? I thought I had replied to this patch; maybe I only thought about it. Given that we already have a select

Re: [PATCH] gitk: workaround Tcl/Tk Cmd-TAB behavior on OSX

2013-04-19 Thread Paul Mackerras
On Thu, Apr 11, 2013 at 01:02:48AM +0600, Tair Sabirgaliev wrote: > On OSX Tcl/Tk application windows are created behind all > the applications down the stack of windows. This is very > annoying, because once a gitk window appears, it's the > downmost window and switching to it is pain. > > The pa

Re: [PATCH] gitk: Display the date of a tag in a human friendly way.

2013-04-01 Thread Paul Mackerras
On Sun, Feb 03, 2013 at 06:37:42PM +, Anand Kumria wrote: > Hi Pau, > > I've not been able to find the canonical location of your gitk repository. > > I've tried kernel.org, samba.org and ozlabs.org; none of them to have > it - nor does any amount of google searching I do reveal the location.

Re: [Patch] gitk: added a file history browser

2013-04-01 Thread Paul Mackerras
On Wed, Feb 20, 2013 at 12:14:20AM +0100, Dirk wrote: > Hi, > > I added a file history browser for a single file in the gitk. I use git log > with the option --follow. This option is useful for the user switch from cvs > to git. He misses a history from only one file and the function "Highlight

  1   2   >