Michał Górny wrote:
> On Wed, 2018-08-15 at 14:31 -0700, Jonathan Nieder wrote:
>> It's not clear to me that the name is_status or SIGNATURE_STATUS
>> captures what this field represents. Aren't these all sigcheck
>> statuses? Can you describe briefly what distinguishes the cases where
>> this s
Nguyễn Thái Ngọc Duy wrote:
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -1489,7 +1489,7 @@ int cmd_commit(int argc, const char **argv, const char
> *prefix)
> STATUS_FORMAT_LONG),
> OPT_BOOL('z', "null", &s.null_termination,
>
On Wed, 2018-08-15 at 14:31 -0700, Jonathan Nieder wrote:
> Michał Górny wrote:
>
> > GnuPG supports creating signatures consisting of multiple signature
> > packets. If such a signature is verified, it outputs all the status
> > messages for each signature separately. However, git currently doe
Hi,
Ævar Arnfjörð Bjarmason wrote:
> Extend the NO_TCLTK=NoThanks flag to be understood by the
> Documentation Makefile.
>
> Before this change compiling and installing with NO_TCLTK would result
> in no git-gui, gitk or git-citool being installed, but their
> respective manual pages would still
On Wed, Aug 15, 2018 at 07:49:25AM +0200, Christian Couder wrote:
> > And so here the convention is simpler, because we're talking about the
> > main HEAD. But we still have know if you want to do that, and not update
> > some refs/remotes/ symref in a bare repo.
>
> We could maybe look at the "r
Hi,
Agis wrote:
> On 16 Aug 2018, at 15:08, Agis wrote:
>>$ mkdir foo
>>$ git clone g...@github.com:agis/private.git foo
>>Cloning into 'foo'...
>>Permission denied (publickey).
>>fatal: Could not read from remote repository.
[...]
>>$ ls foo
>>ls: cannot access 'foo'
Jeff King writes:
> Here are _my_ opinions on how we should fill the role
> ...
> So here are the nominations I came up with. If you'd like to nominate
> somebody else (or yourself!), please do. If you have opinions, let me
> know (public or private, as you prefer).
>
> - Christian Couder
>
This is a followup to the issue I raised back in March[1], which is
that our project committee at Software Freedom Conservancy has two
members, but is required by the charter to have at least three.
There wasn't any substantive discussion in response to that email or at
the contributor summit. I i
Andrei Rybak writes:
> On 14/08/18 13:47, SZEDER Gábor wrote:
>> ... both
>> invocations produce empty 'pack{a,b}.objects' files, and the
>> subsequent 'test_cmp' happily finds those two empty files identical.
>
> Is test_cmp ever used for empty files? Would it make sense for
> test_cmp to issue
Duy Nguyen writes:
> On Thu, Aug 16, 2018 at 7:01 PM Junio C Hamano wrote:
>>
>> Nguyễn Thái Ngọc Duy writes:
>>
>> > The description of this key does not really tell what 'minimal' mode
>> > checks exactly. More information about this mode can be found in the
>> > commit message of c08e4d5b5c
Jeff King writes:
> On Thu, Aug 16, 2018 at 11:57:14AM -0400, Jeff King wrote:
>
>> The only way to solve that is to count bytes. We don't have a total byte
>> count in most cases, and it wouldn't always make sense (e.g., the
>> "Compressing objects" meter can show the same issue, but it's not re
--
Good-Day!,
Can you assist me to handle this transaction? I will forward you the
full details about the transaction if you are ready.
Yours faithfully
Mr. Malik Sanfo
--
Now, there is a parallel "rebase-i-in-c" effort going on, and of
course, setting various shell various and formulating a command line
that essentially does
. git-rebase--$backend
of course stops working.
> +static int run_specific_rebase(struct rebase_options *opts)
> +{
> + const c
Hi,
On Thu, Aug 16, 2018 at 1:25 AM, Thomas Gummerer wrote:
> On 08/08, Paul-Sebastian Ungureanu wrote:
>> Hello,
>>
>> Here is the whole `git stash` C version. Some of the previous
>> patches were already reviewed (up to and including "stash: convert
>> store to builtin"), but there are some whi
On Thu, Aug 16, 2018 at 04:55:56PM -0400, Jeff King wrote:
> > * We spend the majority of the ~30s on this:
> >
> > https://github.com/git/git/blob/63749b2dea5d1501ff85bab7b8a7f64911d21dea/pack-check.c#L70-L79
>
> This is hashing the actual packfile. This is potentially quite long,
> especia
On Thu, Aug 16, 2018 at 10:35:53PM +0200, Ævar Arnfjörð Bjarmason wrote:
> This is all interesting, but I think unrelated to what Ulrich is talking
> about. Quote:
>
> Between the two phases of "git fsck" (checking directories and
> checking objects) there was a break of several seconds w
On 14/08/18 13:47, SZEDER Gábor wrote:
> ... both
> invocations produce empty 'pack{a,b}.objects' files, and the
> subsequent 'test_cmp' happily finds those two empty files identical.
Is test_cmp ever used for empty files? Would it make sense for
test_cmp to issue warning when an empty file is bei
Junio C Hamano writes:
> Elia Pinto writes:
>
>> diff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh
>> index be6e09314..658647d83 100755
>> --- a/t/t2025-worktree-add.sh
>> +++ b/t/t2025-worktree-add.sh
>> @@ -252,6 +252,11 @@ test_expect_success 'add -B' '
>> test_cmp_rev maste
Elia Pinto writes:
> diff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh
> index be6e09314..658647d83 100755
> --- a/t/t2025-worktree-add.sh
> +++ b/t/t2025-worktree-add.sh
> @@ -252,6 +252,11 @@ test_expect_success 'add -B' '
> test_cmp_rev master^ poodle
> '
>
> +test_expect
On Thu, Aug 16 2018, Jeff King wrote:
> On Thu, Aug 16, 2018 at 08:54:25AM +0200, Ulrich Windl wrote:
>
>> I'd like to point out some minor issue observed while processing some
>> 5-object repository with many binary objects, but most are rather
>> small:
>>
>> Between the two phases of "git
On Thu, Aug 16, 2018 at 11:57:14AM -0400, Jeff King wrote:
> The only way to solve that is to count bytes. We don't have a total byte
> count in most cases, and it wouldn't always make sense (e.g., the
> "Compressing objects" meter can show the same issue, but it's not really
> putting through byt
On Thu, Aug 16, 2018 at 11:52:13AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > I think that makes sense. We already see duplicates from
> > for_each_packed_object() when they're in multiple packs, and callers
> > just need to be ready to deal with it (and depending on what you're
> >
On Thu, Aug 16, 2018 at 8:39 PM Jeff King wrote:
>
> On Thu, Aug 16, 2018 at 08:31:17PM +0200, Nguyễn Thái Ngọc Duy wrote:
>
> > I just realized how often I type "git ci --amend". Looking back at my
> > ~/.bash_history (only 10k lines) this is the second most often git
> > command I type which may
Jeff King writes:
> I think that makes sense. We already see duplicates from
> for_each_packed_object() when they're in multiple packs, and callers
> just need to be ready to deal with it (and depending on what you're
> doing, you may actually _want_ the duplicates).
You of course would also see
On Thu, Aug 16 2018, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
>> On Thu, Aug 16, 2018 at 12:54 PM, Shani Fridman
>> wrote:
>>>
>>> Hi everybody,
>>>
>>> I've got a question regarding submodules -
>>>
>>> I'm working on a git project with submodules connected to it, and pulling
On Thu, Aug 16, 2018 at 08:31:17PM +0200, Nguyễn Thái Ngọc Duy wrote:
> I just realized how often I type "git ci --amend". Looking back at my
> ~/.bash_history (only 10k lines) this is the second most often git
> command I type which may justify a short option for it (assuming that
> other people
On Thu, Aug 16, 2018 at 8:27 PM Ben Peart wrote:
>
> From: Ben Peart
>
> Skip merging the commit, updating the index and working directory if and
> only if we are creating a new branch via "git checkout -b ."
> Any other checkout options will still go through the former code path.
>
> If sparse_c
I just realized how often I type "git ci --amend". Looking back at my
~/.bash_history (only 10k lines) this is the second most often git
command I type which may justify a short option for it (assuming that
other people use this option often too, of course).
The short option space for 'git commit'
From: Ben Peart
Skip merging the commit, updating the index and working directory if and
only if we are creating a new branch via "git checkout -b ."
Any other checkout options will still go through the former code path.
If sparse_checkout is on, require the user to manually opt in to this
optim
Introduce the config "submodule..gitdirpath" which is used to
indicate where a submodule's gitdir is located inside of a repository's
"modules" directory.
Signed-off-by: Brandon Williams
---
Maybe something like this on top? Do you think we should disallow "../"
in this config, even though it i
On Thu, Aug 16, 2018 at 7:01 PM Junio C Hamano wrote:
>
> Nguyễn Thái Ngọc Duy writes:
>
> > The description of this key does not really tell what 'minimal' mode
> > checks exactly. More information about this mode can be found in the
> > commit message of c08e4d5b5c (Enable minimal stat checkin
Ævar Arnfjörð Bjarmason writes:
> On Thu, Aug 16, 2018 at 12:54 PM, Shani Fridman
> wrote:
>>
>> Hi everybody,
>>
>> I've got a question regarding submodules -
>>
>> I'm working on a git project with submodules connected to it, and pulling
>> changes from them every month (more or less).
>> Som
samuel.maft...@gmail.com writes:
> From: Samuel Maftoul
>
> Add support for configuring default sort ordering for git branches. Command
> line option will override this configured value, using the exact same
> syntax.
Using the exact same syntax as ...?
> Signed-off-by: Samuel Maftoul
> ---
>
On Thu, Aug 16, 2018 at 12:54 PM, Shani Fridman
wrote:
>
> Hi everybody,
>
> I've got a question regarding submodules -
>
> I'm working on a git project with submodules connected to it, and pulling
> changes from them every month (more or less).
> Sometimes I need to checkout older versions of th
Christian Couder writes:
> From: Jeff King
>
> Signed-off-by: Jeff King
> Signed-off-by: Christian Couder
> ---
> t/t5319-delta-islands.sh | 143 +++
> 1 file changed, 143 insertions(+)
> create mode 100755 t/t5319-delta-islands.sh
I should have told you
On Thu, Aug 16, 2018 at 01:19:17AM +0100, Ramsay Jones wrote:
> As a quick ("just before bedtime") exercise, I tried adding
> a Makefile target to perform a similar check. The result is
> given below, but I haven't had time to look too closely at
> the results:
The resulting patch doesn't look to
On Wed, Aug 15, 2018 at 10:05:04AM -0400, Derrick Stolee wrote:
> One thing that I realized while reading it is that the multi-pack-index is
> not integrated into the for_each_packed_object method. I was already going
> to work on some cleanups in that area [1][2].
>
> When using the new flag wit
Stefan Beller writes:
> The change a086f921a72 (submodule: decouple url and submodule interest,
> 2017-03-17) enables us to do more than originally thought.
> As the url setting was used both to actually set the url where to
> obtain the submodule from, as well as used as a boolean flag later
> t
On Wed, Aug 15, 2018 at 09:28:44AM -0400, Derrick Stolee wrote:
> On 8/10/2018 7:15 PM, Jeff King wrote:
> > diff --git a/commit-graph.c b/commit-graph.c
> > index b0a55ad128..69a0d1c203 100644
> > --- a/commit-graph.c
> > +++ b/commit-graph.c
> > @@ -730,7 +730,7 @@ void write_commit_graph(const
On 08/15, Jonathan Nieder wrote:
> Stefan Beller wrote:
> > Jonathan Nieder wrote:
>
> >> All at the cost of recording a little configuration somewhere. If we
> >> want to decrease the configuration, we can avoid recording it there in
> >> the easy cases (e.g. when name == gitdirname). That's "j
On Thu, Aug 16, 2018 at 9:50 AM Mark Nudelman
wrote:
>
> So I'm not sure what the best solution is. Linus's proposal to disable
> the line counting stuff if -X is set seems reasonable. I will look into
> that and see if there are any issues with it.
One option that I didn't try to go for - beca
Stefan Beller writes:
> While at it fix a typo (s/independed/independent) and
> make sure git is not in a chain of pipes.
>
> Signed-off-by: Stefan Beller
> ---
> t/t7410-submodule-checkout-to.sh | 99 +++-
> 1 file changed, 58 insertions(+), 41 deletions(-)
Makes s
Nguyễn Thái Ngọc Duy writes:
> The description of this key does not really tell what 'minimal' mode
> checks exactly. More information about this mode can be found in the
> commit message of c08e4d5b5c (Enable minimal stat checking -
> 2013-01-22).
>
While I agree that we need to do _something_
Nguyễn Thái Ngọc Duy writes:
> --quit is supposed to be --abort but without restoring HEAD. Leaving
> CHERRY_PICK_HEAD behind could make other commands mistake that
> cherry-pick is still ongoing (e.g. "git commit --amend" will refuse to
> work). Clean it too.
>
> For --abort, this job of deleti
-X is a workaround for the previous behavior of -F, but it's not a great
solution. By not sending the terminal init sequence, some things can be
broken, depending on the terminal. For example, some terminals send the
"wrong" sequences for the arrow keys when the terminal doesn't receive
the i
Torsten Bögershausen writes:
> check_stat is 0 on Windows, and inum is allways 0 in lstat().
> I was thinking about systems which don't have inodes and inum,
> and then generate an inum in memory, sometimes random.
> After a reboot or a re-mount of the file systems those ino values
> change.
> Ho
Ramsay Jones writes:
> BTW, I happen to be on the 'pu' branch.
>
> I think some of the errors are due to missing compiler flags
> (-I, -D, etc); which flags did you pass to the compiler?
>
> Well, it killed 15min. before bed! ;-)
>
> ATB,
> Ramsay Jones
It certainly does look fun. I anticipate
--quit is supposed to be --abort but without restoring HEAD. Leaving
CHERRY_PICK_HEAD behind could make other commands mistake that
cherry-pick is still ongoing (e.g. "git commit --amend" will refuse to
work). Clean it too.
For --abort, this job of deleting CHERRY_PICK_HEAD is on "git reset"
so we
On Thu, Aug 16, 2018 at 05:18:51PM +0200, Duy Nguyen wrote:
> > During "git gc" the writing objects phase did not update for some
> > seconds, but then the percentage counter jumped like from 15% to
> > 42%.
> [...]
>
> Is it possible to make this repository public? You can also use "git
> fast-e
Phillip Wood writes:
> This commit implements a minimal fix which fixes the crash and allows
> the user to successfully commit a conflict resolution with 'git rebase
> --continue'. It does not write .git/rebase-merge/patch,
> .git/rebase-merge/stopped-sha or update REBASE_HEAD.
I think that shou
The description of this key does not really tell what 'minimal' mode
checks exactly. More information about this mode can be found in the
commit message of c08e4d5b5c (Enable minimal stat checking -
2013-01-22).
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt | 2 ++
1 file chan
On Thu, Aug 16, 2018 at 08:54:25AM +0200, Ulrich Windl wrote:
> I'd like to point out some minor issue observed while processing some
> 5-object repository with many binary objects, but most are rather
> small:
>
> Between the two phases of "git fsck" (checking directories and
> checking obje
Ævar Arnfjörð Bjarmason writes:
> However, manually going over:
>
> git grep -e OPT_HIDDEN_BOOL -e PARSE_OPT_HIDDEN
>
> Shows many options we don't want to show in completion either,
> e.g. "git am --binary" or "git branch -l". Many of these are internal,
> deprecated, or no-ops. There's als
On Thu, Aug 16, 2018 at 8:12 AM Junio C Hamano wrote:
>
> Stefan Beller writes:
>
> > Originally we have had the url in the config, (a) that we can change
> > the URLs after the "git submodule init" and "git submodule update"
> > step that actually clones the submodule if not present and mu
On Thu, Aug 16, 2018 at 4:03 PM Torsten Bögershausen wrote:
> check_stat is 0 on Windows,
How? check_stat is 1 by default. And "git init" does not add this key
on new repos.
> Now back to the compiler switch:
> Windows always set inum to 0 and I can't think about a situation where
> a file in a
On Thu, Aug 16, 2018 at 1:10 PM Ulrich Windl
wrote:
>
> Hi!
>
> I'd like to point out some minor issue observed while processing some
> 5-object repository with many binary objects, but most are rather small:
>
> Between the two phases of "git fsck" (checking directories and checking
> objec
Stefan Beller writes:
> Originally we have had the url in the config, (a) that we can change
> the URLs after the "git submodule init" and "git submodule update"
> step that actually clones the submodule if not present and much more
> importantly (b) to know which submodule "was initializ
The PARSE_OPT_HIDDEN is, per the documentation of the "option" struct
in option parse-options.h, only supposed to affect -h output, not
completion. That's what the PARSE_OPT_NOCOMPLETE flag is supposed to
be for.
Since 2e29dca66a ("completion: use __gitcomp_builtin in _git_commit",
2018-02-09) we'
On Thu, Aug 16, 2018 at 3:50 PM Hadi Safari wrote:
>
> Hi!
>
> I'm wondering why there isn't --allow-empty and --allow-empty-message in
> completeion list of git commit command.
This is because they are marked "hidden" in the code. If you do "git
commit -h", they will not show up either. Ævar pro
Jonathan Nieder writes:
> So it would be nice, for future-proofing, if we can change the naming
> scheme later.
> ...
> All at the cost of recording a little configuration somewhere. If we
> want to decrease the configuration, we can avoid recording it there in
> the easy cases (e.g. when name =
Stefan Beller writes:
>>
>> * sb/config-write-fix (2018-08-08) 3 commits
>> - git-config: document accidental multi-line setting in deprecated syntax
>> - config: fix case sensitive subsection names on writing
>> - t1300: document current behavior of setting options
>>
>> Recent update to "gi
On Thu, Aug 16, 2018 at 4:55 AM Shani Fridman
wrote:
>
>
> Hi everybody,
>
> I've got a question regarding submodules -
>
> I'm working on a git project with submodules connected to it, and pulling
> changes from them every month (more or less).
> Sometimes I need to checkout older versions of th
On Thu, Aug 16, 2018 at 6:15 AM Derrick Stolee wrote:
>
> On 8/15/2018 7:01 PM, Junio C Hamano wrote:
> > * ds/commit-graph-with-grafts (2018-07-19) 8 commits
> >(merged to 'next' on 2018-08-02 at 0ee624e329)
> > + commit-graph: close_commit_graph before shallow walk
> > + commit-graph: no
On Wed, Aug 15, 2018 at 12:38:49PM -0700, Junio C Hamano wrote:
This should answer Duys comments as well.
> Torsten Bögershausen writes:
>
[snip]
> > Should the following be protected by core.checkstat ?
> > if (check_stat) {
>
> I do not think such a if statement is strictly necessary.
>
On 8/15/2018 7:01 PM, Junio C Hamano wrote:
* ds/commit-graph-with-grafts (2018-07-19) 8 commits
(merged to 'next' on 2018-08-02 at 0ee624e329)
+ commit-graph: close_commit_graph before shallow walk
+ commit-graph: not compatible with uninitialized repo
+ commit-graph: not compatible wit
Nevermind, this is does not happen in 2.18.0. Apparently it was fixed somewhere
between 2.11 and 2.18.
> On 16 Aug 2018, at 15:08, Agis wrote:
>
> Hello.
>
> I've recently observed the following:
>
>$ mkdir foo
>$ # try to clone from a repository that you have no access to
>$ git
Hello.
I've recently observed the following:
$ mkdir foo
$ # try to clone from a repository that you have no access to
$ git clone g...@github.com:agis/private.git foo
Cloning into 'foo'...
Permission denied (publickey).
fatal: Could not read from remote repository.
P
Hi everybody,
I've got a question regarding submodules -
I'm working on a git project with submodules connected to it, and pulling
changes from them every month (more or less).
Sometimes I need to checkout older versions of the project (tags or specific
commits), that needs the older versions
Hi Eric,
On Thu, 16 Aug 2018 at 10:25, Eric Sunshine wrote:
> (/me nudges Martin off the fence onto the side of not bothering to
> mention the obvious)
:-)
Thanks for sanity-checking my thoughts. I agree with everything you
wrote in your reply (and, FWIW, your other findings that you sent
separ
From: Samuel Maftoul
Add support for configuring default sort ordering for git branches. Command
line option will override this configured value, using the exact same
syntax.
Signed-off-by: Samuel Maftoul
---
Documentation/config.txt | 6 +
Documentation/git-branch.txt | 5 ++--
buil
On Thu, Aug 16, 2018 at 4:06 AM wrote:
> Add support for configuring default sort ordering for git branches. Command
> line option will override this configured value, using the exact same
> syntax.
>
> Signed-off-by: Samuel Maftoul
> ---
> diff --git a/Documentation/config.txt b/Documentation/co
On Wed, Aug 15, 2018 at 4:56 PM Elia Pinto wrote:
> Add the '--quiet' option to git worktree,
> as for the other git commands. 'add' is the
> only command affected by it since all other
> commands, except 'list', are currently
> silent by default.
Nit: wrap the commit message at around 70 columns
Hi,
On Wed, 15 Aug 2018, Junio C Hamano wrote:
> Phillip Wood writes:
>
> >> I wonder if it makes it easier to read, understand and maintain if
> >> there were a local variable that gets opts->current_fixup_count+2 at
> >> the beginning of the function, make these three places refer to that
> >
Hi Phillip,
On Wed, 15 Aug 2018, Phillip Wood wrote:
> From: Phillip Wood
>
> If a merge command in the todo list specifies just a branch to merge
> with no -C/-c argument then item->commit is NULL. This means that if
> there are merge conflicts error_with_patch() is passed a NULL commit
> whic
On Thu, Aug 16, 2018 at 12:41 AM Martin Ågren wrote:
> On Wed, 15 Aug 2018 at 22:56, Elia Pinto wrote:
> The word "currently" means I can't shake the feeling that Eric has a
> very good point in [1]:
>
> It might make sense to say instead that this is adding a --quiet
> option _in general_, r
Hi Stefan,
On Tue, 14 Aug 2018, Stefan Beller wrote:
> On Tue, Aug 14, 2018 at 11:54 AM Johannes Schindelin
> wrote:
> >
> > On Mon, 13 Aug 2018, Stefan Beller wrote:
> >
> > > > > The later lines that indicate a change to the Makefile will be
> > > > > treated as context both in the outer and i
On Wed, Aug 15 2018, Linus Torvalds wrote:
> On Wed, Aug 15, 2018 at 2:29 PM Ævar Arnfjörð Bjarmason
> wrote:
>>
>> Downloading & trying versions of it locally reveals that it's as of
>> version 520, not 530. The last version before 520 is 487. Presumably
>> it's covered by this item in the cha
From: Samuel Maftoul
Add support for configuring default sort ordering for git branches. Command
line option will override this configured value, using the exact same
syntax.
Signed-off-by: Samuel Maftoul
---
Documentation/config.txt | 6 +
Documentation/git-branch.txt | 3 +++
built
Hi!
I'm wondering why there isn't --allow-empty and --allow-empty-message in
completeion list of git commit command. I'm getting only following flags
from v2.18.0 on `git commit --`:
--ahead-behind --include --reedit-message=
--all --interactive --reset-auth
On 25/5/1397 AP 10:53 AM, Torsten Bögershausen wrote:
This repo seams not ment to be cloned onto a file system, which is
case-insensitive.
For example, (see below), this 2 files a different in the repo, but the file
system
can not have 'WordPress' and 'Wordpres's as different files or directori
80 matches
Mail list logo
