Hi Stefan, On Tue, 14 Aug 2018, Stefan Beller wrote:
> On Tue, Aug 14, 2018 at 11:54 AM Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: > > > > On Mon, 13 Aug 2018, Stefan Beller wrote: > > > > > > > The later lines that indicate a change to the Makefile will be > > > > > treated as context both in the outer and inner diff, such that > > > > > those lines stay regular color. > > > > > > > > While I am a fan of having those lines colored correctly, I have > > > > to admit that I am not exactly enthusiastic about that extra > > > > indentation... > > > > > > > > Otherwise, this looks good to me. > > > > > > Can you explain what makes you less enthused about the indentation? > > > > > > Advantage: > > > * allows easy coloring (easy implementation) > > > Disadvantage: > > > * formats change, > > > > This is it. It breaks my visual flow. > > > > > but the range diff is still in its early design phase, so we're not > > > breaking things, yet? > > > > Indeed. We're not breaking things. If you feel strongly about it, we > > can have that indentation, I *can* get used to it. > > I only feel strongly about it now as that is the *easiest* way to make > the colors look like I want them to look. And I really value colors in > the range-diff. Earlier you said that color-less range-diff is nearly > useless for you and I thought it was hyperbole, but by now I realize how > much truth you spoke. So getting the colors fixed to not markup files > (+++/ --- lines of the inner diff) is a high priority for me. So high > that I would compromise on the indentation/flow of these corner case > areas. Okay, let's go with your indentation, then. Ciao, Dscho
