On Thu, 29 Aug 2013 10:41:08 +0400
Sergey Popov wrote:
> 28.08.2013 20:06, hasufell пишет:
> > On 08/28/2013 05:53 PM, "Paweł Hajdan, Jr." wrote:
> And if WORKDIR will contain whitespace(s), does this code still be
> working? :-)
>
> // sorry for bikeshedding, can not resist
Just try it out ...
Dnia 2013-08-29, o godz. 10:41:08
Sergey Popov napisał(a):
> 28.08.2013 20:06, hasufell пишет:
> > On 08/28/2013 05:53 PM, "Paweł Hajdan, Jr." wrote:
> >>>
> >>> S=${WORKDIR}/SDL2_mixer-${PV}
> >
> >> Why no quotes? ("")
> >
> >
> >>> S=${WORKDIR}/${MY_P}
> >
> >> Why no quotes? ("")
> >
> >
28.08.2013 20:06, hasufell пишет:
> On 08/28/2013 05:53 PM, "Paweł Hajdan, Jr." wrote:
>>>
>>> S=${WORKDIR}/SDL2_mixer-${PV}
>
>> Why no quotes? ("")
>
>
>>> S=${WORKDIR}/${MY_P}
>
>> Why no quotes? ("")
>
>
>>> S=${WORKDIR}/SDL2_ttf-${PV}
>
>> I suggest quotes ("").
>
>
>
> Those are var
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/28/2013 05:53 PM, "Paweł Hajdan, Jr." wrote:
>>
>> S=${WORKDIR}/SDL2_mixer-${PV}
>
> Why no quotes? ("")
>
>
>> S=${WORKDIR}/${MY_P}
>
> Why no quotes? ("")
>
>
>> S=${WORKDIR}/SDL2_ttf-${PV}
>
> I suggest quotes ("").
>
Those are vari
Just small, very small comments. To avoid being accused of bikeshedding,
I'm totally fine if you don't apply any of them. It's entirely up to you. :)
https://bugs.gentoo.org/show_bug.cgi?id=480826 :
> if use directfb ; then
> # since DirectFB can link against SDL and trigger a
On Wed, 28 Aug 2013 16:37:44 +0200
hasufell wrote:
From a fairly quick review:
> smpeg2: https://bugs.gentoo.org/show_bug.cgi?id=481792
https://481792.bugs.gentoo.org/attachment.cgi?id=356542
What if what the debug flag does is changed in the future?
I'd suggest to drop the flag and patch the
