On Wed, 28 Aug 2013 16:37:44 +0200 hasufell <hasuf...@gentoo.org> wrote:
From a fairly quick review: > smpeg2: https://bugs.gentoo.org/show_bug.cgi?id=481792 https://481792.bugs.gentoo.org/attachment.cgi?id=356542 What if what the debug flag does is changed in the future? I'd suggest to drop the flag and patch the build system. Other than that I don't see any questionable matters. The rest of my suggestions would be bikeshedding as you say, because it depends on your own idea of it; eg. a lot of dependencies have no slots, etc... Thank you for bringing this to the Portage tree, it has a huge demand. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
signature.asc
Description: PGP signature
