28.08.2013 20:06, hasufell пишет:
> On 08/28/2013 05:53 PM, "Paweł Hajdan, Jr." wrote:
>>>
>>> S=${WORKDIR}/SDL2_mixer-${PV}
> 
>> Why no quotes? ("")
> 
> 
>>> S=${WORKDIR}/${MY_P}
> 
>> Why no quotes? ("")
> 
> 
>>> S=${WORKDIR}/SDL2_ttf-${PV}
> 
>> I suggest quotes ("").
> 
> 
> 
> Those are variable assignments and don't need a quote.
> 

And if WORKDIR will contain whitespace(s), does this code still be
working? :-)

// sorry for bikeshedding, can not resist

-- 
Best regards, Sergey Popov
Gentoo developer
Gentoo Desktop Effects project lead
Gentoo Qt project lead
Gentoo Proxy maintainers project lead

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to