Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-23 Thread leerho
Justin, Thank you for the vote. The code for this Release Candidate was frozen as of Tuesday, 17 September at 17:54 GMT. Since that time our team has engaged with you a number of times to perfect our handling of the LICENSE and NOTICE files. The current version of how these two files will look

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-22 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - hashed and signatures fine - DISCLAIMER exists (and is WIP version) - LICENSE and NOTICE need more work (se below) - No unexpected binary files - All source files have ASF headers - Can compile from source This code [1][2] inside [3] is missing

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-21 Thread Kevin Ratnasekera
+1 ( binding ) - Incubating in name - DISCLAIMER exists - Checked PGP signatures - Checked Checksums - Code builds from maven and Unit tests passes Regards Kevin On Wed, Sep 18, 2019 at 3:42 AM Dave Fisher wrote: > > > > On Sep 17, 2019, at 2:01 PM, leerho wrote: > > > > Dave, > > > > Is thi

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-17 Thread Dave Fisher
> On Sep 17, 2019, at 2:01 PM, leerho wrote: > > Dave, > > Is this what you are looking for? Yes! Regards, Dave > > Lee. > > On Tue, Sep 17, 2019 at 1:05 PM Dave Fisher > wrote: > > > > On Sep 17, 2019, at 12:47 PM, leerho > > wrote: > >

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-17 Thread leerho
Dave, Is this what you are looking for? Lee. On Tue, Sep 17, 2019 at 1:05 PM Dave Fisher wrote: > > > > On Sep 17, 2019, at 12:47 PM, leerho wrote: > > > > Dave, > > > > Thanks for your vote! > > > > Please elaborate on: > > > >> I had to “guess” at the build instruction - `mvn clean install`

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-17 Thread Dave Fisher
> On Sep 17, 2019, at 12:47 PM, leerho wrote: > > Dave, > > Thanks for your vote! > > Please elaborate on: > >> I had to “guess” at the build instruction - `mvn clean install` > > > What additional instructions should I add ? The README.md should explicitly mention `mvn clean install` al

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-17 Thread leerho
Dave, Thanks for your vote! Please elaborate on: > I had to “guess” at the build instruction - `mvn clean install` What additional instructions should I add ? Also, we have been corresponding with Justin on the structure of the LICENSE and NOTICE files and will get this straightened out with

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-17 Thread Furkan KAMACI
Hi, +1 (binding - carrying my vote) Kind Regards, Furkan KAMACI On Tue, Sep 17, 2019 at 8:54 PM leerho wrote: > ### NEW COMPONENT! ### > > Hello Apache DataSketches IPMC and Community, > > 1. This is a call for vote to release Apache DataSketches-java version: > 1.0.0-incubating-RC2 > > N

Re: [VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-17 Thread Dave Fisher
+1 (binding) - Incubating in name - DISCLAIMER exists - LICENSE and NOTICE are fine - No unexpected binary files - Checked PGP signatures - Checked Checksums - Code compiles and tests successfully run I had to “guess” at the build instruction - `mvn clean instal

[VOTE] Release DataSketches-java 1.0.0-incubating-RC2

2019-09-17 Thread leerho
### NEW COMPONENT! ### Hello Apache DataSketches IPMC and Community, 1. This is a call for vote to release Apache DataSketches-java version: 1.0.0-incubating-RC2 NOTE 1: This is the core Java component of the DataSketches library that includes all the sketch algorithms in production-ready p