Justin, Thank you for the vote.
The code for this Release Candidate was frozen as of Tuesday, 17 September at 17:54 GMT. Since that time our team has engaged with you a number of times to perfect our handling of the LICENSE and NOTICE files. The current version of how these two files will look in the next release can be found in the GitHub master branch: https://github.com/apache/incubator-datasketches-java. If you still find that these new versions of the LICENSE and NOTICE files do not meet your requirements, please let us know. With respect to the 9 items mentioned above: Items 1, 2, 3, are appropriately mentioned in the new version of the LICENSE referenced above. (They were mentioned in the RC2 version but in the wrong place.) Item 4 is mentioned under the Public Domain section of the new LICENSE. Items 5, 7, 8, 9 are references to published research papers (arxiv.org is a repository of scientific research papers) There is no code in these papers that was copied or even adapted in our product. Referencing these papers allows users to find the mathematical proofs of why these algorithms work. Item 6 is a reference to our own website and our own work. Thank you for the time you have spent on this! Lee. On Sun, Sep 22, 2019 at 12:40 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - hashed and signatures fine > - DISCLAIMER exists (and is WIP version) > - LICENSE and NOTICE need more work (se below) > - No unexpected binary files > - All source files have ASF headers > - Can compile from source > > This code [1][2] inside [3] is missing from LICENSE. ([2] is also > mentioned in other files). This is also missing from LICENSE [4]. > > How is [5] licensed? (it’s used by [6]). Similarly with [7][8][9] used by > other pieces of code. > > NOTICE contains license information which should be placed in LICENSE. The > ASF copyright in NOTICE should probably come first. > > There are also still some references to https://datasketches.github.io > that probably need to be corrected. > > Thanks, > Justin > > 1. https://github.com/OpenHFT/Zero-Allocation-Hashing > 2. https://github.com/Cyan4973/xxHash > 3. ./src/main/java/org/apache/datasketches/hash/XxHash.java > 4. https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp > 5. https://arxiv.org/abs/1603.05346v1 > 6 ./src/main/java/org/apache/datasketches/kll/KllFloatsSketch.java > 7 https://arxiv.org/abs/1708.06839 > 8 https://arxiv.org/abs/1306.3284 > 9 http://dblp.org/rec/html/journals/tods/AgarwalCHPWY13 > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
