Hi, +1 (binding)
I checked: - incubating in name - hashed and signatures fine - DISCLAIMER exists (and is WIP version) - LICENSE and NOTICE need more work (se below) - No unexpected binary files - All source files have ASF headers - Can compile from source This code [1][2] inside [3] is missing from LICENSE. ([2] is also mentioned in other files). This is also missing from LICENSE [4]. How is [5] licensed? (it’s used by [6]). Similarly with [7][8][9] used by other pieces of code. NOTICE contains license information which should be placed in LICENSE. The ASF copyright in NOTICE should probably come first. There are also still some references to https://datasketches.github.io that probably need to be corrected. Thanks, Justin 1. https://github.com/OpenHFT/Zero-Allocation-Hashing 2. https://github.com/Cyan4973/xxHash 3. ./src/main/java/org/apache/datasketches/hash/XxHash.java 4. https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp 5. https://arxiv.org/abs/1603.05346v1 6 ./src/main/java/org/apache/datasketches/kll/KllFloatsSketch.java 7 https://arxiv.org/abs/1708.06839 8 https://arxiv.org/abs/1306.3284 9 http://dblp.org/rec/html/journals/tods/AgarwalCHPWY13 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
