Re: [PATCH v2] ARM: Block predication on atomics [PR111235]

2023-10-03 Thread Maxim Kuvyrkov
Cauldron presentation. "Green/Red" in patchwork mean the usual PASS/FAIL. It's only in post-commit CI in jenkins interface green and red mean something different. -- Maxim Kuvyrkov https://www.linaro.org

[PATCH] Format gotools.sum closer to what DejaGnu does

2023-11-02 Thread Maxim Kuvyrkov
... to restore compatability with validate_failures.py . The testsuite script validate_failures.py expects "Running ..." to extract values, and gotools.sum provided "Running ". Note that libgo.sum, which also uses Makefile logic to generate DejaGnu-like output, already has "..." suffix. gotools

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-11-02 Thread Maxim Kuvyrkov
Patch proposed at https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635000.html -- Maxim Kuvyrkov https://www.linaro.org > On Sep 27, 2023, at 18:47, Maxim Kuvyrkov wrote: > > Hi Bernhard, > > Thanks, I meant to fix this, but forgot. > > The underlying problem he

Re: [PATCH] Format gotools.sum closer to what DejaGnu does

2023-11-02 Thread Maxim Kuvyrkov
> On Nov 2, 2023, at 21:02, rep.dot@gmail.com wrote: > > Hi Maxim! > > Many thanks for the patch! Quick question below.. > > On 2 November 2023 13:48:55 CET, Maxim Kuvyrkov > wrote: >> ... to restore compatability with validate_failures.py . >> The t

[PATCH v2] Format gotools.sum closer to what DejaGnu does

2023-11-03 Thread Maxim Kuvyrkov
extract values, and gotools.sum provided "Running ". Note that libgo.sum, which also uses Makefile logic to generate DejaGnu-like output, already has "..." suffix. gotools/ChangeLog: * Makefile.am: Update "Running ..." output * Makefile.i

Re: [PATCH] simplify-rtx: Extend (truncate (*extract ...)) fold [PR87763]

2020-02-03 Thread Maxim Kuvyrkov
these can be avoided? [Let me know if you need help reproducing this problem.] Thank you, -- Maxim Kuvyrkov https://www.linaro.org > On Jan 27, 2020, at 7:41 PM, Richard Sandiford > wrote: > > In the gcc.target/aarch64/lsl_asr_sbfiz.c part of this PR, we have: > > Fa

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-03-01 Thread Maxim Kuvyrkov
> On Feb 29, 2024, at 21:59, Richard Earnshaw (lists) > wrote: > > On 29/02/2024 17:55, Andrew Pinski (QUIC) wrote: >>> -Original Message- >>> From: Maxim Kuvyrkov >>> Sent: Thursday, February 29, 2024 9:46 AM >>> To: Andrew Pins

[PATCH] [testsuite] Fixup dg-options in {gcc, g++, gfortran}.dg/vect.exp tests

2024-03-13 Thread Maxim Kuvyrkov
This patch has been tested on - aarch64-linux-gnu - arm-linux-gnueabihf (VFP, NEON disabled by default), - arm-none-eabi (Soft-FP) with the following [expected] differences in the test results: - FAIL now PASS [FAIL => PASS]: Executed from: gcc:gcc.dg/vect/vect.exp gcc:gcc.dg/v

Re: [PATCH] [testsuite] Fixup dg-options in {gcc, g++, gfortran}.dg/vect.exp tests

2024-03-13 Thread Maxim Kuvyrkov
> On Mar 13, 2024, at 15:25, Richard Earnshaw > wrote: > > > > On 13/03/2024 10:58, Maxim Kuvyrkov wrote: >> This patch has been tested on >> - aarch64-linux-gnu >> - arm-linux-gnueabihf (VFP, NEON disabled by default), >> - arm-none-eabi (Soft-FP) &g

[PATCH v2] [testsuite] Fixup dg-options in {gcc, g++, gfortran}.dg/vect.exp tests

2024-03-13 Thread Maxim Kuvyrkov
Changes in v2: - Better changelog entry. - NFC. This patch has been tested on - aarch64-linux-gnu - arm-linux-gnueabihf (VFP, NEON disabled by default), - arm-none-eabi (Soft-FP) with the following [expected] differences in the test results: - FAIL now PASS [FAIL => PASS]: Execut

Re: [PATCH v1 00/13] Add aarch64-w64-mingw32 target

2024-02-21 Thread Maxim Kuvyrkov
Hi Evgeny, Great job! For reference, here is a test build of this patch series using Linaro Toolchain CI: https://ci.linaro.org/view/tcwg-build/job/tcwg_gnu_mingw_build--master-woa64-build/9/artifact/artifacts/ -- Maxim Kuvyrkov https://www.linaro.org > On Feb 21, 2024, at 21:47, Evg

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Maxim Kuvyrkov
> On Feb 29, 2024, at 21:35, Andrew Pinski (QUIC) > wrote: > > > >> -Original Message- >> From: Evgeny Karpov >> Sent: Thursday, February 29, 2024 8:46 AM >> To: Andrew Pinski >> Cc: Richard Sandiford ; gcc- >> patc...@gc

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-15 Thread Maxim Kuvyrkov
Hi Vladimir, Hi Jeff, Richard and Alexander have reviewed this patch and [I assume] have no further comments. OK to merge? On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > This patch avoids sched-deps.cc:find_inc() creating exponential number > of dependencies, which become memo

Re: [PATCH v3 3/8] Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc

2024-01-15 Thread Maxim Kuvyrkov
Dear RTL maintainers, Gently ping. This patch adds a couple of new functions to lists.cc, which then are used to simplify logic in the scheduler. OK to merge? On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > This patch simplifies logic behind deps_join(), which will be > importa

Re: [PATCH v3 4/8] Improve and fix sched-deps.cc: dump_dep() and dump_lists().

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This patch is borderline trivial and affects only the lucky few who debug sched-deps.cc code. OK to merge? On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > Better propagate flags from dump_lists() into dump_dep() and > add a missing

Re: [PATCH v3 5/8] Add a bit more logging scheduler's dependency analysis

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This is a trivial patch, which makes debugging sched-deps.cc slightly more enjoyable. On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > gcc/ChangeLog: > > * sched-deps.cc (sd_add_dep, find_inc): Add logging about >

Re: [PATCH v3 6/8] sched_deps.cc: Simplify initialization of dependency contexts

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This is a trivial cleanup. On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > gcc/ChangeLog: > > * sched-deps.cc (init_deps, init_deps_reg_last): Simplify. > (free_deps): Remove useless code. > --- > gcc/

Re: [PATCH v3 7/8] Improve logging of register data in scheduler dependency analysis

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This patch improves debugging output, it does not touch scheduling logic. On Wed, 22 Nov 2023 at 15:15, Maxim Kuvyrkov wrote: > Scheduler dependency analysis uses two main data structures: > 1. reg_pending_* data contains effects of INSN

Re: [PATCH v3 8/8] Improve logging of scheduler dependency analysis context

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This patch improves debugging output, it does not touch scheduling logic. On Wed, 22 Nov 2023 at 15:15, Maxim Kuvyrkov wrote: > Scheduler dependency analysis uses two main data structures: > 1. reg_pending_* data contains effects of INSN

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-16 Thread Maxim Kuvyrkov
> On Jan 17, 2024, at 10:51, Richard Biener wrote: > > On Tue, Jan 16, 2024 at 3:52 PM Jeff Law wrote: >> >> >> >> On 1/15/24 05:56, Maxim Kuvyrkov wrote: >>> Hi Vladimir, >>> Hi Jeff, >>> >>> Richard and Alexander have re

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-17 Thread Maxim Kuvyrkov
> On Jan 17, 2024, at 19:02, Richard Biener wrote: > > On Wed, Jan 17, 2024 at 8:39 AM Maxim Kuvyrkov > wrote: >> >>> On Jan 17, 2024, at 10:51, Richard Biener >>> wrote: >>> >>> On Tue, Jan 16, 2024 at 3:52 PM Jeff Law wrote: >>

[PATCH v1] Fix compare-debug bootstrap failure

2024-01-17 Thread Maxim Kuvyrkov
... caused by scheduler fix for PR96388 and PR111554. This patch adjusts decision sched-deps.cc:find_inc() to use length of dependency lists sans any DEBUG_INSN instructions. gcc/ChangeLog: * haifa-sched.cc (dep_list_size): Make global. * sched-deps.cc (find_inc): Use instead of

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-17 Thread Maxim Kuvyrkov
> On Jan 17, 2024, at 19:05, Maxim Kuvyrkov wrote: > >> On Jan 17, 2024, at 19:02, Richard Biener wrote: >> >> On Wed, Jan 17, 2024 at 8:39 AM Maxim Kuvyrkov >> wrote: >>> >>>> On Jan 17, 2024, at 10:51, Richard Biener >>>> wr

[PATCH] Make gcc.target/arm/bics_3.c testcase a bit more generic [PR113542]

2024-01-25 Thread Maxim Kuvyrkov
After fwprop improvement in r14-8319-g86de9b66480, codegen in bics_3.c test changed from "bics" to "bic" instruction, with the overall instruction stream remaining at the same quality. This patch makes the scan-assembler directive accept both "bics" and "bic". BEFORE r14-8319-g86de9b66480:

Re: [PATCH] tree-optimization/113576 - non-empty latch and may_be_zero vectorization

2024-01-25 Thread Maxim Kuvyrkov
tional-options "-march=skylake-avx512" } */ Please adjust the testcase; this fails on non-x86_64 targets, see [1] and [2]. [1] https://patchwork.sourceware.org/project/gcc/patch/20240124144159.51c503858...@sourceware.org/ [2] https://ci.linaro.org/job/tcwg_gcc_check--master-aarch

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-09 Thread Maxim Kuvyrkov
save the state of DFA before the initial advance_one_cycle(), and then restore it if no real insns have been scheduled. Kind regards, -- Maxim Kuvyrkov https://www.linaro.org > On Nov 8, 2023, at 06:49, Kewen.Lin wrote: > > Hi, > > Gentle ping this: > > https://gc

[PATCH 0/1] Avoid exponential behavior in scheduler and better logging

2023-11-20 Thread Maxim Kuvyrkov
logging patches to be published, as it'll take me another week to clean them up. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96388 [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111554 Maxim Kuvyrkov (1): sched-deps.cc (find_modifiable_mems): Avoid exponential behavior gc

[PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
This patch avoids sched-deps.cc:find_inc() creating exponential number of dependencies, which become memory and compilation time hogs. Consider example (simplified from PR96388) ... === sp=sp-4 // sp_insnA mem_insnA1[sp+A1] ... mem_insnAN[sp+AN] sp=sp-4 // sp_insnB mem_insnB1[sp+B1] ... mem_insnBM[

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 17:09, Richard Biener wrote: > > On Mon, Nov 20, 2023 at 1:08 PM Maxim Kuvyrkov > wrote: >> >> This patch avoids sched-deps.cc:find_inc() creating exponential number >> of dependencies, which become memory and compilation time hogs. >&g

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 17:52, Alexander Monakov wrote: > > > On Mon, 20 Nov 2023, Maxim Kuvyrkov wrote: > >> This patch avoids sched-deps.cc:find_inc() creating exponential number >> of dependencies, which become memory and compilation time hogs. >> Consider

[PATCH v2] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
This patch avoids sched-deps.cc:find_inc() creating exponential number of dependencies, which become memory and compilation time hogs. Consider example (simplified from PR96388) ... === sp=sp-4 // sp_insnA mem_insnA1[sp+A1] ... mem_insnAN[sp+AN] sp=sp-4 // sp_insnB mem_insnB1[sp+B1] ... mem_insnBM[

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 17:45, Richard Biener wrote: > > On Mon, Nov 20, 2023 at 2:42 PM Maxim Kuvyrkov > wrote: >> >>> On Nov 20, 2023, at 17:09, Richard Biener >>> wrote: >>> >>> On Mon, Nov 20, 2023 at 1:08 PM Maxim Kuvyrkov >>&

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-21 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 20:30, Alexander Monakov wrote: > > > On Mon, 20 Nov 2023, Maxim Kuvyrkov wrote: > >>> On Nov 20, 2023, at 17:52, Alexander Monakov wrote: >>> >>> >>> On Mon, 20 Nov 2023, Maxim Kuvyrkov wrote: >>> >>

[PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-22 Thread Maxim Kuvyrkov
This patch avoids sched-deps.cc:find_inc() creating exponential number of dependencies, which become memory and compilation time hogs. Consider example (simplified from PR96388) ... === sp=sp-4 // sp_insnA mem_insnA1[sp+A1] ... mem_insnAN[sp+AN] sp=sp-4 // sp_insnB mem_insnB1[sp+B1] ... mem_insnBM[

[PATCH v3 0/8] Avoid exponential behavior in scheduler and better logging

2023-11-22 Thread Maxim Kuvyrkov
g/bugzilla/show_bug.cgi?id=111554 Maxim Kuvyrkov (8): sched-deps.cc (find_modifiable_mems): Avoid exponential behavior Unify implementations of print_hard_reg_set() Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc Improve and fix sched-deps.cc: dump_dep() and dump_lists(). Add a bit mo

[PATCH v3 5/8] Add a bit more logging scheduler's dependency analysis

2023-11-22 Thread Maxim Kuvyrkov
gcc/ChangeLog: * sched-deps.cc (sd_add_dep, find_inc): Add logging about dependency creation. --- gcc/sched-deps.cc | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc index 4d357079a7a..2a87158b

[PATCH v3 6/8] sched_deps.cc: Simplify initialization of dependency contexts

2023-11-22 Thread Maxim Kuvyrkov
gcc/ChangeLog: * sched-deps.cc (init_deps, init_deps_reg_last): Simplify. (free_deps): Remove useless code. --- gcc/sched-deps.cc | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc index 2a87158ba4b..e0d3c97d935

[PATCH v3 2/8] Unify implementations of print_hard_reg_set()

2023-11-22 Thread Maxim Kuvyrkov
We currently have 3 implementations of print_hard_reg_set() (all with the same name!) in ira-color.cc, ira-conflicts.cc, and sel-sched-dump.cc. This patch generalizes implementation in ira-color.cc, and uses it in all other places. The declaration is added to hard-reg-set.h. The motivation for t

[PATCH v3 8/8] Improve logging of scheduler dependency analysis context

2023-11-22 Thread Maxim Kuvyrkov
Scheduler dependency analysis uses two main data structures: 1. reg_pending_* data contains effects of INSN on the register file, which is then incorporated into ... 2. deps_desc object, which contains commulative information about all instructions processed from deps_desc object's initializa

[PATCH v3 3/8] Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc

2023-11-22 Thread Maxim Kuvyrkov
This patch simplifies logic behind deps_join(), which will be important for the upcoming improvements of sched-deps.cc logging. The only functional change is that when deps_join() is called with empty state for the 2nd argument, it will not reverse INSN_ and EXPR_LISTs in the 1st argument. Before

[PATCH v3 4/8] Improve and fix sched-deps.cc: dump_dep() and dump_lists().

2023-11-22 Thread Maxim Kuvyrkov
Better propagate flags from dump_lists() into dump_dep() and add a missing "]" in dump_lists(). gcc/ChangeLog: * sched-deps.cc (DUMP_DEP_PRO): Improve comment. (dump_dep_flags): Remove. (DUMP_LISTS_SIZE, DUMP_LISTS_DEPS, DUMP_LISTS_ALL): Continue numbering from DUM

[PATCH v3 7/8] Improve logging of register data in scheduler dependency analysis

2023-11-22 Thread Maxim Kuvyrkov
Scheduler dependency analysis uses two main data structures: 1. reg_pending_* data contains effects of INSN on the register file, which is then incorporated into ... 2. deps_desc object, which contains commulative information about all instructions processed from deps_desc object's initializa

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-09-27 Thread Maxim Kuvyrkov
t; . My preferred way of fixing this is to make go's testsuite print out "..." . We have a similar patch for glibc [1]. [1] https://sourceware.org/pipermail/libc-alpha/2023-June/148702.html -- Maxim Kuvyrkov https://www.linaro.org > On Sep 26, 2023, at 19:46, Bernhard Reutner

Re: [PATCH, libgcc] Fix licenses on several files

2013-08-26 Thread Maxim Kuvyrkov
On 29/07/2013, at 10:03 AM, Maxim Kuvyrkov wrote: > While verifying license compliance for GCC and its libraries I noticed that > several libgcc files that end up in the final library are licensed under > GPL-3.0+ instead of GPL-3.0-with-GCC-exception. > > This is, obvious

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-09-03 Thread Maxim Kuvyrkov
sections. */ > #undef M68K_OFFSETS_MUST_BE_WITHIN_SECTIONS_P > #define M68K_OFFSETS_MUST_BE_WITHIN_SECTIONS_P 1 > + > +#undef TARGET_LIBC_HAS_FUNCTION > +#define TARGET_LIBC_HAS_FUNCTION no_c99_libc_has_function > diff --git a/gcc/config/moxie/uclinux.h b/gcc/config/moxie/uclinux.h > index 498037e..85c65f2 100644 > --- a/gcc/config/moxie/uclinux.h > +++ b/gcc/config/moxie/uclinux.h > @@ -37,3 +37,6 @@ see the files COPYING3 and COPYING.RUNTIME > respectively. If not, see > --wrap=mmap --wrap=munmap --wrap=alloca\ > %{fmudflapth: --wrap=pthread_create\ > }} %{fmudflap|fmudflapth: --wrap=main}" > + > +#undef TARGET_LIBC_HAS_FUNCTION > +#define TARGET_LIBC_HAS_FUNCTION no_c99_libc_has_function > > Thanks, -- Maxim Kuvyrkov www.kugelworks.com

Re: [bootstrap] Fix build for several targets (including pr58242)

2013-09-04 Thread Maxim Kuvyrkov
nitial decision it now becoming a mess. I'm thinking along similar lines as you to restrict Bionic/Android handling only to targets that actually support it. As Alexander said in his email, this rework should be done as a separate patch. Thanks, -- Maxim Kuvyrkov www.kugelworks.com

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2013-09-04 Thread Maxim Kuvyrkov
On 4/09/2013, at 7:43 PM, Alexander Ivchenko wrote: > Hi Maxim, > > 2013/9/4 Maxim Kuvyrkov : >> On 23/08/2013, at 1:04 AM, Alexander Ivchenko wrote: >> >>> Ugh.. thanks, you are right. That points to another problem that I >>> didn't see before: &g

Cleanup Linux libc selection and Android support

2013-09-18 Thread Maxim Kuvyrkov
ks in linux.h - 0005-Cleanup-libc-selection-and-Android-support Split Android handling from libc selection and remove Android handling from targets that don't support it. Thanks, -- Maxim Kuvyrkov www.kugelworks.com

[PATCH 1/5] Rename files for libc selection on Linux targets

2013-09-18 Thread Maxim Kuvyrkov
Mechanical rename of files in preparation for splitting Android handling from libc selection. The patch series was tested on various Linux and uClinux targets including arm, bfin, c6x, m68k, mips, powerpc, x86, x86_64. OK to apply? -- Maxim Kuvyrkov www.kugelworks.com 0001-Rename-files-for

[PATCH 2/5] Rename functions relating to libc support on Linux targets

2013-09-18 Thread Maxim Kuvyrkov
Mechanical rename of functions. The patch series was tested on various Linux and uClinux targets including arm, bfin, c6x, m68k, mips, powerpc, x86, x86_64. OK to apply? -- Maxim Kuvyrkov www.kugelworks.com 0002-Rename-functions-relating-to-libc-support-on-Linux-t.patch Description: Binary

[PATCH 3/5] Robustify check for IFUNC support

2013-09-18 Thread Maxim Kuvyrkov
various Linux and uClinux targets including arm, bfin, c6x, m68k, mips, powerpc, x86, x86_64. OK to apply? Thanks, -- Maxim Kuvyrkov www.kugelworks.com 0003-Robustify-check-for-IFUNC-support.patch Description: Binary data

[PATCH 4/5] Cleanup definitions of libc-related target hooks

2013-09-18 Thread Maxim Kuvyrkov
S_FUNCTION and TARGET_HAS_IFUNC_P separately for *-linux-* and for *-uclinux-*. The patch series was tested on various Linux and uClinux targets including arm, bfin, c6x, m68k, mips, powerpc, x86, x86_64. OK to apply? Thanks, -- Maxim Kuvyrkov www.kugelworks.com 0004-Cleanup-definitions-

[PATCH 5/5] Cleanup libc selection and Android support

2013-09-18 Thread Maxim Kuvyrkov
This patch splits Android handling from libc selection and removes Android handling from targets that don't support it. The patch series was tested on various Linux and uClinux targets including arm, bfin, c6x, m68k, mips, powerpc, x86, x86_64. OK to apply? Thanks, -- Maxim Kuv

[PATCH] Add testcase for PR61033

2016-02-20 Thread Maxim Kuvyrkov
This patch adds a testcase for PR61033 [1]. The bug is about compiler going into infinite loop while solving data-flow in vt_find_locations on arm-* targets. The issue in fixed in GCC 5 and later by Richard B.'s r211624 [2]. The bug affects GCC 4.8 and 4.9, but is unlikely to be fixed there.

[PATCH,testsuite] Print markers to stderr to avoid races with sanitizer output

2016-03-01 Thread Maxim Kuvyrkov
en remote testing. This patch fixes the affected tests in GCC testsuite, and I'll be also posting a similar patch for LLVM testsuite. OK for trunk? -- Maxim Kuvyrkov www.linaro.org 8cffd698.diff Description: Binary data

Re: [PATCH,testsuite] Print markers to stderr to avoid races with sanitizer output

2016-03-01 Thread Maxim Kuvyrkov
> On Mar 1, 2016, at 12:31 PM, Maxim Kuvyrkov wrote: > > This patch improves sanitizer testsuite to avoid sporadic failures, > especially when [cross-]testing on a remote machine. > > There are several unstable sanitizer tests in GCC testsuite (e.g., > g++.dg/tsan/aligne

Re: [PATCH] Fix detection of setrlimit in libstdc++ testsuite

2016-03-02 Thread Maxim Kuvyrkov
PING ^ 2. The patch is sitting without comments for 4+ months. -- Maxim Kuvyrkov www.linaro.org > On Dec 10, 2015, at 4:47 PM, Maxim Kuvyrkov wrote: > >> On Nov 11, 2015, at 7:56 PM, Maxim Kuvyrkov >> wrote: >> >> Hi, >> >> This patch fixes an

Re: Cleanup Linux libc selection and Android support

2013-12-07 Thread Maxim Kuvyrkov
On 6/11/2013, at 1:44 pm, Maxim Kuvyrkov wrote: > On 19/09/2013, at 8:26 am, Maxim Kuvyrkov wrote: > >> Following recent breakage caused by adding nominal Android support to all >> *linux* targets [*] this patch series cleans up libc selection for Linux >> targets (-

[PATCH] Fix mips64-linux and s390x-linux builds

2013-12-09 Thread Maxim Kuvyrkov
On 9/12/2013, at 8:21 am, Maxim Kuvyrkov wrote: > On 9/12/2013, at 3:24 am, Jan-Benedict Glaw wrote: > >> Hi Maxim! >> >> One of your recent libc<->android clean-up patches broke the >> mips64-linux target as a side-effect, see eg. >

Re: [PATCH] Fix mips64-linux and s390x-linux builds

2013-12-10 Thread Maxim Kuvyrkov
On 10/12/2013, at 1:07 am, Maxim Kuvyrkov wrote: > My recent patches to cleanup support for Android/Bionic for *-linux-* targets > broke mips64-linux and s390x-linux builds. Unfortunately, these targets fell > out from the test coverage of these cleanups. > > The problems

Re: [testsuite] Fix potential race conditions in gfortran tests

2015-10-22 Thread Maxim Kuvyrkov
Hi, And this is a similar patch for gfortran.dg/streamio_N.f90 tests. OK to commit? -- Maxim Kuvyrkov www.linaro.org > On Oct 18, 2015, at 4:17 PM, Mikael Morin wrote: > > Le 16/10/2015 10:08, Christophe Lyon a écrit : >> Hi, >> >> We have noticed a few random

[PATCH] Fix detection of setrlimit in libstdc++ testsuite

2015-11-11 Thread Maxim Kuvyrkov
using user-mode QEMU made 27_io/fpos/14775.cc execution test to FAIL. This test uses setrlimit set max file size, and is misbehaving only under QEMU. I believe this a QEMU issue with not handling setrlimit correctly. -- Maxim Kuvyrkov www.linaro.org 0001-Use-setrlimit-for-testing-libstdc-in-c

Re: [PATCH] Fix detection of setrlimit in libstdc++ testsuite

2015-12-10 Thread Maxim Kuvyrkov
> On Nov 11, 2015, at 7:56 PM, Maxim Kuvyrkov wrote: > > Hi, > > This patch fixes an obscure cross-testing problem that crashed (OOMed) our > boards at Linaro. Several tests in libstdc++ (e.g., [1]) limit themselves to > some reasonable amount of RAM and then tr

Re: One more patch for PR91333

2020-02-17 Thread Maxim Kuvyrkov
,99183,99863 Could you look into whether these regressions can be avoided? Thanks, -- Maxim Kuvyrkov https://www.linaro.org > On Feb 2, 2020, at 7:46 PM, Vladimir Makarov wrote: > > The previous patch for > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91333 > > resulted

Re: One more patch for PR91333

2020-02-18 Thread Maxim Kuvyrkov
> On Feb 18, 2020, at 6:30 PM, Vladimir Makarov wrote: > > On 2/17/20 10:08 AM, Maxim Kuvyrkov wrote: >> Hi Vladimir, >> >> This patch increases code size at -Os on arm-linux-gnueabihf by 1% (with no >> code-size reductions) on several SPEC CPU2006

Re: [PATCH 4/6] Port prefetch configuration from aarch32 to aarch64

2017-06-09 Thread Maxim Kuvyrkov
> On Jun 8, 2017, at 6:13 PM, Richard Earnshaw (lists) > wrote: > > On 08/06/17 14:47, James Greenhalgh wrote: >> On Mon, Jan 30, 2017 at 08:35:00AM -0800, Andrew Pinski wrote: >>> On Mon, Jan 30, 2017 at 3:48 AM, Maxim Kuvyrkov >>> wrote: >>>

Re: [PATCH 4/6] Port prefetch configuration from aarch32 to aarch64

2017-06-09 Thread Maxim Kuvyrkov
/small-benefit tradefoff it gives, I'd say "why not". > > With that change in place and the obvious rebase needed for patch 6/6 in > place, both this (4/6) and patch 6/6 are OK. Thanks, James. I'm going to commit this once bootstrap / regtest finish on aarch64-linux-gnu. -- Maxim Kuvyrkov www.linaro.org 0001-Port-prefetch-configuration-from-aarch32-to-aarch64-.patch Description: Binary data

Re: [PATCH 5/6][AArch64] Enable -fprefetch-loop-arrays at -O3 for cores that benefit from prefetching.

2017-06-09 Thread Maxim Kuvyrkov
> On Jun 8, 2017, at 7:31 PM, James Greenhalgh wrote: > > On Fri, Feb 03, 2017 at 02:58:23PM +0300, Maxim Kuvyrkov wrote: >>> On Jan 30, 2017, at 5:50 PM, Maxim Kuvyrkov >>> wrote: >>> >>>> On Jan 30, 2017, at 3:23 PM, Kyrill Tkachov >>

Re: [PATCH 6/6][AArch64] Update prefetch tuning parameters for falkor and qdf24xx tunings.

2017-06-09 Thread Maxim Kuvyrkov
> On Jun 8, 2017, at 7:32 PM, James Greenhalgh wrote: > > On Mon, Jan 30, 2017 at 03:08:04PM +0300, Maxim Kuvyrkov wrote: >> This patch enables software prefetching at -O3 for Qualcomm's qdf24xx cores. >> >> Bootstrapped and regtested on x86_64-linux-gnu and aa

Re: [PATCH 0/6] Improve -fprefetch-loop-arrays in general and for AArch64 in particular

2017-06-09 Thread Maxim Kuvyrkov
> On May 28, 2017, at 8:01 AM, Andrew Pinski wrote: > > On Tue, Feb 28, 2017 at 1:53 AM, Maxim Kuvyrkov >> ... >> Hi Kyrill, >> >> My hope was to push them in time for GCC 7, but it seems to late now. I'll >> return to these patches at the beginnin

Re: [C++ PATCH] Fix -fsanitize={null,alignment} of references (PR c++/79572)

2017-11-24 Thread Maxim Kuvyrkov
er of type 'const int' iref is NULL == Is it essential for this testcase to use __builtin_printf or simple "fprintf (stderr, ...)" would do just fine? > +} > + > +int > +main () > +{ > + foo (*((int*) __null)); > +} Regards, -- Maxim Kuvyrkov

Re: C++ PATCH to primary_template_instantiation_p

2017-11-28 Thread Maxim Kuvyrkov
ion function specialization to 'const B&' is not an exact match /home/tcwg-buildslave/workspace/tcwg-buildfarm/tcwg-x86_64-build/snapshots/gcc.git~master/gcc/testsuite/g++.dg/cpp0x/fntmpdefarg2a.C:21:6: note: initializing argument 1 of 'void f2(const B&)' compiler exited with status 1 FAIL: g++.dg/cpp0x/fntmpdefarg2a.C -std=gnu++11 (test for warnings, line 8) PASS: g++.dg/cpp0x/fntmpdefarg2a.C -std=gnu++11 (test for errors, line 26) PASS: g++.dg/cpp0x/fntmpdefarg2a.C -std=gnu++11 (test for excess errors) === Regards, -- Maxim Kuvyrkov www.linaro.org

Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL

2018-01-31 Thread Maxim Kuvyrkov
; but that isn't feasible if you want a well-defined sort ordering. Agree. Wilco, your patch looks good. Thanks for fixing this! -- Maxim Kuvyrkov www.linaro.org

Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL

2018-02-07 Thread Maxim Kuvyrkov
instructions outside the target_bb get the highest model_index, > all we need to do is sort on model_index. If the model_index is the same > we defer to RFS_DEP_COUNT and/or RFS_TIE. > > Bootstrap OK, OK for commit? Looks good to me. -- Maxim Kuvyrkov www.linaro.org > >

Re: [PATCH][arm] PR target/82518: Return false in ARRAY_MODE_SUPPORTED_P for BYTES_BIG_ENDIAN

2018-04-25 Thread Maxim Kuvyrkov
rmv8l-linux-gnueabihf target fail a few of slp-perm-* tests. Using [check_effective_target_arm_little_endian] should fix this. Would you please fix this on master and gcc-7-branch? Thanks! -- Maxim Kuvyrkov www.linaro.org

Re: [Libgomp, Fortran] Fix canadian cross build

2018-05-23 Thread Maxim Kuvyrkov
s the replacement >of AC_CHECK_PROG by AC_PATH_PROG to get the absolute name of the >program. >(ACX_CHECK_INSTALLED_TARGET_TOOL): Use renamed function. > > ChangeLog > 2017-06-23 Yvan Roux > >* configure.ac: Use NCN_STRICT_PATH_TARGET_TOOLS instead of >NCN_STRICT_CHECK_TARGET_TOOLS. >* configure: Regenerate. > -- Maxim Kuvyrkov www.linaro.org

Re: Cleanup Linux libc selection and Android support

2013-11-05 Thread Maxim Kuvyrkov
On 19/09/2013, at 8:26 am, Maxim Kuvyrkov wrote: > Following recent breakage caused by adding nominal Android support to all > *linux* targets [*] this patch series cleans up libc selection for Linux > targets (-mglibc/-muclibc/-mbionic), splits libc selection logic from Android

[PATCH] Fix race in libstdc++ testsuite

2014-10-16 Thread Maxim Kuvyrkov
data file, with one thread overwriting the file that was created by another thread. The fix is to use unique name cin_unget-1-[pid].txt for the data file. Tested on x86_64-linux-gnu. OK to apply? -- Maxim Kuvyrkov www.linaro.org 0001-Fix-race-in-libstdc-testsuite.ChangeLog Description: Binary

[PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-19 Thread Maxim Kuvyrkov
"thanks" goes to Richard good discussion of the problem and suggestions on the approach to fix it. The patch was bootstrapped on x86_64-linux-gnu (which doesn't really exercises the patch), and cross-tested on arm-linux-gnueabihf and aarch64-linux-gnu. OK to apply? --

[PATCH] Improve scheduler dumps of ready list

2014-10-20 Thread Maxim Kuvyrkov
troubleshoot several scheduling problems in the register pressure scheduling. Tested on x86_64-linux-gnu, arm-linux-gnueabihf and aarch64-linux-gnu. OK to apply? Thank you, -- Maxim Kuvyrkov www.linaro.org 0002-last_rfs_win.ChangeLog Description: Binary data 0002-last_rfs_win.patch

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-20 Thread Maxim Kuvyrkov
On Oct 21, 2014, at 8:11 AM, Sebastian Pop wrote: > Maxim Kuvyrkov wrote: >> Hi, >> >> This patch improves register pressure scheduling (both >> SCHED_PRESSURE_WEIGHTED and SCHED_PRESSURE_MODEL) to better estimate number >> of available registers. >>

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-20 Thread Maxim Kuvyrkov
[Adding ARM maintainers to CC] On Oct 21, 2014, at 9:44 AM, Sebastian Pop wrote: > Hi Maxim, > > Maxim Kuvyrkov wrote: >> Thanks, benchmarking results are welcome! AArch64 doesn't use reg_pressure >> scheduling by default. Use "-fsched-pressure >> -

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-20 Thread Maxim Kuvyrkov
On Oct 21, 2014, at 10:39 AM, Ramana Radhakrishnan wrote: > On Mon, Oct 20, 2014 at 10:17 PM, Richard Sandiford > wrote: >> Maxim Kuvyrkov writes: >>> [Adding ARM maintainers to CC] >>> >>> On Oct 21, 2014, at 9:44 AM, Sebastian Pop wrote: >>>

[PATCH 3/8] Remove cached_first_cycle_multipass_dfa_lookahead and cached_issue_rate

2014-10-20 Thread Maxim Kuvyrkov
backends currently treat dfa_lookahead and issue_rate as constants for the duration of scheduling passes. Bootstrapped on x86_64-linux-gnu. Regression testing is in progress. OK to commit if no regressions? [ChangeLog is part of the git patch] -- Maxim Kuvyrkov www.linaro.org 0003-Remove

[PATCH 4/8] Disable max_issue when scheduling for register pressure

2014-10-20 Thread Maxim Kuvyrkov
ssure scheduling. This will change soon with upcoming patches that will enable max_issue during 2nd scheduling pass for ARM and AArch64. Bootstrapped on x86_64-linux-gnu. Regression testing is in progress. OK to commit if no regressions? [ChangeLog is part of the git patch] Thank you, --

[PATCH 5/8] Enable max_issue for AArch32 and AArch64

2014-10-20 Thread Maxim Kuvyrkov
rking results that you can share. Bootstrap on aarch64-linux-gnu is in progress. OK to apply, provided no performance or correctness regressions? Thank you, -- Maxim Kuvyrkov www.linaro.org 0005-Enable-max_issue-for-AArch32-and-AArch64.patch Description: Binary data

[PATCH 6/8] Handle SCRATCH in decompose_address

2014-10-20 Thread Maxim Kuvyrkov
linux-gnueabihf and aarch64-linux-gnu. OK to apply? Thank you, [ChangeLog is part of the git patch] -- Maxim Kuvyrkov www.linaro.org 0006-Handle-SCRATCH-in-decompose_address.patch Description: Binary data

[PATCH 7/8] Model cache auto-prefetcher in scheduler

2014-10-20 Thread Maxim Kuvyrkov
nd 3 (look through ready list and 2-stall queue) should be considered and benchmarked. Bootstrapped on x86_64-linux-gnu and regtested on arm-linux-gnueaihf and aarch64-linux-gnu. OK to apply, provided no performance or correctness regressions? [ChangeLog is part of the git patch] Thank you,

[PATCH 8/8] Use rank_for_schedule to as tie-breaker in model_order_p

2014-10-20 Thread Maxim Kuvyrkov
-linux-gnueabihf and aarch64-linux-gnu. OK to apply? Thank you, -- Maxim Kuvyrkov www.linaro.org 0008-Use-rank_for_schedule-to-as-tie-breaker-in-model_ord.patch Description: Binary data

Re: [PATCH 8/8] Use rank_for_schedule to as tie-breaker in model_order_p

2014-10-21 Thread Maxim Kuvyrkov
On Oct 21, 2014, at 9:11 PM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> This patch improves model_order_p to use non-reg-pressure version of >> rank_for_schedule when it needs to break the tie. At the moment it is >> comparing INSN_PRIORITY by itself, an

Re: [PATCH 8/8] Use rank_for_schedule to as tie-breaker in model_order_p

2014-10-21 Thread Maxim Kuvyrkov
On Oct 22, 2014, at 9:24 AM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> On Oct 21, 2014, at 9:11 PM, Richard Sandiford >> wrote: >> >>> Maxim Kuvyrkov writes: >>>> This patch improves model_order_p to use non-reg-pressure version of >

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-21 Thread Maxim Kuvyrkov
On Oct 22, 2014, at 4:24 AM, Vladimir Makarov wrote: > On 10/20/2014 02:57 AM, Maxim Kuvyrkov wrote: >> Hi, >> >> This patch improves register pressure scheduling (both >> SCHED_PRESSURE_WEIGHTED and SCHED_PRESSURE_MODEL) to better estimate number >> of a

Re: [PATCH 5/8] Enable max_issue for AArch32 and AArch64

2014-10-22 Thread Maxim Kuvyrkov
On Oct 23, 2014, at 11:42 AM, Sebastian Pop wrote: > Sebastian Pop wrote: >> Maxim Kuvyrkov wrote: >>> This change requires benchmarking, which I can't easily do at the moment. I >>> would appreciate any benchmarking results that you can share. >> >&g

Re: [PATCH 6/8] Handle SCRATCH in decompose_address

2014-10-22 Thread Maxim Kuvyrkov
On Oct 23, 2014, at 9:02 AM, Jeff Law wrote: > On 10/20/14 21:35, Maxim Kuvyrkov wrote: >> Hi, >> >> This patch is a simple fix to allow decompose_address to handle >> SCRATCH'es during 2nd scheduler pass. This patch is a prerequisite >> for

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-22 Thread Maxim Kuvyrkov
the patch I'm going to commit after some more testing. Thank you both reviews! -- Maxim Kuvyrkov www.linaro.org 0001-sched_class_reg_num.ChangeLog Description: Binary data 0001-sched_class_reg_num.patch Description: Binary data

Re: [PATCH 3/8] Remove cached_first_cycle_multipass_dfa_lookahead and cached_issue_rate

2014-10-22 Thread Maxim Kuvyrkov
On Oct 22, 2014, at 4:53 AM, Vladimir Makarov wrote: > On 10/20/2014 11:16 PM, Maxim Kuvyrkov wrote: >> Hi, >> >> This patch cleans up (removes) cached_first_cycle_multipass_dfa_lookahead >> and cached_issue_rate. >> >> These seem to be an artifact from

[PATCH] New debug parameter sched-pressure-factor

2014-10-22 Thread Maxim Kuvyrkov
sters (and, likely, cause a lot of spills). Thank you, -- Maxim Kuvyrkov www.linaro.org 0008-Sched_pressure_factor.patch Description: Binary data

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-23 Thread Maxim Kuvyrkov
On Oct 23, 2014, at 8:20 PM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> @@ -6701,6 +6753,24 @@ alloc_global_sched_pressure_data (void) >>saved_reg_live = BITMAP_ALLOC (NULL); >>region_ref_regs = BITMAP_ALLOC (NULL); >> } >> +

Re: [PATCH, sched] Cleanup and improve multipass_dfa_lookahead_guard

2014-06-03 Thread Maxim Kuvyrkov
O_SPEC(insn) should not be accessed for sel-sched. Because pending_data_specs turns out to always be null during sel-sched, "pending_data_specs >= 16" can be used as a shorthand for "sched_deps_info->generate_spec_deps && !sel_sched_p () && pending_data_specs >= 16" -- Maxim Kuvyrkov www.linaro.org

Re: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3

2015-04-18 Thread Maxim Kuvyrkov
not clobber operand[1]. By marking operand[3] early-clobber we ensure that operand[1] is in a different register from what operand[0] and operand[3] were assigned to. This case should be handled equally well before and after the patch. My understanding is that Kugan's patch with Jakub's fix on top satisfy both of these cases. -- Maxim Kuvyrkov www.linaro.org

  1   2   3   4   >