> On Jun 23, 2017, at 4:44 PM, Yvan Roux <yvan.r...@linaro.org> wrote: > > Hello, > > Fortran parts of libgomp (omp_lib.mod, openacc.mod, etc...) are > missing in a canadian cross build, at least when target gfortran > compiler comes from PATH and not from GFORTRAN_FOR_TARGET. > > Back in 2010, executability test of GFORTRAN was added to fix libgomp > build on cygwin, but when the executable doesn't contain the path, > "test -x" fails and part of the library are not built. > > This patch fixes the issue by using M4 macro AC_PATH_PROG (which > returns the absolute name) instead of AC_CHECK_PROG in the function > defined in config/acx.m4: NCN_STRICT_CHECK_TARGET_TOOLS. I renamed it > into NCN_STRICT_PATH_TARGET_TOOLS to keep the semantic used in M4. > > Tested by building cross and candian cross toolchain (host: > i686-w64-mingw32) for arm-linux-gnueabihf with issue and with a > complete libgomp. > > ok for trunk ?
Hi Yvan, The patch looks OK, but it is a pain to review. Would you please split it into 2 patches: one for the mechanical renames, and one for logical changes to acx.m4? This should allow Paolo and DJ to approve your patch. Thanks! > > Thanks > Yvan > > config/ChangeLog > 2017-06-23 Yvan Roux <yvan.r...@linaro.org> > > * acx.m4 (NCN_STRICT_CHECK_TARGET_TOOLS): Renamed to ... > (NCN_STRICT_PATH_TARGET_TOOLS): ... this. It reflects the replacement > of AC_CHECK_PROG by AC_PATH_PROG to get the absolute name of the > program. > (ACX_CHECK_INSTALLED_TARGET_TOOL): Use renamed function. > > ChangeLog > 2017-06-23 Yvan Roux <yvan.r...@linaro.org> > > * configure.ac: Use NCN_STRICT_PATH_TARGET_TOOLS instead of > NCN_STRICT_CHECK_TARGET_TOOLS. > * configure: Regenerate. > <libgomp-canadian.patch> -- Maxim Kuvyrkov www.linaro.org
