[PATCH] Fix GCOV scan pattern (PR testsuite/86366).

2018-07-02 Thread Martin Liška
Hi. This fixes broken tests gcc.dg/profile-dir*. I'm going to install the patch. Martin gcc/testsuite/ChangeLog: 2018-07-02 Martin Liska PR testsuite/86366 * gcc.dg/profile-dir-1.c: Fix scanned pattern. * gcc.dg/profile-dir-2.c: Likewise. * gcc.dg/profile-dir

Re: [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]]

2018-07-03 Thread Martin Liška
On 06/29/2018 09:04 PM, Jeff Law wrote: > I think this is fine for the trunk. > > jeff Thank you Jeff. I found some issues when doing build of all targets (contrib/config-list.mk). I'll update patch and test that affected cross-compilers still produce same output. However I noticed one ppc64 i

Re: [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]]

2018-07-03 Thread Martin Liška
On 07/03/2018 11:55 AM, Segher Boessenkool wrote: > On Tue, Jul 03, 2018 at 10:53:20AM +0200, Martin Liška wrote: >> On 06/29/2018 09:04 PM, Jeff Law wrote: >>> I think this is fine for the trunk. >>> >>> jeff >> >> Thank you Jeff. >> >>

Re: extract_range_from_binary* cleanups for VRP

2018-07-03 Thread Martin Liška
Hi. It caused UBSAN errors: $ cat ubsan.i int a; void d() { int c, b = 8 - a; } $ /home/marxin/Programming/gcc2/objdir/./gcc/xgcc -B/home/marxin/Programming/gcc2/objdir/./gcc/ ubsan.i -c -O2 ../../gcc/tree-vrp.c:1715:26: runtime error: load of value 255, which is not a valid value for type 'bo

Re: [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]]

2018-07-03 Thread Martin Liška
On 07/03/2018 12:58 PM, Segher Boessenkool wrote: > On Tue, Jul 03, 2018 at 12:15:48PM +0200, Martin Liška wrote: >>> toplev.c already has (in init_alignments): >>> >>> if (align_jumps_max_skip > align_jumps) >>> align_jumps_max_skip = align_jumps

[PATCH] Fix bootstrap on ia64 with old GCC version.

2018-07-03 Thread Martin Liška
Hi. In order to make GCC 4.1 happy and build current tip, we need to define static constants out of a class definition. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2018-07-03 Martin Liska * tree-switch-conversion.h (struct jump_table_cluster): Define constant values outs

[PATCH] Fix DOS-based system build and fix documentation.

2018-07-03 Thread Martin Liška
Hi. I'm sending fix for DOS-based system, it's a compilation error that I introduced some time ago. Plus I add Jonathan's correction of a documentation entry. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2018-07-03 Martin Liska Jonathan Wakely * coverage.c: Use corr

[PATCH] Remove legacy testcase for -fprofile-generate=./

2018-07-03 Thread Martin Liška
Hi. As new option mangles absolute path of a compiled file, it's hard to come up with a scan-file pattern. Note similar test is done in gcc.dg/profile-dir-*.c that I adjusted few days ago. Ready for trunk? Thanks, Martin gcc/testsuite/ChangeLog: 2018-07-03 Martin Liska * gcc.dg/pr4

Re: [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]]

2018-07-03 Thread Martin Liška
On 07/03/2018 10:53 AM, Martin Liška wrote: Thank you Jeff. I found some issues when doing build of all targets (contrib/config-list.mk). I'll update patch and test that affected cross-compilers still produce same output. Hello. I'm done with testing, I bootstrapped and regtested

Re: [PATCH 2/3] Temporary remove "at least 8 byte alignment" code from x86

2018-07-03 Thread Martin Liška
On 06/13/2018 04:02 AM, Jeff Law wrote: On 05/21/2018 07:55 AM, marxin wrote: gcc/ChangeLog: 2017-04-18 Denys Vlasenko * config/i386/i386-common.c (ix86_handle_option): Remove support for obsolete -malign-loops, -malign-jumps and -malign-functions options. * config/i386

Re: extract_range_from_binary* cleanups for VRP

2018-07-04 Thread Martin Liška
On 07/03/2018 07:48 PM, Aldy Hernandez wrote: > > > On 07/03/2018 08:16 AM, Martin Liška wrote: >> Hi. >> >> It caused UBSAN errors: >> >> $ cat ubsan.i >> int a; >> void d() { int c, b = 8 - a; } >> >> $ /home/marxin/Programming/gc

Re: [PATCH] Fix bootstrap on ia64 with old GCC version.

2018-07-04 Thread Martin Liška
On 07/03/2018 07:32 PM, Jakub Jelinek wrote: > On Tue, Jul 03, 2018 at 07:22:19PM +0200, Martin Liška wrote: >> In order to make GCC 4.1 happy and build current tip, we need to define >> static constants out of a class definition. >> >> Ready for trunk? >> Than

[PATCH][OBVIOUS] Add missing Optimization attribute.

2018-07-09 Thread Martin Liška
Hi. I'm putting back what I accidentally removed. Martin gcc/ChangeLog: 2018-07-09 Martin Liska * common.opt: Add back wrongly removed attribute. --- gcc/common.opt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/common.opt b/gcc/common.opt index 963c37f04c

Re: [PATCH][OBVIOUS] Add missing Optimization attribute.

2018-07-10 Thread Martin Liška
On 07/10/2018 10:01 AM, Andre Vieira (lists) wrote: > On 09/07/18 09:11, Martin Liška wrote: >> Hi. >> >> I'm putting back what I accidentally removed. >> >> Martin >> >> gcc/ChangeLog: >> >> 2018-07-09 Martin Liska >> >

Re: [PATCH, S390] Increase function alignment to 16 bytes

2018-07-12 Thread Martin Liška
On 07/11/2018 05:40 PM, Robin Dapp wrote: Hi, the following patch increases the default function alignment to 16 bytes. This helps get rid of some unwanted performance effects. I'm unsure whether or when it's necessary to implement OVERRIDE_OPTIONS_AFTER_CHANGE. Hi. Yes, it's how that shoul

[PATCH] Revert one more symbol_summary::get to ::get_create (PR ipa/86529).

2018-07-16 Thread Martin Liška
Hi. This is one more revert related to symbol_summary. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. I'm going to install the patch. Martin gcc/ChangeLog: 2018-07-16 Martin Liska PR ipa/86529 * ipa-pure-const.c (malloc_candidate_p): Revert ::get

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-17 Thread Martin Liška
On 07/16/2018 11:24 PM, Jeff Law wrote: > All 4 patches in this kit are fine after you fix the minor issue Pat > reported with patch #1 on ppc. > > Jeff Thank you Jeff for the trust. I fixed the minor issue and installed the patch set. Martin

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-18 Thread Martin Liška
On 07/18/2018 05:52 AM, Michael Collison wrote: > Hi Martin, > > Your alignment patch breaks the arm port. In the file arm.c, function > 'get_label_padding' the code uses: > > static HOST_WIDE_INT > get_label_padding (rtx label) > { > HOST_WIDE_INT align, min_insn_size; > > align = 1 << lab

[PATCH] Print default options selection for -march,-mcpu and -mtune for aarch64 (PR driver/83193).

2018-07-18 Thread Martin Liška
Hi. This is aarch64 fix for PR83193. It's about setting of default options so that --help=target -Q prints proper numbers: Now this is seen on my cross-compiler: --- /home/marxin/Downloads/options-2-before.txt 2018-07-18 14:53:11.658146543 +0200 +++ /home/marxin/Downloads/options-2.txt2

[PATCH] Provide extension hint for aarch64 target (PR driver/83193).

2018-07-18 Thread Martin Liška
Hi. This patch improves aarch64 feature modifier hints. May I please ask ARM folks to test the patch? Thanks, Martin gcc/ChangeLog: 2018-07-18 Martin Liska PR driver/83193 * common/config/aarch64/aarch64-common.c (aarch64_parse_extension): Set invalid_extension when

[PATCH] Show valid options for -march and -mtune in --help=target for arm32 (PR driver/83193).

2018-07-18 Thread Martin Liška
Hi. This introduces new ForceHelp option flag that helps to print valid option enum values that are not directly used as a type of an option. May I please ask ARM folks to test the patch? Thanks, Martin gcc/ChangeLog: 2018-07-18 Martin Liska PR driver/83193 * config/arm/arm-

Re: [PATCH] Show valid options for -march and -mtune in --help=target for arm32 (PR driver/83193).

2018-07-19 Thread Martin Liška
enum values is printed >> +in @option{--help} output. >> + > > are printed Yep. I'm sending updated version of the patch. Martin > > Thanks, > > Thomas > On Wed, 18 Jul 2018 at 16:50, Martin Liška wrote: >> >> Hi. >> >> This in

Re: [PATCH] Show valid options for -march and -mtune in --help=target for arm32 (PR driver/83193).

2018-07-19 Thread Martin Liška
This is correct version of the patch. Anyway, I'm thinking about the ForceHelp attribute. I may do it in a bit different version. Let me come up with one another version of the patch. Martin >From 9bfc1400213911b4508e90198df7b2dd11efc85c Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 20 Feb 2

Re: [PATCH] Show valid options for -march and -mtune in --help=target for arm32 (PR driver/83193).

2018-07-19 Thread Martin Liška
On 07/19/2018 11:28 AM, Richard Earnshaw (lists) wrote: > On 19/07/18 08:30, Martin Liška wrote: >> This is correct version of the patch. Anyway, I'm thinking about the >> ForceHelp >> attribute. I may do it in a bit different version. Let me come up with one >>

Re: [PATCH] Show valid options for -march and -mtune in --help=target for arm32 (PR driver/83193).

2018-07-19 Thread Martin Liška
On 07/19/2018 12:01 PM, Richard Earnshaw (lists) wrote: > On 19/07/18 10:56, Martin Liška wrote: >> On 07/19/2018 11:28 AM, Richard Earnshaw (lists) wrote: >>> On 19/07/18 08:30, Martin Liška wrote: >>>> This is correct version of the patch. Anyway, I'm

Re: [PATCH] Show valid options for -march and -mtune in --help=target for arm32 (PR driver/83193).

2018-07-19 Thread Martin Liška
On 07/19/2018 12:31 PM, Richard Earnshaw (lists) wrote: > On 19/07/18 11:22, Martin Liška wrote: >> On 07/19/2018 12:01 PM, Richard Earnshaw (lists) wrote: >>> On 19/07/18 10:56, Martin Liška wrote: >>>> On 07/19/2018 11:28 AM, Richard Earnshaw (lists) wrote: >>

[PATCH] Merge Ignore and Deprecated in .opt files.

2018-07-19 Thread Martin Liška
Hi. Few weeks ago I added new Deprecated flag for options. Apparently, there's one similar called Ignore. Thus I moved all Deprecated to Ignore and for all Ignored I do a warning of following format: $ xgcc: warning: switch ‘-mmpx’ is no longer supported After that there were quite some usages f

Re: [PATCH] Merge Ignore and Deprecated in .opt files.

2018-07-19 Thread Martin Liška
On 07/19/2018 03:47 PM, Jakub Jelinek wrote: > On Thu, Jul 19, 2018 at 03:25:15PM +0200, Martin Liška wrote: >> Few weeks ago I added new Deprecated flag for options. Apparently, there's >> one similar called Ignore. Thus I moved all Deprecated to Ignore and for >> all

[PATCH] Prototype of hook for possible list of option values.

2018-07-20 Thread Martin Liška
Hi. I'm sending patch candidate with suggested target common hook. It allows a target to list all possible values for an option. Using the API, I implemented -march and -mtune option listing on i386. Richard you asked about the values. Yes, target should list all possible values, mainly because

Re: [PATCH] When using -fprofile-generate=/some/path mangle absolute path of file (PR lto/85759).

2018-07-20 Thread Martin Liška
On 07/20/2018 06:02 AM, Bin.Cheng wrote: > On Fri, Jun 29, 2018 at 9:54 PM, Martin Liška wrote: >> On 06/22/2018 10:35 PM, Jeff Law wrote: >>> On 05/16/2018 05:53 AM, Martin Liška wrote: >>>> On 12/21/2017 10:13 AM, Martin Liška wrote: >>>>>

[PATCH] Remove unused code.

2018-07-20 Thread Martin Liška
Hi. Following was introduced in r230331 and as David confirmed it was installed accidentally. It has never been used. Ready for trunk? Martin gcc/ChangeLog: 2018-07-20 Martin Liska * tree.h (DECL_LOCATION_RANGE): Remove unused macro. (get_decl_source_range): Remove unused fu

Re: [PATCH] Prototype of hook for possible list of option values.

2018-07-20 Thread Martin Liška
On 07/20/2018 11:48 AM, Richard Earnshaw (lists) wrote: > On 20/07/18 09:04, Martin Liška wrote: >> Hi. >> >> I'm sending patch candidate with suggested target common hook. It allows a >> target >> to list all possible values for an option. Using the API,

Re: [PATCH] Prototype of hook for possible list of option values.

2018-07-20 Thread Martin Liška
On 07/20/2018 12:25 PM, Richard Earnshaw (lists) wrote: > On 20/07/18 11:14, Martin Liška wrote: >> On 07/20/2018 11:48 AM, Richard Earnshaw (lists) wrote: >>> On 20/07/18 09:04, Martin Liška wrote: >>>> Hi. >>>> >>>> I'm sending pat

Re: [PATCH] Merge Ignore and Deprecated in .opt files.

2018-07-20 Thread Martin Liška
On 07/19/2018 04:21 PM, Jakub Jelinek wrote: > On Thu, Jul 19, 2018 at 04:16:10PM +0200, Martin Liška wrote: >> I must admit that was my intention :) In my eyes it makes it more consistent >> and >> it gives consumers feedback about usage of an option that does nothing. >&

Re: [PATCH] Prototype of hook for possible list of option values.

2018-07-20 Thread Martin Liška
On 07/20/2018 12:58 PM, Richard Earnshaw (lists) wrote: > Modifiers are context dependent. The architecture implies which > modifiers can be applied (and what they mean in detail, so, for example, > +fp means enable the default floating point variant for this > architecture). Not all modifiers ap

Re: [PATCH] Prototype of hook for possible list of option values.

2018-07-23 Thread Martin Liška
On 07/23/2018 03:47 PM, Richard Earnshaw (lists) wrote: > On 20/07/18 12:06, Martin Liška wrote: >> On 07/20/2018 12:58 PM, Richard Earnshaw (lists) wrote: >>> Modifiers are context dependent. The architecture implies which >>> modifiers can be applied (and what t

[PATCH] Introduce __builtin_expect_with_probability (PR target/83610).

2018-07-24 Thread Martin Liška
Hi. This is implementation of new built-in that can be used for more fine tweaking of probability. Micro benchmark is attached as part of the PR. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin gcc/ChangeLog: 2018-07-24 Martin Liska

[PATCH] gcov: Fix wrong usage of NAN in statistics (PR gcov-profile/86536).

2018-07-24 Thread Martin Liška
Hi. We have situations where a branch can return more often than called (fork). Thus I decided to rapidly simplify format_gcov and print ratios that are provided. No extra values are handled now. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. If no objections, I'll ins

[PATCH] Limix dump_flag enum values range (PR middle-end/86645).

2018-07-24 Thread Martin Liška
Hi. That fixes many UBSAN issues that are caused by: {"all", dump_flags_t (~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_GRAPH | TDF_STMTADDR | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV | TDF_GIMPLE))}, That goes out of: minv =

[PATCH] Come up with TARGET_GET_VALID_OPTION_VALUES option hook (PR driver/83193).

2018-07-24 Thread Martin Liška
Hi. I'm sending updated version of the patch. It comes up with a new target common hook that provide option completion list. It's used both in --help=target and with --completion option. I implemented support for -match and -mtune for i386 target. Patch can bootstrap on x86_64-linux-gnu and sur

[PATCH] Explain asan parameters in params.def (PR sanitizer/79635).

2018-07-24 Thread Martin Liška
Hi. That's simple patch that improves documentation as requested in the PR. Ready for trunk? Martin gcc/ChangeLog: 2018-07-24 Martin Liska PR sanitizer/79635 * params.def: Explain ASan abbreviation and provide a documentation link. --- gcc/params.def | 2 ++ 1 file

[PATCH][OBVIOUS] Fix wrong declaration.

2018-07-25 Thread Martin Liška
Hi. It's obvious fix of return type. It's the same what's in gcc/config/rs6000/rs6000.h. Martin gcc/ChangeLog: 2018-07-25 Martin Liska * config/powerpcspe/powerpcspe-protos.h (rs6000_loop_align): Fix return type. --- gcc/config/powerpcspe/powerpcspe-protos.h | 2 +- 1 file

[PATCH] Fix target clones (PR gcov-profile/85370).

2018-07-25 Thread Martin Liška
Hi. Target clones have DECL_ARTIFICIAL set to 1, but we want to provide --coverage for that. With patched GCC on can see: -:0:Source:pr85370.c -:0:Graph:pr85370.gcno -:0:Data:pr85370.gcda -:0:Runs:1 -:0:Programs:1 -:1:__attri

[PATCH] Fix GCOV CFG related issues.

2018-07-25 Thread Martin Liška
Hi. It fixes couple of very similar issues. Currently we handle GOTO expression, but it's not easy to find these in GIMPLE middle-end. The patch fixes that. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Will install in couple of days if no objection. Martin gcc/Chan

[PATCH] GCOV: add cache for streamed locations.

2018-07-25 Thread Martin Liška
Hi. Last patch from GCOV series is about not streaming of redundant lines for a basic-block. It helps to fix few issues. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Will install in couple of days if no objection. Martin gcc/ChangeLog: 2018-07-25 Martin Liska

Re: [PATCH] Fix target clones (PR gcov-profile/85370).

2018-07-26 Thread Martin Liška
On 07/25/2018 03:50 PM, Richard Biener wrote: > On Wed, Jul 25, 2018 at 3:38 PM Martin Liška wrote: >> >> Hi. >> >> Target clones have DECL_ARTIFICIAL set to 1, but we want to >> provide --coverage for that. With patched GCC on can see: >> >>

[PATCH] Fix an UBSAN error in cp/parse.c (PR c++/86653).

2018-07-26 Thread Martin Liška
Hello. Quite simple patch that initializes a boolean value before it's used. The variable is not initialized when an error recovery happens. Ready for trunk after testing? Thanks, Martin gcc/cp/ChangeLog: 2018-07-26 Martin Liska PR c++/86653 * parser.c (cp_parser_condition):

[PATCH] Add linker_output as prefix for LTO temps (PR lto/86548).

2018-07-26 Thread Martin Liška
Hi. As requested in the PR, now we produce prefixes for temp files in LTO: Example: $ gcc -flto main.o a.o --save-temps -o mybinary generates: $ ls /tmp/mybinary* /tmp/mybinary /tmp/mybinary.ltrans0.o /tmp/mybinary.ltrans0.s /tmp/mybinary.ltrans.out Patch can bootstrap on ppc64le-redhat-lin

Re: [PATCH] Add linker_output as prefix for LTO temps (PR lto/86548).

2018-07-26 Thread Martin Liška
On 07/26/2018 01:34 PM, Richard Biener wrote: > On Thu, Jul 26, 2018 at 12:55 PM Martin Liška wrote: >> >> Hi. >> >> As requested in the PR, now we produce prefixes for temp files in LTO: >> >> Example: >> $ gcc -flto main.o a.o --save-temps -o my

Re: [PATCH] Add linker_output as prefix for LTO temps (PR lto/86548).

2018-07-26 Thread Martin Liška
On 07/26/2018 02:26 PM, Richard Biener wrote: > On Thu, Jul 26, 2018 at 2:12 PM Martin Liška wrote: >> >> On 07/26/2018 01:34 PM, Richard Biener wrote: >>> On Thu, Jul 26, 2018 at 12:55 PM Martin Liška wrote: >>>> >>>> Hi. >>>> >>

[PATCH] Print heuristics probability fraction part with 2 digits.

2018-07-26 Thread Martin Liška
Hi. It's just a cosmetics change where I want to print 2 digits of fraction part of heuristics probabilities. It helps to distinguish 100% from PROB_VERY_LIKELY (99.96%). Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin gcc/ChangeLog: 201

[PATCH] Add malloc predictor (PR middle-end/83023).

2018-07-26 Thread Martin Liška
Hi. Following patch implements new predictors that annotates malloc-like functions. These almost every time return a non-null value. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin gcc/ChangeLog: 2018-07-26 Martin Liska PR mi

Re: [PATCH] Add malloc predictor (PR middle-end/83023).

2018-07-27 Thread Martin Liška
On 07/26/2018 05:00 PM, Marc Glisse wrote: > On Thu, 26 Jul 2018, Martin Liška wrote: > >> Following patch implements new predictors that annotates malloc-like >> functions. >> These almost every time return a non-null value. > > Out of curiosity (the __builtin_ex

Re: [RFC] Fix recent popcount change is breaking

2018-07-27 Thread Martin Liška
On 07/11/2018 02:31 PM, Richard Biener wrote: > Why not simply make popcountdi available in the kernel? They do have > implementations for other libgcc functions IIRC. Can you please Kugan create Linux kernel bug for that? So that discussion can happen? Thanks, Martin

[PATCH] Add memmove to value profiling (PR value-prof/35543).

2018-08-01 Thread Martin Liška
Hi. As requested in the PR, I would like to add value profiling for BUILT_IN_MEMMOVE. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Martin gcc/ChangeLog: 2018-07-31 Martin Liska PR value-prof/35543 * value-prof.c (interesting_

[RFC][PATCH] Clean up of histogram allocation and release.

2018-08-01 Thread Martin Liška
Hi. Attempt of the patch is to remove all histograms right after "profile_estimate" pass. Then nobody should use them. That will simplify code we'll not need verification and currently we leaked some histograms till the end of compilation. Patch can bootstrap on x86_64-linux-gnu and survives regr

[PATCH] __gcov_indirect_call_callee can't be null in __gcov_indirect_call_profiler_v2.

2018-08-01 Thread Martin Liška
Hi. This one is forgotten removal as we call __gcov_indirect_call_profiler_v2 only in situations where __gcov_indirect_call_callee is non-null. I'm going to install that. libgcc/ChangeLog: 2018-07-31 Martin Liska * libgcov-profiler.c (__gcov_indirect_call_profiler_v2): Do not

[PATCH] Improve dumping of value profiling transformations.

2018-08-01 Thread Martin Liška
Hi. This is format clean-up of value transformations that can happen. It makes it easier to grep them and find how many were actually applied. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Martin gcc/ChangeLog: 2018-07-31 Martin Liska

Re: [PATCH] Add memmove to value profiling (PR value-prof/35543).

2018-08-01 Thread Martin Liška
On 08/01/2018 12:14 PM, Jan Hubicka wrote: > OK, thanks! > We have other builtins that may fold into string function which we expand > internally (str variants comes to mind) perhaps they could be instrumented, > too. Sure, as mentioned here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35543#c5,

Re: [PATCH] Fix target clones (PR gcov-profile/85370).

2018-08-01 Thread Martin Liška
On 07/26/2018 11:00 AM, Richard Biener wrote: > On Thu, Jul 26, 2018 at 10:44 AM Martin Liška wrote: >> >> On 07/25/2018 03:50 PM, Richard Biener wrote: >>> On Wed, Jul 25, 2018 at 3:38 PM Martin Liška wrote: >>>> >>>> Hi. >>>> >

[PATCH] if-to-switch: properly allow side effects only for first condition

2022-06-30 Thread Martin Liška
Properly allow side effects only for a first BB in a condition chain. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR tree-optimization/106126 gcc/ChangeLog: * gimple-if-to-switch.cc (struct condition_info): Save

Re: [PATCH] lto: pass -pthread to AM_LDFLAGS [PR 106118]

2022-07-01 Thread Martin Liška
> > OK > I've just pushed that as 51debf7f857. Martin

[PATCH] gcc-descr: by default show revision for HEAD

2022-07-04 Thread Martin Liška
I've made the mistake multiple times while doing a bisection. One would expect that gcc-descr w/o an argument would print revision for the current HEAD and not master. Thus change it. Ready to be installed? Thanks, Martin contrib/ChangeLog: * git-descr.sh: By default print revision for H

[PATCH][pushed] MAINTAINERS: fix alphabetic sorting

2022-07-04 Thread Martin Liška
ChangeLog: * MAINTAINERS: fix sorting of names --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f4a11cdc755..7d9aab76dd9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -463,8 +463,8 @@ Andreas Jaeger

[PATCH] lto-plugin: Add path to libatomic for riscv64

2022-07-04 Thread Martin Liška
Similarly to libgo, we need to provide -L for targets where libpthread does depends on libatomic. Ready for master? PR bootstrap/106156 lto-plugin/ChangeLog: * Makefile.am: Use PTHREAD_CFLAGS. * Makefile.in: Regenerate. * configure.ac: Detect if PTHREAD_CFLAGS sh

Re: [PATCH] lto-plugin: Add path to libatomic for riscv64

2022-07-04 Thread Martin Liška
On 7/4/22 14:28, Richard Biener wrote: > ... but ... is libatomic properly built for the host? libgo is a > target library. You're correct. Well, so the host library should be taken, which works for stage1 lto-plugin: [ 668s] libtool: link: gcc -shared -fPIC -DPIC .libs/lto-plugin.o -pth

Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION

2022-07-04 Thread Martin Liška
On 7/1/22 08:36, Richard Biener wrote: > On Thu, Jun 30, 2022 at 10:42 AM Martin Liška wrote: >> >> On 6/30/22 08:43, Rui Ueyama wrote: >>> Thanks Martin for creating this patch. >> >> You're welcome. >> >>> >>> Here is a prelimin

[PATCH] lto-plugin: use locking only for selected targets

2022-07-07 Thread Martin Liška
For now, support locking only for linux targets that are different from riscv* where the target depends on libatomic (and fails during bootstrap). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR lto/106170 lto-plugin/Change

[PATCH] lto-dump: Do not print output file

2022-07-07 Thread Martin Liška
Right now the following is printed: lto-dump .file "" .ident "GCC: (GNU) 13.0.0 20220707 (experimental)" .section.note.GNU-stack,"",@progbits After the patch we print -help and do not emit any assembly output: lto-dump Usage: lto-dump [OPTION]... SUB_COMMAND [O

Re: [PATCH] lto-plugin: use locking only for selected targets

2022-07-07 Thread Martin Liška
On 7/7/22 13:52, Rainer Orth wrote: > Richard Biener via Gcc-patches writes: > >>> +if test x$use_locking = xyes; then >>> + AC_DEFINE(HAVE_PTHREAD_LOCKING, 1, >>> + [Define if the system-provided pthread locking mechanism.]) > > This isn't even a sentence. At least I cannot parse it

Re: [PATCH] lto-plugin: use locking only for selected targets

2022-07-07 Thread Martin Liška
On 7/7/22 13:46, Richard Biener wrote: > OK - that also resolves the mingw issue, correct? I suppose we need Yes. > to be careful to not advertise v1 API (which includes threadsafeness) > when not HAVE_PTHREAD_LOCKING. Will reflect that in the patch. I'm going to push it now. Martin

Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION

2022-07-08 Thread Martin Liška
vives regression tests. Ready to be installed? Thanks, Martin On 7/7/22 04:19, Rui Ueyama wrote: > On Mon, Jul 4, 2022 at 10:17 PM Martin Liška <mailto:mli...@suse.cz>> wrote: > > On 7/1/22 08:36, Richard Biener wrote: > > On Thu, Jun 30, 2022 at 10:42 AM Martin Liška &

Re: [PATCH v2] Support --disable-fixincludes.

2022-07-08 Thread Martin Liška
On 5/25/22 07:37, Alexandre Oliva wrote: > On May 24, 2022, Martin Liška wrote: > >> Allways install limits.h and syslimits.h header files >> to include folder. > > typo: s/Allways/Always/ Hello. Fixed. > > I'm a little worried about this bit, too

Re: [PATCH] inline: Rebuild target option node for caller [PR105459]

2022-07-08 Thread Martin Liška
On 6/6/22 08:20, Kewen.Lin wrote: > |Hi, PR105459 exposes one issue in inline_call handling that when it decides > to copy FP flags from callee to caller and rebuild the optimization node for > caller fndecl, it's possible that the target option node is also necessary to > be rebuilt. Without up

Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION

2022-07-11 Thread Martin Liška
On 7/11/22 11:55, Richard Biener wrote: > On Mon, Jul 11, 2022 at 11:16 AM Alexander Monakov wrote: >> >> On Mon, 11 Jul 2022, Rui Ueyama wrote: >> but ignoring min_api_supported is wrong, and assuming max_api_supported > 0 is also wrong. It really should check how given [min; max] range

Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION

2022-07-11 Thread Martin Liška
{ >fprintf (stderr, "requested an unsupported API version (%d)\n", > api_version); >abort (); > } > > On Mon, Jul 11, 2022 at 6:51 PM Martin Liška wrote: >> >> On 7/11/22 11:55, Richard Biener wrote: >>> On Mon, Jul 11, 2022

Re: [pushed 1/2] Convert label_text to C++11 move semantics

2022-07-11 Thread Martin Liška
On 7/7/22 22:00, David Malcolm via Gcc-patches wrote: > |libcpp's class label_text stores a char * for a string and a flag saying > whether it owns the buffer. I added this class before we could use C++11, and > so to avoid lots of copying it required an explicit call to > label_text::maybe_free

[PATCH] libsanitizer: cherry-pick 9cf13067cb5088626ba7 from upstream

2022-07-11 Thread Martin Liška
I'm going to push the following cherry-pick which fixes libasan build with top-of-tree glibc. Martin 9cf13067cb5088626ba7ee1ec4c42ec59c7995a0 [sanitizer] Remove #include to resolve fsconfig_command/mount_attr conflict with glibc 2.36 --- .../sanitizer_platform_limits_posix.cpp|

Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION

2022-07-12 Thread Martin Liška
On 7/12/22 08:28, Richard Biener wrote: > On Mon, Jul 11, 2022 at 6:35 PM Alexander Monakov wrote: >> >> On Mon, 11 Jul 2022, Martin Liška wrote: >> >>> I've clarified that linker should return a value that is in range >>> [minimal_api_supported, maxi

Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION

2022-07-12 Thread Martin Liška
On 7/12/22 13:50, Rui Ueyama wrote: > I'm fine, though I don't think I have a right to sign off. I've just pushed that. @Rui: Can you please merge the mold counter-part? Thanks, Martin

[PATCH] lto-plugin: use -pthread only for detected targets

2022-07-13 Thread Martin Liška
Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin Use -pthread only if we are going to use pthread functionality. PR bootstrap/106156 lto-plugin/ChangeLog: * configure: Regenerate. * configure.ac: Use -pthread o

[PATCH][pushed] docs: fix position of @end deftypefn

2022-07-14 Thread Martin Liška
gcc/ChangeLog: * doc/gimple.texi: Close properly a deftypefn. --- gcc/doc/gimple.texi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/doc/gimple.texi b/gcc/doc/gimple.texi index dd9149377f3..9150218fed8 100644 --- a/gcc/doc/gimple.texi +++ b/gcc/doc/gimple.texi @

[PATCH part2][PUSHED] docs: fix position of @end deftypefn

2022-07-14 Thread Martin Liška
gcc/ChangeLog: * doc/gimple.texi: Close properly a deftypefn. --- gcc/doc/gimple.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/doc/gimple.texi b/gcc/doc/gimple.texi index 9150218fed8..7832fa6ff90 100644 --- a/gcc/doc/gimple.texi +++ b/gcc/doc/gimple.texi

[PATCH][pushed] libiberty: fix docs typo

2022-07-14 Thread Martin Liška
libiberty/ChangeLog: * functions.texi: Replace strtoul with strtoull. --- libiberty/functions.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libiberty/functions.texi b/libiberty/functions.texi index e4d74b58220..b56b02e0686 100644 --- a/libiberty/functions.texi +

Re: [PATCH] lto-plugin: use -pthread only for detected targets

2022-07-14 Thread Martin Liška
On 7/13/22 14:15, Richard Biener wrote: > Didn't we have it that way and not work? IIRC LDFLAGS is only > used during configure link tests and _not_ substituted? You are right. There's a proper fix that utilizes AM_CONDITIONAL and sets LDFLAGS properly in Makefile.am. Patch can bootstrap on x86

Re: [PATCH] lto-plugin: use -pthread only for detected targets

2022-07-14 Thread Martin Liška
On 7/14/22 12:10, Richard Biener wrote: > On Thu, Jul 14, 2022 at 12:03 PM Martin Liška wrote: >> >> On 7/13/22 14:15, Richard Biener wrote: >>> Didn't we have it that way and not work? IIRC LDFLAGS is only >>> used during configure link tests and

Re: libgo patch committed: Don't include in sysinfo.c

2022-07-21 Thread Martin Liška
On 7/21/22 12:19, Richard Biener via Gcc-patches wrote: > On Wed, Jul 13, 2022 at 6:03 PM Ian Lance Taylor via Gcc-patches > wrote: >> >> This libgo patch stops including when building >> gen-sysinfo.go. Removing this doesn't change anything at least with >> glibc 2.33. The include was added in

Re: [PATCH] libsanitizer: cherry-pick 9cf13067cb5088626ba7 from upstream

2022-07-21 Thread Martin Liška
On 7/21/22 12:18, Richard Biener wrote: > Can you also push this to active branches please? Sure, I've just done that. Cheers, Martin

[PATCH][pushed] remove 'continue' as last statement in loop

2022-07-22 Thread Martin Liška
PR other/106370 gcc/cp/ChangeLog: * init.cc (sort_mem_initializers): Remove continue as last stmt in a loop. libiberty/ChangeLog: * _doprnt.c: Remove continue as last stmt in a loop. --- gcc/cp/init.cc | 1 - libiberty/_doprnt.c | 1 - 2 files chang

[PATCH] Allow space in git commit-mklog args

2022-07-22 Thread Martin Liška
Hi. Motivation example: $ git commit-mklog -a -b 'PR other/106370,PR other/12345' Preserving a space from git gcc-mklog hook to contrib/mklog.py seems pretty challenging. Thus I recommend preserving extra mklog args via env where it's encoded in JSON format. Thoughts? Thanks, Martin contrib/Cha

[PATCH][pushed] mklog: fill-up subject prefix only for a single PR

2022-07-22 Thread Martin Liška
I've just pushed this one. Martin contrib/ChangeLog: * mklog.py: Use component: [PR xyz] only when one PR is used. --- contrib/mklog.py | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/contrib/mklog.py b/contrib/mklog.py index cd5ef0bcc74..86937

[PATCH] analyzer: fix coding style in sm-fd.cc

2022-07-24 Thread Martin Liška
Hi. First, thanks Mir for your contribution. The following patch addresses coding style issues I let you know in: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106003#c3 Most notably, I converted Windows endlines to Unix style, replace 8 spaces with tabs and removed trailing whitespaces. Please

[PATCH] analyzer: convert tests with dos2unix

2022-07-24 Thread Martin Liška
Ready for master? Thanks, Martin gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fd-2.c: Convert Windows endlines to Unix style. * gcc.dg/analyzer/fd-3.c: Likewise. * gcc.dg/analyzer/fd-4.c: Likewise. * gcc.dg/analyzer/fd-5.c: Likewise. * c-c++-common/at

[PATCH] docs: remove recently added trailing whitespaces

2022-07-25 Thread Martin Liška
Pushed as obvious. Martin gcc/ChangeLog: * doc/extend.texi: Remove trailing whitespaces. * doc/invoke.texi: Likewise. --- gcc/doc/extend.texi | 12 ++-- gcc/doc/invoke.texi | 10 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gcc/doc/extend.t

[PATCH] contrib: use sphinx-build from a venv

2022-07-25 Thread Martin Liška
Hi. As you likely know, I'm still working on transition of the current docs to Sphinx. But for now, I've sent a modernizing patches for the current libgccjit documentation and I will need a more recent version of Sphinx. Can please a maintainer install the package from pip? Something like: vir

Re: [PATCH 1/7] jit,docs: use enum directive for enumeral types

2022-07-25 Thread Martin Liška
On 7/26/22 00:35, David Malcolm wrote: > On Mon, 2022-07-25 at 10:52 +0200, Martin Liska wrote: >> gcc/jit/ChangeLog: >> >> * docs/conf.py: Add needs_sphinx = '3.0' where c:type was >> added. > > Looking at the footer of https://gcc.gnu.org/onlinedocs/jit/index.html > I see we currently on

Re: [PATCH 2/7] jit,docs: replace c:type:`int_type` with :expr:`int_type`

2022-07-25 Thread Martin Liška
On 7/26/22 00:37, David Malcolm wrote: > On Mon, 2022-07-25 at 11:03 +0200, Martin Liska wrote: >> Use expression that work fine for basic type. > > What's the motivation for this change? Surely the things being marked > up are types, rather than expressions? Problem is that one can't reference

Re: [PATCH 6/7] jit,docs: use :expr:`type *` for pointers to a type

2022-07-25 Thread Martin Liška
On 7/26/22 00:41, David Malcolm wrote: > On Mon, 2022-07-25 at 14:39 +0200, Martin Liska wrote: >> gcc/jit/ChangeLog: >> >> * docs/cp/intro/tutorial02.rst: Use :expr:`type *` for >> pointers to a type >> * docs/cp/topics/asm.rst: Likewise. >> * docs/cp/topics/contexts.rst: L

[PATCH 7/7] jit,docs: remove :ref:`modindex`

2022-07-25 Thread Martin Liška
gcc/jit/ChangeLog: * docs/index.rst: Remove reference to module index as we don't emit any. --- gcc/jit/docs/index.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/jit/docs/index.rst b/gcc/jit/docs/index.rst index 21c3140e238..0f575966303 100644 --- a/gcc/jit/docs/index.

[PATCH] jit,docs: shorten assembly output

2022-07-25 Thread Martin Liška
Shorten the assembly example so that there is not slider. Ready for master? Thanks, Martin gcc/jit/ChangeLog: * docs/cp/intro/tutorial02.rst: Shorten the assembly example so that there is not slider. * docs/cp/intro/tutorial04.rst: Likewise. * docs/intro/tutorial0

  1   2   3   4   5   6   7   8   9   10   >