Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

On 11/6/19 10:21 AM, Egeyar Bagcioglu wrote: > Hello, > > I would like to propose the following patches which introduce a compile > option --record-gcc-command-line. When passed to gcc, it saves the command > line option into the produced object file. The option makes it trivial to > trace back

Re: [PATCH 0/4] Eliminate cc0 from m68k

On 11/13/19 6:04 AM, Bernd Schmidt wrote: > This is a set of patches to convert m68k so that it no longer uses cc0. > The approach is to combine cc0 setter/user pairs into cbranch and cstore > patterns. It does not expose the flag register directly. Since m68k is a > target that is not under active

Re: [PATCH 4/5] Handle FIELD_DECL in IPA ICF.

On 11/8/19 3:01 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf-gimple.c (func_checker::hash_operand): Improve > func_checker::hash_operand by handling of FIELD_DECLs. OK jeff

Re: [PATCH 2/5] Update dump message in IPA ICF.

On 11/8/19 12:13 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf-gimple.c (func_checker::compare_gimple_call): Update > bail out reason. > (func_checker::compare_gimple_assign): Likewise. OK jeff

Re: [PATCH 5/5] Update statistics about needed symbols in IPA ICF.

On 11/11/19 6:38 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf.c (sem_item_optimizer::execute): Save > loaded_symbols. > (sem_item_optimizer::parse_nonsingleton_classes): > Return number of loaded symbols. > (sem_item_optimi

Re: [PATCH 3/5] Use func_checker::hash_operand for hashing of GIMPLE operands.

On 11/8/19 1:31 AM, Martin Liska wrote: > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf-gimple.h (func_checker::func_checker): Add > default constructor. > * ipa-icf.c (sem_function::init): Make operand_equal_p > and hash_operand public. > (sem_item::ad

Re: [PATCH 1/2] gdbinit.in: call a function with "call", not "set"

On 11/13/19 4:20 AM, Segher Boessenkool wrote: > Hi! > > On Tue, Nov 12, 2019 at 02:47:33PM +0300, Konstantin Kharlamov wrote: >> Last time a command that calls a function of debuggee with "set" was >> added is 2013 year. Apparently something has changed since then, since >> doing "set foo()" in g

Re: [PATCH 1/4] Preliminary m68k patches

On 11/13/19 6:08 AM, Bernd Schmidt wrote: > This tidies up a few spots in the m68k backend in preparation for the > large patch to follow. This is purely for review purposes: this patch > has not been tested independently, and will be committed together with > the following one. > > Noteworthy ch

Re: [PATCH 05/41] Add -fdiagnostics-nn-line-numbers

On Wed, 2020-01-08 at 23:35 -0500, David Malcolm wrote: > On Wed, 2020-01-08 at 21:17 -0700, Jeff Law wrote: > > On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > > > I may be able to self-approve this. It's used by the > > > diagnostic_path > > &

Re: [PATCH] testsuite: add lib/nn-line-numbers.exp

On Wed, 2020-01-08 at 17:07 -0500, David Malcolm wrote: > (replying to my own "[PATCH 05/41] Add -fdiagnostics-nn-line-numbers" > with a followup that does it at the DejaGnu level rather than as a > test-only option) > > On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > > I may be able to

Re: [PATCH 06/41] Add diagnostic paths

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > I believe I can self-approve this with my "diagnostic messages" > maintainer hat on. It has dependencies on the auto_delete_vec > and the -fdiagnostics-nn-line-numbers patches. > > Changed in v5: > - updated copyright years to include 2020

Re: [PATCH 08/41] timevar.def: add TVs for analyzer

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > This takes the place of the auto_client_timevar code from v1 of the kit: > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01519.html > > gcc/ChangeLog: > * timevar.def (TV_ANALYZER): New timevar. > (TV_ANALYZ

Re: [PATCH 09/41] analyzer: add ChangeLog

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > New in v5. Creating this file means all the ChangeLog entries in > gcc/analyzer are now for this file, rather than for gcc/ChangeLog. > > gcc/analyzer/ChangeLog: > * ChangeLog: New file. Not sure if we have a policy here, but given t

Re: [PATCH 10/41] analyzer: changes to configure.ac

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Unchanged since v4; needs review. > > This patch adds a configuration option to disable building the analyzer. > It is built by default (but off by default at compile-time). > > gcc/ChangeLog: > * configure.ac (--disable-analyzer, EN

Re: [PATCH 12/41] analyzer: new files: analyzer-selftests.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff approved the v1 version of this patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00497.html > I believe the subsequent changes are obvious enough to be self-approvable. > > Changed in v5: > - update ChangeLog path > - upda

Re: [PATCH 11/41] analyzer: add new files to Makefile.in

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Unchanged since v4; needs review > > gcc/ChangeLog: > * Makefile.in (lang_opt_files): Add analyzer.opt. > (ANALYZER_OBJS): New. > (OBJS): Add digraph.o, graphviz.o, tristate.o and ANALYZER_OBJS. OK jeff >

Re: [PATCH 14/41] analyzer: logging support

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Changed in v5: > - update ChangeLog path > - updated copyright years to include 2020 > > Changed in v4: > - wrap with #if ENABLE_ANALYZER > - add DISABLE_COPY_AND_ASSIGN > > This patch adds a logging framework to the ana

Re: [PATCH 16/41] analyzer: new files: graphviz.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review > > Changed in v5: > - updated copyright years to include 2020 > > Changed in v3: > - https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02461.html > - moved from gcc/analyzer to gcc > > This patch adds a simple wrapper class to m

Re: [PATCH 15/41] analyzer: new file: analyzer-pass.cc and pass registration

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Changed in v5: > - update ChangeLog path > - updated copyright years to include 2020 > > Changed in v4: > - Remove include of gcc-plugin.h, reworking includes accordingly. > - Use TV_ANALYZER rather than TV_NONE for the p

Re: [PATCH 17/41] analyzer: new files: digraph.{cc|h} and shortest-paths.h

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff semi-approved an earlier version of this here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00502.html > > Changed in v5: > - updated copyright years to include 2020 > > Changed in v4: > - Moved from gcc/analyzer to gcc, renami

Re: [PATCH 19/41] analyzer: new files: analyzer.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff reviewed an earlier version of this here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00503.html > My response: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00809.html > I have followup patches that implement the function_set

Re: [PATCH 20/41] analyzer: new files: tristate.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff semi-approved an earlier version of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00504.html > > msebor had some observations here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00644.html > TODO: investigate

Re: [PATCH 23/41] analyzer: new files: pending-diagnostic.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > There was some discussion of the v1 version of this here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00536.html > in terms of whether this could be moved up to the "gcc" subdir > (not without a lot of extra work). >

Re: [PATCH 26/41] analyzer: new file: sm-file.cc

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff reviewed the v1 version of this patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00507.html > > I note this seems somewhat incomplete -- which is fine given my > > recommendation was to focus on the double-free analyzer. T

Re: [PATCH 27/41] analyzer: new file: sm-pattern-test.cc

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff approved the v1 version of this patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00508.html > and the subsequent changes are obvious in my view. > > Changed in v5: > - update ChangeLog path > - updated copyright years to i

Re: [PATCH 28/41] analyzer: new file: sm-sensitive.cc

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff reviewed the v1 version of this patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00509.html > > Given it's not ready for production, fine. Presumably one of the areas > > for improvement is a better answer to the "what con

Re: [PATCH 29/41] analyzer: new file: sm-signal.cc

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Although the comments say "experimental", there are followups (using > function_set) which make this much more production-ready than the > other sm-*.cc (other than malloc). > > Changed in v5: > - update ChangeLog path >

Re: [PATCH 30/41] analyzer: new file: sm-taint.cc

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Initial comments by Jeff here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00510.html > This checker isn't ready for production yet, so the discussion in the > cover letter applies here. > > Changed in v5: > - update ChangeLog path >

Re: [PATCH 32/41] analyzer: new files: call-string.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff approved the v1 version of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00806.html > and the followups count as obvious in my opinion. > > Changed in v5: > - update ChangeLog path > - updated copyright years to inc

Re: [PATCH 31/41] analyzer: new files: analysis-plan.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff approved ("No concerns here") the v1 version of this patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00511.html > and the subsequent changes fall under the "obvious" rule in my > opinion. > > Changed in v5: > - update Cha

Re: [PATCH 33/41] analyzer: new files: program-point.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff approved the v1 version of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00811.html > (modulo hash_map issues), and the followups count as obvious in my > opinion. > > Changed in v5: > - update ChangeLog path > - up

Re: [PATCH 35/41] analyzer: new file: exploded-graph.h

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff's initial review of v1 of this patch: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00813.html > I've addressed most of the issues he raised there. > TODO: should some structs be classes? > > Changed in v5: > - update ChangeLog pat

Re: [PATCH 36/41] analyzer: new files: state-purge.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff approved the v1 version of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00815.html > (with one item that I've addressed in v5), and the followups count as > obvious in my opinion. > > Changed in v5: > - update Chan

Re: [PATCH 40/41] gdbinit.in: add break-on-saved-diagnostic

On Wed, 2020-01-08 at 04:03 -0500, David Malcolm wrote: > Needs review (or potentially falls under the "obvious" rule, at a > stretch). > > This patch adds a "break-on-saved-diagnostic" command to gdbinit.in, > useful for debugging when a diagnostic is queued by the analyzer. > > gcc/ChangeLog: >

Re: [PATCH 41/41] analyzer: test suite

On Wed, 2020-01-08 at 04:03 -0500, David Malcolm wrote: > Needs review. > > Changed in v5: > - updated for removal of analyzer-specific builtins: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01310.html > > Changed in v4: > - more tests, including a test for .dot output and an LTO test > - up

Re: [PATCH 07/41] Add ordered_hash_map

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. This is used in many places in the analyzer. > msebor made some comments about the v1 version of this patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00231.html > > Changed in v5: > - updated copyright years to

Re: [PATCH 13/41] analyzer: command-line options

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. msebor expressed some concerns in an earlier version > of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00233.html > re overlap with existing functions, and very long names. > For the former, they all have

Re: [PATCH 24/41] analyzer: new files: sm.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > The v1 version of this patch was reviewed by Jeff here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00805.html > TODO: looks like I still need to act on some of his comments there > > Changed in v5: > - update ChangeLog path > - updat

Re: [PATCH 07/41] Add ordered_hash_map

On Fri, 2020-01-10 at 11:30 -0500, David Malcolm wrote: > On Fri, 2020-01-10 at 09:22 -0700, Jeff Law wrote: > > On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > > > Needs review. This is used in many places in the analyzer. > > > msebor made some comments a

Re: [PATCH 25/41] analyzer: new files: sm-malloc.cc and sm-malloc.dot

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Re the v1 version of this patch Jeff asked in: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00506.html > > This goes well beyond what we were originally targeting -- which begs > > the question, what's the state of th

Re: [PATCH 39/41] analyzer: new files: diagnostic-manager.{cc|h}

On Wed, 2020-01-08 at 04:03 -0500, David Malcolm wrote: > Needs review. Jeff reviewed the v1 version of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00818.html > requesting a function to be split up, which I did in v4. > See the URLs below for notes on the other changes. Just

Re: [PATCH 38/41] analyzer: new files: checker-path.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Jeff approved the v1 version of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00820.html > There are some non-trivial changes in the followups (see the URLs > below). > > Changed in v5: > - update ChangeLog path > - upda

Re: [PATCH 35/41] analyzer: new file: exploded-graph.h

On Fri, 2020-01-10 at 12:18 -0500, David Malcolm wrote: > On Fri, 2020-01-10 at 09:10 -0700, Jeff Law wrote: > > On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > > > Jeff's initial review of v1 of this patch: > > > https://gcc.gnu.org/ml/gcc-patches/

Re: [PATCH 18/41] analyzer: new files: supergraph.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Changed in v5: > - update ChangeLog path > - updated copyright years to include 2020 > > Changed in v4: > - Rework includes to avoid gcc-plugin.h > - Wrap everything with #if ENABLE_ANALYZER > - Replace auto_client_timeva

Re: [PATCH 34/41] analyzer: new files: program-state.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Changed in v5: > - update ChangeLog path > - updated copyright years to include 2020 > > Changed in v4: > - Remove include of gcc-plugin.h, reworking includes accordingly. > - Wrap everything in #if ENABLE_ANALYZER > - Re

Re: [PATCH 18/41] analyzer: new files: supergraph.{cc|h}

On Fri, 2020-01-10 at 12:40 -0500, David Malcolm wrote: > > > On Fri, 2020-01-10 at 10:24 -0700, Jeff Law wrote: > > I don't see any EH handling mechansisms. I realize we haven't > > focused > > on C++ and thus EH hasn't been the top of our minds, but

Re: [PATCH] testsuite: add lib/nn-line-numbers.exp

On Fri, 2020-01-10 at 11:44 -0500, David Malcolm wrote: > On Fri, 2020-01-10 at 08:35 -0700, Jeff Law wrote: > > On Wed, 2020-01-08 at 17:07 -0500, David Malcolm wrote: > > > (replying to my own "[PATCH 05/41] Add -fdiagnostics-nn-line- > > > numbers" >

Re: [PATCH 21/41] analyzer: new files: constraint-manager.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Changed in v5: > - update ChangeLog path > - updated copyright years to include 2020 > > Changed in v4: > - Remove include of gcc-plugin.h, reworking includes accordingly. > - Wrap everything in #if ENABLE_ANALYZER > - Re

Re: [PATCH 37/41] analyzer: new files: engine.{cc|h}

On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote: > Needs review. > > Changed in v5: > - update ChangeLog path > - updated copyright years to include 2020 > > Changed in v4: > - Remove include of gcc-plugin.h, reworking includes accordingly. > - Wrap everything in #if ENABLE_ANALYZER > - Re

Re: [PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

On Mon, 2020-01-13 at 13:32 -0500, Jason Merrill wrote: > On 12/12/19 3:44 PM, Jason Merrill wrote: > > On Wed, Dec 11, 2019 at 1:37 PM Jeff Law > <mailto:l...@redhat.com>> wrote: > > On Wed, 2019-12-11 at 00:03 -0700, Sandra Loosemore wrote: > > >

Re: [PATCH GCC11]Improve uninitialized warning with value range info

On Wed, 2020-01-08 at 12:58 +0800, bin.cheng wrote: > Hi, > > Function use_pred_not_overlap_with_undef_path_pred of > pass_late_warn_uninitialized > checks if predicate of variable use overlaps with predicate of undefined > control flow path. > For now, it only checks ssa_var comparing against c

Re: [PATCH] Fix a bug that propagation in recursive function uses wrong aggregate lattice (PR ipa/93084)

On Tue, 2020-01-07 at 14:18 +0100, Martin Jambor wrote: > Hi, > > On Fri, Jan 03 2020, Feng Xue OS wrote: > > When checking a self-recursively generated value for aggregate jump > > function, wrong aggregate lattice was used, which will cause infinite > > constant propagation. This patch is compos

Re: [PATCH] gdbinit.in: make shorthands accept an explicit argument

On Sat, 2020-01-04 at 16:35 +0300, Alexander Monakov wrote: > Hi, > > I'm posting an updated patch for GCC gdbinit originally proposed by > Konstantin. > The patch amends debugging shorthands such as 'pr' to accept an explicit > argument, in addition to taking an implicit argument from $ as today

Re: [PATCH] Remove redundant builtins for avx512f scalar instructions.

On Tue, 2019-12-24 at 13:31 +0800, Hongyu Wang wrote: > Hi: > For avx512f scalar instructions, current builtin function like > __builtin_ia32_*{sd,ss}_round can be replaced by > __builtin_ia32_*{sd,ss}_mask_round with mask parameter set to -1. This > patch did the replacement and remove the corre

Re: [PATCH] Fix wrong-code x86 issue with avx512{f,vl} fma (PR target/93009)

On Sat, 2019-12-21 at 00:34 +0100, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, the following testcase is miscompiled with avx512vl. > The reason is that the fma *_bcst_1 define_insns have two alternatives: > "=v,v" "0,v" "v,0" "m,m" and use the same > vfmadd213* %3, %2, %0 > pattern. I

Re: [PATCH] Fix symver attribute with LTO

On Wed, 2019-12-18 at 10:26 +0100, Jan Hubicka wrote: > Hi, > sorry I forgot to include cgraph and varpool changes in the patch. > > Index: varpool.c > === > --- varpool.c (revision 279467) > +++ varpool.c (working copy) > @@ -539,8 +

Re: [PATCH PR92926]Fix wrong code caused by ctor node translation unit wide sharing

On Thu, 2020-01-09 at 14:20 +0800, Bin.Cheng wrote: > On Fri, Dec 20, 2019 at 3:10 PM Richard Biener > wrote: > > On December 20, 2019 2:13:47 AM GMT+01:00, "Bin.Cheng" > > wrote: > > > On Fri, Dec 13, 2019 at 11:26 AM bin.cheng > > > wrote: > > > > Hi, > > > > > > > > As reported in PR92926,

Re: [PATCH 1/3] Refactor copying decl section names

On Tue, 2019-11-12 at 22:28 -0800, Strager Neds wrote: > Sometimes, we need to copy a section name from one decl or symtab node > to another. Currently, this is done by getting the source's section > name and setting the destination's section name. For example: > > set_decl_section_name (dest,

Re: [PATCH] libiberty, include: add bsearch_r

On Fri, 2020-01-10 at 15:55 +, Nick Alcock wrote: > libctf wants a bsearch that takes a void * arg pointer to avoid a > nonportable use of __thread. > > bsearch_r is required, not optional, at this point because as far as I > can see this obvious-sounding function is not implemented by anyone'

Fix for LTO compromised autoconf test in libiberty

GCC's ability to inline/clone self-recursive calls compromises the find_stack_direction test in libiberty's configure. The test essentially takes the address of a local in an outer and inner context then compares their addresses to determine the direction of stack growth. Inlining causes the loc

Re: Fix for LTO compromised autoconf test in libiberty

On Tue, 2020-01-14 at 23:21 +0100, Andreas Schwab wrote: > On Jan 14 2020, Jeff Law wrote: > > > diff --git a/libiberty/aclocal.m4 b/libiberty/aclocal.m4 > > index bf8a907100f..381ed3b27e3 100644 > > --- a/libiberty/aclocal.m4 > > +++ b/libiberty/aclocal.m4 &

Re: Fix for LTO compromised autoconf test in libiberty

On Tue, 2020-01-14 at 23:09 +0100, Jakub Jelinek wrote: > On Tue, Jan 14, 2020 at 03:02:01PM -0700, Jeff Law wrote: > > Bootstrapped and regression tested on x86_64. Verified STACK_DIRECTION > > is correct via hand inspection. > > > > OK for the trunk? > > Woul

Re: Fix for LTO compromised autoconf test in libiberty

On Tue, 2020-01-14 at 23:33 +, Joseph Myers wrote: > My preference is still what I said in > ;: either > eliminate C alloca from libiberty, or don't build it with any compiler > defining __GNUC__. I'd be surprised if there are host c

Re: [PATCH] tree-optimization: Fix tree dse of __*_chk PR93262

On Wed, 2020-01-15 at 01:02 +0100, Jakub Jelinek wrote: > Hi! > > The following testcase shows that GCC trunk mishandles DSE of __*_chk > calls. Tail trimming of the calls is fine, we want to just decrease the > third argument and keep the first two and last arguments unmodified. > But for head t

Re: [PATCH] tree-optimization: Fix tree dse of strncpy PR93249

On Wed, 2020-01-15 at 00:53 +0100, Jakub Jelinek wrote: > Hi! > > As the testcase shows, tail trimming of strncpy in tree-ssa-dse.c is fine, > we just copy or clear fewer bytes in the destination, but unlike > memcpy/memset etc., head trimming is problematic in certain cases. > If we can prove tha

Re: [PATCH] Do not set -fomit-frame-pointer if TARGET_OMIT_LEAF_FRAME_POINTER_P.

On Fri, 2020-01-03 at 12:23 +0100, Martin Liška wrote: > Hi. > > I'm not fully sure about the change, but -momit-leaf-frame-pointer > probably should not globally omit frame pointers? > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks,

Re: Fix for LTO compromised autoconf test in libiberty

On Tue, 2020-01-14 at 23:33 +, Joseph Myers wrote: > My preference is still what I said in > ;: either > eliminate C alloca from libiberty, or don't build it with any compiler > defining __GNUC__. I'd be surprised if there are host c

Re: [PATCH] adjust object size computation for union accesses and PHIs (PR 92765)

On Wed, 2020-01-15 at 13:18 +, Martin Sebor wrote: > The strcmp optimization newly introduced in GCC 10 relies on > the size of the smallest referenced array object to determine > whether the function can return zero. When the size of > the object is smaller than the length of the other string

Re: [PATCH] Fix PR libgcc/92988

On Mon, 2019-12-30 at 14:23 -0500, John David Anglin wrote: > Tested on hppa64-hp-hpux11.11. > > Okay? > > Dave > > 2019-12-30 John David Anglin > > PR libgcc/92988 > * crtstuff.c (__do_global_dtors_aux): Only call __cxa_finalize if > DEFAULT_USE_CXA_ATEXIT is true. Who is

Re: [PATCH] Fix PR libgcc/92988

On Wed, 2020-01-15 at 17:27 -0500, John David Anglin wrote: > On 2020-01-15 3:45 p.m., Jeff Law wrote: > > On Mon, 2019-12-30 at 14:23 -0500, John David Anglin wrote: > > > Tested on hppa64-hp-hpux11.11. > > > > > > Okay? > > > > >

Re: [PATCH] Fix ICE caused by swallowing a token in c_parser_consume_token

On Thu, 2020-01-16 at 23:43 +, Joseph Myers wrote: > Thanks, patch committed. Beat me to it :-) I spun it yesterday, but didn't get around to committing it. jeff

Re: [PATCH] Fix noreorder symbol partitioning reversion.

On Thu, 2020-01-16 at 20:43 +0100, Martin Liška wrote: > Hi. > > The patch is fixes a regression in libgcrypt package where > we incorrectly forget to stream out a definition of a no-reorder symbol. > It's caused by LTO balanced map reversion, where we do not revert > also best_noreorder_pos. > >

Re: [PATCH] testsuite: Unbreak compat.exp testing with alt compiler (PR testsuite/93294)

On Thu, 2020-01-16 at 18:01 +0100, Jakub Jelinek wrote: > Hi! > > The PR87488 changes include: > * lib/prune.exp (TEST_ALWAYS_FLAGS): Add -fdiagnostics-urls=never. > Unfortunately, this broke all the compat.exp etc. compatibility testing with > alternate compilers, because those compilers (l

Re: [PATCH] arm: fix rtl checking bootstrap (PR target/93312)

On Fri, 2020-01-17 at 20:15 +0100, Jakub Jelinek wrote: > Hi! > > As reported in PR93312, the: > > > > > > > * config/arm/arm.c (clear_operation_p): New function. > change broke RTL checking bootstrap. > > On the testcase from the PR (which is distilled from libgcc2.c, so I think > we don

Re: [PATCH] cprop: Don't replace fixed hard regs with pseudos [PR93124]

On Wed, 2020-01-22 at 12:02 +, Richard Sandiford wrote: > One consequence of r276318 was that cselib now preserves sp-based > values across function calls. This in turn convinced cprop to > replace the clobber in: > >(set (reg PSUEDO) (reg sp)) >... >(call ...) >... >(clob

Re: [PATCH] auto-inc-dec: Don't add incs/decs to bare CLOBBERs [PR93124]

On Wed, 2020-01-22 at 12:11 +, Richard Sandiford wrote: > In this PR, auto-inc-dec was trying to turn: > > (set (reg X) (plus (reg X) (const_int N))) > (clobber (mem (reg X))) > > into: > > (clobber (mem (pre_modify (reg X) ...))) > > But bare clobber insns are just there to des

Re: [PATCH 4/4] [ARC] Update ARC600 multiplication cost.

On Wed, 2020-01-22 at 10:14 +0200, Claudiu Zissulescu wrote: > The ARC's 600 multiplication instruction can accept signed 12 bit > instructions. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.c (arc_rtx_costs): Update mul64 cost. OK jeff >

Re: [PATCH 3/4] [ARC] Save mlo/mhi registers when ISR.

On Wed, 2020-01-22 at 10:14 +0200, Claudiu Zissulescu wrote: > ARC600 when configured with mul64 instructions uses mlo and mhi > registers to store the 64 result of the multiplication. In the ARC600 > ISA documentation we have the next register configuration when ARC600 > is configured only with mu

Re: [PATCH] avoid -Wrestrict on sprintf %p with destination as argument (PR 84919)

On Wed, 2020-01-22 at 15:59 +0100, Martin Sebor wrote: > The early front-end only implementation of -Wrestrict that's still > present in GCC 10 issues a false postive for %p arguments that are > the same as the destination. Bug 84919 reports an instance of this > false positive in the Linux kernel

Re: [PATCH] Allow tree-ssa.exp to be run by itself

On Tue, 2020-01-21 at 17:56 -0800, apin...@marvell.com wrote: > From: Andrew Pinski > > tree-ssa testcases sometimes check autovect effective target > but does not set it up. On MIPS, those testcases fail with > some TCL error messages. This fixes the issue by calling > check_vect_support_and_s

Re: [PATCH] testsuite: Add target/xfail argument to check-function-bodies

On Tue, 2020-01-21 at 14:59 +, Richard Sandiford wrote: > check-function-bodies allows individual function tests to be > annotated with target/xfail selectors, but sometimes it's > useful to have the same selector for all functions. > > Tested on aarch64-linux-gnu and x86_64-linux-gnu, and wit

Re: [PATCH] Fix PR 93242: patchable-function-entry broken on MIPS

On Mon, 2020-01-20 at 09:42 +0100, Richard Biener wrote: > On Sat, Jan 18, 2020 at 1:47 AM wrote: > > From: Andrew Pinski > > > > On MIPS, .set noreorder/reorder needs to emitted around > > the nop. The template for the nop instruction uses %(/%) to > > do that. But default_print_patchable_fun

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

On Wed, 2020-01-22 at 15:39 +, Andrew Burgess wrote: > The motivation behind this change is to make it easier for a user to > link against static libraries on a target where dynamic libraries are > the default library type (for example GNU/Linux). > > Further, my motivation is really for linki

Re: [PATCH 1/4] [ARC] Make libgcc compatible with ARC's reduced register set config.

On Wed, 2020-01-22 at 10:14 +0200, Claudiu Zissulescu wrote: > ARC processors can work with a reduced register set (i.e. registers > r4-r9 and r16-r25 are not available). This option can be enabled > passing -mrf16 option to the compiler, or by using -mcpu=em_mini CPU > configuration. Using RF16 co

Re: [PATCH] Fix PR 93242: patchable-function-entry broken on MIPS

On Wed, 2020-01-22 at 13:16 -0800, Andrew Pinski wrote: > On Wed, Jan 22, 2020 at 12:48 PM Jeff Law wrote: > > On Mon, 2020-01-20 at 09:42 +0100, Richard Biener wrote: > > > On Sat, Jan 18, 2020 at 1:47 AM wrote: > > > > From: Andrew Pinski > > > > >

Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.

On Thu, 2020-01-23 at 10:58 +, Dragan Mladjenovic wrote: > On 07.12.2019. 19:33, Jeff Law wrote: > > On Thu, 2019-11-07 at 17:05 +, Dragan Mladjenovic wrote: > > > On 01.11.2019. 11:32, Dragan Mladjenovic wrote: > > > > On 10.08.2019. 00:15, Joseph Myers wrote

Re: [PATCH] Fix patchable-function-entry on arc

On Wed, 2020-01-22 at 17:25 -0800, apin...@marvell.com wrote: > From: Andrew Pinski > > The problem here is arc looks at current_output_insn unconditional > but sometimes current_output_insn is NULL. With patchable-function-entry, > it will be. This is similar to how the nios2, handles "%.". >

Re: [PATCH] postreload: Fix up postreload combine [PR93402]

On Thu, 2020-01-23 at 20:05 +0100, Richard Biener wrote: > On January 23, 2020 7:22:02 PM GMT+01:00, Jakub Jelinek > wrote: > > Hi! > > > > The following testcase is miscompiled, because the postreload pass > > changes: > > -(insn 14 13 23 2 (parallel [ > > -(set (reg:DI 1 dx [94]) >

Re: [PATCH] Filter out language specific options from --help=common.

On Thu, 2020-01-23 at 15:28 +0100, Martin Liška wrote: > Hi. > > The following is attempt to fix the PR. Idea is such that > all non-driver Common options that are also used in context > of a languages should not be printed in --help=common. An > exception would be an option that will be included

Re: [PATCH] Do not print params in --help except --help=param.

On Thu, 2020-01-23 at 15:26 +0100, Martin Liška wrote: > Hi. > > The patch finishes stripping of params in --help dump > for e.g. --help=joined or --help=separate. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/Ch

Re: [PATCH] cprop: Don't replace fixed hard regs with pseudos [PR93124]

On Thu, 2020-01-23 at 11:43 +, Richard Sandiford wrote: > Jeff Law writes: > > On Wed, 2020-01-22 at 12:02 +, Richard Sandiford wrote: > > > One consequence of r276318 was that cselib now preserves sp-based > > > values across function calls. This in turn convi

Re: [PATCH] libsanitizer: Add missign file and regen Makefile.in

On Wed, 2020-01-22 at 22:23 +0100, Andreas Tobler wrote: > Hi all, > > I'm digginig out old patches and I want to complete the libasan support > for FreeBSD x86_64. The below one was not that obvious when you have > been away for the past years. > > In the last import the sanitizer_platform_lim

Re: [PATCH 2/4] [ARC] Propagate uncached type attribute.

On Wed, 2020-01-22 at 10:14 +0200, Claudiu Zissulescu wrote: > Like `packed` type attribute, the ARC's `uncached` type attribute > needs to be propagated to each member of the struct where it is used. > Fix this behavior and add a test. > > gcc/ > -xx-xx Claudiu Zissulescu > > * conf

Re: [PATCH] doc: target.def (flags_regnum): Mention effect on delay slot filling.

On Thu, 2020-01-23 at 20:38 +0100, Hans-Peter Nilsson wrote: > gcc: > * target.def (flags_regnum): Also mention effect on delay slot filling. > * doc/tm.texi: Regenerate. > > Noticed the "hard way" dealing with performance fallout for the > CRIS decc0ration. > > Previously, the documentation blur

Re: [patch, testsuite] Add -fdelete-null-pointer-checks to some C++ testcases

On Tue, 2020-01-21 at 15:00 -0700, Sandra Loosemore wrote: > In doing some nios2-elf testing, I ran into a bunch of failures in > constexpr-related tests in the C++ testsuite. This target defaults to > -fno-delete-null-pointer-checks at the request of Altera/Intel, in order > to support some of

[committed] [PR target/92269] Fix label for profiling on H8

As mentioned in the PR, there's a bug in the H8 profiling support which results in the wrong label name being emitted. Specifically the label is missing a ".". While we're in stage4, this affects just the H8 and only when profiling is enabled, so I went ahead and committed the fix to the trunk.

[committed] [PR translation/90162] Fix diagnostic to better follow guidelines

ommit dfa075d00d396f554b4aca183c3ca685fbb73bbd Author: Jeff Law Date: Thu Jan 23 16:03:27 2020 -0700 Fix diagnostic text on H8. * config/h8300/h8300.c (h8300_option_override): Fix diagnostic text. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c00deeed142..023e9c398ea 100644 --- a/gcc/ChangeLog +++

Re: [patch, testsuite] Add -fdelete-null-pointer-checks to some C++ testcases

On Thu, 2020-01-23 at 14:59 -0700, Sandra Loosemore wrote: > On 1/23/20 1:17 PM, Jeff Law wrote: > > On Tue, 2020-01-21 at 15:00 -0700, Sandra Loosemore wrote: > > > In doing some nios2-elf testing, I ran into a bunch of failures in > > > constexpr-related tests in the

[committed] [PR target/13721] Emit reasonable diagnostic rather than ICE for bogus ASM on H8 port

lossage for the other cases. Tested in my tester overnight with no regressions. Committed to the trunk. Jeff commit 64c9f2d9972ad359a32f0a97ee0a806c2532db15 Author: Jeff Law Date: Fri Jan 24 08:57:46 2020 -0700 Emit reasonable diagnostic rather than ICE on invalid ASM on H8 port

[committed] [PR tree-optimization/92788] Check right edge flags when suppressing jump threading

that case. But it really should have been checking EDGE_COMPLEX which includes ABNORMAL_CALL, EH and PRESERVE. This patch fixes that oversight and resolves the BZ. Bootstrapped and regression tested on x86_64. Committed to the trunk. jeff commit 98181563dc4c65c9d23eaa99134e18876b6ec671 Author

<    1   2   3   4   5   6   7   8   9   10   >