On Wed, 2020-01-08 at 04:03 -0500, David Malcolm wrote: > Needs review. Jeff reviewed the v1 version of the patch here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00818.html > requesting a function to be split up, which I did in v4. > See the URLs below for notes on the other changes. Just an FYI, thanks for those pointers to the earlier discussions. They're really handy for refreshing my memory.
> > Changed in v5: > - update ChangeLog path > - updated copyright years to include 2020 > > Changed in v4: > - Remove include of gcc-plugin.h, reworking includes accordingly. > - Wrap everything in #if ENABLE_ANALYZER > - Remove /// comment lines > - Add custom events: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00213.html > - Generalize rewind_info_t to exploded_edge::custom_info_t > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00219.html > - Add support for global state: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00217.html > - Show rewind destination for leaks due to longjmp > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02029.html > - Split diagnostic_manager::prune_path into subroutines > - Add DISABLE_COPY_AND_ASSIGN (saved_diagnostic); > > This patch adds diagnostic_manager and related support classes for > saving, deduplicating, and emitting analyzer diagnostics. > > gcc/analyzer/ChangeLog: > * diagnostic-manager.cc: New file. > * diagnostic-manager.h: New file. OK jeff