Re: [PATCH 1/2] analyzer: further fixes for comparisons between uncomparable types (PR 93450)

2020-01-31 Thread Jakub Jelinek
On Thu, Jan 30, 2020 at 08:19:17PM -0500, David Malcolm wrote: > gcc/analyzer/ChangeLog: > PR analyzer/93450 > * constraint-manager.cc > (constraint_manager::get_or_add_equiv_class): Only compare constants > if their types are compatible. > * region-model.cc (constant_

Re: [PATCH 2/2] analyzer: avoid use of fold_build2

2020-01-31 Thread Jakub Jelinek
On Thu, Jan 30, 2020 at 08:19:18PM -0500, David Malcolm wrote: > gcc/analyzer/ChangeLog: > * constraint-manager.cc (range::constrained_to_single_element): > Replace fold_build2 with fold_binary. Remove unnecessary newline. > (constraint_manager::get_or_add_equiv_class): Replace f

[PATCH] c++: Partially implement P1042R1: __VA_OPT__ wording clarifications [PR92319]

2020-01-31 Thread Jakub Jelinek
removal changes that are also in the paper, so haven't touched that part. 2020-01-31 Jakub Jelinek Partially implement P1042R1: __VA_OPT__ wording clarifications PR preprocessor/92319 * macro.c (expand_arg): Move declarations before vaopt_state definition.

Re: [PATCH][GCC][middle-end] Fix logical shift truncation (PR91838)

2020-01-31 Thread Jakub Jelinek
-sse testing). The test is also in a wrong directory, has non-standard specification that it requires c++11 or later. Fixed thusly, regtested on i686-linux and x86_64-linux (the latter with --target_board=unix\{-m32/-mno-mmx/-mno-sse,-m32,-m64\}), committed to trunk as obvious. 2020-01-31 Jakub Je

[PATCH] fortran: Fix up TYPE_ARG_TYPES of procs with scalar VALUE optional args [PR92305]

2020-01-31 Thread Jakub Jelinek
ux, powerpc64le-linux and powerpc64-linux (the last one with both -m32/-m64). Ok for trunk? 2020-01-31 Jakub Jelinek PR fortran/92305 * trans-types.c (gfc_get_function_type): Also push boolean_type_node types for non-character scalar VALUE optional dummy arguments.

[PATCH] arm: Fix ICE with movsi + cmpsi -> movsi_compare0 peephole2 [PR91913]

2020-02-01 Thread Jakub Jelinek
_REGNUM" as condition. And yet another option would be to add some predicate that would be arm_hard_general_register_operand and would require that REGNO != SP_REGNUM and use it in this peephole2. But I'd need a suggestion how to call that predicate, because I have no idea how arm call

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Jakub Jelinek
On Sat, Feb 01, 2020 at 07:30:15AM +, Bernd Edlinger wrote: > @@ -239,20 +243,86 @@ colorize_init (diagnostic_color_rule_t rule) > } > } > > +/* Return URL_FORMAT_XXX which tells how we should emit urls > + when in always mode. > + We use GCC_URLS and if that is not defined TERM_URL

Re: [PATCH] fortran: Fix up TYPE_ARG_TYPES of procs with scalar VALUE optional args [PR92305]

2020-02-01 Thread Jakub Jelinek
On Sat, Feb 01, 2020 at 09:43:30AM +0100, Tobias Burnus wrote: > Aha, there the problem was hidden! — I assumed something in the tree went > wrong, but didn't spot where. > > Does this also fix PR 92844? The full diff of test_summary for libgomp on powerpc64le-linux is: === libgo

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Jakub Jelinek
On Sat, Feb 01, 2020 at 03:43:20PM +, Bernd Edlinger wrote: > I seem to remember him saying that he always has to configure with > --with-diagnostics-color=never, and the URLs are on top of that. > But there was no configure option for that, which, given his explanation, > made immediately sens

[PATCH] s390x: Fix popcounthi2_z196 expander [PR93533]

2020-02-01 Thread Jakub Jelinek
8)) >> 8 when we need to either zero extend or mask the result at the end in order to avoid bits from above HImode to affect it, when we can do (x + (x >> 8)) & 0xff (or zero extension). Bootstrapped/regtested on s390x-linux, ok for trunk? 2020-02-01 Jakub jelinek PR ta

Re: [PATCH, v3] wwwdocs: e-mail subject lines for contributions

2020-02-03 Thread Jakub Jelinek
On Mon, Feb 03, 2020 at 05:48:57PM +, Michael Matz wrote: > On Mon, 3 Feb 2020, Richard Earnshaw (lists) wrote: > > > The idea is that the [...] part is NOT part of the commit, only part of > > the email. > > I understand that, but the subject line of this thread says "e-mail > subject line

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-03 Thread Jakub Jelinek
On Mon, Feb 03, 2020 at 08:16:52PM +, Bernd Edlinger wrote: > Jakub, can you confirm that the COLORTERM on your working > gnome-terminal is set to "truecolor" ? On the box where I have display attached to yes, but it isn't propagated through ssh to the workstation that I do GCC development on,

[PATCH] libcpp: Fix ICEs on __has_include syntax errors [PR93545]

2020-02-04 Thread Jakub Jelinek
f we wanted just one error per __has_include, we could add some boolean whether we've emitted errors already and only emit the first one we encounter (not implemented). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02-04 Jakub Jelinek PR preprocesso

[PATCH] libcpp: Diagnose __has_include outside of preprocessor directives [PR93545]

2020-02-04 Thread Jakub Jelinek
still allow it in #define if it is then used in preprocessing directives, I guess that use isn't strictly valid either, but clang seems to accept it. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02-04 Jakub Jelinek * macro.c (builtin_has_include)

[PATCH] c++: Handle CONSTRUCTORs without indexes in find_array_ctor_elt [PR93549]

2020-02-04 Thread Jakub Jelinek
owing n elements have linearly increasing indexes omitted? If we have such an assurance, we could do direct access to access the array elts in such CONSTRUCTORs and be even more efficient than binary search. 2020-02-04 Jakub Jelinek PR c++/93549 * constexpr.c (find_array_ctor_elt):

[PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-04 Thread Jakub Jelinek
re if the RA has a way to express that (and IPA-RA certainly ATM doesn't). 2020-02-04 Jakub Jelinek PR target/92190 * config/i386/i386-features.c (ix86_add_reg_usage_to_vzeroupper): Only include sets and not clobbers in the vzeroupper pattern. * config/i386

Re: [PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-04 Thread Jakub Jelinek
seems to work on the testcase, will bootstrap/regtest it soon. 2020-02-04 Jakub Jelinek PR target/92190 * config/i386/i386-features.c (ix86_add_reg_usage_to_vzeroupper): Only include sets and not clobbers in the vzeroupper pattern. * config/i386/sse.md (*avx_vze

[PATCH] i386: Make xmm16-xmm31 call used even in ms ABI

2020-02-04 Thread Jakub Jelinek
Hi! On Tue, Feb 04, 2020 at 11:16:06AM +0100, Uros Bizjak wrote: > I guess that Comment #9 patch form the PR should be trivially correct, > but althouhg it looks obvious, I don't want to propose the patch since > I have no means of testing it. I don't have means of testing it either. https://docs

Re: [PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-04 Thread Jakub Jelinek
ng code with -fipa-ra, but user asked for that with -fdisable-rtl-split{3,4,5}, so guess that is ok. 2020-02-04 Jakub Jelinek PR target/92190 * config/i386/i386-features.c (ix86_add_reg_usage_to_vzeroupper): Only include sets and not clobbers in the vzeroupper pattern.

Re: [PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-04 Thread Jakub Jelinek
> real insn. My opinion is, that this separation avoids confusion as > much as possible. Okay. So like this if it passes bootstrap/regtest then? 2020-02-04 Jakub Jelinek PR target/92190 * config/i386/i386-features.c (ix86_add_reg_usage_to_vzeroupper): Only includ

Re: [PATCH][DOCUMENTATION] Document ASLR for Precompiled Headers.

2020-02-04 Thread Jakub Jelinek
On Tue, Feb 04, 2020 at 02:55:31PM +0100, Richard Biener wrote: > On Tue, Feb 4, 2020 at 2:45 PM Martin Liška wrote: > > > > Hi. > > > > The patch is about enhancement of the documentation, where > > we do not support ASLR for Precompiled Headers. > > > > Ready for trunk? > > I think we support A

Re: [RFA] [PR rtl-optimization/90275] Handle nop reg->reg copies in cse

2020-02-04 Thread Jakub Jelinek
On Tue, Feb 04, 2020 at 06:04:09PM -0700, Jeff Law wrote: > --- a/gcc/cse.c > +++ b/gcc/cse.c > @@ -5572,6 +5572,16 @@ cse_insn (rtx_insn *insn) > sets[i].rtl = 0; > } > > + /* Similarly for no-op moves. */ > + if (n_sets == 1 > + && GET_CODE (src) == REG Just nits

Re: [PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-05 Thread Jakub Jelinek
On Tue, Feb 04, 2020 at 02:15:04PM +0100, Uros Bizjak wrote: > On Tue, Feb 4, 2020 at 2:13 PM Jakub Jelinek wrote: > > > > On Tue, Feb 04, 2020 at 01:38:51PM +0100, Uros Bizjak wrote: > > > As Richard advised, let's put this safety stuff back. Usually, in > >

Re: [PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-05 Thread Jakub Jelinek
On Wed, Feb 05, 2020 at 10:58:04AM +0100, Jakub Jelinek wrote: > Attached are 3 possible incremental patches for recog.c, all of them fix > all the above regressions, but haven't fully bootstrapped/regtested any of > them yet. My preference would be the last one, which for -O0 and

[committed] openmp: Avoid ICEs with declare simd; declare simd inbranch [PR93555]

2020-02-05 Thread Jakub Jelinek
86-linux, committed to trunk. 2020-02-05 Jakub Jelinek PR middle-end/93555 * omp-simd-clone.c (expand_simd_clones): If simd_clone_mangle or simd_clone_create failed when i == 0, adjust clone->nargs by clone->inbranch. * c-c++-common/gomp/pr93555

[committed] Fix up comment typo.

2020-02-05 Thread Jakub Jelinek
Hi! When briefly looking at PR93586, I've noticed a typo, fixed thusly, committed to trunk as obvious. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index aec156eb773..a4005841f60 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,8 @@ 2020-02-05 Jakub Jelinek + * tre

[PATCH] c++: Mark __builtin_convertvector operand as read [PR93557]

2020-02-05 Thread Jakub Jelinek
ut as the argument must be a vector type, e.g. integral promotions aren't really needed. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02-05 Jakub Jelinek PR c++/93557 * semantics.c (cp_build_vec_convert): Call decay_conversion on arg

Re: [PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-05 Thread Jakub Jelinek
On Wed, Feb 05, 2020 at 11:46:51AM +0100, Uros Bizjak wrote: > I think we should just enable split4 also for -O0. This would also > allow us to remove the "optimize > 0" check above and allow us to > generate a bit more optimal code even with -O0 for > TARGET_SSE_PARTIAL_REG_DEPENDENCY and TARGET_A

Re: [PATCH] i386: Omit clobbers from vzeroupper until final [PR92190]

2020-02-05 Thread Jakub Jelinek
On Wed, Feb 05, 2020 at 12:11:15PM +0100, Uros Bizjak wrote: > > I think the primary question is, do we for -O0 need to enable split2 (as in, > > will anything in pro_and_epilogue or jump2 passes benefit from the > > splitting and worth running two -O0 post-RA split passes), then we could go > > wi

Re: [PATCH/RFC] Make -fanalyzer C only for GCC 10 (PR 93392)

2020-02-05 Thread Jakub Jelinek
On Wed, Feb 05, 2020 at 09:59:19AM -0500, David Malcolm wrote: > Although the analyzer works on GIMPLE SSA and therefore in theory ought > to support all languages supported by GCC, the code currently only > supports the subset of GIMPLE SSA expressible via the C frontend. > > For GCC 10 I want to

Re: [PATCH/RFC] Make -fanalyzer C only for GCC 10 (PR 93392)

2020-02-05 Thread Jakub Jelinek
On Wed, Feb 05, 2020 at 04:18:49PM +0100, Jakub Jelinek wrote: > C has ctors before main too, look for attribute constructor. And you can have exceptions in C too, attribute cleanup for the C "destructors" that are invoked when exception is thrown or pthread cancellati

Re: [PATCH] i386: Make xmm16-xmm31 call used even in ms ABI

2020-02-05 Thread Jakub Jelinek
On Thu, Feb 06, 2020 at 01:00:36AM +, JonY wrote: > On 2/4/20 11:42 AM, Jakub Jelinek wrote: > > Hi! > > > > On Tue, Feb 04, 2020 at 11:16:06AM +0100, Uros Bizjak wrote: > >> I guess that Comment #9 patch form the PR should be trivially correct, > >>

[PATCH] openmp: Notice reduction decl in outer contexts after adding it to shared [PR93515]

2020-02-06 Thread Jakub Jelinek
ivate/linear clauses, will handle that for GCC11. Without this patch, the patch I'll post next breaks c-c++-common/gomp/loop-5.c testcase. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2020-02-06 Jakub Jelinek PR libgomp/93515 *

openmp: Fix handling of non-addressable shared scalars in parallel nested inside of target [PR93515]

2020-02-06 Thread Jakub Jelinek
. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2020-02-06 Jakub Jelinek PR libgomp/93515 * omp-low.c (use_pointer_for_field): For nested constructs, also look for map clauses on target construct. (scan_omp_1_stmt) : Bump temporarily

[PATCH] i386: Improve avx* vector concatenation [PR93594]

2020-02-06 Thread Jakub Jelinek
, both for this low part + zero concatenation special case and for other cases too, so the following define_insn_and_split just recognizes avx_vec_concat made of a low half of a cast and some other reg. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02-06 Jakub Jelinek

Re: [PATCH] c++: Handle CONSTRUCTORs without indexes in find_array_ctor_elt [PR93549]

2020-02-06 Thread Jakub Jelinek
On Wed, Feb 05, 2020 at 01:31:30PM -0500, Jason Merrill wrote: > > from the constexpr new change apparently broke the following testcase. > > When handling COND_EXPR, we build_vector_from_val, however as the argument > > we > > pass to it is not an INTEGER_CST/REAL_CST, but that wrapped in a > > N

Re: [PATCH] c++: Handle CONSTRUCTORs without indexes in find_array_ctor_elt [PR93549]

2020-02-06 Thread Jakub Jelinek
On Thu, Feb 06, 2020 at 10:38:25AM -0500, Jason Merrill wrote: > > I don't know, can try to add some instrumentation and do bootstrap/regtest > > with it. The handling of the CONSTRUCTORs with missing or present or mixed > > indexes is what I found in various middle-end routines. > > The only thin

Re: [committed] x86: Emit "#" instead of calling gcc_unreachable for invalid insns.

2020-02-06 Thread Jakub Jelinek
On Thu, Feb 06, 2020 at 05:36:43PM +0100, Uros Bizjak wrote: > 2020-02-06 Uroš Bizjak > > * config/i386/i386.md (*pushtf): Emit "#" instead of > calling gcc_unreachable in insn output. > (*pushxf): Ditto. > (*pushdf): Ditto. > (*pushsf_rex64): Ditto for alternatives other th

Re: [PATCH] Fix PowerPC -fstack-clash-protection -mprefixed-addr ICE (PR target/93122)

2020-02-06 Thread Jakub Jelinek
On Thu, Feb 06, 2020 at 01:15:25PM -0600, Segher Boessenkool wrote: > On Thu, Jan 30, 2020 at 05:14:08PM +0100, Jakub Jelinek wrote: > > Here is what I meant as the alternative, i.e. don't check any predicates, > > just gen_add3_insn, if that fails, force rs into register and

[wwwdocs] Mention common attribute in gcc-10/porting_to.html

2020-02-06 Thread Jakub Jelinek
Hi! On Tue, Jan 07, 2020 at 03:15:05PM +, Wilco Dijkstra wrote: > --- a/htdocs/gcc-10/porting_to.html > +++ b/htdocs/gcc-10/porting_to.html > @@ -29,9 +29,25 @@ and provide solutions. Let us know if you have suggestions > for improvements! > Preprocessor issues > --> > > - > + > +Default

[PATCH] i386: Fix splitters that call extract_insn_cached [PR93611]

2020-02-06 Thread Jakub Jelinek
perly, while if we call it say from some other context than splitter conditions, the insn is already cached, we don't reset the cache. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02-07 Jakub Jelinek PR target/93611 * config/i386/i386.c (

[PATCH] i386: Better patch to improve avx* vector concatenation [PR93594]

2020-02-07 Thread Jakub Jelinek
n about those, but more importantly, in RTL it would probably force zero initialization of that or use or an uninitialized pseudo, all of which is hard to match in an pattern, so I think an UNSPEC is better for that. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02

[PATCH] arm: Fix up arm installed unwind.h for use in pedantic modes [PR93615]

2020-02-07 Thread Jakub Jelinek
on armv7hl-linux-gnueabi, ok for trunk? 2020-02-07 Jakub Jelinek PR target/93615 * config/arm/unwind-arm.h (gnu_Unwind_Find_got): Rename to ... (_Unwind_gnu_Find_got): ... this. Use __asm instead of asm. Remove trailing :s

Re: [PATCH] i386: Make xmm16-xmm31 call used even in ms ABI

2020-02-07 Thread Jakub Jelinek
try in the patch, and likely add a testcase like the above, so like below? Have you tested the earlier version of the patch on mingw64 or cygwin? If yes, can you just test the testcase from the following patch, without and with the i386.h part and verify it FAILs without and PASSes with it? Ju

Re: [PATCH] xfail and improve some failing libgomp tests

2020-02-07 Thread Jakub Jelinek
On Fri, Feb 07, 2020 at 09:56:38AM +0100, Harwath, Frederik wrote: > * {target-32.c, thread-limit-2.c}: > no "usleep" implemented for nvptx. Cf. https://gcc.gnu.org/PR81690 Please don't, I want to deal with that using declare variant, just didn't get yet around to finishing the last patch needed f

Re: [PATCH] i386: Make xmm16-xmm31 call used even in ms ABI

2020-02-08 Thread Jakub Jelinek
ame binutils version. > > I guess that covers it? I went ahead and committed the patch (with the double config/i386/ in it fixed obviously). > > 2020-02-07 Uroš Bizjak > > Jakub Jelinek > > > > PR target/65782 > > * config/i38

[PATCH v2] c++: Handle CONSTRUCTORs without indexes in find_array_ctor_elt [PR93549]

2020-02-08 Thread Jakub Jelinek
Hi! On Thu, Feb 06, 2020 at 05:04:49PM +0100, Jakub Jelinek wrote: > On Thu, Feb 06, 2020 at 10:38:25AM -0500, Jason Merrill wrote: > > > I don't know, can try to add some instrumentation and do bootstrap/regtest > > > with it. The handling of the CONSTRUCTORs

Re: [PATCH] i386: Make xmm16-xmm31 call used even in ms ABI

2020-02-08 Thread Jakub Jelinek
On Sat, Feb 08, 2020 at 11:32:40AM +0100, Uros Bizjak wrote: > On Sat, Feb 8, 2020 at 11:05 AM Jakub Jelinek wrote: > > > > On Sat, Feb 08, 2020 at 08:24:38AM +, JonY wrote: > > > It does not, I just checked with the master branch of binutils. > > ... > > &

Re: [PATCH] i386: Make xmm16-xmm31 call used even in ms ABI

2020-02-08 Thread Jakub Jelinek
On Sat, Feb 08, 2020 at 11:32:40AM +0100, Uros Bizjak wrote: > I think that the patch should also be backported to gcc-9 branch. The > change is backward compatible, since the new code will save and > restore zmm16+ registers at the caller site, and the old code (e.g. > existing libraries) will the

[committed] openmp: Optimize DECL_IN_CONSTANT_POOL vars in target regions

2020-02-08 Thread Jakub Jelinek
"omp declare target", so that they are on the target device from the beginning and don't need to be copied there. Bootstrapped/regtested on x86_64-linux and i686-linux, tested also with x86_64-linux to nvptx-none offloading, committed to trunk. 2020-02-09 Jakub Jelinek

[PATCH] c++: Fix ICE during constexpr virtual call evaluation [PR93633]

2020-02-08 Thread Jakub Jelinek
inux and i686-linux, ok for trunk? 2020-02-08 Jakub Jelinek PR c++/93633 * constexpr.c (cxx_eval_constant_expression): If obj is heap var with ARRAY_TYPE, use the element type. Punt if objtype after that is not a class type. * g++.dg/cpp2a/constexpr-new

Re: [PATCH] xfail and improve some failing libgomp tests

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 08:49:47AM +0100, Harwath, Frederik wrote: > Add xfails for nvptx offloading because > "no GOMP_OFFLOAD_async_run implemented in plugin-nvptx.c" > (https://gcc.gnu.org/PR81688) and because > "omp target link not implemented for nvptx" > (https://gcc.gnu.org/PR81689). > > li

Patch ping

2020-02-10 Thread Jakub Jelinek
Hi! I'd like to ping a couple of patches: PR target/91913 - arm movsi + cmpsi -> movsi_compare0 peephole2 ICE fix https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00010.html PR preprocessor/92319 - partially implement P1042R1: __VA_OPT__ wording clarifications https://gcc.gnu.org/ml/gcc-patc

Re: [PATCH] arm: Fix up arm installed unwind.h for use in pedantic modes [PR93615]

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 02:03:47PM +0100, Christophe Lyon wrote: > > 2020-02-07 Jakub Jelinek > > > > PR target/93615 > > * config/arm/unwind-arm.h (gnu_Unwind_Find_got): Rename to ... > > (_Unwind_gnu_Find_got): ... this. Use

[committed] i386: Fix strncmp last arguments in x86_64_elf_section_type_flags [PR93641]

2020-02-10 Thread Jakub Jelinek
nk as obvious. 2020-02-10 Jakub Jelinek PR target/58218 PR other/93641 * config/i386/i386.c (x86_64_elf_section_type_flags): Fix up last arguments of strncmp. --- gcc/config/i386/i386.c.jj 2020-02-07 19:11:57.378982855 +0100 +++ gcc/config/i386/i386.c 2020-

[committed] c++: Fix strncmp last argument in dump_decl_name [PR93641]

2020-02-10 Thread Jakub Jelinek
Hi! I'm not aware of symbols starting with _ZG that don't start with _ZGR prefix, but perhaps in the future there might be some. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2020-02-10 Jakub Jelinek PR o

[PATCH] c-format: -Wformat-diag fix [PR93641]

2020-02-10 Thread Jakub Jelinek
on x86_64-linux and i686-linux, ok for trunk? 2020-02-10 Jakub Jelinek PR other/93641 * c-format.c (check_plain): Fix up last argument of strncasecmp. Remove useless extra test. * gcc.dg/format/gcc_diag-11.c (test_cdiag_bad_words): Add two further te

[PATCH] i386: Fix -mavx -mno-mavx2 ICE with VEC_COND_EXPR [PR93637]

2020-02-10 Thread Jakub Jelinek
her than current TARGET_AVX. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Or do you prefer the disabling of the vcond patterns instead? 2020-02-10 Jakub Jelinek PR target/93637 * config/i386/sse.md (VI_256_AVX2): New mode iterator. (vcond_mask_)

Re: [PATCH] i386: Fix -mavx -mno-mavx2 ICE with VEC_COND_EXPR [PR93637]

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 03:40:18PM +0100, Richard Biener wrote: > Hmm. Maybe with FP operands we can also try to implement the mask > as != 0.0 FP condition? Not sure if -1 (or 1) is enough non-NaNish to > not cause problems of course. Well, by the time we reach expansion, we have just the VECTO

Re: [PATCH] fix off-by-one mistakes in attribute access syntax checking (PR 93640)

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 10:20:50AM -0700, Martin Sebor wrote: > PR 93641 points out a number of off-by-one mistakes in calls to strncmp > in GCC where the bound is (unintentionally) less than the length of > the string literal argument. > > PR 93640 is a separate report of another such mistake in

Re: [committed] i386: Fix strncmp last arguments in x86_64_elf_section_type_flags [PR93641]

2020-02-10 Thread Jakub Jelinek
On Mon, Feb 10, 2020 at 12:00:28PM -0600, Segher Boessenkool wrote: > On Mon, Feb 10, 2020 at 03:07:49PM +0100, Jakub Jelinek wrote: > > + || strncmp (name, ".lbss.", sizeof (".lbss.") - 1) == 0 > > You can just use strlen (".lbss.") which is n

[PATCH] real: Fix roundeven on inf/nan [PR93663]

2020-02-11 Thread Jakub Jelinek
alse for rvc_inf/rvc_nan like it returns for rvc_zero, so that we handle roundeven with all those values as round. Inf/NaN are not halfway in between two integers... Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02-12 Jakub Jelinek PR middle-

[PATCH] i386: Fix k*shift* intrinsics [PR93673]

2020-02-11 Thread Jakub Jelinek
actually contains the CONST_INT which has VOIDmode). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Another option would be to drop the modes from match_operand with const_0_to_255_operand. 2020-02-12 Jakub Jelinek PR target/93673 * config/i386/sse.md (k

[PATCH] i386: Fix up vec_extract_lo* patterns [PR93670]

2020-02-12 Thread Jakub Jelinek
d/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-02-12 Jakub Jelinek PR target/93670 * config/i386/sse.md (VI48F_256_DQ): New mode iterator. (avx512vl_vextractf128): Use it instead of VI48F_256. Remove TARGET_AVX512DQ from condition.

[PATCH] c++: Emit DFP typeinfos even when DFP is disabled [PR92906]

2020-02-12 Thread Jakub Jelinek
EFAULT 16 +_ZTIPKDd@@CXXABI_1.3.4 OBJECT WEAK DEFAULT 16 +_ZTIPKDe@@CXXABI_1.3.4 OBJECT WEAK DEFAULT 16 +_ZTIPKDf@@CXXABI_1.3.4 OBJECT WEAK DEFAULT 16 ). Ok for trunk? 2020-02-12 Jakub Jelinek PR libstdc++/92906 * cp-tree.h (enum cp_tree_index): Add CPTI_FALLBACK_DFLOAT32_

[committed] testsuite: Fix up gcc.target/powerpc/pr93122.c test

2020-02-12 Thread Jakub Jelinek
owerpc/pr93122.c test, so it now FAIL: gcc.target/powerpc/pr93122.c (test for excess errors) Excess errors: xgcc: error: unrecognized command-line option '-mprefixed-addr'; did you mean '-mprefixed'? Fixed thusly, bootstrapped/regtested on powerpc64le-linux, committed to trunk as o

testsuite: Fix g++.dg/analyzer/pr93212.C with check-c++-all

2020-02-12 Thread Jakub Jelinek
or '-std=gnu++14' Fixed thusly, regtested on x86_64-linux, committed to trunk as obvious. 2020-02-13 Jakub Jelinek * g++.dg/analyzer/pr93212.C: Require c++14 rather than c++11. --- gcc/testsuite/g++.dg/analyzer/pr93212.C +++ gcc/testsuite/g++.dg/analyzer/pr93212.C @@ -1,4 +1,

[PATCH] sccvn: Handle bitfields in vn_reference_lookup_3 [PR93582]

2020-02-12 Thread Jakub Jelinek
uite/gcc.target/i386/pr37870.c main 2020-02-13 Jakub Jelinek PR tree-optimization/93582 * fold-const.h (shift_bytes_in_array_left, shift_bytes_in_array_right): Declare. * fold-const.c (shift_bytes_in_array_left, shift_bytes_in_array_right): New function, moved

Re: [PATCH] openmp: ignore nowait if async execution is unsupported [PR93481]

2020-02-13 Thread Jakub Jelinek
On Thu, Feb 13, 2020 at 09:04:36AM +0100, Harwath, Frederik wrote: > --- a/libgomp/target.c > +++ b/libgomp/target.c > @@ -2022,6 +2022,16 @@ GOMP_target (int device, void (*fn) (void *), const > void *unused, >gomp_unmap_vars (tgt_vars, true); > } > > +static unsigned int Add inline? > +

[PATCH] i386: Fix up _mm*_mask_popcnt_epi* [PR93696]

2020-02-13 Thread Jakub Jelinek
so it isn't that it used to be broken even in other compilers and got changed afterwards). The following patch fixes it, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Not really sure about release branches, perhaps with big fat warning in gcc-{8,9}/changes.html ? 2020-02

Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274]

2020-02-13 Thread Jakub Jelinek
On Thu, Feb 13, 2020 at 09:39:05AM +0100, Uros Bizjak wrote: > > Changelog > > gcc/ > >* config/i386/avx512vbmi2intrin.h > >(_mm512_[,mask_,maskz_]shrdi_epi16, > >_mm512_[,mask_,maskz_]shrdi_epi32, > >_m512_[,mask_,maskz_]shrdi_epi64, > >_mm512_[,mask_,maskz_

Re: Patch ping

2020-02-13 Thread Jakub Jelinek
On Wed, Feb 12, 2020 at 02:39:05PM -0700, Jeff Law wrote: > On Mon, 2020-02-10 at 10:24 +0100, Jakub Jelinek wrote: > > Hi! > > > > I'd like to ping a couple of patches: > > > > PR target/91913 - arm movsi + cmpsi -> movsi_compare0 peephole2 ICE fix >

[PATCH] c: Fix ICE with cast to VLA [93576]

2020-02-13 Thread Jakub Jelinek
expressions that do have side-effects. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and release branches? 2020-02-13 Jakub Jelinek PR c/93576 * c-decl.c (grokdeclarator): If this_size_varies, only push size into *expr if it has side effects.

Backports to 9.3

2020-02-13 Thread Jakub Jelinek
-6625-gbacdd5e978dad84e9c547b0d5c7fed14b8d75157 Jakub From 3b2fbe3e723b20ea9089e5f45c55b79feb37085b Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Thu, 23 Jan 2020 20:08:22 +0100 Subject: [PATCH 01/15] postreload: Fix up postreload combine [PR93402] The following testcase is miscompiled, because the postreload pass ch

[PATCH] wwwdocs: P1042R1: mention only partial support [PR92319]

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 08:41:45AM +0100, Jason Merrill wrote: > > I'm afraid I'm completely lost about the padding preservation/removal > > changes that are also in the paper, so haven't touched that part. For this, shall we mention the support is only partial like this? The standard has some exa

Re: Backports to 9.3

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 07:45:43AM -0800, H.J. Lu wrote: > Are you preparing for GCC 9.3? I'd like to include this in GCC 9.3: > > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1d69147af203d4dcd2270429f90c93f1a37ddfff > > It is very safe. Uros asked me to wait for a week before backporting to >

[committed] c++: Fix thinko in enum_min_precision [PR61414]

2020-02-14 Thread Jakub Jelinek
86_64-linux and i686-linux and committed to trunk, 9.3 and 8.4. 2020-02-14 Jakub Jelinek PR c++/61414 * class.c (enum_min_precision): Change prec type from int to int &. * g++.dg/cpp0x/enum39.C: New test. --- gcc/cp/class.c.jj 2020-02-12 11:44:18.423371637 +0100

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 08:24:30PM +, GT wrote: > Function rs6000_simd_clone_adjust, even though it's body is empty, > cannot simply be removed. I tried it. It resulted in ICE. In my > view, leaving it empty is preferable to modifying other files > unrelated to rs6000.c in order to avoid having

Re: [RFC PATCH v0] PPC64: Implement POWER Architecure Vector Function ABI.

2020-02-14 Thread Jakub Jelinek
On Fri, Feb 14, 2020 at 10:02:39PM +, GT wrote: > > > Function rs6000_simd_clone_adjust, even though it's body is empty, > > > cannot simply be removed. I tried it. It resulted in ICE. In my > > > view, leaving it empty is preferable to modifying other files > > > unrelated to rs6000.c in order

[PATCH] match.pd: Disallow side-effects in GENERIC for non-COND_EXPR to COND_EXPR simplifications [PR93744]

2020-02-14 Thread Jakub Jelinek
for 8/9 backports (+ the testcases). Bootstrapped/regtested on x86_64-linux and i686-linux. 2020-02-15 Jakub Jelinek PR tree-optimization/93744 * match.pd (((m1 >/=/<= m2) * d -> (m1 >/=/<= m2) ? d : 0, A - ((A - B) & -(C cmp D)) -> (C cmp D) ? B :

Re: [PATCH] Fix PR66552, Missed optimization when shift amount is result of signed modulus

2020-02-17 Thread Jakub Jelinek
On Mon, Feb 17, 2020 at 09:01:13AM +0100, Richard Biener wrote: > On Mon, 17 Feb 2020, Li Jia He wrote: > > This patch wants to fix PR66552 on gimple and optimizes (x shift (n mod C)) > > to (x shift (n bit_and (C - 1))) when C is a constant and power of two as > > discussed in PR66552. > > > > Th

Re: [PATCH] Enable ICE-after-error with -fchecking

2019-12-04 Thread Jakub Jelinek
On Wed, Dec 04, 2019 at 03:20:59PM +0100, Richard Biener wrote: > Currently IL verification errors trigger "confused by earlier errors" > messages with a release compiler but compiling with -fchecking. > That is because those use error() before internal_error. > > This precludes useful things like

Re: [PATCH] Enable mask operation for 128/256-bit vector VCOND_EXPR under avx512f (PR92686)

2019-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2019 at 09:56:46AM +0800, Hongtao Liu wrote: > --- a/gcc/config/i386/i386-expand.c > +++ b/gcc/config/i386/i386-expand.c > + /* Using vector move with mask register. */ > + cmp = force_reg (cmpmode, cmp); > + /* Optimize for mask zero. */ > + op_true = > +

[PATCH] Fix Fortran ICE in tree-nested.c (PR fortran/92781)

2019-12-05 Thread Jakub Jelinek
fixes that, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-12-05 Jakub Jelinek PR fortran/92781 * trans-decl.c (gfc_get_symbol_decl): If sym->backend_decl is current_function_decl, add length to current rather than parent function an

[PATCH] Fix ICE with movstrictqi (PR target/92791)

2019-12-05 Thread Jakub Jelinek
on to FAIL. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-12-05 Jakub Jelinek PR target/92791 * config/i386/i386.md (movstrict): Move test for TARGET_PARTIAL_REG_STALL and not optimizing for size from expander's condition to the body - FAI

Re: [Patch][OpenMP] Fix use_device_… with absent optional arg

2019-12-05 Thread Jakub Jelinek
On Fri, Nov 29, 2019 at 01:03:13PM +0100, Tobias Burnus wrote: > --- a/gcc/fortran/trans-openmp.c > +++ b/gcc/fortran/trans-openmp.c > @@ -60,7 +60,8 @@ gfc_omp_is_allocatable_or_ptr (const_tree decl) > > /* True if the argument is an optional argument; except that false is also > returned f

Re: SPARC build broken

2019-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2019 at 09:25:40AM -0500, David Edelsohn wrote: > Sorry. I had to add tm_p.h because Jakub's earlier patch to add > output.h to cp-gimplify.c broke AIX. > > We certainly can add memmodel.h to cp-gimplify.c. I'd say so. E.g. c-family/c-cppbuiltin.c which also includes output.h inc

Re: [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments

2019-12-05 Thread Jakub Jelinek
On Wed, Nov 20, 2019 at 02:06:18PM +0100, Tobias Burnus wrote: > ** Included in the attached patch are the following previously posted > patches: [1] the trivial libgomp/oacc-mem.c change, [2] only the remaining > single-line change in omp-low.c, [3] the trans-openmp.c changes (which had > to be mo

Re: [RFC] Characters per line: from punch card (80) to line printer (132) (was: [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments)

2019-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2019 at 04:46:45PM +0100, Thomas Schwinge wrote: > Hi! > > ;-P Jakub, thanks for furnishing me a fit occasion here: > > On 2019-12-05T16:15:15+0100, Jakub Jelinek wrote: > > [...] much more indented though, but you could > > use a temporary, like:

Re: [PATCH] add -Wmismatched-tags (PR 61339)

2019-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2019 at 04:33:10PM -0700, Martin Sebor wrote: > > It's hard to distinguish between this type and the previous one by name; > > this one should probably have "map" in its name. > > > > > +static GTY (()) record_to_locs_t *rec2loc; > > ... > > > +    rec2loc = new record_to_locs_t ()

Re: Check for bitwise identity when encoding VECTOR_CSTs (PR 92768)

2019-12-05 Thread Jakub Jelinek
:4:1: warning: SSE vector return without SSE enabled changes the ABI [-Wpsabi] Similarly to other tests, I've added -w -Wno-psabi to disable such warnings, different targets have different and not all have it under -Wno-psabi. Tested on x86_64-linux and i686-linux, committed to trunk as obvious: 2

[PATCH] Fix up Fortran debug info for arrays with descriptors (PR fortran/92775)

2019-12-05 Thread Jakub Jelinek
at aren't ever used since r251949 and just waste compile time memory. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-12-06 Jakub Jelinek PR fortran/92775 * trans.h (struct lang_type, struct lang_decl): Remove span member. (GFC

Re: Add -fpartial-profile-training

2019-12-05 Thread Jakub Jelinek
er --help=optimizers option(s): "^ +-.*[^:.]$" absent from output: " -fprofile-partial-training Do not assume that functions never executed during the train run are cold" Fixed thusly, tested on x86_64-linux, committed to trunk as obvious: 2019-12-06 Jakub Jelinek * common.opt (

[C++ PATCH] CWG 1299, not extending temporary lifetime for ?: (PR c++/92831)

2019-12-06 Thread Jakub Jelinek
t, so I'm just asking how it should behave. extend_ref_init_temps_1 is never called in that case when the expression is COND_EXPR. 2019-12-06 Jakub Jelinek PR c++/92831 - CWG 1299, not extending temporary lifetime for ?: * cp-tree.h (extend_ref_init_temps): Add a new argu

[PATCH] Canonicalize fancy ways of expressing blend operation into COND_EXPR (PR tree-optimization/92834)

2019-12-06 Thread Jakub Jelinek
n/max). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-12-06 Jakub Jelinek PR tree-optimization/92834 * match.pd (A - ((A - B) & -(C cmp D)) -> (C cmp D) ? B : A, A + ((B - A) & -(C cmp D)) -> (C cmp D) ? B : A): New simplifications.

Patch ping (was Re: [C++ PATCH] (temporarily) undefine __cpp_consteval)

2019-12-06 Thread Jakub Jelinek
On Fri, Nov 29, 2019 at 10:30:13AM +0100, Jakub Jelinek wrote: > 2019-11-29 Jakub Jelinek > > * c-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for > now. > > * g++.dg/cpp2a/feat-cxx2a.C: Don't test __cpp_consteval for now. I&#x

[C++ PATCH] Tweak concept diagnostics

2019-12-06 Thread Jakub Jelinek
pt keyword we emit inform (location, "% only available with %<-fconcepts%>"); The following patch adjusts the latter to match the former, because I think more people will use -std=c++2a than -fconcepts in the GCC 10 timeframe. Tested on x86_64-linux, ok

Re: [PATCH 1/2] pretty-print: support URL escape sequences (PR 87488)

2019-12-06 Thread Jakub Jelinek
around and both the URL and the text are visible, but the line with ST has more garbage than line with BEL BEL instead of ST is also what ls -l --hyperlink prints. Ok for trunk? 2019-12-07 Jakub Jelinek * pretty-print.c (pp_begin_url,

[committed] Fix up xvalue handling in ?: with omitted middle operand (PR c++/92831)

2019-12-06 Thread Jakub Jelinek
sion, i.e. > > > - if (lvalue_p (arg1)) > > + if (glvalue_p (arg1)) > > arg2 = arg1 = cp_stabilize_reference (arg1); Indeed, that fixes it and you've preapproved a patch doing that on IRC, which I've committed to trunk now that it successfully bootstrap

Re: [PING 3][PATCH] track dynamic allocation in strlen (PR 91582)

2019-12-06 Thread Jakub Jelinek
On Fri, Dec 06, 2019 at 05:19:36PM -0700, Martin Sebor wrote: > With part 2 (below) of this work committed, I've rebased the patch > on the top of trunk and on top of the updated part 1 (also below). > Attached is the result, retested on x86_64-linux. > --- a/gcc/tree-ssa-strlen.c > +++ b/gcc/tree

<    1   2   3   4   5   6   7   8   9   10   >