Re: [COMMITTED/13] Fix PR 110386: backprop vs ABSU_EXPR

2024-05-09 Thread Andrew Pinski
On Sun, Oct 1, 2023 at 12:28 PM Andrew Pinski wrote: > > From: Andrew Pinski > > The issue here is that when backprop tries to go > and strip sign ops, it skips over ABSU_EXPR but > ABSU_EXPR not only does an ABS, it also changes the > type to unsigned. > Since strip_si

[PATCH] Match: optimize `a == CST & unary(a)` [PR111487]

2024-05-13 Thread Andrew Pinski
eLog: * match.pd (tcc_int_unary): New operator list. (`a == CST & unary(a)`): New pattern. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/and-unary-1.c: New test. Signed-off-by: Andrew Pinski --- gcc/match.pd| 12 gcc/testsuite/gcc.dg/tree-ssa/and-u

Re: [RFC][PATCH] PR tree-optimization/109071 - -Warray-bounds false positive warnings due to code duplication from jump threading

2024-05-13 Thread Andrew Pinski
On Mon, May 13, 2024, 11:41 PM Kees Cook wrote: > On Mon, May 13, 2024 at 02:46:32PM -0600, Jeff Law wrote: > > > > > > On 5/13/24 1:48 PM, Qing Zhao wrote: > > > -Warray-bounds is an important option to enable linux kernal to keep > > > the array out-of-bound errors out of the source tree. > > >

[PATCH 2/2] middle-end: Remove integer_three_node [PR116537]

2024-08-29 Thread Andrew Pinski
h_ref): Call build_int_cst instead of using integer_three_node. * tree.cc (build_common_tree_nodes): Remove initialization of integer_three_node. * tree.h (integer_three_node): Delete. Signed-off-by: Andrew Pinski --- gcc/tree-core.h | 1 - gcc/tree-ssa

[PATCH 1/2] expand: Small speed up expansion of __builtin_prefetch

2024-08-29 Thread Andrew Pinski
This is a small speed up of the expansion of __builtin_prefetch. Basically for the optional arguments, no reason to call expand_normal on a constant integer that we know the value, just replace it with GEN_INT/const0_rtx instead. Bootstrapped and tested on x86_64-linux. gcc/ChangeLog: *

[PATCH] middle-end: also optimized `popcount(a) <= 1` [PR90693]

2024-08-29 Thread Andrew Pinski
ts_dom_walker::after_dom_children): Call match_single_bit_test for LE_EXPR/GT_EXPR also. gcc/testsuite/ChangeLog: * gcc.target/aarch64/popcnt-le-1.c: New test. * gcc.target/aarch64/popcnt-le-2.c: New test. * gcc.target/aarch64/popcnt-le-3.c: New test. Signed-off-by: Andrew Pin

Re: [PATCH v2] GCC Driver : Enable very long gcc command-line option

2024-08-30 Thread Andrew Pinski
ike what is done for the normal command line. Hard coding "/tmp" here is wrong because TMPDIR might not be set to "/tmp" and even more with -save-temps, the response file should stay around afterwards and be in the working directory rather than TMPDIR. Thanks, Andrew Pinski > +

[PATCH 1/2] testsuite: Change what is being tested for pr66726-2.c

2024-08-30 Thread Andrew Pinski
ed on x86_64-linux. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/pr66726-2.c: Update scan dump message. Signed-off-by: Andrew Pinski --- gcc/testsuite/gcc.dg/tree-ssa/pr66726-2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr66726-2.c

Re: [PATCH] MATCH: add abs support for half float

2024-09-01 Thread Andrew Pinski
On Sun, Sep 1, 2024 at 4:27 PM Kugan Vivekanandarajah wrote: > > Hi Andrew. > > > On 28 Aug 2024, at 2:23 pm, Andrew Pinski wrote: > > > > External email: Use caution opening links or attachments > > > > > > On Tue, Aug 27, 2024 at 8:54 PM Kugan Vive

[PATCH] slsr: Use simple_dce_from_worklist in SLSR [PR116554]

2024-08-31 Thread Andrew Pinski
e and replace_profitable_candidates. (analyze_candidates_and_replace): Call simple_dce_from_worklist and update calls to replace_profitable_candidates, and replace_uncond_cands_and_profitable_phis. Signed-off-by: Andrew Pinski --- gcc/gimple-ssa-strength-reduction.cc

[PUSEHED] libobjc: Add cast to void* to disable warning for casting between incompatible function types [PR89586]

2024-08-31 Thread Andrew Pinski
* sendmsg.c (__objc_get_forward_imp): Add cast to `void*` before casting to IMP. Signed-off-by: Andrew Pinski --- libobjc/sendmsg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libobjc/sendmsg.c b/libobjc/sendmsg.c index e781b2a9e50..65bc250ad90 100644 --- a

[PATCH 2/2] phiopt: Ignore some nop statements in heursics [PR116098]

2024-08-30 Thread Andrew Pinski
predicts for heuristic for conversion with a constant. gcc/testsuite/ChangeLog: * c-c++-common/torture/pr116098-1.c: New test. * gcc.target/aarch64/csel-1.c: New test. Signed-off-by: Andrew Pinski --- .../c-c++-common/torture/pr116098-1.c | 84 +++ gcc

Re: [PATCH 2/8] i386: Optimize ordered and nonequal

2024-09-02 Thread Andrew Pinski
his (bit_ior (unordered @0 @1) (eq @0 @1))? The :c is needed for bit_and for sure. BUT should not needed for ordered/ne though because the canonicalization of the operations should have the operands in the same order as `a ordered b` is the same as `b ordered a`. Thanks, Andrew Pinski > > And

Re: [PATCH v1 7/9] aarch64: Disable the anchors

2024-09-02 Thread Andrew Pinski
On Mon, Sep 2, 2024 at 6:12 AM Evgeny Karpov wrote: > > The anchors have been disabled as they use symbol + offset, which is > not applicable for COFF AArch64. This does not make sense to me at all. Anchors are a small optimization to group together some static decls so that you could reuse an an

Re: [PATCH 1/3] SVE intrinsics: Fold constant operands.

2024-09-03 Thread Andrew Pinski
int_binop. The obvious patch would move the assert below the check for INTEGER_CSTs. I can't test it right now though. Thanks, Andrew Pinski > > Signed-off-by: Jennifer Schmitz > > gcc/ > * config/aarch64/aarch64-sve-builtins.cc (aarch64_const_binop): >

[PATCH] split-path: Improve ifcvt heurstic for split path [PR112402]

2024-09-03 Thread Andrew Pinski
gcc.dg/tree-ssa/split-path-5.c: Update scan. * gcc.dg/tree-ssa/split-path-6.c: Update scan. * g++.dg/tree-ssa/pr88797.C: Update scan. * gcc.dg/tree-ssa/split-path-13.c: New test. Signed-off-by: Andrew Pinski --- gcc/gimple-ssa-split-paths.cc | 172 ++-

[PATCH 1/2] split-paths: Move check for # of statements in join earlier

2024-09-03 Thread Andrew Pinski
for # of statments in join earlier and add a debug print. Signed-off-by: Andrew Pinski --- gcc/gimple-ssa-split-paths.cc | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/gcc/gimple-ssa-split-paths.cc b/gcc/gimple-ssa-split-paths.cc index 8b4304fe59e

[PATCH 2/2] split-path: Improve ifcvt heurstic for split path [PR112402]

2024-09-03 Thread Andrew Pinski
gcc.dg/tree-ssa/split-path-5.c: Update scan. * gcc.dg/tree-ssa/split-path-6.c: Update scan. * g++.dg/tree-ssa/pr88797.C: Update scan. * gcc.dg/tree-ssa/split-path-13.c: New test. Signed-off-by: Andrew Pinski --- gcc/gimple-ssa-split-paths.cc | 172 ++-

Re: [pushed] c++: support C++11 attributes in C++98

2024-09-03 Thread Andrew Pinski
"C++11 attributes " > -"only available with %<-std=c++11%> or %<-std=gnu++11%>"); > + if (pedantic) > + pedwarn (loc, OPT_Wc__11_extensions, > + "C++11 attributes " > + "only available

[PATCH] object-size: Use simple_dce_from_worklist in object-size pass

2024-09-03 Thread Andrew Pinski
x86_64-linux-gnu. gcc/ChangeLog: * tree-object-size.cc (object_sizes_execute): Mark lhs for maybe dceing if doing a propagate. Call simple_dce_from_worklist. Signed-off-by: Andrew Pinski --- gcc/tree-object-size.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion

[PUSHED] aarch64: Fix testcase vec-init-22-speed.c [PR116589]

2024-09-03 Thread Andrew Pinski
4/vec-init-22-speed.c: Update scan for better code gen. Signed-off-by: Andrew Pinski --- gcc/testsuite/gcc.target/aarch64/vec-init-22-speed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.target/aarch64/vec-init-22-speed.c b/gcc/testsuite/gcc.target/aarch6

[PATCH] expand: Add dump for costing of positive divides

2024-09-03 Thread Andrew Pinski
dump of the two costs for positive division. Signed-off-by: Andrew Pinski --- gcc/expr.cc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/gcc/expr.cc b/gcc/expr.cc index 320be8b17a1..7a471f20e79 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -9648,6 +9648,7 @@ expand_expr_divmod

[PATCH] aarch64: Handle attributes in the global namespace for aarch64_lookup_shared_state_flags [PR116598]

2024-09-04 Thread Andrew Pinski
ones in the `arm` namespace instead. Built and tested for aarch64-linux-gnu. gcc/ChangeLog: * config/aarch64/aarch64.cc (aarch64_lookup_shared_state_flags): Ignore attributes in the global namespace. Signed-off-by: Andrew Pinski --- gcc/config/aarch64/aarch64.cc | 4 1

Re: [PATCH] aarch64: Handle attributes in the global namespace for aarch64_lookup_shared_state_flags [PR116598]

2024-09-04 Thread Andrew Pinski
On Wed, Sep 4, 2024 at 2:36 PM Marek Polacek wrote: > > On Wed, Sep 04, 2024 at 02:05:21PM -0700, Andrew Pinski wrote: > > The code in aarch64_lookup_shared_state_flags all C++11 attributes on the > > function type > > had a namespace associated with them.

[PATCH] aarch64: Use is_attribute_namespace_p and get_attribute_name inside aarch64_lookup_shared_state_flags [PR116598]

2024-09-04 Thread Andrew Pinski
pace_p and get_attribute_name instead of manually grabbing the namespace and name of the attribute. Signed-off-by: Andrew Pinski --- gcc/config/aarch64/aarch64.cc | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch6

Re: [PATCH] aarch64: Handle attributes in the global namespace for aarch64_lookup_shared_state_flags [PR116598]

2024-09-04 Thread Andrew Pinski
On Wed, Sep 4, 2024 at 2:44 PM Andrew Pinski wrote: > > On Wed, Sep 4, 2024 at 2:36 PM Marek Polacek wrote: > > > > On Wed, Sep 04, 2024 at 02:05:21PM -0700, Andrew Pinski wrote: > > > The code in aarch64_lookup_shared_state_flags all C++11 attributes on the >

[PATCH] fab: Cleanup eh after optimize_memcpy [PR116601]

2024-09-04 Thread Andrew Pinski
++.dg/torture/except-2.C: New test. Signed-off-by: Andrew Pinski --- gcc/testsuite/g++.dg/torture/except-2.C | 18 ++ gcc/tree-ssa-ccp.cc | 11 +-- 2 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/torture/except

Re: [PATCH] RISC-V: Define LOGICAL_OP_NON_SHORT_CIRCUIT to 1 [PR116615]

2024-09-05 Thread Andrew Pinski
h it could implement ccmp optab now but nobody has that implemented yet). Note RISCV's cset is cheap (both size and speed) due to being close to MIPS and just having instructions which set the GPRs and then comparing against 0. I don't have time until next year to start looking at improv

Re: [PATCH] fab: Cleanup eh after optimize_memcpy [PR116601]

2024-09-05 Thread Andrew Pinski
On Thu, Sep 5, 2024 at 12:26 AM Richard Biener wrote: > > On Thu, Sep 5, 2024 at 8:25 AM Andrew Pinski wrote: > > > > When optimize_memcpy was added in r7-5443-g7b45d0dfeb5f85, > > a path was added such that a statement was turned into a non-th

Re: [PATCH 1/2] split-paths: Move check for # of statements in join earlier

2024-09-05 Thread Andrew Pinski
On Tue, Sep 3, 2024 at 11:30 PM Kyrylo Tkachov wrote: > > Hi Andrew, > > > On 3 Sep 2024, at 20:11, Andrew Pinski wrote: > > > > External email: Use caution opening links or attachments > > > > > > This moves the check for # of statements to copy in

Re: [PATCH] gimple ssa: Don't use __builtin_popcount in switch exp transform [PR116616]

2024-09-06 Thread Andrew Pinski
> -} > + tree type = TREE_TYPE (op); > + > + /* Build (op ^ (op - 1)) > (op - 1). */ > + tree tmp1 = gimple_build (&gsi, false, GSI_NEW_STMT, loc, MINUS_EXPR, type, > + op, build_one_cst (type)); > + tree tmp2 = gimple_build (&g

[PATCH] fab: Factor out the main folding part of pass_fold_builtins::execute [PR116601]

2024-09-06 Thread Andrew Pinski
as updated. (pass_fold_builtins::execute): Factor out folding code into ... (fold_all_builtin_stmt): This. gcc/testsuite/ChangeLog: * g++.dg/torture/except-2.C: New test. Signed-off-by: Andrew Pinski --- gcc/testsuite/g++.dg/torture/except-2.C | 18 + gcc/tree-

Re: [PATCH v2] GCC Driver : Enable very long gcc command-line option

2024-09-06 Thread Andrew Pinski
Following your suggestion, I have updated the logic to avoid hardcoding > /tmp. > Please find the revised version of patch at the following link: > > https://gcc.gnu.org/pipermail/gcc-patches/2024-September/662519.html > > Thanks, > Sunil Dora >

[PATCH] gimple-fold: Move optimizing memcpy to memset to fold_stmt from fab

2024-09-06 Thread Andrew Pinski
ltins::execute): Remove code that calls optimize_memcpy. gcc/testsuite/ChangeLog: * gcc.dg/pr78408-1.c: Adjust dump scan to match where the optimization now happens. * g++.dg/torture/except-2.C: New test. Signed-off-by: Andrew Pinski --- gcc/gimple-fo

Re: [PATCH] Add new warning Wmissing-designated-initializers [PR39589]

2024-09-07 Thread Andrew Pinski
what files and what functions were changed but not how. Other than that the patch looks good to me but I can't approve it. Thanks, Andrew Pinski > > > --- > gcc/c-family/c.opt| 4 +++ > gcc/c/c-typeck.cc |

[PUSHED] split-path: Fix dump wording about duplicating too many statements

2024-09-07 Thread Andrew Pinski
): Fix wording on the print. Signed-off-by: Andrew Pinski --- gcc/gimple-ssa-split-paths.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gimple-ssa-split-paths.cc b/gcc/gimple-ssa-split-paths.cc index 32b5c445760..886d85a94e4 100644 --- a/gcc/gimple-ssa-split

[PUSHED] Fix pr116588.c for -m32

2024-09-07 Thread Andrew Pinski
. Signed-off-by: Andrew Pinski --- gcc/testsuite/gcc.dg/pr116588.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/gcc.dg/pr116588.c b/gcc/testsuite/gcc.dg/pr116588.c index 677964dd1d6..6b0678d465e 100644 --- a/gcc/testsuite/gcc.dg/pr116588.c +++ b/gcc/testsuite/gcc.dg/pr116588.c

Re: [r15-3529 Regression] FAIL: gcc.dg/pr116588.c (test for excess errors) on Linux/x86_64

2024-09-07 Thread Andrew Pinski
fore running fast VRP, make sure all edges have EXECUTABLE set. > > caused > > FAIL: gcc.dg/pr116588.c (test for excess errors) Fixed with r15-3533-g35c2bcb2389d34 . Thanks, Andrew Pinski > > with GCC configured with > > ../../gcc/configure > --prefix=/export/us

[PATCH] phiopt: Small refactoring/cleanup of non-ssa name case of factor_out_conditional_operation

2024-09-08 Thread Andrew Pinski
consts fits into the new type. Signed-off-by: Andrew Pinski --- gcc/tree-ssa-phiopt.cc | 122 - 1 file changed, 60 insertions(+), 62 deletions(-) diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc index 271a5d51f09..06ec5875722 100644 --- a/gcc

Re: [PATCH 00/10] __builtin_dynamic_object_size

2024-09-08 Thread Andrew Pinski
ptr + tmp where before the pointer plus was inside each branch instead. So my question is there any progress on implementing objsz with ranger or has that work been put off? I filed https://gcc.gnu.org/PR116556 for this. Do you have any start of patches for this so it maybe it could be taken to

[PATCH 2/2] phiopt: Move the common code between pass_phiopt and pass_cselim into a seperate function

2024-09-09 Thread Andrew Pinski
(execute_over_cond_phis): New template function, moved the common parts from pass_phiopt::execute/pass_cselim::execute. (pass_phiopt::execute): Move the functon specific parts of the loop into an lamdba. (pass_cselim::execute): Likewise. Signed-off-by: Andrew Pinski --- gcc

[PATCH 1/2] phiopt: Use gimple_phi_result rather than PHI_RESULT [PR116643]

2024-09-09 Thread Andrew Pinski
. (cond_if_else_store_replacement_1): Likewise. Signed-off-by: Andrew Pinski --- gcc/tree-ssa-phiopt.cc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc index 06ec5875722..bd8ede06a98 100644 --- a/gcc/tree-ssa-phiopt.cc +++ b/gcc

Re: [PATCH] JSON dumping for GENERIC trees

2024-09-11 Thread Andrew Pinski
On Wed, Sep 11, 2024 at 6:51 PM wrote: > > From: Thor C Preimesberger > > This patch allows the compiler to dump GENERIC trees as JSON objects. > > The dump flag -fdump-tree-original-json dumps each fndecl node in the > C frontend's gimplifier as a JSON object and traverses related nodes > in an

[PATCH] Fix factor_out_conditional_operation heuristics for constants

2024-09-12 Thread Andrew Pinski
86_64-linux-gnu. gcc/ChangeLog: * tree-ssa-phiopt.cc (factor_out_conditional_operation): Instead of just ignorning a NOP/PREDICT, skip over them before checking the heuristics. Signed-off-by: Andrew Pinski --- gcc/tree-ssa-phiopt.cc | 14 -- 1 file chang

[PATCH] phi-opt: Improve heuristics for factoring out with constant (again) [PR116699]

2024-09-13 Thread Andrew Pinski
s the last statement. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/phi-opt-factor-1.c: New test. Signed-off-by: Andrew Pinski --- .../gcc.dg/tree-ssa/phi-opt-factor-1.c| 26 +++ gcc/tree-ssa-phiopt.cc| 6 + 2 files changed, 32

[PATCH] Mark the copy/move constructor/operator= of auto_bitmap as delete

2024-09-14 Thread Andrew Pinski
Since we are written in C++11, these should be marked as delete rather than just private. Bootstrapped and tested on x86_64-linux-gnu. gcc/ChangeLog: * bitmap.h (class auto_bitmap): Mark copy/move constructor/operator= as deleted. Signed-off-by: Andrew Pinski --- gcc/bitmap.h

[PATCH] vect: release defs of removed statement

2024-09-14 Thread Andrew Pinski
op.cc (optimize_mask_stores): Call release_defs after the call to gsi_remove with last argument of true. Signed-off-by: Andrew Pinski --- gcc/tree-vect-loop.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index cc15492f6a0..62c7f90779f 100644 --- a/gcc

Re: [PATCH] tree-object-size: Fold PHI node offsets with constants [PR116556]

2024-09-14 Thread Andrew Pinski
won't work for integer constants which have the what would be the sign bit set. That is: ``` void __attribute__ ((noinline)) test9 (unsigned cond) { char *buf2 = __builtin_malloc (10); char *p; __SIZE_TYPE__ t; if (cond) t = -4; else t = 4; p = &buf2[4] + t;

[PUSHED] testsuite; Fix execute/pr52286.c for 16bit

2024-09-14 Thread Andrew Pinski
The code path which was added for 16bit had a broken inline-asm which would only assign maybe half of the registers for the `long` type to 0. Adding L to the input operand of the inline-asm fixes the issue by now assigning the full 32bit value of the input register that would match up with the out

[PATCH] vect: Set pattern_stmt_p on the newly created stmt_vec_info

2024-09-15 Thread Andrew Pinski
pattern_stmt_p. Signed-off-by: Andrew Pinski --- gcc/tree-vectorizer.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/tree-vectorizer.cc b/gcc/tree-vectorizer.cc index 0efabcbb258..4279b6db4cf 100644 --- a/gcc/tree-vectorizer.cc +++ b/gcc/tree-vectorizer.cc @@ -535,6 +535,7 @@ stmt_vec_info

Re: [PATCH] c++: alias of decltype(lambda) is opaque [PR116714]

2024-09-16 Thread Andrew Pinski
On Mon, Sep 16, 2024 at 8:12 AM Patrick Palka wrote: > > Bootstrapped and regtested on x86_64-pc-linuxgnu, does this look > OK for trunk? Sadly the prerequisity patch r15-2331-g523836716137d0 > probably isn't suitable for backporting, so I reckon this should be > trunk-only. > > -- >8 -- > > Here

[PATCH] vect: Use simple_dce_worklist in the vectorizer [PR116711]

2024-09-16 Thread Andrew Pinski
(vec_info): Add dce_worklist field. (vect_slp_if_converted_bb): Add bitmap argument. * tree-vectorizer.h (vect_slp_if_converted_bb): Add bitmap argument. gcc/testsuite/ChangeLog: * gcc.dg/vect/bb-slp-77.c: New test. Signed-off-by: Andrew Pinski --- gcc/testsuite/gcc.dg/v

Re: [Ping^4] [Patch, AArch64, ILP32] 3/5 Minor change in function.c:assign_parm_find_data_types()

2013-08-24 Thread Andrew Pinski
ttp://gcc.gnu.org/ml/gcc-patches/2013-06/msg01485.html >From my point of view it is correct after understanding the ABI better though I cannot approve it. Thanks, Andrew Pinski > > Regards, > Yufeng > > > On 07/18/13 11:28, Yufeng Zhang wrote: >> >> Ping^3~ >> &

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-11 Thread Andrew Pinski
ack could do due to the instructions still take a issue slot. Is it true that for these two processors it takes an issue slot or is it being done before issue? Thanks, Andrew Pinski > > IMO adjust_priority would be preferable if it allows to achieve the goal. > > Alexander

Re: [AArch64] Implement vset_lane intrinsics in C

2013-09-13 Thread Andrew Pinski
way ARM decided the lanes don't match up with array entry there. Thanks, Andrew Pinski > > Thanks, > James > > --- > gcc/ > > 2013-09-13 James Greenhalgh > > * config/aarch64/arm_neon.h > (__aarch64_vset_lane_any): New. > (__aarch64

Re: [AArch64] Implement vset_lane intrinsics in C

2013-09-13 Thread Andrew Pinski
On Fri, Sep 13, 2013 at 11:57 AM, James Greenhalgh wrote: > On Fri, Sep 13, 2013 at 07:39:08PM +0100, Andrew Pinski wrote: >> I don't think this works for big-endian due to the way ARM decided the >> lanes don't match up with array entry there. > > Hi Andrew, >

Re: [PATCH] Enhance phiopt to handle BIT_AND_EXPR

2013-09-30 Thread Andrew Pinski
;& operand_equal_for_phi_arg_p (arg1, op0))) +{ + *code = gimple_assign_rhs_code (def1); + return 1; +} + } +} Out into its own function since it is repeated again for gimple_assign_rhs2 (def). Also what about cascading BIT_AND_EXPR like: if((a == 0) & (...) & (...)

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-10-01 Thread Andrew Pinski
nsn 23 17 26 2 (set (reg/i:SI 2 $2) (and:SI (reg:SI 2 $2 [+4 ]) (const_int 536870911 [0x1fff]))) t.c:18 156 {*andsi3} (nil)) Which is considered an ext instruction And with the Octeon simulator which causes undefined arguments to 32bit word operations to come ou

[Committed] Fix truncate of a memory for vector mode

2012-10-02 Thread Andrew Pinski
, Andrew Pinski 2012-10-02 Andrew Pinski * simplify-rtx.c (simplify_unary_operation_1 ): Don't optimize a truncate of a mem if it is a vector mode. Index: simplify-rtx.c === --- simplify-rtx.c (revision 1

Re: [PATCH] PowerPC VLE port

2012-10-03 Thread Andrew Pinski
(simple_return "1")]) Submitted separately it looks. > libgcc/longlong.h Gets sync'd with glibc's version sometimes. Also have you thought have just adding a vle.md for all the needed patterns and disabling the patterns in rs6000.md for VLE and not us

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-05 Thread Andrew Pinski
8/BUILD/../libgcc/gthr-default.h', > needed by `bits/gthr-default.h'. Stop. > > See fix attached. > > Ok for trunk and 4.7? Why do you want to compile libstdc++ separately from GCC? I think you need to explain why you want to do that. In fact libstdc++ depends on libgcc int

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-05 Thread Andrew Pinski
On Fri, Oct 5, 2012 at 12:13 PM, Andrew Pinski wrote: > On Fri, Oct 5, 2012 at 7:32 AM, Pavel Chupin wrote: >> I can't configure libstdc++ separately. To reproduce: >> >> mkdir BUILD >> cd BUILD >> ../libstdc++-v3/configure >> >> Error: >&

Re: [PATCH/MIPS] Use ins/dins instruction when written manually

2012-10-05 Thread Andrew Pinski
On Sun, Aug 19, 2012 at 10:13 AM, Richard Sandiford wrote: > Andrew Pinski writes: >> Right now we only produce ins when a zero_extract is used on the >> right hand side. We can do better by adding some patterns which >> combine for the ins instruction. This patch adds

Re: [PATCH/MIPS] Use ins/dins instruction when written manually

2012-10-05 Thread Andrew Pinski
On Fri, Oct 5, 2012 at 8:43 PM, Andrew Pinski wrote: > On Sun, Aug 19, 2012 at 10:13 AM, Richard Sandiford > wrote: >> Andrew Pinski writes: >>> Right now we only produce ins when a zero_extract is used on the >>> right hand side. We can do better by adding s

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-10 Thread Andrew Pinski
ed we use gimple- as the prefix for new files. I had did this on my simplifier branch (that branch is not fully dead, I hope to work on it soonish). Thanks, Andrew Pinski > > Ciao! > Steven

Re: [ARM] fix for PR49423

2012-10-13 Thread Andrew Pinski
2]) [0 S2 A16]))) src/gcc/testsuite/gcc.c-torture/execute/scal-to-vec2.c:49 161 {*arm_zero_extendhisi2_v6} (nil)) (insn 1075 357 1077 7 (set (mem/c:SI (plus:SI (reg/f:SI 11 fp) (const_int -60 [0xffc4])) [0 %sfp+-24 S4 A32]) (reg:SI 8 r8)) src/gcc/testsuite/gcc.c-tort

Re: [asan] migrate runtime from llvm

2012-10-15 Thread Andrew Pinski
libasan so at least the toplevel parts can be reviewed easier? Also the changelog entry for gcc.c go under the gcc/ChangeLog rather than the toplevel one. Thanks, Andrew Pinski > > Thanks, > Wei. > > gcc/ChangeLog: > 2012-10-15 Wei Mi > > migrate llvm runtime to asan

Re: [asan] migrate runtime from llvm

2012-10-15 Thread Andrew Pinski
the toplevel one. >> >> Thanks, >> Andrew Pinski > > Sure, I attach it. Thanks for pointing out the changelog error. +%{fasan|coverage:-lasan -lpthread -ldl -lstdc++}\ Just curious, does asan runtime really require linking against pthread and the standard C++ library? Al

Re: [PATCH, ARM] Subregs of VFP registers in big-endian mode

2012-10-20 Thread Andrew Pinski
gt; -fomit-frame-pointer execution test > FAIL -> PASS: be-code-on-qemu/gcc.sum:gcc.dg/torture/type-generic-1.c -O3 -g > execution test > FAIL -> PASS: be-code-on-qemu/gcc.sum:gcc.dg/torture/type-generic-1.c -Os > execution test > > OK for mainline, or any comments?

[PATCH/AARCH64] Fix build after __builtin_thread_pointer changes

2012-10-29 Thread Andrew Pinski
rch64-thunder-elf. Thanks, Andrew Pinski ChangeLog: * config/aarch64/aarch64-protos.h (aarch64_load_tp): New proto. * config/aarch64/aarch64.c (aarch64_load_tp): Export. (aarch64_init_builtins): Don't add __builtin_thread_pointer builtin. * config/aarch64

Re: Enable building of libatomic on AArch64

2013-10-04 Thread Andrew Pinski
ing here also, This is the same patch which we have been using internally and I would like to see this approved. Thanks, Andrew Pinski >

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-16 Thread Andrew Pinski
ests: > gcc.dg/uninit-pred-8_b.c > gcc.dg/uninit-pred-9_b.c > uninit pass should be enhanced to handle more complex conditions. Will > submit a bug to track it and fix it later. > > Is it OK for trunk? I had a much simpler change which did basically the same fro

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-17 Thread Andrew Pinski
On Thu, Oct 17, 2013 at 4:03 AM, Richard Biener wrote: > On Thu, Oct 17, 2013 at 4:14 AM, Andrew Pinski wrote: >> On Wed, Oct 16, 2013 at 2:12 AM, Zhenqiang Chen >> wrote: >>> Hi, >>> >>> The patch enhances ifcombine pass to recover some non short circu

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-17 Thread Andrew Pinski
On Thu, Oct 17, 2013 at 6:39 PM, Andrew Pinski wrote: > On Thu, Oct 17, 2013 at 4:03 AM, Richard Biener > wrote: >> On Thu, Oct 17, 2013 at 4:14 AM, Andrew Pinski wrote: >>> On Wed, Oct 16, 2013 at 2:12 AM, Zhenqiang Chen >>> wrote: >>>> Hi, >

Re: [PATCH][buildrobot] libcpp/lex.c: Use enum properly

2013-10-24 Thread Andrew Pinski
On Thu, Oct 24, 2013 at 6:22 PM, Mike Stump wrote: > On Oct 24, 2013, at 2:05 AM, Jan-Benedict Glaw wrote: >> - enum raw_str_phase { RAW_STR_PREFIX, RAW_STR, RAW_STR_SUFFIX }; >> - raw_str_phase phase = RAW_STR_PREFIX; >> + enum raw_str_phase { RAW_STR_PREFIX, RAW_STR, RAW_STR_SUFFIX } phase =

Re: Minor mudflap fallout

2013-10-26 Thread Andrew Pinski
e PRED_MUDFLAP in > cris_emit_trap_for_misalignment, which should explain its use. > Is there a replacement? I think you could use PRED_NORETURN which should be a reasonable replacement. Thanks, Andrew Pinski > > PRED_MUDFLAP: > -/* Branches to a mudflap bounds check are extremely unlikely. > > brgds, H-P

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-26 Thread Andrew Pinski
lk" so it can do combine recursively. > > But I think we need some heuristic to control the number of ifs. Move > too much compares from > the inner_bb to outer_bb is not good. I think this depends on the target. For MIPS we don't want an upper bound as integer comparison

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-26 Thread Andrew Pinski
So it at least reduces this patch. Also your bb_has_overhead_p can be simply: !gsi_one_before_end_p (gsi_start_nondebug_after_labels_bb (inner_cond_bb)) Where gsi_start_nondebug_after_labels_bb is defined as: /* Return a new iterator pointing to the first non-debug non-label statement in basic block BB. */ static inline gimple_stmt_iterator gsi_start_nondebug_after_labels_bb (basic_block bb) { gimple_stmt_iterator i = gsi_after_labels (bb); if (!gsi_end_p (i) && is_gimple_debug (gsi_stmt (i))) gsi_next_nondebug (&i); return i; } Thanks, Andrew Pinski

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-26 Thread Andrew Pinski
On Sat, Oct 26, 2013 at 2:30 PM, Andrew Pinski wrote: > On Fri, Oct 18, 2013 at 2:21 AM, Zhenqiang Chen > wrote: >> On 18 October 2013 00:58, Jeff Law wrote: >>> On 10/17/13 05:03, Richard Biener wrote: >>>>>> >>>>>> Is it OK for trunk

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-27 Thread Andrew Pinski
On Sat, Oct 26, 2013 at 4:49 PM, Andrew Pinski wrote: > On Sat, Oct 26, 2013 at 2:30 PM, Andrew Pinski wrote: >> On Fri, Oct 18, 2013 at 2:21 AM, Zhenqiang Chen >> wrote: >>> On 18 October 2013 00:58, Jeff Law wrote: >>>> On 10/17/13 05:03, Richard Biener

[PATCH] Fix PR 58867: asan and ubsan tests not run for installed testing

2013-10-29 Thread Andrew Pinski
, Andrew Pinski ChangeLog: * lib/ubsan-dg.exp (check_effective_target_fundefined_sanitizer): New function. (ubsan_init): Save off ALWAYS_CXXFLAGS. (ubsan_finish): Restore ALWAYS_CXXFLAGS correctly. * lib/asan-dg.exp (check_effective_target_faddress_sanitizer): Change to creating an executable. (asan_init

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-29 Thread Andrew Pinski
On Mon, Oct 28, 2013 at 10:51 PM, Jeff Law wrote: > On 10/27/13 12:55, Andrew Pinski wrote: >> >> Here is my latest patch which adds the testcases from Zhenqiang's >> patch and fixes item 1 and 2. >> >> OK? Bootstrapped and tested on x86_64-linux-gnu with n

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-29 Thread Andrew Pinski
On Tue, Oct 29, 2013 at 3:28 AM, Richard Biener wrote: > On Sun, Oct 27, 2013 at 7:55 PM, Andrew Pinski wrote: >> On Sat, Oct 26, 2013 at 4:49 PM, Andrew Pinski wrote: >>> On Sat, Oct 26, 2013 at 2:30 PM, Andrew Pinski wrote: >>>> On Fri, Oct 18, 2013 at 2:21

Re: Fix PR 67665: ICE when passing two empty files directly to cc1 with -g

2016-01-21 Thread Andrew Pinski
On Wed, Jan 13, 2016 at 4:36 AM, Richard Biener wrote: > On Wed, Jan 13, 2016 at 9:27 AM, Andrew Pinski wrote: >> Hi, >> The support -combine was removed a while back but cc1 still accepts >> more than one file if directly invoked. The support for multiple >> files

Re: [PATCH][AArch64] Only update assembler .arch directive when necessary

2016-02-04 Thread Andrew Pinski
to make life easier > for the kernel folk so this patch helps with that. I had suggested a change to the Linux kernel already to fix this issue: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/395191.html Thanks, Andrew Pinski > > With this patch we go back to emitt

[PATCH] Fix PR 69282: ICE on 464.h264ref at -O3

2016-02-07 Thread Andrew Pinski
aarch64-linux-gnu with no regressions. Thanks, Andrew Pinski ChangeLog: * optabs-tree.c (expand_vec_cond_expr_p): Don't early return if get_vcond_mask_icode returns false. Testsuite/ChangeLog: * gcc.c-torture/compile/20160205-1.c: New testcase. Index: optabs-t

Re: [patch] introduce aarch64 as a Go architecture

2013-11-29 Thread Andrew Pinski
On Fri, Nov 29, 2013 at 11:34 AM, Matthias Klose wrote: > Please let's pick aarch64. Everybody names it this way, except of course > Debian And the linux kernel. > :-/ If I understand ARM developers correctly, there will be something like > aarch32 in the future (x32 for ARM), and I think you

Re: [patch] introduce aarch64 as a Go architecture

2013-12-02 Thread Andrew Pinski
e one way or another myself, but we need to pick one. >> >> I don't care too much myself. AArch64 is more correct but arm64 is more >> obvious. Also plan9/inferno will use arm64 IIUC. > > All the documentation relevant to this architecture uses the term > "aarch64". How is arm64 obvious? The same reason Linus used arm64: https://lkml.org/lkml/2012/7/15/133 Thanks, Andrew Pinski > > /Marcus

[PATCH/AARCH64 3/6] Fix up multi-lib options

2013-12-03 Thread Andrew Pinski
and should not be there. This patch changes the definition of MULTILIB_OPTIONS so we have a / inbetween the options rather than a space. OK? Build and tested on aarch64-elf with both --with-multilib-list=lp64,ilp32 and without it. Thanks, Andrew Pinski * config/aarch64/t-aarch64

[PATCH/middle-end 2/6] __builtin_thread_pointer and AARCH64 ILP32

2013-12-03 Thread Andrew Pinski
by handling a NULL target like we are able to handle for a non register/correct mode target inside expand_builtin_thread_pointer. OK? Build and tested for aarch64-elf with no regressions. Thanks, Andrew Pinski * builtins.c (expand_builtin_thread_pointer): Create a new target

[PATCH/AARCH64 0/6] Add ILP32 GNU/Linux support

2013-12-03 Thread Andrew Pinski
incrementally. Only the last patch depends on the rest of the patches. The rest can be applied independently. Thanks, Andrew Pinski Andrew Pinski (6): 2013-12-02 Andrew Pinski 2013-11-25 Andrew Pinski 2013-12-02 Andrew Pinski 2013-12-02 Andrew Pinski 2013-12-02 Andrew Pinski

[PATCH/AARCH64 4/6] Implement the trap pattern

2013-12-03 Thread Andrew Pinski
). Thanks, Andrew Pinski * config/aarch64/aarch64.md (trap): New pattern. --- gcc/ChangeLog |9 + gcc/config/aarch64/aarch64.md |5 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64

[PATCH/AARCH64 1/6] Fix size and pointer different types for ILP32.

2013-12-03 Thread Andrew Pinski
--- OK? Built and tested for aarch64-elf without any regressions. Thanks, Andrew Pinski * config/aarch64/aarch64.h (SIZE_TYPE): Set to unsigned int for ILP32. (PTRDIFF_TYPE): Set to int for ILP32. --- gcc/ChangeLog|5 + gcc/config/aarch64/aarch64.h |

[PATCH/AARCH64 5/6] Fix TLS for ILP32.

2013-12-03 Thread Andrew Pinski
with no regressions. Thanks, Andrew Pinski * config/aarch64/aarch64.c (aarch64_load_symref_appropriately): Handle TLS for ILP32. * config/aarch64/aarch64.md (tlsie_small): Change to an expand to handle ILP32. (tlsie_small_): New pattern. (tlsle_small

[PATCH/AARCH64 6/6] Support ILP32 multi-lib

2013-12-03 Thread Andrew Pinski
x-gnu with and without --with-multilib-list=lp64,ilp32. Thanks, Andrew Pinski * config/aarch64/aarch64-linux.h (GLIBC_DYNAMIC_LINKER): /lib/ld-linux32-aarch64.so.1 is used for ILP32. (LINUX_TARGET_LINK_SPEC): Add linker script file whose name depends on -mabi= and

Re: [PATCH/AARCH64 6/6] Support ILP32 multi-lib

2013-12-09 Thread Andrew Pinski
On Mon, Dec 9, 2013 at 2:57 PM, Joseph S. Myers wrote: > On Mon, 9 Dec 2013, Yufeng Zhang wrote: > >> > -#define GLIBC_DYNAMIC_LINKER "/lib/ld-linux-aarch64.so.1" >> > +#define GLIBC_DYNAMIC_LINKER "/lib/ld-linux%{mabi=ilp32:32}-aarch64.so.1" >> >> To be more explicit and consistent, the name of t

Re: [PATCH/AARCH64 6/6] Support ILP32 multi-lib

2013-12-09 Thread Andrew Pinski
On Mon, Dec 9, 2013 at 12:12 PM, Yufeng Zhang wrote: > On 12/03/13 21:24, Andrew Pinski wrote: >> >> Hi, >>This is the final patch which adds support for the dynamic linker and >> multi-lib directories for ILP32. I did not change multi-arch support as >>

Re: [PATCH] Fix PR 58867: asan and ubsan tests not run for installed testing

2013-12-14 Thread Andrew Pinski
On Tue, Oct 29, 2013 at 7:56 AM, Andrew Pinski wrote: > Hi, > The problem here is that both asan and ubsan testsuite test if we > have set a library path before running the testsuite. This is > incorrect when running the already installed testing as there is no > path to set.

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-03 Thread Andrew Pinski
#endif. > * machmode.h (GET_MODE_SIZE, GET_MODE_NUNITS, GET_MODE_INNER): > For GCC_VERSION >= 4001 use mode_*_inline routines instead of > mode_* arrays if the argument is __builtin_constant_p. > * lower-subreg.c (dump_choices): Make sure GET_MODE_SIZE

Re: [PATCH] Introduce MODE_SIZE mode attribute

2014-01-03 Thread Andrew Pinski
On Fri, Jan 3, 2014 at 6:27 PM, Andrew Pinski wrote: > On Fri, Jan 3, 2014 at 3:37 PM, Jakub Jelinek wrote: >> On Fri, Jan 03, 2014 at 03:39:11PM +, Joseph S. Myers wrote: >>> On Fri, 3 Jan 2014, Jakub Jelinek wrote: >>> >>> > I've noticed that esp

<    1   2   3   4   5   6   7   8   9   10   >