[PATCH 0/2] strncmp builtin expansion improvement

n via cmpstrnsi in the case where c_strlen() return null for both strings. With these two patches bootstrap passes on x86_64 linux, currently checking regtest. If clean, ok for trunk? -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Techn

[PATCH 1/2, i386] cmpstrnsi needs string length

expansion of strncmp when neither string argument is constant. -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC ToolchainIndex: config/i386/i386.md

[PATCH 2/2, expand] make expand_builtin_strncmp more general

This patch adds code to expand_builtin_strncmp so it also attempts expansion via cmpstrnsi in the case where c_strlen() returns NULL for both string arguments, meaning that neither one is a constant. -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263

Re: [RFC PATCH] expand_strn_compare should attempt expansion even if neither string is constant

On Wed, 2016-11-02 at 13:41 +0100, Bernd Schmidt wrote: > On 10/27/2016 03:14 AM, Aaron Sawdey wrote: > > > > I'm currently working on a builtin expansion of strncmp for powerpc > > similar to the one for memcmp I checked recently. One thing I > >

[PATCH] builtin expansion of strncmp for rs6000

trunk if no new regressions? 2016-11-17 Aaron Sawdey * config/rs6000/rs6000-protos.h (expand_strn_compare): Declare. * config/rs6000/rs6000.md (UNSPEC_CMPB): New unspec. (cmpb3): pattern for generating cmpb. (cmpstrnsi): pattern to expand strncmp

Re: [PATCH] builtin expansion of strncmp for rs6000

nks, Aaron -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC ToolchainIndex: gcc/config/rs6000/rs6000-protos.h === --- gcc/config/rs6000/rs6000-proto

[PATCH] Add testcases to test builtin-expansion of memcmp and strncmp

ested parties from targets that have a strncmp builtin. The tests pass on ppc64le and x86_64. OK for trunk? -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC ToolchainIndex: gcc/testsuite/gcc.dg/memcm

[PATCH] add reassociation width target function for power8

Hi, This patch enables TARGET_SCHED_REASSOCIATION_WIDTH for power8 and up. The widths returned are derived from testing with SPEC 2006 and some simple tests on power8. Bootstrapped and regtested on powerpc64le-unknown-linux-gnu, ok for trunk? 2016-05-04 Aaron Sawdey * config/rs6000

[PATCH] add myself to MAINTAINERS

Sujoy Saraswati Trevor Saunders +Aaron Sawdey William Schmidt Tilo Schwarz Martin Sebor

Re: [PATCH 1/2, i386] cmpstrnsi needs string length

ChangeLog for this patch: 2016-11-03  Aaron Sawdey   * config/i386/i386.md (cmpstrnsi): New test to bail out if neither string input is a string constant. --  Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology

Re: [PATCH 2/2, expand] make expand_builtin_strncmp more general

ChangeLog for this patch: 2016-11-03  Aaron Sawdey   * builtins.c (expand_builtin_strncmp): Attempt expansion of strncmp via cmpstrnsi even if neither string is constant. -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux

Re: [PATCH 0/2] strncmp builtin expansion improvement

onstant but the length is. Thanks,    Aaron -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC Toolchain

Re: [PATCH 0/2] strncmp builtin expansion improvement

proc pushq   %rbx .cfi_def_cfa_offset 16 .cfi_offset 3, -16 movl%edx, %ebx movl$5, %edx callstrncmp movl%ebx, %edx I think it's pretty clear from the code in expand_builtin_strncmp that if len1 and len2 are both NULL, you end up

Re: [PATCH 2/2, expand] make expand_builtin_strncmp more general

Richard,   Thanks for the review ... comments below. On Tue, 2016-11-08 at 13:36 +0100, Richard Biener wrote: > On Tue, Nov 1, 2016 at 11:29 PM, Aaron Sawdey > wrote: > > > > This patch adds code to expand_builtin_strncmp so it also attempts > > expansion via cmp

[PATCH v2 0/2] strncmp builtin expansion improvement

d any more. Bootstrap & regtest passed on x86_64 with svn 242454, ok for trunk? -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC Toolchain

[PATCH v2 2/2, expand] make expand_builtin_strncmp more general

This patch makes expand_builtin_strncmp attempt to expand via cmpstrnsi even if neither of the string arguments are string constants. 2016-11-16  Aaron Sawdey   * builtins.c (expand_builtin_strncmp): Attempt expansion of strncmp via cmpstrnsi even if neither string is constant

[PATCH v2 1/2, i386] cmpstrnsi needs string length

expansion of strncmp when neither string argument is constant. I've also changed the pattern to indicate that operand 3 may be clobbered (if it happens to be in cx already). 2016-11-16  Aaron Sawdey   * config/i386/i386.md (cmpstrnsi): New test to bail out if neither string inp

[committed] strncmp builtin expansion improvement

Committed to trunk as 242556 after removing the use->clobber change from cmpstrnsi and bootstrap/regtest. gcc/ChangeLog 2016-11-17  Aaron Sawdey   * config/i386/i386.md (cmpstrnsi): New test to bail out if neither string input is a string constant. 2016-11-17  Aaron Saw

LTO inliner -- sensitivity to increasing register pressure

have any comments or feedback? Thanks, Aaron -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC Toolchain

Re: LTO inliner -- sensitivity to increasing register pressure

the case that's happening in bzip2. Aaron -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC Toolchain

Re: LTO inliner -- sensitivity to increasing register pressure

ight not be a good thing to do longer > term. > > David > > On Fri, Apr 18, 2014 at 9:43 AM, Aaron Sawdey > wrote: > > Honza, > > Seeing your recent patches relating to inliner heuristics for LTO, I > > thought I should mention some related work I'm doing. >

Ping: [PATCH] PR rtl-optimization/96791 Check precision of partial modes

Not exactly a patch ping, but I was hoping we could re-engage the discussion on this and figure out how we can make POImode work for powerpc. How does x86 solve this? There was some suggestion that it has some similar situations? Thanks, Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux

Re: [PATCH] [PATCH] PR rtl-optimization/96791 Check precision of partial modes

id it. There is no solution like that for the MMA builtins that use POImode and are (in theory) exposed to the same problem. So I ask again, how can we tell extract_low_bits() that POImode is off limits to its prying fingers? Thanks, Aaron Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Lin

Re: [PATCH,rs6000] Add patterns for combine to support p10 fusion

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Oct 26, 2020, at 4:44 PM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > > This patch adds the first couple patterns to support p10 fusion. These > will allow combine to create a sing

Re: [PATCH,rs6000 2/2] Fusion patterns for add-logical/logical-add

One last addendum to this. I discovered that that needs a "sort" in front of "keys %logicals_addsub" because otherwise you may get the operators in different orders sometimes which leads to fusion.md having the patterns in different orders which isn't helpful for sane debugging. Segher and I discu

[PATCH,rs6000] Fix p10 fusion test cases for -m32

For some reason this never showed up on gcc-patches, trying again. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > Begin forwarded message: > > From: Aaron Sawdey > Subject: [PATCH,rs6000] Fix p10 fusion test cases for -m32 > Date: May 25, 2021 at 1:45

[PATCH,rs6000] Fix operand order to subf for p10 fusion.

This certainly causes a bootstrap miscompare, and might also be responsible for PR/100820. The operands to subf were reversed in the logical-add/sub fusion patterns, and I screwed up my bootstrap test which is how it ended up getting committed. If bootstrap and regtest passes, ok for trunk (and ev

[PATCH,rs6000] Do not check if SMS succeeds on powerpc

These tests have become unstable and SMS either succeeds or doesn't depending on things like changes in instruction latency. Removing the scan-rtl-dump-times checks for powerpc*-*-*. If bootstrap/regtest is passes, ok for trunk and backport to 11? Thanks! Aaron gcc/testsuite * gcc.dg

Re: [PATCH,rs6000 0/2] p10 add-add and add-logical fusion series

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Apr 26, 2021, at 3:21 PM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > > Two more sets of combine patterns for p10 fusion. These require > the "Add insn types for fusion pairs&

Re: [PATCH,rs6000] Add insn types for fusion pairs

Ping. In answer to Will’s question — some of these are not immediately used but will be in other pending patches. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Apr 26, 2021, at 1:04 PM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > >

Re: [PATCH,rs6000] Test cases for p10 fusion patterns

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Apr 26, 2021, at 2:00 PM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > > This adds some test cases to make sure that the combine patterns for p10 > fusion are working. > >

[PATCH] rs6000: unaligned VSX in memcpy/memmove expansion

This patch adds a few new instructions to inline expansion of memcpy/memmove. Generation of all these is controlled by the option -mblock-ops-unaligned-vsx which is set on by default if the target has TARGET_EFFICIENT_UNALIGNED_VSX. * unaligned vsx load/store (V2DImode) * unaligned vsx pair load/

[committed] rs6000: unaligned VSX in memcpy/memmove expansion

I've modified slightly per Will & Segher's comments, re-regstrapped and posting what I've actually committed. Aaron This patch adds a few new instructions to inline expansion of memcpy/memmove. Generation of all these are controlled by the option -mblock-ops-unaligned-vsx which is set on by def

[PATCH] [PATCH] PR rtl-optimization/96791 Check precision of partial modes

Now that the documentation for partial modes says they have a known number of bits of precision, would it make sense for extract_low_bits to check this before attempting to extract the bits? This would solve the problem we have been having with POImode and extract_low_bits -- DSE tries to use it t

Re: [PATCH] [PATCH] PR rtl-optimization/96791 Check precision of partial modes

If it feels like a hack, that would because it is a hack. What I’d really like to discuss is how to accomplish the real goal: keep anything from trying to do other operations (zero/sign extend for one) to POImode. Is there an existing mechanism for this? Thanks, Aaron Aaron Sawdey, Ph.D

Re: [PATCH] [PATCH] PR rtl-optimization/96791 Check precision of partial modes

So, would it be legitimate for extract_low_bits to query if the truncate pattern it will likely use is actually available? Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Sep 10, 2020, at 10:10 AM, Segher Boessenkool > wrote: > > Hi! > > On Th

[PATCH][PR96791] disable POImode ld/st for memcpy [committed]

This is a (hopefully temporary) fix to PR96791. This will make the default be -mno-block-ops-vector-pair even on power10, so we will not hit the issue of DSE trying to truncate a POImode register. I am still concerned it will be possible to hit this because the MMA builtins will also generate POImo

[PATCH][rs6000][PR92379] fix UB shift of 64-bit type by 64 bits

This is a fix for PR92379. Passes regstrap on ppc64le. Pre-approved by Segher, committing after posting. 2020-03-13  Aaron Sawdey     PR target/92379     * config/rs6000/rs6000.c (num_insns_constant_multi) Don't shift a     64-bit value by 64 bits (UB). diff --git a/gcc/config/rs6000/r

[PATCH] rs6000: Add execution tests for mma builtins.

Updated slightly, removed -Wno-psabi as requested and also fixed the fact that it wasn't actually checking __builtin_cpu_is or __builtin_cpu_supports. OK for trunk and backport to 10? Thanks, Aaron 2020-06-30 Rajalakshmi Srinivasaraghavan Aaron Sawdey gcc/test

[PATCH] rs6000: fix power10_hw test

The code snippet for this test was returning 1 if power10 instructions executed correctly. It should return 0 if the test passes. OK for trunk and backport to 10? Thanks, Aaron * lib/target-supports.exp (check_power10_hw_available): Return 0 for passing test. --- gcc/testsuit

[PATCH] rs6000: fix power10_hw test [v2]

The code snippet for this test was returning 1 if power10 instructions executed correctly. It should return 0 if the test passes. Approved offline by Segher with slight change. Will push after posting. * lib/target-supports.exp (check_power10_hw_available): Return 0 for passing t

[PATCH] rs6000: Add execution tests for mma builtins. [v3]

Aaron 2020-06-30 Rajalakshmi Srinivasaraghavan Aaron Sawdey gcc/testsuite/ * gcc.target/powerpc/p10-identify.c: New file. * gcc.target/powerpc/mma-single-test.c: New file. * gcc.target/powerpc/mma-double-test.c: New file. --- .../gcc.target/powerp

Re: [PATCH] expr: Move reduce_bit_field target mode check [PR96151]

This fixed the ICE I was seeing, thanks. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Jul 10, 2020, at 10:40 AM, Richard Sandiford > wrote: > > In some cases, expand_expr_real_2 prefers to use the mode of the > caller-suggested target instead of

[PATCH] rs6000: Add execution tests for mma builtins [v4]

est environment correctly identifies itself, and that it can execute MMA code and get the right answer. A future patch will add an effective-target test for powerpc_mma_hw, which these mma tests will also need to check for. OK for trunk and backport to 10? 2020-06-30 Rajalakshmi Srinivasaraghavan

[PATCH] rs6000: add effective-target test ppc_mma_hw

Add a test for dejagnu to determine if execution of MMA instructions is supported in the test environment. Add an execution test to make sure that __builtin_cpu_supports("mma") is true if we can execute MMA instructions. OK for trunk and backport to 10? Thanks! Aaron gcc/testsuite/ *

[PATCH] rs6000: clean up testsuite power10_hw check

Because the check for power10_hw is not called check_effective_target_power10_hw, it needs to be looked for by is-effective-target-keyword. Also reorder things in is-effective-target to put power10_hw with the other ppc stuff. These little fixes for power10 dejagnu support were pre-approved for tr

[PATCH], rs6000, PR/target 94622, Be more careful with plq for atomic_load

the doubleword swap, which was wrong. OK for trunk if regstrap passes on ppc64le power9? Thanks, Aaron 2020-04-20 Aaron Sawdey PR target/94622 * config/rs6000/sync.md (load_quadpti): Make this have attr prefixed if TARGET_PREFIXED. (atomic_load): Do not

Re: [PATCH][v2], rs6000, PR/target 94622, Be more careful with plq for atomic_load

with the doubleword swap, which was wrong. So, of course you can't use set_attr with an if_then_else. The below code actually builds and passes regstrap on ppc64le power9. OK for trunk? Thanks, Aaron 2020-04-20 Aaron Sawdey PR target/94622 * config/rs6000/sy

[PATCH][v3], rs6000: Use plq/pstq for atomic_{load, store} (PR94622)

, also with the doubleword swap, which was wrong. While adding comments I realized we have exactly the same problem with pstq/stq so I have added fixes for that as well. Assuming that regstrap passes, OK for trunk? Thanks, Aaron 2020-04-20 Aaron Sawdey PR target/94622

[PATCH] rs6000: PR target/95347 Correctly identify stfs if prefixed

en if we use NON_PREFIXED_DEFAULT, address_to_insn_form() can see that it has the PCREL symbol ref. OK for trunk if regstrap on ppc64le passes? Thanks, Aaron 2020-05-29 Aaron Sawdey PR target/95347 * config/rs6000/rs6000.c (prefixed_store_p): Add special case for

[PATCH] rs6000: identify lfs prefixed case PR95347

The same problem also arises for plfs where prefixed_load_p() doesn't recognize it so we get just lfs in the asm output with a @pcrel address. OK for trunk if regstrap on ppc64le passes? Thanks, Aaron PR target/95347 * config/rs6000/rs6000.c (is_stfs_insn): Rename to

[pushed][PATCH] identify lfs prefixed case PR95347

This passed regstrap and was approved offline by Segher, posting the final form (minus my debug code, oops). The same problem also arises for plfs where prefixed_load_p() doesn't recognize it so we get just lfs in the asm output with an @pcrel address. PR target/95347 * config/rs6

Re: [PATCH,rs6000] Combine patterns for p10 load-cmpi fusion

Ping. I assume we’re going to want a separate patch for the new instruction type. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Dec 4, 2020, at 1:19 PM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > > This patch adds the first batch

Re: [PATCH,rs6000] Fusion patterns for logical-logical

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Dec 10, 2020, at 8:41 PM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > > This patch adds a new function to genfusion.pl to generate patterns for > logical-logical fusion. They are

Re: [PATCH,rs6000] Test cases for p10 fusion patterns

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Dec 11, 2020, at 1:53 PM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > > This adds some test cases to make sure that the combine patterns for p10 > fusion are working. > >

Re: [PATCH,rs6000] Combine patterns for p10 load-cmpi fusion

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Jan 3, 2021, at 2:42 PM, Aaron Sawdey wrote: > > Ping. > > I assume we’re going to want a separate patch for the new instruction type. > > Aaron Sawdey, Ph.D. saw...@linux.ibm.com

Re: [PATCH,rs6000] Fusion patterns for logical-logical

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Jan 3, 2021, at 2:43 PM, Aaron Sawdey wrote: > > Ping. > > Aaron Sawdey, Ph.D. saw...@linux.ibm.com > IBM Linux on POWER Toolchain > > >> On Dec 10, 2020, at 8:41 PM, acsaw...@li

Re: [PATCH,rs6000] Test cases for p10 fusion patterns

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Jan 3, 2021, at 2:44 PM, Aaron Sawdey wrote: > > Ping. > > Aaron Sawdey, Ph.D. saw...@linux.ibm.com > IBM Linux on POWER Toolchain > > >> On Dec 11, 2020, at 1:53 PM, acsaw...@li

Re: [PATCH,rs6000] Optimize pcrel access of globals [ping]

Ping. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Dec 9, 2020, at 11:04 AM, acsaw...@linux.ibm.com wrote: > > From: Aaron Sawdey > > Ping. I've folded in the changes to comments suggested by Will Schmidt. > > This patch implements a

Re: [pushed][PATCH] identify lfs prefixed case PR95347

Now that this has been in trunk for a bit with no issues, ok to back port to 10? Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > On Jun 3, 2020, at 4:10 PM, Aaron Sawdey wrote: > > This passed regstrap and was approved offline by Segher, posting > th

[PATCH] rs6000: Allow --with-cpu=power10

Update config.gcc so that we can use --with-cpu=power10. I've tested that this does do the expected thing with --with-cpu=power10 and also that it still builds and bootstraps correctly using --with-cpu=power9 on power9. If there isn't any other testing I need to do for this, ok for trunk? Thanks

[PATCH] rs6000: Add execution tests for mma builtins.

. Actually the power10_hw test I think requires current glibc to pick up the change that lets __builtin_cpu_is("power10") work. OK for trunk? Thanks, Aaron 2020-06-30 Rajalakshmi Srinivasaraghavan Aaron Sawdey gcc/testsuite/ * gcc.target/powerpc/mma-single-test.c

[PATCH,rs6000] Make MMA builtins use opaque modes [v2]

For some reason this patch never showed up on gcc-patches. Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain > Begin forwarded message: > > From: acsaw...@linux.ibm.com > Subject: [PATCH,rs6000] Make MMA builtins use opaque modes [v2] > Date: November 19, 2

Re: [PATCH] Additional small changes to support opaque modes

think it deserves a comment at least. > > The rest looks good to me FWIW. > > Richard I should look at this again — since I originally put that in, I switched the target portion of what I’ve been doing to use an UNSPEC to remove all use of an opaque mode const_int from the rtf. This may not be needed any more. Thanks, Aaron Aaron Sawdey, Ph.D. saw...@linux.ibm.com IBM Linux on POWER Toolchain

Re: [PATCH] Additional small changes to support opaque modes

> On Nov 20, 2020, at 4:57 AM, Aaron Sawdey via Gcc-patches > wrote: > > >> On Nov 20, 2020, at 3:55 AM, Richard Sandiford >> wrote: >> >> acsawdey--- via Gcc-patches writes: >>> @@ -16767,7 +16768,7 @@ loc_descriptor (rtx rtl, machine_mode mod

[PATCH] Add needed earlyclobber to fusion patterns

The add-logical and add-add fusion patterns all have constraint alternatives "=0,1,&r,r" for the output (3). The inputs 0 and 1 are used in the first fusion instruction and then either may be reused as a temp for the output of the first insn which is input to the second. However, if input 2 is the

[PATCH,rs6000] Fix p10 fusion regtests

From: Aaron Sawdey Update the count of matches for the fusion combine patterns after the recent changes to them. At Segher's request, used \m and \M in the match patterns. Also I have grouped together all alternatives of each fusion insn, which should hopefully make this test a little

[PATCH, rs6000] Do not enable pcrel-opt by default

SPEC2017 testing on p10 shows that this optimization does not have a positive impact on performance. So we are no longer going to enable it by default. The test cases for it needed to be updated so they always enable it to test it. OK for trunk and backport to 11 if bootstrap/regtest passes? Than

<    1   2