Re: [PATCH] libstdc++: Fix up string _M_constructor exports [PR103827]

2025-03-30 Thread Jan Hubicka
> On Thu, Mar 27, 2025 at 02:04:24PM +0100, Jan Hubicka wrote: > > > > Newline between functions please. > > > > > > > > OK with those two changes. > > > > > > Looking back through my inbox, this one doesn't seem to have been > > > pushed. Was it superseded by something else, or is it just waiting

Re: [PATCH v1] RISC-V: Make VXRM as global register [PR118103]

2025-03-30 Thread Jeff Law
On 2/12/25 2:03 AM, Richard Sandiford wrote: Just realized I didn't answer this part of your message. It's not really fixing any known issue. Just felt like the right thing to do as VXRM is roughly similar to (but clearly not 100% the same) FRM. But it sounds from the discussion like one

Re: [PATCH] i386: Add attr_isa for vaes patterns to sync with attr gpr16. [pr119473]

2025-03-30 Thread Hongtao Liu
On Fri, Mar 28, 2025 at 1:55 PM Hu, Lin1 wrote: > > For vaes patterns with jm constraint and gpr16 attr, it requires "isa" > attr to distinct avx/avx512 alternatives in ix86_memory_address_reg_class. > Also adds missing type and mode attributes for those vaes patterns. Ok. > > gcc/ChangeLog: > >

Re: [PATCH] i386: Add PTA_AVX10_1_256 to PTA_DIAMONDRAPIDS

2025-03-30 Thread Hongtao Liu
On Fri, Mar 28, 2025 at 4:22 PM Haochen Jiang wrote: > > Hi all, > > For -march= handling, PTA_AVX10_1 will not imply PTA_AVX10_1_256, > resulting in TARGET_AVX10_1 becoming true while TARGET_AVX10_1_256 > false. Since we will check TARGET_AVX10_1_256 in GCC 15 for AVX512 > feature enabling for AV

Fix x86 -Os costs of loads and stores

2025-03-30 Thread Jan Hubicka
Hi, this patch fixes problem with size costs declaring all moves to have equal size (which was caught by the sanity check I tried in prologue move cost hook). Costs are relative to reg-reg move which is two. Coincidentally it is also size of the encoding, so the costs should represent typical size

Re: [PATCH] libstdc++: Fix up string _M_constructor exports [PR103827]

2025-03-30 Thread Jonathan Wakely
On Sun, 30 Mar 2025, 23:15 Jakub Jelinek, wrote: > On Thu, Mar 27, 2025 at 02:04:24PM +0100, Jan Hubicka wrote: > > > > Newline between functions please. > > > > > > > > OK with those two changes. > > > > > > Looking back through my inbox, this one doesn't seem to have been > > > pushed. Was it s

Re: [PATCH 01] aarch64: Changed CRC test.

2025-03-30 Thread Mariam Arutunian
Thank you too. On Sun, Mar 30, 2025, 19:34 Jeff Law wrote: > > > On 3/26/25 6:15 AM, Mariam Arutunian wrote: > > Fixed the iteration number in crc-crc32c-data16.c test from 8 to 16 to > > match the test name. > Thanks. I pushed this to the trunk. > > jeff >

Re: [PATCH] RISC-V: Add pattern for vector-scalar multiply-add/sub [PR119100]

2025-03-30 Thread Robin Dapp
So may be the way to go is add a field to the uarch tuning structure indicating the additional cost (if any) of a register file crossing vector op of this nature. Then query that in riscv_rtx_costs or whatever our rtx_cost function is named. Default that additional cost to zero initially. Th

Re: [PATCH] RISC-V: vsetvl: skip abnormal edge on vsetvl insertion [PR119533]

2025-03-30 Thread Andreas Schwab
On Mär 29 2025, Vineet Gupta wrote: > diff --git a/gcc/config/riscv/riscv-vsetvl.cc > b/gcc/config/riscv/riscv-vsetvl.cc > index 0ac2538f596f..3b81e7f09924 100644 > --- a/gcc/config/riscv/riscv-vsetvl.cc > +++ b/gcc/config/riscv/riscv-vsetvl.cc > @@ -3391,7 +3391,6 @@ pre_vsetvl::emit_vsetvl () >

Re: [Patch, fortran] PR85836: Implement the F2018 reduce intrinsic

2025-03-30 Thread H.J. Lu
On Wed, Mar 19, 2025 at 11:23 AM Paul Richard Thomas wrote: > > Hi Andre, > > Thanks for the review - I'll act on the points that you raised. > > The Linaro people reported a failure in reduce_1.f90 execution, which I > believe is due to incorrect casting of 'dim' and a wrong specification of its

Re: [PATCH] c++: Honor noipa attribute for FE nothrow discovery [PR119518]

2025-03-30 Thread Jason Merrill
On 3/29/25 4:32 AM, Jakub Jelinek wrote: Hi! The following testcase has different code generation in bar depending on whether foo is defined or just declared. That is undesirable when it has noipa attribute, that attribute is documented to be a black box between caller and callee, so the caller

Re: [PATCH, RFC 0/7] Doc: Further cleanups to extend.texi [PR42270]

2025-03-30 Thread Sandra Loosemore
On 3/26/25 14:50, Sandra Loosemore wrote: Here's another batch of patches to address PR42270, a complaint about the poor organization of the documentation for GNU extensions. My last set of patches for this was focused on grouping everything but the attributes and builtins documentation into cat

Re: [PATCH] RISC-V: xtheadmemidx: Split slli.uw pattern

2025-03-30 Thread Bohan Lei
The RTL pattern has an "and" operation, which clears out the upper bits after the shift operation. Since we have (INTVAL (operands[3]) >> INTVAL (operands[2])) == 0x as a constraint, the RTL template and the split code should be semantically identical. Also, the RTL template here is tec

Re: Mark const parameters passed by invisible reference as readonly in the function body

2025-03-30 Thread Jan Hubicka
Hi, I noticed that this patch got forgotten and I think it may be useful to solve this next stage 1. > > cp_apply_type_quals_to_decl drops 'const' if the type has mutable members. > Unfortunately TREE_READONLY on the PARM_DECL isn't helpful in the case of an > invisiref parameter. > > > > But ma

New Swedish PO file for 'gcc' (version 15.1-b20250316)

2025-03-30 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: https://translationproject.org/latest/gcc/sv.po (This file, 'gcc-15.1-b20250316.sv.po'

[COMMITTED] robots.txt: Disallow robots to create new or list all activity on a bug

2025-03-30 Thread Mark Wielaard
--- htdocs/robots.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/htdocs/robots.txt b/htdocs/robots.txt index 36be4d139064..01ae43dd7000 100644 --- a/htdocs/robots.txt +++ b/htdocs/robots.txt @@ -14,6 +14,8 @@ Disallow: /bugzilla/show_bug.cgi*ctype=xml* Disallow: /bugzilla/attachment.cg

RE: [PATCH] cobol: Fix up cobol/{charmaps,valconv}.cc rules

2025-03-30 Thread Robert Dubner
Folks: Am I missing something stupid here? I just tried putting CXXFLAGS_SAVE=$(CXXFLAGS) override CXXFLAGS:=$(CXXFLAGS_SAVE) -I DUBNER_CXXFLAGS near the beginning of cobol/Make-lang.in, and override CXXFLAGS:=$(CXXFLAGS_SAVE) near the end. I don't have time right now to do a full check, but

[PATCH] gcc_release: Generate srcdir extras/infos/man pages from all FEs [PR119510]

2025-03-30 Thread Jakub Jelinek
Hi! Enabling cobol explicitly (at least unconditionally) in gcc_release has the disadvantage that the script no longer works for GCC <= 14, I think it would be better to keep it working for all still supported release branches. And as mentioned in the PR, we still don't generate the --enable-gene

RE: [PATCH] cobol: Fix up cobol/{charmaps,valconv}.cc rules

2025-03-30 Thread Robert Dubner
Follow-up. I risked wrath from my family and grabbed a minute. Tried the -L thing and eliminated all the SED statements on the .h files. It worked. Are there reasons not to use it? > -Original Message- > From: Robert Dubner > Sent: Sunday, March 30, 2025 09:52 > To: Jakub Jelinek ; I

Re: [PING][PATCH v3 0/4] Fix data races with sub-longword accesses on Alpha

2025-03-30 Thread Maciej W. Rozycki
On Sat, 22 Mar 2025, Maciej W. Rozycki wrote: > > This is v3 of the series comprising the final 4 outstanding changes. I > > note that the corresponding v2 patches have been approved, but concerns > > were discussed, which this update has addressed. > > Ping for: >

Re: [PATCH] wwwdocs: Clarify DCO name/identity and (anonymous) pseudonym policy

2025-03-30 Thread Mark Wielaard
Ping again. Are there any other clarifications you like to see added? On Mon, Jan 27, 2025 at 11:18:08PM +0100, Mark Wielaard wrote: > On Mon, Jan 20, 2025 at 11:59:16AM +0100, Mark Wielaard wrote: > > On Sun, Jan 19, 2025 at 05:14:20PM +0100, Mark Wielaard wrote: > > > On Tue, Dec 17, 2024 at 04:

Re: [PATCH] RISC-V: xtheadmemidx: Split slli.uw pattern

2025-03-30 Thread Jeff Law
On 3/23/25 8:43 PM, Bohan Lei wrote: The combine pass can generate an index like (and:DI (mult:DI (reg:DI) (const_int scale)) (const_int mask)) when XTheadMemIdx is available. LRA may pull it out, and thus a splitter is needed when Zba is not available. A similar splitter were introduced when

Re: [PATCH] aarch64: change another CRC test

2025-03-30 Thread Mariam Arutunian
Yes, thank you! On Sun, Mar 30, 2025, 19:40 Sam James wrote: > Fixed the iteration number in crc-crc32-data16.c test from 8 to 16 to > match the test name, just like in r15-9038-gdf55a933cfc675. > > gcc/testsuite/ChangeLog: > * gcc.target/aarch64/crc-crc32-data16.c: Fix iteration >

Re: [PATCH] Doc: -Wzero-as-null-pointer-constant is also available for C [PR119173]

2025-03-30 Thread Sandra Loosemore
On 3/30/25 06:48, Martin Uecker wrote: Here is a small documentation patch. Martin Doc: -Wzero-as-null-pointer-constant is also available for C [PR119173] The warning -Wzero-as-null-pointer-constant is now not only supported in C++ but also in C. Change the documentatio

Re: [PATCH] combine: Special case set_noop_p in two spots

2025-03-30 Thread Jakub Jelinek
On Sat, Mar 29, 2025 at 06:51:21PM -0600, Jeff Law wrote: > > 2025-03-28 Jakub Jelinek > > > > * combine.cc (try_combine): Sets which satisfy set_noop_p can go > > to i2 unless i3 is a jump and the other set is not. > Shouldn't this wait for gcc-16? Or can you make a reasonable case th

Re: [PATCH] aarch64: change another CRC test

2025-03-30 Thread Jeff Law
On 3/30/25 9:39 AM, Sam James wrote: Fixed the iteration number in crc-crc32-data16.c test from 8 to 16 to match the test name, just like in r15-9038-gdf55a933cfc675. gcc/testsuite/ChangeLog: * gcc.target/aarch64/crc-crc32-data16.c: Fix iteration count to match testname. --- D

[PATCH] Doc: -Wzero-as-null-pointer-constant is also available for C [PR119173]

2025-03-30 Thread Martin Uecker
Here is a small documentation patch. Martin Doc: -Wzero-as-null-pointer-constant is also available for C [PR119173] The warning -Wzero-as-null-pointer-constant is now not only supported in C++ but also in C. Change the documentation accordingly. PR c/119173

[PING^3][PATCH] Alpha: Fix base block alignment calculation regression

2025-03-30 Thread Maciej W. Rozycki
On Tue, 25 Feb 2025, Maciej W. Rozycki wrote: > Address this issue by recursing into COMPONENT_REF tree nodes until the > outermost one has been reached, which is supposed to be a MEM_REF one, > accumulating the offset as we go, fixing a commit e0dae4da4c45 ("Alpha: > Also use tree information

[PATCH] gcc-gitref.cgi: Redirect to cgit instead of gitweb

2025-03-30 Thread Mark Wielaard
cgit is more efficient compared to gitweb and has nicer URLs. Other redirects like gcc.gnu.org/g:x and bugzilla now also redirect to cgit. --- cgi-bin/gcc-gitref.cgi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cgi-bin/gcc-gitref.cgi b/cgi-bin/gcc-gitref.cgi index 17b5f

Re: [wwwdocs] Add Ada's GCC 15 changelog entry

2025-03-30 Thread Fernando Oleo Blanco
Hi, is there any feedback that I should apply? If not, I would like to see the patch merged so that people can see the changes for Ada :) Best regards, Fer On 3/24/25 19:47, Fernando Oleo Blanco wrote: > Dear GCC maintainers, > > I have written the GCC 15 changelog for Ada. I am attaching the p

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-03-30 Thread Christophe Lyon
Le dim. 30 mars 2025, 22:10, Sam James a écrit : > Jakub Jelinek writes: > > > Hi! > > > > r15-8956 changed in the test: > > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > > +/* { dg-final { scan-assembler-times "ldclr\t" 16 } */ > > which made it even worse than before, when the direc

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-03-30 Thread Sam James
Christophe Lyon writes: > Le dim. 30 mars 2025, 22:10, Sam James a écrit : > > Jakub Jelinek writes: > > > Hi! > > > > r15-8956 changed in the test: > > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > > +/* { dg-final { scan-assembler-times "ldclr\t" 16 } */ > > which made it ev