> On Thu, Mar 27, 2025 at 02:04:24PM +0100, Jan Hubicka wrote:
> > > > Newline between functions please.
> > > >
> > > > OK with those two changes.
> > >
> > > Looking back through my inbox, this one doesn't seem to have been
> > > pushed. Was it superseded by something else, or is it just waiting for
> > > stage 1 now?
> >
> > Seems I missed the approval, sorry. I will push it - I think it would
> > be useful to have it in.
> > (I have more libstdc++ work for next stage1, but solving this is IMO
> > useful)
>
> Unfortunately the exports in this patch only work on targets where size_t is
> unsigned long, not e.g. on ia32 where it is unsigned int, or targets where
> it is unsigned long long.
>
> Fixed thusly, tested on x86_64-linux and i686-linux, ok for trunk?
>
> 2025-03-31 Jakub Jelinek <ja...@redhat.com>
>
> PR tree-optimization/103827
> PR tree-optimization/80331
> PR tree-optimization/87502
> * config/abi/pre/gnu.ver (GLIBCXX_3.4.34): Use [jmy] rather than m
> in pattern for _M_construct<bool>(char const*, size_t).
Ooops, sorry for that. The patch looks good to me.
Honza
>
> --- libstdc++-v3/config/abi/pre/gnu.ver.jj 2025-03-31 00:01:50.579455165
> +0200
> +++ libstdc++-v3/config/abi/pre/gnu.ver 2025-03-31 00:06:30.490601502
> +0200
> @@ -2540,9 +2540,9 @@ GLIBCXX_3.4.34 {
>
> _ZNSt8__format25__locale_encoding_to_utf8ERKSt6localeSt17basic_string_viewIcSt11char_traitsIcEEPv;
> # __sso_string constructor and destructor
> _ZNSt12__sso_string[CD][12]Ev;
> - # void std::__cxx11::basic_string<char, std::char_traits<char>,
> std::allocator<char> >::_M_construct<bool>(char const*, unsigned long)
> + # void std::__cxx11::basic_string<char, std::char_traits<char>,
> std::allocator<char> >::_M_construct<bool>(char const*, size_t)
> # and wide char version
> -
> _ZNSt7__cxx1112basic_stringI[cw]St11char_traitsI[cw]ESaI[cw]EE12_M_constructILb[01]EEEvPK[cw]m;
> +
> _ZNSt7__cxx1112basic_stringI[cw]St11char_traitsI[cw]ESaI[cw]EE12_M_constructILb[01]EEEvPK[cw][jmy];
> } GLIBCXX_3.4.33;
>
> # Symbols in the support library (libsupc++) have their own tag.
>
>
> Jakub
>
