Re: [RFC v3 3/3] c: Add __lengthof__() operator

2024-08-05 Thread Qing Zhao
On Aug 5, 2024, at 06:33, Martin Uecker wrote: > > Am Montag, dem 05.08.2024 um 11:50 +0200 schrieb Jakub Jelinek: >> On Mon, Aug 05, 2024 at 11:45:56AM +0200, Alejandro Colomar wrote: >>> [CC += Kees, Qing] >>> >>> Hi Joseph, >>> >>> On Sun, Aug 04, 2024 at 08:34:24PM GMT, Alejandro Colomar wr

[PATCH v2] Explicitly document that the "counted_by" attribute is only supported in C.

2024-08-05 Thread Qing Zhao
Compared to the first version, the major changes are: 1. Changed the error as a warning with -Wattributes per Jakub and Jason's comments. 2. Update documentation accordingly. 3. Move the testing case to g++.dg/ext Add one more new testing case for C++11 Adjust the testing case according t

[RFC] libstdc++: Replace Ryu with Teju Jagua for float.

2024-08-05 Thread Cassio Neri
Implement the template function teju_jagua which finds the shortest representation of a floating-point number. The floating-point type is a template parameter and the implementation is generic enough to handle all floating-point types of interest, namely, IEEE 754, std::bfloat16_t, x86 80-bit and I

Re: [PATCH ver 3] rs6000, Add new overloaded vector shift builtin int128, variants

2024-08-05 Thread Carl Love
Kewen: On 8/4/24 11:13 PM, Kewen.Lin wrote: Hi Carl, on 2024/8/2 03:35, Carl Love wrote: GCC developers: Version 3, updated the testcase dg-do link to dg-do compile.  Moved the new documentation again.  Retested on Power 10 LE and BE to verify the dg arguments disable the test on Power10BE

Re: [PATCH 1/8] fortran: Add tests covering inline MINLOC/MAXLOC without DIM [PR90608]

2024-08-05 Thread Mikael Morin
Hello, Le 05/08/2024 à 21:25, Harald Anlauf a écrit : Is there a reason you do not use the ieee intrinsic module way to get a quiet nan?  Otherwise, how do you prevent exceptions to happen, possibly leading to a failing test? (The test cases need a workaround to run with NAG). indeed, I didn't

Re: [RFC v3 3/3] c: Add __lengthof__() operator

2024-08-05 Thread Martin Uecker
Am Montag, dem 05.08.2024 um 20:10 + schrieb Qing Zhao: > On Aug 5, 2024, at 06:33, Martin Uecker wrote: > > > > Am Montag, dem 05.08.2024 um 11:50 +0200 schrieb Jakub Jelinek: > > > On Mon, Aug 05, 2024 at 11:45:56AM +0200, Alejandro Colomar wrote: > > > > [CC += Kees, Qing] > > > > > > > >

Re: [RFC v3 3/3] c: Add __lengthof__() operator

2024-08-05 Thread Alejandro Colomar
Hi Qing, On Mon, Aug 05, 2024 at 10:41:43PM GMT, Martin Uecker wrote: > Am Montag, dem 05.08.2024 um 20:10 + schrieb Qing Zhao: > > On Aug 5, 2024, at 06:33, Martin Uecker wrote: > > > > > > Am Montag, dem 05.08.2024 um 11:50 +0200 schrieb Jakub Jelinek: > > > > On Mon, Aug 05, 2024 at 11:45

Re: [PATCH] rs6000, document built-ins vec_test_lsbb_all_ones and, vec_test_lsbb_all_zeros

2024-08-05 Thread Steven Munroe
Looking at the latest version of the Power Vector Intrinsic Programming Reference (Revision 2.0.0_prd, Bill slipped this to me for review), I see that vec_test_lsbb_all_ones vec_test_lsbb_all_zeros both specify vector unsigned char, only. On Mon, Aug 5, 2024 at 1:15 AM Kewen.Lin wrote: > on 2024

[PATCH] sh: Don't call make_insn_raw in sh_recog_treg_set_expr [PR116189]

2024-08-05 Thread Andrew Pinski
This was an interesting compare debug failure to debug. The first symptom was in gcse which would produce different order of creating psedu-registers. This was caused by a different order of a hashtable walk, due to the hash table having different number of entries. Which in turn was due to the n

Re: [PATCH] c++: remove function/var concepts code

2024-08-05 Thread Jason Merrill
On 8/5/24 4:00 PM, Marek Polacek wrote: On Mon, Aug 05, 2024 at 02:52:32PM -0400, Jason Merrill wrote: On 8/5/24 2:44 PM, Marek Polacek wrote: On Mon, Aug 05, 2024 at 12:00:04PM -0400, Jason Merrill wrote: I think we also want to adjust the 'concept bool' handling in cp_parser_decl_specifier

Re: [PATCH] c++: permit errors inside uninstantiated templates [PR116064]

2024-08-05 Thread Jason Merrill
On 8/5/24 3:47 PM, Patrick Palka wrote: On Mon, 5 Aug 2024, Jason Merrill wrote: On 8/5/24 1:14 PM, Patrick Palka wrote: On Mon, 5 Aug 2024, Jason Merrill wrote: On 8/2/24 4:18 PM, Patrick Palka wrote: On Fri, 2 Aug 2024, Patrick Palka wrote: On Fri, 2 Aug 2024, Jason Merrill wrote: On

Re: [PATCH] c++: permit errors inside uninstantiated templates [PR116064]

2024-08-05 Thread Patrick Palka
On Mon, 5 Aug 2024, Jason Merrill wrote: > On 8/5/24 3:47 PM, Patrick Palka wrote: > > On Mon, 5 Aug 2024, Jason Merrill wrote: > > > > > On 8/5/24 1:14 PM, Patrick Palka wrote: > > > > On Mon, 5 Aug 2024, Jason Merrill wrote: > > > > > > > > > On 8/2/24 4:18 PM, Patrick Palka wrote: > > > > > >

[PATCH 3/3] RISC-V: Fix typos in code

2024-08-05 Thread Patrick O'Neill
This fixes typos in function names and executed code. gcc/ChangeLog: * config/riscv/riscv-target-attr.cc (num_occurences_in_str): Rename... (num_occurrences_in_str): here. (riscv_process_target_attr): Update num_occurences_in_str callsite. * config/riscv/riscv-v.cc

[PATCH 1/3] RISC-V: Fix comment typos

2024-08-05 Thread Patrick O'Neill
This fixes most of the typos I found when reading various parts of the RISC-V backend. gcc/ChangeLog: * config/riscv/arch-canonicalize: Fix typos in comments. * config/riscv/autovec.md: Ditto. * config/riscv/riscv-avlprop.cc (avl_can_be_propagated_p): Ditto. (pass_

[PATCH 2/3] RISC-V: Fix non-obvious comment typos

2024-08-05 Thread Patrick O'Neill
This fixes the remainder of the typos I found when reading various parts of the RISC-V backend. gcc/ChangeLog: * config/riscv/riscv-v.cc (legitimize_move): extrac -> extract. (expand_vec_cmp_float): Remove duplicate vmnor.mm. * config/riscv/riscv-vector-builtins.cc: ins ->

[Committed] RISC-V: Add deprecation warning to LP64E abi

2024-08-05 Thread Patrick O'Neill
gcc/ChangeLog: PR target/116152 * config/riscv/riscv.cc (riscv_option_override): Add deprecation warning. gcc/testsuite/ChangeLog: * gcc.target/riscv/predef-9.c: Add check for warning. Signed-off-by: Patrick O'Neill --- gcc/config/riscv/riscv.cc

[Committed] RISC-V: Add deprecation warning to LP64E abi

2024-08-05 Thread Patrick O'Neill
On 8/5/24 07:21, Jeff Law wrote: On 7/30/24 6:32 PM, Patrick O'Neill wrote: gcc/ChangeLog: PR 116152 * config/riscv/riscv.cc (riscv_option_override): Add deprecation warning. gcc/testsuite/ChangeLog: * gcc.target/riscv/predef-9.c: Add check for warning. OK jeff Rebased

Go patch committed: Panic arguments have empty interface type

2024-08-05 Thread Ian Lance Taylor
This patch to the Go frontend determines that panic arguments are empty interfaces. After https://go.dev/cl//536643 passing NULL as the expected type permitted an untyped constant expression to remain untyped. This change will fix them to take on the empty interface type. The panic and print/prin

sched1 pathology on RISC-V : PR/114729

2024-08-05 Thread Vineet Gupta
Hi Richard, I'm reaching out for some insight on PR/114729. Apologies in advance for the long email. On RISC-V we are hitting sched1 pathology on SPEC2017 Cactu where codegen spills are overwhelming the execution: disabling sched1 shaves off 1.3 trillion dynamic icounts which is about half of tot

Re: [PATCH 3/3] RISC-V: Fix typos in code

2024-08-05 Thread Christoph Müllner
On Tue, Aug 6, 2024 at 12:29 AM Patrick O'Neill wrote: > > This fixes typos in function names and executed code. > > gcc/ChangeLog: > > * config/riscv/riscv-target-attr.cc (num_occurences_in_str): Rename... > (num_occurrences_in_str): here. > (riscv_process_target_attr): Up

libbacktrace patch committed: Avoid -Wpointer-arith errors

2024-08-05 Thread Ian Lance Taylor
This patch, based on one by Kirill Müller, adds -Wpointer-arith to the libbacktrace warning options, and adds casts to avoid the cases where the warning currently fires. Bootstrapped and ran libbacktrace testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian * configure.ac (ACX_PROG_CC_WA

Re: [PATCH] sh: Don't call make_insn_raw in sh_recog_treg_set_expr [PR116189]

2024-08-05 Thread Oleg Endo
On Mon, 2024-08-05 at 14:15 -0700, Andrew Pinski wrote: > This was an interesting compare debug failure to debug. The first symptom > was in gcse which would produce different order of creating psedu-registers. > This > was caused by a different order of a hashtable walk, due to the hash table

Re: Re: [PATCH] RISC-V: Minimal support for Zimop extension.

2024-08-05 Thread Xiao Zeng
2024-08-05 23:21  Jiawei wrote: > > >在 2024/8/5 22:15, Jeff Law 写道: >> >> >> On 8/4/24 8:20 PM, Jiawei wrote: >>> >>> 在 2024/8/5 8:45, Jeff Law 写道: On 8/2/24 9:32 AM, Jiawei wrote: > https://github.com/riscv/riscv-isa-manual/blob/main/src/zimop.adoc > > gcc/ChangeLog: >>

RE: [PATCH v1] Match: Support form 1 for scalar signed integer .SAT_ADD

2024-08-05 Thread Li, Pan2
Hi Richard, It looks like the plus will have additional convert to unsigned in int8 and int16, see below example in test.c.006t.gimple. And we need these convert ops in one matching pattern to cover all int scalar types. I am not sure if there is a better way here, given convert in matching pat

RE: [PATCH v1] Match: Add type_has_mode_precision_p check for SAT_TRUNC [PR116202]

2024-08-05 Thread Li, Pan2
> Well that means the caller (vectorizer pattern recog?) wrongly used a > vector of QImode in > the first place, so it needs to check the scalar mode as well? Current vect pattern recog only check the vector mode of define_expand pattern implemented or not. Similar as below without scalar part.

Re: [PATCH] c++: remove function/var concepts code

2024-08-05 Thread Patrick Palka
On Fri, 2 Aug 2024, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu. Comments? > > -- >8 -- > This patch removes vestigial Concepts TS code as discussed in > . Yay! FWIW I think we can also remove the concept

Re: [PATCH] RISC-V: Minimal support for Zimop extension.

2024-08-05 Thread Nelson Chu
2.43 was released over an weekend. Is it possible to let it be supported after 2.44? cc Nick and jan. Thanks Nelson On Mon, Aug 5, 2024 at 11:24 PM Jeff Law wrote: > > > On 8/5/24 9:21 AM, Jiawei wrote: > > > > > Thanks Jeff! I think I do not have the permissions in the binutils repo, > > let

Re: [PATCH] RISC-V: Minimal support for Zimop extension.

2024-08-05 Thread Jeff Law
On 8/5/24 8:17 PM, Nelson Chu wrote: 2.43 was released over an weekend.  Is it possible to let it be supported after 2.44? cc Nick and jan. I don't think it's critical enough to backport to 2.43. I'd just put it on the trunk so that it's available in 2.44. jeff

Re: [PATCH 1/3] RISC-V: Fix comment typos

2024-08-05 Thread Jeff Law
On 8/5/24 4:29 PM, Patrick O'Neill wrote: This fixes most of the typos I found when reading various parts of the RISC-V backend. Comment typos are always OK to fix under the "obvious" rule. No need to wait for an ACK. Jeff

Re: [PATCH 3/3] RISC-V: Fix typos in code

2024-08-05 Thread Jeff Law
On 8/5/24 4:29 PM, Patrick O'Neill wrote: This fixes typos in function names and executed code. gcc/ChangeLog: * config/riscv/riscv-target-attr.cc (num_occurences_in_str): Rename... (num_occurrences_in_str): here. (riscv_process_target_attr): Update num_occurences_in_

Re: sched1 pathology on RISC-V : PR/114729

2024-08-05 Thread Jeff Law
On 8/5/24 5:35 PM, Vineet Gupta wrote: Hi Richard, I'm reaching out for some insight on PR/114729. Apologies in advance for the long email. On RISC-V we are hitting sched1 pathology on SPEC2017 Cactu where codegen spills are overwhelming the execution: disabling sched1 shaves off 1.3 trillio

Re: [PATCH] RISC-V: Clarify that Vector Crypto Extensions require Vector Extensions[PR116150]

2024-08-05 Thread Jeff Law
On 8/5/24 10:23 AM, Patrick O'Neill wrote: On 8/5/24 01:23, Liao Shihua wrote: PR 116150: Zvk* and Zvb* extensions requires v or zve* extension, but on gcc v is implied. gcc/ChangeLog: * common/config/riscv/riscv-common.cc: Removed the zvk extension's implicit expansion

Re: [PATCH, rs6000] Add const_vector into any_operand predicate

2024-08-05 Thread HAO CHEN GUI
Thanks for reviewing the patch. Committed as r15-2740. 在 2024/7/31 17:10, Kewen.Lin 写道: > Hi Haochen, > > on 2024/7/25 11:34, HAO CHEN GUI wrote: >> Hi, >> This patch add const_vector into any_operand predicate. From my >> understanding, any_operand should include all kinds of operands. >> The

Re: [PATCH] RISC-V: Minimal support for Zimop extension.

2024-08-05 Thread Nelson Chu
On Tue, Aug 6, 2024 at 11:17 AM Jeff Law wrote: > > On 8/5/24 8:17 PM, Nelson Chu wrote: > > 2.43 was released over an weekend. Is it possible to let it be > > supported after 2.44? cc Nick and jan. > I don't think it's critical enough to backport to 2.43. I'd just put it > on the trunk so that

Ping^6 [PATCH] add rlwinm pattern for DImode for constant building

2024-08-05 Thread Jiufu Guo
Hi, Gentle ping... BR, Jeff(Jiufu) Guo Jiufu Guo writes: > Hi, > > Gentle ping... > > BR, > Jeff(Jiufu) Guo > > Jiufu Guo writes: > >> Hi, >> >> Gentle ping. >> >> BR, >> Jeff(Jiufu) Guo >> >> Jiufu Guo writes: >> >>> Hi, >>> >>> Gentle ping ... >>> >>> Jiufu Guo writes: >>> Hi,

[PATCH] c++/modules: Handle instantiating qualified template friend classes [PR115801]

2024-08-05 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? Another potential approach would be to go searching for this unexported type and load it, either with a new LOOK_want::ANY_REACHABLE flag or by expanding on the lookup_imported_temploid_friend hack. I'm still not exactly sure how na

Re: [PATCH] RISC-V: Clarify that Vector Crypto Extensions require Vector Extensions[PR116150]

2024-08-05 Thread Liao Shihua
在 2024/8/6 12:34, Jeff Law 写道: On 8/5/24 10:23 AM, Patrick O'Neill wrote: On 8/5/24 01:23, Liao Shihua wrote: PR 116150: Zvk* and Zvb* extensions requires v or zve* extension, but on gcc v is implied. gcc/ChangeLog: * common/config/riscv/riscv-common.cc: Removed the zv

<    1   2