[Patch, fortran] PR107900 Select type with intrinsic type inside associate causes ICE / Segmenation fault

2023-06-17 Thread Paul Richard Thomas via Gcc-patches
Hi All, The attached patch is amply described by the comments and the changelog. It also includes the fix for the memory leak in decl.cc, as promised some days ago. OK for trunk? Regards Paul PS This leaves 89645 and 99065 as the only real blockers to PR87477. These will take a little while to

Re: [PATCH 1/2] c++: implement __remove_pointer built-in trait

2023-06-17 Thread Ken Matsui via Gcc-patches
Hi, I conducted a benchmark for remove_pointer as well as is_object. Just like the is_object benchmark, here is the benchmark code: https://github.com/ken-matsui/gcc-benches/blob/main/remove_pointer_benchmark.cc On my computer, using the gcc HEAD of this patch for a release build, the patch with

Re: [x86_64 PATCH] Two minor tweaks to ix86_expand_move.

2023-06-17 Thread Uros Bizjak via Gcc-patches
On Fri, Jun 16, 2023 at 6:27 PM Roger Sayle wrote: > > > This patch splits out two (independent) minor changes to i386-expand.cc's > ix86_expand_move from a larger patch, given that it's better to review > and commit these independent pieces separately from a more complex patch. > > The first chan

Re: [PATCH V6] VECT: Support LEN_MASK_{LOAD,STORE} ifn && optabs

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/16/23 04:29, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong This patch bootstrap pass on X86, ok for trunk ? Accoding to comments from Richi, split the first patch to add ifn && optabs of LEN_MASK_{LOAD,STORE} only, we don't apply them into vectorizer in this patch. And also add BIAS a

[PATCH v1] RISC-V: Bugfix for RVV float reduction in ZVE32/64

2023-06-17 Thread Pan Li via Gcc-patches
From: Pan Li The rvv integer reduction has 3 different patterns for zve128+, zve64 and zve32. They take the same iterator with different attributions. However, we need the generated function code_for_reduc (code, mode1, mode2). The implementation of code_for_reduc may look like below. code_for_r

Re: [PATCH v6 0/4] P1689R5 support

2023-06-17 Thread Ben Boeckel via Gcc-patches
On Fri, Jun 16, 2023 at 23:55:53 -0400, Jason Merrill wrote: > I see the same thing with patch 4 on x86_64-pc-linux-gnu, e.g. > > FAIL: g++.dg/modules/ben-1_a.C -std=c++17 (test for excess errors) > Excess errors: > /home/jason/gt/gcc/testsuite/g++.dg/modules/ben-1_a.C:9:1: internal > compiler err

Re: [RFC] RISC-V: Support risc-v bfloat16 This patch support bfloat16 in riscv like x86_64 and arm.

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/15/23 03:52, Jin Ma wrote: There are also some problems here, which cannot be simply handled like HF. Many instructions support HF but do not support BF. For example, fadd.h can be used for HF but cannot be used for BF. I guess it may need to be converted to SF first, then fadd.s, a

Re: [Patch, fortran] PR107900 Select type with intrinsic type inside associate causes ICE / Segmenation fault

2023-06-17 Thread Steve Kargl via Gcc-patches
On Sat, Jun 17, 2023 at 10:14:43AM +0100, Paul Richard Thomas via Fortran wrote: > > PS This leaves 89645 and 99065 as the only real blockers to PR87477. > Hate to be the bearer of bad news, but Neil Carlson has added a couple PRs about associate that may not be listed in 87447. https://gcc.gn

Re: [PATCH] RTL: Merge rtx_equal_p and hash_rtx functions with their callback variants

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/14/23 04:15, Uros Bizjak via Gcc-patches wrote: Use default argument when callback function is not required to merge rtx_equal_p and hash_rtx functions with their callback variants. gcc/ChangeLog: * cse.cc (hash_rtx_cb): Rename to hash_rtx. (hash_rtx): Remove. * early-rem

Re: [Ping] Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/16/23 04:17, SenthilKumar.Selvaraj--- via Gcc-patches wrote: On Fri, 2023-06-02 at 12:32 +0530, Senthil Kumar Selvaraj wrote: On Mon, 2023-05-22 at 14:05 +0200, Richard Biener wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Fri, May

Re: [Patch, fortran] PR107900 Select type with intrinsic type inside associate causes ICE / Segmenation fault

2023-06-17 Thread Harald Anlauf via Gcc-patches
Hi Paul, On 6/17/23 11:14, Paul Richard Thomas via Gcc-patches wrote: Hi All, The attached patch is amply described by the comments and the changelog. It also includes the fix for the memory leak in decl.cc, as promised some days ago. OK for trunk? I hate to say it, but you forgot to add the

Re: [wwwdocs] Broken URL to README.Portability

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/14/23 06:06, Jivan Hakobyan via Gcc-patches wrote: This patch fixes the link to README.Portability in "GCC Coding Conventions" page Thanks. I've pushed this to the htdocs repo. jeff

Re: [wwwdocs] Broken URL to README in st/cli-be project

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/14/23 14:54, Jivan Hakobyan wrote: Subject: [wwwdocs] Broken URL to README in st/cli-be project From: Jivan Hakobyan Date: 6/14/23, 14:54 To: gcc-patches@gcc.gnu.org CC: Jeff Law In CLI project link to README is broken. This patch fixes that. Discussed in PR110250 Thanks. I pushed

Re: [PATCH v2] Implement new RTL optimizations pass: fold-mem-offsets.

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/15/23 11:28, Manolis Tsamis wrote: This is a new RTL pass that tries to optimize memory offset calculations by moving them from add immediate instructions to the memory loads/stores. For example it can transform this: addi t4,sp,16 add t2,a6,t4 shl t3,t2,1 ld a2,0(t3)

Re: [PATCH] gcc-ar: Remove code duplication.

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/15/23 06:10, Costas Argyris via Gcc-patches wrote: From c3f3b2fd53291805b5d0be19df6d1a348c5889ec Mon Sep 17 00:00:00 2001 From: Costas Argyris Date: Thu, 15 Jun 2023 12:37:35 +0100 Subject: [PATCH] gcc-ar: Remove code duplication. Preparatory refactoring that simplifies by eliminating s

Re: [PATCH] [contrib] validate_failures.py: Don't consider summary line in wrong place

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/16/23 06:02, Thiago Jung Bauermann via Gcc-patches wrote: When parsing a summary or manifest file, if we're not either after a tool line (e.g. "=== gdb tests ===") or before a summary line (e.g., "=== gdb Summary ===") then the current line can't be a valid result line so ignore it. This

Re: [PATCH v2] RISC-V: testsuite: Add vector_hw and zvfh_hw checks.

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/15/23 09:06, Robin Dapp wrote: Hi, Changes from v1: - Revamped the target selectors again. - Fixed some syntax as well as caching errors that were still present. - Adjusted some test cases I missed. The current situation with target selectors is improvable at best. We definitely n

Re: [PATCH V1] RISC-V:Add float16 tuple type support

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/15/23 00:09, juzhe.zh...@rivai.ai wrote: LGTM Then it's OK with me as well. Thanks! jeff

Re: Followup on PR/109279: large constants on RISCV

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/12/23 13:32, Vineet Gupta wrote: Gave this a try and it seems to fix Andrew's test, but then regresses the actual large const case: 0x1010101_01010101 : the mem to const_int transformation was being done in cse1 which no longer happens and the const pool from initial expand remains a

[PATCH V7] VECT: Support LEN_MASK_{LOAD,STORE} ifn && optabs

2023-06-17 Thread juzhe . zhong
From: Ju-Zhe Zhong This patch bootstrap pass on X86, ok for trunk ? Accoding to comments from Richi, split the first patch to add ifn && optabs of LEN_MASK_{LOAD,STORE} only, we don't apply them into vectorizer in this patch. And also add BIAS argument for possible s390's future use. The descri

Re: Re: [PATCH V6] VECT: Support LEN_MASK_{LOAD,STORE} ifn && optabs

2023-06-17 Thread 钟居哲
Hi, Jeff. >> That first sentence is a bit difficult to parse. Perhaps break it into >> two sentences. Something like this? >> Perform a masked load from the memory location pointed to be operand 1 >> into register operand 0. operand 2 + operand 4 elements are loaded from >> memory and other el

Re: [PATCH v1] RISC-V: Bugfix for RVV float reduction in ZVE32/64

2023-06-17 Thread 钟居哲
I think vlmul1, vlmul1_zve64, vlmul1_zve32 these 3 attributes are no longer used. Could you remove it ? juzhe.zh...@rivai.ai From: pan2.li Date: 2023-06-17 22:23 To: gcc-patches CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v1] RISC-V: Bugfix for

Re: [PATCH V7] VECT: Support LEN_MASK_{LOAD,STORE} ifn && optabs

2023-06-17 Thread 钟居哲
Bootstrap and Regreesion on X86 passed. Jeff and Richi approved. Let's wait for Richard S final approve. Thanks. juzhe.zh...@rivai.ai From: juzhe.zhong Date: 2023-06-18 06:53 To: gcc-patches CC: jeffreyalaw; rguenther; richard.sandiford; Ju-Zhe Zhong; Robin Dapp Subject: [PATCH V7] VECT: Supp

RE: [PATCH V1] RISC-V:Add float16 tuple type support

2023-06-17 Thread Li, Pan2 via Gcc-patches
Committed, thanks Jeff. Pan -Original Message- From: Jeff Law Sent: Sunday, June 18, 2023 6:08 AM To: juzhe.zh...@rivai.ai; shiyulong ; gcc-patches Cc: palmer ; Kito.cheng ; Jim Wilson ; Li, Pan2 ; wuwei2016 ; jiawei ; shihua ; dje.gcc ; mirimmad ; Robin Dapp Subject: Re: [PATCH

RE: [PATCH v1] RISC-V: Bugfix for RVV float reduction in ZVE32/64

2023-06-17 Thread Li, Pan2 via Gcc-patches
Make sense, will update V2 patch for this. Pan From: 钟居哲 Sent: Sunday, June 18, 2023 7:09 AM To: Li, Pan2 ; gcc-patches Cc: rdapp.gcc ; Jeff Law ; Li, Pan2 ; Wang, Yanzhang ; kito.cheng Subject: Re: [PATCH v1] RISC-V: Bugfix for RVV float reduction in ZVE32/64 I think vlmul1, vlmul1_zve64,

[PATCH v2] RISC-V: Bugfix for RVV float reduction in ZVE32/64

2023-06-17 Thread Pan Li via Gcc-patches
From: Pan Li The rvv integer reduction has 3 different patterns for zve128+, zve64 and zve32. They take the same iterator with different attributions. However, we need the generated function code_for_reduc (code, mode1, mode2). The implementation of code_for_reduc may look like below. code_for_r