Re: [PATCH V2] coroutines: Adjust outlined function names [PR95520].

2021-07-12 Thread Jason Merrill via Gcc-patches
On 7/11/21 9:03 AM, Iain Sandoe wrote: Hi Jason, On 9 Jul 2021, at 22:40, Jason Merrill wrote: On 7/9/21 2:18 PM, Iain Sandoe wrote: How about handling this in write_encoding, along the lines of the devel/c++-contracts branch? OK, so I took a look at this and implemented as below. Oh,

Re: [PATCH] c++: permit deduction guides at class scope [PR79501]

2021-07-12 Thread Jason Merrill via Gcc-patches
On 7/9/21 6:41 PM, Patrick Palka wrote: On Fri, 9 Jul 2021, Jason Merrill wrote: On 7/9/21 4:18 PM, Patrick Palka wrote: On Fri, 9 Jul 2021, Patrick Palka wrote: On Fri, 9 Jul 2021, Jason Merrill wrote: On 7/9/21 3:18 PM, Patrick Palka wrote: This adds support for declaring (class-scope)

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread David Edelsohn via Gcc-patches
On Mon, Jul 12, 2021 at 1:47 PM Bill Schmidt wrote: > > On 7/12/21 12:16 PM, Michael Meissner wrote: > > On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: > >> Hi Mike, > >> > >> On 7/7/21 3:04 PM, Michael Meissner wrote: > >>> [PATCH] PR 100167: Fix vector long long multiply/divide te

Re: contracts library support (was Re: [PATCH] PING implement pre-c++20 contracts)

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 5 Jul 2021 at 20:07, Jason Merrill wrote: > > On 6/26/21 10:23 AM, Andrew Sutton wrote: > > > > I ended up taking over this work from Jeff (CC'd on his existing email > > address). I scraped all the contracts changes into one big patch > > against master. See attached. The ChangeLog.contra

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread David Edelsohn via Gcc-patches
On Wed, Jul 7, 2021 at 4:01 PM Michael Meissner wrote: > > [PATCH] Fix vec-splati-runnable.c test. > > I noticed that the vec-splati-runnable.c did not have an abort after one > of the tests. If the test was run with optimization, the optimizer could > delete some of the tests and throw off the c

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Qing Zhao via Gcc-patches
Hi, Kees, Thanks a lot for your testing on kernel testing cases. I have some question in below: > On Jul 12, 2021, at 12:56 PM, Kees Cook wrote: > > On Wed, Jul 07, 2021 at 05:38:02PM +, Qing Zhao wrote: >> Hi, >> >> This is the 4th version of the patch for the new security feature for

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Segher Boessenkool
On Mon, Jul 12, 2021 at 10:32:47AM -0500, Bill Schmidt wrote: > > * gcc.target/powerpc/fold-vec-load-builtin_vec_xl-char.c: There should be something after the ":". If you want to say the same thing for many files, you can say somethin like "ditto" for all but the first. > >-/* { dg-final {

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Segher Boessenkool
On Wed, Jul 07, 2021 at 04:03:20PM -0400, Michael Meissner wrote: > This patch updates the various tests in the testsuite to treat plxv > and pstxv as being vector loads/stores. (That is a not a very good description) The reason it is hard to review this patch is there was no rationale whatsoever

Re: [patch] PR jit/87808: Allow libgccjit to work without an external gcc driver

2021-07-12 Thread Matthias Klose
On 3/26/19 12:52 PM, Matthias Klose wrote: > On 22.03.19 23:00, David Malcolm wrote: >> On Thu, 2019-03-21 at 12:26 +0100, Matthias Klose wrote: >>> Fix PR jit/87808, the embedded driver still needing the external gcc >>> driver to >>> find the gcc_lib_dir. This can happen in a packaging context wh

Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514

2021-07-12 Thread Harald Anlauf via Gcc-patches
Hi Tobias, > On 10.06.21 20:52, Harald Anlauf via Fortran wrote: > > +static bool > > +substring_has_constant_len (gfc_expr *e) > > +{ > > + ptrdiff_t istart, iend; > > + size_t length; > > + bool equal_length = false; > > + > > + if (e->ts.type != BT_CHARACTER > > + || !e->ref > > +

Re: [PATCH 3/4] rs6000: Add support for SSE4.1 "blend" intrinsics

2021-07-12 Thread Paul A. Clarke via Gcc-patches
On Sun, Jul 11, 2021 at 11:29:24AM -0500, Bill Schmidt wrote: > On 7/11/21 11:17 AM, Bill Schmidt wrote: > > On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: > > > _mm_blend_epi16 and _mm_blendv_epi8 were added earlier. > > > Add these four to complete the set. > > > > > > 2021-06-29  Pau

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Segher Boessenkool
On Mon, Jul 12, 2021 at 12:47:43PM -0500, Bill Schmidt wrote: > On 7/12/21 12:16 PM, Michael Meissner wrote: > >>Shouldn't this last be { lp64 && has_arch_pwr10 } ? > >Nope. Because the power10 vector multiply is done in the vector unit, it > >can > >generate the vmulld instruction. > > Please d

Re: [PATCH 1/4] rs6000: Add support for SSE4.1 "test" intrinsics

2021-07-12 Thread Segher Boessenkool
Hi! On Sun, Jul 11, 2021 at 10:45:45AM -0500, Bill Schmidt wrote: > On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: > >--- a/gcc/config/rs6000/smmintrin.h > >+++ b/gcc/config/rs6000/smmintrin.h > >@@ -116,4 +116,54 @@ _mm_blendv_epi8 (__m128i __A, __m128i __B, __m128i > >__mask) > >

Re: [PATCH 2/4] rs6000: Add tests for SSE4.1 "test" intrinsics

2021-07-12 Thread Segher Boessenkool
On Sun, Jul 11, 2021 at 10:49:27AM -0500, Bill Schmidt wrote: > LGTM.  I can't approve, but recommend approval as is. Okay for trunk. Thanks! Segher > >2021-06-29 Paul A. Clarke > > > >gcc/testsuite/ChangeLog: > > * gcc.target/powerpc/sse4_1-ptest.c: Copy from > > gcc/testsuite

Re: [PATCH 4/4] rs6000: Add tests for SSE4.1 "blend" intrinsics

2021-07-12 Thread Segher Boessenkool
On Sun, Jul 11, 2021 at 11:19:56AM -0500, Bill Schmidt wrote: > Please resubmit this when you resubmit 3/4, in case any adjustments are > needed. It is testing if elsewhere-defined functions work according to its specification -- let's hope that doesn't change ;-) Segher

[COMMITTED] Add relation processing to ubsan builtins, and EVRP equality.

2021-07-12 Thread Andrew MacLeod via Gcc-patches
Ubsan builtins use the plus,minus and multiply operations under the covers, but they are not relation aware.  This patch queries for a relation between the 2 operands and passes that on to range-ops. This resolves gcc.dg/pr97505.c when operating in ranger-only mode, and with that, ranger-only

Re: [PATCH, rs6000] fix execution failure of parity_1.f90 on P10 [PR100952]

2021-07-12 Thread HAO CHEN GUI via Gcc-patches
Hi,    I refined the patch according to Segher's advice. Is this okay for trunk? Any recommendations? Thanks a lot. On 6/7/2021 上午 11:01, HAO CHEN GUI wrote: Hi,    The patch fixed the wrong "if" fall through in "cstore4" expand, which causes comparison pattern expanded twice on P10.    T

[PATCH v2] x86: Don't enable UINTR in 32-bit mode

2021-07-12 Thread H.J. Lu via Gcc-patches
UINTR is available only in 64-bit mode. Since the codegen target is unknown when the the gcc driver is processing -march=native, to properly handle UINTR for -march=native: 1. Pass arch[32|64] and tune[32|64] to host_detect_local_cpu to indicate 32-bit and 64-bit codegen. 2. Change ix86_option_ov

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 23:53, guojiufu via Gcc-patches wrote: On 2021-07-12 22:46, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 18:02, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 16:57, Richard Biener wrote: >> > On Mon, 12 Jul 2021, guoji

Re: ipa-modref: merge flags when adding escape

2021-07-12 Thread Alexandre Oliva
Ping? https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573137.html On Jun 18, 2021, Alexandre Oliva wrote: > for gcc/ChangeLog > * ipa-modref.c (modref_lattice::add_escape_point): Merge > min_flags into flags. > (modref_lattice::dump): Fix escape_point's min_flags dumping

drop va_list from formals if requested

2021-07-12 Thread Alexandre Oliva
I'm working on a feature that involves creating wrappers for some functions, using alternate means to pass variable argument lists to the wrapped versions. The split-out (wrapped) function shouldn't be stdarg, and though comments in m_always_copy_start in ipa_param_adjustments suggested that mak

adjust landing pads when changing main label

2021-07-12 Thread Alexandre Oliva
If an artificial label created for a landing pad ends up being dropped in favor of a user-supplied label, the user-supplied label inherits the landing pad index, but the post_landing_pad field is not adjusted to point to the new label. This patch fixes the problem, and adds verification that we

move unreachable user labels to entry point

2021-07-12 Thread Alexandre Oliva
pr42739.C, complicated by some extra wrappers and cleanups from a feature I'm working on, got me very confused because a user label ended up in a cleanup introduced by my pass, where it couldn't possibly have been initially. The current logic may move such an unreachable user label multiple time

avoid early reference to debug-only symbol

2021-07-12 Thread Alexandre Oliva
If some IPA pass replaces the only reference to a constant non-public non-automatic variable with its initializer, namely the address of another such variable, the former becomes unreferenced and it's discarded by symbol_table::remove_unreachable_nodes. It calls debug_hooks->late_global_decl whi

sync up new type indices for body adjustments

2021-07-12 Thread Alexandre Oliva
The logic in fill_vector_of_new_param_types may skip some parameters when pushing into m_new_types, but common_initialization doesn't take that into account, and may end up attempting to access the vector past its end when IPA_PARAM_OP_(NEW|SPLIT) operands appear after skipped _COPY ones. This p

fix typo in attr_fnspec::verify

2021-07-12 Thread Alexandre Oliva
Odd-numbered indices describing argument access sizes in the fnspec string can only hold 't' or a digit, as tested in the beginning of the case. When checking that the size-supplying argument does not have additional information associated with it, the test that excludes the 't' possibility look

[PATCH] [android] Disable large files when unsupported

2021-07-12 Thread Abraão de Santana via Gcc-patches
If C++ is enabled with Bionic on API Level < 24 ( and with NDK >= r15 as lower versions just ignore the issue ) you get errors of ::fgetpos and ::fsetpos error: 'fsetpos' has not been declared in '::' . The issue is that API Level < 24 doesn't implement large files (64 bit), so when _FILE_OFFSET_B

Re: [PATCH] [android] Disable large files when unsupported

2021-07-12 Thread Abraão de Santana via Gcc-patches
This could be better achieved by rewriting the libstdc++-v3/configure file to fail the test for _FILE_OFFSET_BITS = 64 when fpos is not defined. But this is kind of an odd spot to be, as this is an oddity from those specific conditions on Bionic and I don't know if it's worth devising a universal t

RE: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-12 Thread Wang, Pengfei via Gcc-patches
> Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. Can you please explain the behavior here? Is there difference between _Float16 and _Complex _Float16 when return? I.e., 1, In which case will _Float16 values return in both %xmm0 and %xmm1? 2, For a single _Float16 value, ar

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Michael Meissner via Gcc-patches
On Mon, Jul 12, 2021 at 10:32:47AM -0500, Bill Schmidt wrote: > Hi Mike, > >diff --git a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c > >b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c > >index 1269fe635c6..d5ed700b9bc 100644 > >--- a/gcc/testsuite/gcc.target/powerpc/pr8

Re: [Patch, fortran] PR fortran/100906/100907/100911/100914/100915/100916

2021-07-12 Thread Sandra Loosemore
On 6/13/21 12:36 PM, José Rui Faustino de Sousa via Gcc-patches wrote: Hi All! Proposed patch to: Bug 100906 - Bind(c): failure handling character with len/=1 Bug 100907 - Bind(c): failure handling wide character Bug 100911 - Bind(c): failure handling C_PTR Bug 100914 - Bind(c): errors handling

Re: [PATCH 10/10] vect: Reuse reduction accumulators between loops

2021-07-12 Thread Richard Biener via Gcc-patches
On Mon, Jul 12, 2021 at 7:55 PM Richard Sandiford wrote: > > Richard Biener via Gcc-patches writes: > > On Fri, Jul 9, 2021 at 3:12 PM Richard Sandiford > > wrote: > >> > >> Thanks for the review. > >> > >> Richard Biener writes: > >> >> @@ -588,6 +600,23 @@ public: > >> >>/* Unrolling fact

Re: [PATCH v2] docs: Add 'S' to Machine Constraints for RISC-V

2021-07-12 Thread Kito Cheng via Gcc-patches
committed to trunk. On Mon, Jul 12, 2021 at 12:48 PM Fangrui Song wrote: > > On 2021-07-12, Kito Cheng wrote: > >It was undocument before, but it might used in linux kernel for resolve > >code model issue, so LLVM community suggest we should document that, > >so that make it become supported/docu

Re: [patch] PR jit/87808: Allow libgccjit to work without an external gcc driver

2021-07-12 Thread Richard Biener via Gcc-patches
On Mon, Jul 12, 2021 at 11:00 PM Matthias Klose wrote: > > On 3/26/19 12:52 PM, Matthias Klose wrote: > > On 22.03.19 23:00, David Malcolm wrote: > >> On Thu, 2019-03-21 at 12:26 +0100, Matthias Klose wrote: > >>> Fix PR jit/87808, the embedded driver still needing the external gcc > >>> driver to

Re: [PATCH v2] x86: Don't enable UINTR in 32-bit mode

2021-07-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Jul 12, 2021 at 06:51:30PM -0700, H.J. Lu wrote: > @@ -404,9 +404,18 @@ const char *host_detect_local_cpu (int argc, const char > **argv) >if (argc < 1) > return NULL; I think it would be simpler to use 2 arguments instead of one. So change the above to if (argc < 2) > > - ar

<    1   2