On Mon, Jul 12, 2021 at 10:32:47AM -0500, Bill Schmidt wrote:
> > * gcc.target/powerpc/fold-vec-load-builtin_vec_xl-char.c:
There should be something after the ":". If you want to say the same
thing for many files, you can say somethin like "ditto" for all but the
first.
> >-/* { dg-final { scan-assembler "\t(lvx|lxv|lvsr|stxv)" } } */
> >+/* { dg-final { scan-assembler "\t(lvx|lxv|lvsr|stxv|plxv|pstxv)" } } */
Please use p?lxv etc.
> >-/* { dg-final { scan-assembler-times
> >{\mlxvw4x\M|\mlxvd2x\M|\mlxvx\M|\mlvx\M} 12 } } */
> >+/* { dg-final { scan-assembler-times
> >{\mlxvw4x\M|\mlxvd2x\M|\mlxvx\M|\mlvx\M|\mplxv\M} 12 } } */
Same here. p?lxvx? I suppose. Unless there is a reason plain lxv
would be bad here?
> >-/* { dg-final { scan-assembler-times {\mlxvd2x\M|\mlxvx\M|\mlvx\M} 6 } }
> >*/
> >+/* { dg-final { scan-assembler-times
> >{\mlxvd2x\M|\mlxvx\M|\mlvx\M|\mplxv\M} 6 } } */
Maybe you even want
/* { dg-final { scan-assembler-times {\m(?:p?lxv|lvx\M)} 6 } } */
or such?
> >-/* { dg-final { scan-assembler-times
> >{\mlxvw4x\M|\mlxvd2x\M|\mlxvx\M|\mlvx\M} 6 } } */
> >+/* { dg-final { scan-assembler-times
> >{\mlxvw4x\M|\mlxvd2x\M|\mlxvx\M|\mlvx\M|\mplxv\M} 6 } } */
(Something caused these lines to be wrapped btw, please fix that in the
mail config -- not sure where it happened)
> >--- a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
> >+++ b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
> >@@ -30,5 +30,5 @@ vector signed long long splats4(void)
> >
> > /* { dg-final { scan-assembler-times {\mvspltis[bhw]\M} 0 } } */
> > /* { dg-final { scan-assembler-times {\mvsl[bhwd]\M} 0 } } */
> >-/* { dg-final { scan-assembler-times {\mlvx\M|\mlxv\M|\mlxvd2x\M} 2 } } */
> >+/* { dg-final { scan-assembler-times
> >{\mlvx\M|\mlxv\M|\mlxvd2x\M|\mplvx\M} 2 } } */
>
> Oopsie. I think you mean "plxv" for this one.
So why did testing not catch it?
Thanks for the review Bill! :-)
Segher
