Hi! On Sun, Jul 11, 2021 at 10:45:45AM -0500, Bill Schmidt wrote: > On 6/29/21 1:08 PM, Paul A. Clarke via Gcc-patches wrote: > >--- a/gcc/config/rs6000/smmintrin.h > >+++ b/gcc/config/rs6000/smmintrin.h > >@@ -116,4 +116,54 @@ _mm_blendv_epi8 (__m128i __A, __m128i __B, __m128i > >__mask) > > return (__m128i) vec_sel ((__v16qu) __A, (__v16qu) __B, __lmask); > > } > > > >+extern __inline int __attribute__((__gnu_inline__, __always_inline__, > >__artificial__)) > Line too long, please fix here and below. (Existing cases can be left.)
I wouldn't bother in this case. There is no way to write these attribute lines in a reasonable way, it doesn't overflow 80 char by that much, and there isn't anything interesting at the end of line. You could put it on a line by itself, which helps for now because it won't get too long until you add another attribute ;-) There should be a space before (( though, and "extern" on definitions is superfluous. But I do not care much about that either -- this isn't a part of the compiler proper anyway :-) > LGTM; I can't approve, but recommend approval with line lengths fixed. It is okay for trunk with whatever changes you want to do. Thanks! Segher
