Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > One possibility is to add -fdump-tree-optimized and scan for > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" > "optimized" } } */ > resp. > /* { dg-final { scan-tree-dump "log \\(\[^\n\r]*\\); \\\[tail call\

Re: [PATCH] Fix PR 81721: ICE with PCH and Pragma warning and C++ operator

2019-05-16 Thread Joseph Myers
On Mon, 1 Apr 2019, apin...@marvell.com wrote: > From: Andrew Pinski > > Hi, > The problem here is the token->val.node is not saved over > a precompiled header for C++ operator. This can cause an > internal compiler error as we tried to print out the spelling > of the token as we assumed it w

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-16 Thread Segher Boessenkool
On Thu, May 16, 2019 at 12:03:14PM +0100, Iain Sandoe wrote: > I did a quick check... > > dfp.exp most (all?) fail despite > > /* { dg-require-effective-target powerpc_p9vector_ok } */ > > with errors like this… > > error: decimal floating point not supported for this target Okay, so the test

[PATCH] Remove incorrect assertion from filesystem::absolute

2019-05-16 Thread Jonathan Wakely
The assertion is wrong, it should be *s.end() == 0, but that's not allowed. Just remove it, but keep the comment. * src/c++17/fs_ops.cc (absolute(const path&, error_code&)) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Remove bogus assertion. Tested x86_64-w64-mingw32, committed to trunk. c

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: [...] We are not consistent here in `gnat_target_compile' anyway, as you can see from the two existing `concat' invocations, and also the `timeout=300' element. That is the GCC testsuite rather than DejaGnu itself, so it

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Maxim Kuvyrkov wrote: > The scripts convert svn history branch by branch. They rely on git-svn > on convert individual branches. Git-svn is a good tool for converting > individual branches. It is, however, either very slow at converting the > entire GCC repo, or goes int

[C++ Patch] PR 67184 ("Missed optimization with C++11 final specifier")

2019-05-16 Thread Paolo Carlini
Hi, when Roberto Agostino and I implemented the front-end devirtualization of final overriders we missed this case, where it comes from the base. It seems to me that by way of access_path the existing approach can be neatly extended. Tested x86_64-linux. Thanks, Paolo. /

Go patch committed: Add intrinsics for runtime/internal/sys functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang adds intrinsics for runtime/internal/sys functions. runtime/internal/sys.Ctz32/64 and Bswap32/64 are currently implemented with compiler builtin functions. But if they are called from another package, the compiler does not know and therefore cannot tu

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. Some of the changes in this patch are questionable. The diagnostics for

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Wed, 15 May 2019 at 16:57, Richard Sandiford wrote: > > Thanks for doing this. > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: This patch really exposes a significant deficiency in our current implementation of default_target_compile: the order of various flags can be significant, but we only have that order implicitly expressed in the code, whic

Re: [PATCH] soft-fp: Update soft-fp from glibc

2019-05-16 Thread Joseph Myers
On Wed, 15 May 2019, H.J. Lu wrote: > This patch is updating all soft-fp from glibc, most changes are > copyright years update, and changes other than years update are > > * soft-fp/extenddftf2.c: Use "_FP_W_TYPE_SIZE < 64" to check if > 4_FP_W_TYPEs are used for IEEE quad precision.

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Thu, 16 May 2019, Maxim Kuvyrkov wrote: > Let's avoid mixing the two discussions: (1) converting svn repo to git > (and getting community consensus to switch to git) and (2) deciding on > which branches to keep in the new repo. > > With git, we can always split away unneeded history by remov

Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang intrinsifies the runtime/internal/atomic functions. Currently the runtime/internal/atomic functions are implemented in C using C compiler intrinsics. This patch lets the Go frontend recognize these functions and turn them into intrinsics directly. Bo

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Martin Sebor
On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the c-family/ directory and pointed out by the -Wformat-diag warning. Some of the changes in this patch

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 16 May 2019 at 21:14, Richard Biener wrote: > > On Wed, May 15, 2019 at 4:40 AM wrote: > > > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop-ivopts.c (get_mem_type_

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /* { dg-final { scan-tree-dump "log

New Spanish PO file for 'gcc' (version 9.1.0)

2019-05-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: https://translationproject.org/latest/gcc/es.po (This file, 'gcc-9.1.0.es.po', has jus

[PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread linkw
From: Kewen Lin Hi, Previous version link: https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html Comparing with the previous version, I moved the generic parts of rs6000 target hook to IVOPTs. But I still kept the target hook as previous which checks some target specific criteria like inner

[PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-16 Thread Feng Xue OS
This patch is meant to give user a way to optimize away those empty loops which are impossible to be recognized by compiler, such as C++ STL container-based loop, void f (std::map &m)   {     for (auto it = m.begin (); it != m.end (); ++it);   } An option "-ffinite-loop" is added t

Re: LWG2593 Move from allocator state is preserved

2019-05-16 Thread François Dumont
2 other tests needed to be adapted in 21_strings. Attached patch applied. 2019-05-17  François Dumont     Move from state of allocators (LWG2593)     * include/bits/stl_deque.h     (_Deque_base(_Deque_base&&, false_type)): Remove.     (_Deque_base(_Deque_base&&, true_type)): Remove.     (_Deque

Re: Deque code cleanup and optimizations

2019-05-16 Thread François Dumont
Here is the simplified patch. I put back the _M_map checks, we'll see later if those can be removed.     * include/bits/stl_deque.h     (_Deque_iterator<>::__ptr_to): Remove, use std::__ptr_rebind.     (_Deque_base(_Deque_base&&, const allocator_type&)): New.     (_Deque_base::_Deque_impl_data):

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Kugan Vivekanandarajah
Hi, On Fri, 17 May 2019 at 13:37, wrote: > > From: Kewen Lin > > Hi, > > Previous version link: > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html > > Comparing with the previous version, I moved the generic > parts of rs6000 target hook to IVOPTs. But I still kept > the target hook as

Strenghten aliasing_component_refs_p

2019-05-16 Thread Jan Hubicka
Hi, this patch cuts walks in aliasing_component_refs_p if the type we look for can not fit into a given type by comparing their sizes. Similar logic already exists in indirect_ref_may_alias_decl_p. When we walk reference a.b.c.d.e looking for type x we only need to do it if sizeof(a)>=sizeof(x) an

Go patch committed: Make value method of direct iface take pointer

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang make value methods of direct interface types take a pointer argument. Currently, a value method of a direct interface type takes the value of the receiver, which is pointer shaped, as the first parameter. When this method is called through interface, w

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Kewen.Lin
on 2019/5/17 下午1:30, Kugan Vivekanandarajah wrote: > Hi, > > On Fri, 17 May 2019 at 13:37, wrote: >> >> From: Kewen Lin >> >> +/* Check whether number of iteration computation is too costly for doloop >> + transformation. It expands the gimple sequence to equivalent RTL insn >> + sequence,

Re: [PATCH] i386: Enable MMX intrinsics without SSE/SSE2/SSSE3

2019-05-16 Thread Uros Bizjak
On Thu, May 16, 2019 at 11:59 PM H.J. Lu wrote: > > Since MMX intrinsics are marked with SSE/SSE2/SSSE3 for SSE emulation, > enable them without SSE/SSE2/SSSE3 if MMX is enabled. > > Restore TARGET_3DNOW check, which was changed to TARGET_3DNOW_A by > revision 271235. > > gcc/ > > PR targe

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午11:09, JunMa 写道: 在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /*

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Fri, May 17, 2019 at 02:24:22PM +0800, JunMa wrote: > 2019-05-17  Jun Ma Two spaces before < rather than one. >     PR tree-optimization/90106 >     * gcc.dg/cdce3.c: New test. > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/cdce3.c > @@ -0,0 +1,12 @@ > +/* { dg-do compile } */ Just use one s

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Segher Boessenkool
Hi Kewen, On Thu, May 16, 2019 at 10:35:30PM -0500, li...@linux.ibm.com wrote: > 2) For the other part of target invalid stmt check, as the > hook invalid_within_doloop grep data shows, no all targets > need to check whether invalid instructions exist in doloop. > If we scan all stmts as generic,

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Segher Boessenkool
On Fri, May 17, 2019 at 03:30:41PM +1000, Kugan Vivekanandarajah wrote: > On Fri, 17 May 2019 at 13:37, wrote: > > + if (GET_CODE (body) == SET) > > + { > > + rtx set_val = XEXP (body, 1); > > + enum rtx_code code = GET_CODE (set_val); > > + enum rtx_class cls =

<    1   2