On Tue, 14 May 2019, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning.
Some of the changes in this patch are questionable. The diagnostics for attribute scalar_storage_order and visibility arguments use \" because the argument is a string constant not an identifier. So making those use %qs makes the diagnostics misleading, by suggesting an attribute argument is used that is not in fact valid for that attribute. -- Joseph S. Myers jos...@codesourcery.com