Maciej W. Rozycki wrote:
On Wed, 15 May 2019, Jacob Bachmeyer wrote:
[...]
We are not consistent here in `gnat_target_compile' anyway, as you can
see from the two existing `concat' invocations, and also the `timeout=300'
element.
That is the GCC testsuite rather than DejaGnu itself, so it is less of a
concern to me.
Perhaps {lappend options ada} might be simpler? Is placing ada at the
beginning of the list important?
It can't be last because we override the default compiler otherwise
selected by this option in `default_target_compile', and then options
passed in may override it further. Overall I felt it to be safer if we
placed the compiler type selection first rather than somewhere in the
middle.
This is probably a bug in DejaGnu, (those options should set defaults
rather than override whatever else has been given) but you will still
need to work around it for the installed base.
I hope it clears your concerns.
As far as the patch to GCC goes, I am not worried.
-- Jacob
