Re: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-22 Thread Richard Sandiford
Richard Biener writes: > On August 21, 2017 7:46:09 PM GMT+02:00, Richard Sandiford > wrote: >>Richard Biener writes: >>> On Tue, Aug 8, 2017 at 10:20 PM, Richard Kenner >>> wrote: > Correct. It is truncated for integer shift, but not simd shift > instructions. We generate a pattern in

Re: [PATCH] Fix fallout from VRP strict-overflow changes

2017-08-22 Thread Richard Biener
On Mon, 21 Aug 2017, Martin Sebor wrote: > On 08/21/2017 01:51 AM, Richard Biener wrote: > > On Sat, 19 Aug 2017, Andreas Schwab wrote: > > > > > On Aug 17 2017, Richard Biener wrote: > > > > > > > I was notifed I broke proper handling of undefined overflow in > > > > multiplicative ops handlin

Re: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-22 Thread Richard Biener
On Tue, Aug 22, 2017 at 9:29 AM, Richard Sandiford wrote: > Richard Biener writes: >> On August 21, 2017 7:46:09 PM GMT+02:00, Richard Sandiford >> wrote: >>>Richard Biener writes: On Tue, Aug 8, 2017 at 10:20 PM, Richard Kenner wrote: >> Correct. It is truncated for integer shif

Re: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-22 Thread Richard Sandiford
Richard Biener writes: > On Tue, Aug 22, 2017 at 9:29 AM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On August 21, 2017 7:46:09 PM GMT+02:00, Richard Sandiford >>> wrote: Richard Biener writes: > On Tue, Aug 8, 2017 at 10:20 PM, Richard Kenner > wrote: >>> Correc

Re: [PATCH, gcc-7-branch] Backport PR80038

2017-08-22 Thread Richard Biener
On Mon, Aug 21, 2017 at 5:39 PM, Xi Ruoyao wrote: > On 2017-08-21 23:37 +0800, Xi Ruoyao wrote: >> On 2017-04-25 09:30 -0600, Jeff Law wrote: >> > On 04/14/2017 06:44 PM, Xi Ruoyao wrote: >> > > On 2017-04-14 15:00 +0800, Xi Ruoyao wrote: >> > > > On 2017-04-13 09:05 +0200, Richard Biener wrote: >

[Ping~][PATCH, DWARF] Add DW_CFA_AARCH64_negate_ra_state to dwarf2.def/h and dwarfnames.c

2017-08-22 Thread Jiong Wang
On 10/08/17 17:39, Jiong Wang wrote: Hi, A new vendor CFA DW_CFA_AARCH64_negate_ra_state was introduced for ARMv8.3-A return address signing, it is multiplexing DW_CFA_GNU_window_save in CFA vendor extension space. This patch adds necessary code to make it available to external, the GDB

Re: [PING #2] [PATCH] enhance -Wrestrict to handle string built-ins (PR 78918)

2017-08-22 Thread Richard Biener
On Mon, Aug 21, 2017 at 10:10 PM, Martin Sebor wrote: > On 08/09/2017 10:14 AM, Jeff Law wrote: >> >> On 08/06/2017 05:08 PM, Martin Sebor wrote: >> Well, simply because the way as implemented isn't a must-alias query but maybe one that's good enough for warnings (reduces false posi

Re: [PATCH] Remove -feliminate-dwarf2-dups

2017-08-22 Thread Richard Biener
On Mon, 21 Aug 2017, Richard Biener wrote: > > This was agreed upon and now that early LTO debug landed here it is. > > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. > > In case the gcc_unreachable () gets through I'll instead remove the > if as noted in my followup TODO. Appl

[PATCH] Avoid re-allocating PHIs in split_edge

2017-08-22 Thread Richard Biener
The following patch makes sure to not grow the number of incoming edges in the destination when doing split_edge on GIMPLE. That's easy by first redirecting the existing edge to the destination to the new block rather than creating the new fallthru from the new block to the destination. Bootstra

Re: [PATCH] Switch on *.cc tests for g++ ASan

2017-08-22 Thread Richard Biener
On Wed, Aug 9, 2017 at 6:27 PM, Jeff Law wrote: > On 08/07/2017 11:59 PM, Slava Barinov wrote: >> * g++.dg/asan/asan.exp: Switch on *.cc tests. >> >> Signed-off-by: Slava Barinov >> --- >> gcc/testsuite/ChangeLog| 4 >> gcc/testsuite/g++.dg/asan/asan.exp | 2 +- >> 2 files

[AArch64, committed] Fix label mode

2017-08-22 Thread Richard Sandiford
This patch fixes a case where we tried to force a VOIDmode label into a DImode register, which led to invalid rtl that was previously undiagnosed. Tested on aarch64-linux-gnu and applied as obvious. Richard 2017-08-22 Richard Sandiford Alan Hayward David Sherwood

[AArch64] Remove use of wider vector modes

2017-08-22 Thread Richard Sandiford
The AArch64 port defined x2, x3 and x4 vector modes that were only used in the rtl for the AdvSIMD LD{2,3,4} patterns. It seems unlikely that this rtl would have led to any valid simplifications, since the values involved were unspecs that had a different number of operands from the non-dreg versi

[AArch64] Rename cmp_result iterator

2017-08-22 Thread Richard Sandiford
The comparison results provided by the V_cmp_result/v_cmp_result attribute were simply the corresponding integer vector. We'd also like to have easy access to the integer vector for SVE, but using "cmp_result" would be confusing because SVE comparisons return predicates instead of vectors. This p

[AArch64] Tweak aarch64_classify_address interface

2017-08-22 Thread Richard Sandiford
Previously aarch64_classify_address used an rtx code to distinguish LDP/STP addresses from normal addresses; the code was PARALLEL to select LDP/STP and anything else to select normal addresses. This patch replaces that parameter with a dedicated enum. The SVE port will add another enum value that

[AArch64] Tighten address register subreg checks

2017-08-22 Thread Richard Sandiford
Previously we allowed subregs of non-GPR modes to be base and index registers in non-strict mode. In practice such subregs will always require a reload, so we get better code by disallowing them. Tested on aarch64-linux-gnu. OK to install? Richard 2017-08-22 Richard Sandiford A

Re: std::list optimizations

2017-08-22 Thread Jonathan Wakely
On 21/08/17 21:14 +0200, François Dumont wrote: On 18/08/2017 22:04, Jonathan Wakely wrote: On 28/07/17 18:42 +0200, François Dumont wrote: Hi Completing execution of the testsuite revealed a bug. So here is the correct version of this patch. François On 21/07/2017 19:14, François Dumont

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Szabolcs Nagy
On 04/08/17 13:21, Richard Biener wrote: > On Thu, 3 Aug 2017, Jason Merrill wrote: >> OK if testing passes. > > Thanks. Meanwhile testing passed. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, LTO bootstrapped > on x86_64-unknown-linux-gnu (both all languages). I've successfully > bu

[PATCH] Fix PR81921

2017-08-22 Thread Richard Biener
The following patch fixes PR81921 (and LTO build of libgo) which I ran into when trying to enable free-lang-data for non-LTO compiles. free-lang-data forces a DECL_FUNCTION_SPECIFIC_TARGET for all functions so we have them ending up with target_option_default_node eventually which is something ix

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Richard Biener
On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > On 04/08/17 13:21, Richard Biener wrote: > > On Thu, 3 Aug 2017, Jason Merrill wrote: > >> OK if testing passes. > > > > Thanks. Meanwhile testing passed. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, LTO bootstrapped > > on x86_64-unkn

Re: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-22 Thread Wilco Dijkstra
Hi, The main reason we have this issue is that DImode can be treated as a vector of size 1. As a result we do not know whether the shift is an integer or SIMD instruction. One way around this is to never use the SIMD variant, another is to introduce V1DImode for vectors of size 1. Short term I be

RFC: Explicit move preference hints

2017-08-22 Thread Wilco Dijkstra
Hi, The register allocator inserts move preferences when an instruction has one or more dead sources in add_insn_allocno_copies. If an instruction doesn't have a matching constraint (eg. "0"), then any dead source is treated as a copy with all destination registers with a low priority. In reality

Re: Make more use of paradoxical_subreg_p

2017-08-22 Thread Richard Biener
On Mon, Aug 21, 2017 at 3:31 PM, Richard Sandiford wrote: > This patch makes more use of the existing paradoxical_subreg_p > predicate and also adds a version that operates on outer and > inner modes. > > Some of the affected tests were based on GET_MODE_SIZE rather than > GET_MODE_PRECISION and s

Re: ping [PATCH] [MSP430] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-08-22 Thread Jozef Lawrynowicz
On 02/08/2017 17:45, Joseph Myers wrote: On Wed, 2 Aug 2017, Jeff Law wrote: I think Joseph's suggestion for looking at partial float handling may be useful, though ia64's RFmode may be more interesting as it's not a multiple of 8 in bitsize. IF/KF modes on the ppc port have similar properties

Re: [PATCH 2/2] C: use full locations within c_parser_expr_list's vec

2017-08-22 Thread Andreas Schwab
On Aug 18 2017, David Malcolm wrote: > gcc/c/ChangeLog: > * c-parser.c (c_parser_expr_list): Use c_expr::get_location () > rather than peeking the location of the first token. > * c-tree.h (c_expr::get_location): New method. This breaks gcc.dg/Wtraditional-conversion-2.c on m68

[PATCH] Fix inliner assert with free-lang-data

2017-08-22 Thread Richard Biener
free-lang-data can end up unsharing TYPE_SIZE[_UNIT], the following patch fixes that similar to how verify_type_variant behaves to not ICE during inlining. Refactoring free-lang-data a bit could avoid the false unsharing. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2

[PATCH] Remove output_die_symbol

2017-08-22 Thread Richard Biener
This addresses one postponed feedback from the early LTO debug time by simply removing output_die_symbol from output_die as we have no ! die->comdat_type_p symbols left apart from the CU one produced by LTO debug which I added the guard for. Bootstrapped and tested on x86_64-unknown-linux-gnu, ok

Re: [PATCH] Fix PR81921

2017-08-22 Thread Uros Bizjak
On Tue, Aug 22, 2017 at 12:15 PM, Richard Biener wrote: > > The following patch fixes PR81921 (and LTO build of libgo) which I ran > into when trying to enable free-lang-data for non-LTO compiles. > > free-lang-data forces a DECL_FUNCTION_SPECIFIC_TARGET for all functions > so we have them ending

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Szabolcs Nagy
On 22/08/17 11:17, Richard Biener wrote: > On Tue, 22 Aug 2017, Szabolcs Nagy wrote: >> on aarch64_be-none-elf i see >> >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 (test for excess errors) >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 -O (test for excess errors) >> PASS->FAIL: gcc.dg/debu

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Richard Biener
On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > On 22/08/17 11:17, Richard Biener wrote: > > On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > >> on aarch64_be-none-elf i see > >> > >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 (test for excess errors) > >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2

Re: [PATCH] Fix PR81921

2017-08-22 Thread Richard Biener
On Tue, 22 Aug 2017, Uros Bizjak wrote: > On Tue, Aug 22, 2017 at 12:15 PM, Richard Biener wrote: > > > > The following patch fixes PR81921 (and LTO build of libgo) which I ran > > into when trying to enable free-lang-data for non-LTO compiles. > > > > free-lang-data forces a DECL_FUNCTION_SPECIF

Re: [PATCH] Fix PR81921

2017-08-22 Thread Kyrill Tkachov
Hi Richard, [roping in more aarch64 maintainers] On 22/08/17 13:27, Richard Biener wrote: On Tue, 22 Aug 2017, Uros Bizjak wrote: On Tue, Aug 22, 2017 at 12:15 PM, Richard Biener wrote: The following patch fixes PR81921 (and LTO build of libgo) which I ran into when trying to enable free-lan

Re: [PATCH] Fix PR81921

2017-08-22 Thread Segher Boessenkool
On Tue, Aug 22, 2017 at 02:27:28PM +0200, Richard Biener wrote: > Thanks. Of course this was copied by other targets (and the x86 > one maybe from the default). So the following is an extended patch. > > Ok for the rs6000 and aarch64 bits? Sure, rs6000 part is fine. Thanks! Segher >

Re: [PATCH] -fftz-math: assume that denorms _must_ be flushed to zero optimizations

2017-08-22 Thread Pekka Jääskeläinen
Hi Richard and Joseph, Replies for both inline: I wrote: >> Both the inputs and outputs must be flushed to zero in the HSAIL’s >> ‘ftz’ semantics. >> FTZ operations were previously always “explicit” in the BRIG FE output, like >> you >> propose here; there were builtin calls injected for all inp

Re: Fix inconsistent section flags

2017-08-22 Thread coypu
ping

Re: [PATCH] -fftz-math: assume that denorms _must_ be flushed to zero optimizations

2017-08-22 Thread Richard Biener
On Tue, Aug 22, 2017 at 3:28 PM, Pekka Jääskeläinen wrote: > Hi Richard and Joseph, > > Replies for both inline: > > I wrote: >>> Both the inputs and outputs must be flushed to zero in the HSAIL’s >>> ‘ftz’ semantics. >>> FTZ operations were previously always “explicit” in the BRIG FE output, >>>

Re: [PATCH] Switch on *.cc tests for g++ ASan

2017-08-22 Thread Jeff Law
On 08/22/2017 03:12 AM, Richard Biener wrote: > On Wed, Aug 9, 2017 at 6:27 PM, Jeff Law wrote: >> On 08/07/2017 11:59 PM, Slava Barinov wrote: >>> * g++.dg/asan/asan.exp: Switch on *.cc tests. >>> >>> Signed-off-by: Slava Barinov >>> --- >>> gcc/testsuite/ChangeLog| 4 >>>

Re: [PATCH] Avoid re-allocating PHIs in split_edge

2017-08-22 Thread Jeff Law
On 08/22/2017 03:03 AM, Richard Biener wrote: > > The following patch makes sure to not grow the number of incoming > edges in the destination when doing split_edge on GIMPLE. That's > easy by first redirecting the existing edge to the destination > to the new block rather than creating the new f

Re: [PATCH] Improve alloca alignment

2017-08-22 Thread Wilco Dijkstra
Jeff Law wrote: On 07/26/2017 05:29 PM, Wilco Dijkstra wrote: > > But then the check size_align % MAX_SUPPORTED_STACK_ALIGNMENT != 0 > > seems wrong too given that round_push uses a different alignment to align > > to. > I had started to dig into the history of this code, but just didn't have >

Re: PR81635: Use chrecs to help find related data refs

2017-08-22 Thread Richard Sandiford
Richard Biener writes: > On Fri, Aug 18, 2017 at 12:30 PM, Richard Biener > wrote: >> On Thu, Aug 17, 2017 at 2:24 PM, Bin.Cheng wrote: >>> On Thu, Aug 17, 2017 at 12:35 PM, Richard Sandiford >>> wrote: "Bin.Cheng" writes: > On Wed, Aug 16, 2017 at 6:50 PM, Richard Sandiford > wr

[PATCH][PR tree-optimization/81741] Throttle recording conditional equivalences

2017-08-22 Thread Jeff Law
This patch addresses some issues with conditional equivalences. First, it stops recording blindly recording conditional equivalences. Which leads to regressions... So for certain binary expressions (for example x - y), if we lookup the expression in the hash table and miss, we do a second lookup

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 02/08 - V3

2017-08-22 Thread Jeff Law
On 08/18/2017 08:05 AM, Richard Biener wrote: > On Mon, Jul 31, 2017 at 7:38 AM, Jeff Law wrote: >> >> This patch introduces generic mechanisms to protect the dynamically >> allocated stack space against stack-clash attacks. >> >> Changes since V2: >> >> Dynamic allocations can be emitted as unrol

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread Jeff Law
On 08/19/2017 12:22 PM, Martin Sebor wrote: > On 07/30/2017 11:35 PM, Jeff Law wrote: >> This patch introduces the stack clash protection options >> >> Changes since V2: >> >> Adds two new params. The first controls the size of the guard area. >> This controls the threshold for when a function pro

[PATCH] Add 'short_call' attribute for MIPS targets

2017-08-22 Thread Simon Atanasyan
Currently GCC supports 'long_call', 'far', and 'near' attributes. The 'long_call' and 'far' attributes are synonyms. This patch adds support for the 'short_call' attribute as a synonym for `near` to make this list complete, consistent with other targets, and compatible with attributes supported by

Re: [PATCH] [i386] PR 81850 Don't ignore -mabi=sysv on Cygwin/MinGW

2017-08-22 Thread Daniel Santos
On 08/22/2017 01:26 AM, Andreas Schwab wrote: > On Aug 21 2017, Daniel Santos wrote: > >> This is a problem that occured because of this code in >> ix86_option_override_internal: >> >> if (!opts_set->x_ix86_abi) >> opts->x_ix86_abi = DEFAULT_ABI; > Why is that a problem? Note opts_set vs op

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread Jeff Law
On 08/18/2017 08:01 AM, Richard Biener wrote: > On Mon, Jul 31, 2017 at 7:35 AM, Jeff Law wrote: >> This patch introduces the stack clash protection options >> >> Changes since V2: >> >> Adds two new params. The first controls the size of the guard area. >> This controls the threshold for when a

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Martin Sebor
On 08/21/2017 07:41 PM, Daniel Santos wrote: It took me a while to figure out how to do this so I figured that it should be in the docs. OK for trunk? * doc/install.texi: Add more details on selecting multiple tests. Thank you! It had taken me some time to figure this out. +The fil

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread David Malcolm
On Tue, 2017-08-22 at 09:35 -0600, Jeff Law wrote: > On 08/19/2017 12:22 PM, Martin Sebor wrote: > > On 07/30/2017 11:35 PM, Jeff Law wrote: > > > This patch introduces the stack clash protection options > > > > > > Changes since V2: > > > > > > Adds two new params. The first controls the size o

[PATCH][GCC][mid-end] Fix single use requirement for xorsign (x * copysign (1, y))

2017-08-22 Thread Tamar Christina
Hi All, This patch fixes the placement of the single-use requirement for xorsign. on `x = a * copysign (1, b)` the intention was that `copysign (1, b)` be single use, and not `x`. Requiring `x` to be single use blocks transformation where we do want it to occur. Regtested on aarch64-none-linux-g

[PATCH][GCC][mid-end] Add generic test for xorsign (x * copysign (1, y))

2017-08-22 Thread Tamar Christina
Hi All, Since XORSIGN is a mid-end transformation I'm adding a generic test to check for targets that support it if the transformation has been carried out or not in tree. Regtested on aarch64-none-linux-gnu, arm-none-eabi and x86_64-pc-linux-gnu with no regressions Ok for trunk? gcc/ 2017-08-2

Re: [PATCH][GCC][mid-end] Fix single use requirement for xorsign (x * copysign (1, y))

2017-08-22 Thread Tamar Christina
Sorry, forgot to add some maintainers :) From: gcc-patches-ow...@gcc.gnu.org on behalf of Tamar Christina Sent: Tuesday, August 22, 2017 5:27:23 PM To: gcc-patches@gcc.gnu.org Cc: nd; l...@redhat.com Subject: [PATCH][GCC][mid-end] Fix single use requireme

Re: [PATCH] Fix PR81921

2017-08-22 Thread Richard Earnshaw (lists)
On 22/08/17 13:55, Kyrill Tkachov wrote: > Hi Richard, > [roping in more aarch64 maintainers] > > On 22/08/17 13:27, Richard Biener wrote: >> On Tue, 22 Aug 2017, Uros Bizjak wrote: >> >>> On Tue, Aug 22, 2017 at 12:15 PM, Richard Biener >>> wrote: The following patch fixes PR81921 (and LTO

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread Jeff Law
On 08/22/2017 10:26 AM, David Malcolm wrote: >> Thanks. I settled on the %< %> style. None of the other warnings in >> that area use either. Otherwise I would have just selected whatever >> was >> most commonly used in that code. > > A nit that don't seem to have been mentioned: the patch refer

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Mike Stump
> On Aug 22, 2017, at 8:58 AM, Martin Sebor wrote: > > On 08/21/2017 07:41 PM, Daniel Santos wrote: >> It took me a while to figure out how to do this so I figured that it should >> be >> in the docs. OK for trunk? >> >> * doc/install.texi: Add more details on selecting multiple tests. >

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Mike Stump
On Aug 22, 2017, at 8:58 AM, Martin Sebor wrote: > > On 08/21/2017 07:41 PM, Daniel Santos wrote: >> It took me a while to figure out how to do this so I figured that it should >> be >> in the docs. OK for trunk? Oh, yeah, with the correction mentioned, Ok.

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Daniel Santos
On 08/22/2017 10:58 AM, Martin Sebor wrote: > On 08/21/2017 07:41 PM, Daniel Santos wrote: >> It took me a while to figure out how to do this so I figured that it >> should be >> in the docs. OK for trunk? >> >> * doc/install.texi: Add more details on selecting multiple tests. > > Thank you!

Re: [PATCH] Fix PR81921

2017-08-22 Thread Richard Biener
On August 22, 2017 6:38:55 PM GMT+02:00, "Richard Earnshaw (lists)" wrote: >On 22/08/17 13:55, Kyrill Tkachov wrote: >> Hi Richard, >> [roping in more aarch64 maintainers] >> >> On 22/08/17 13:27, Richard Biener wrote: >>> On Tue, 22 Aug 2017, Uros Bizjak wrote: >>> On Tue, Aug 22, 2017 at

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Mike Stump
On Aug 22, 2017, at 10:32 AM, Daniel Santos wrote: > >> I would suggest "escaped or quoted." >> The whole argument to RUNTESTFLAGS can be quoted in either single >> or double quotes and, AFAICT, so can the space-separated test >> names within it. > > Well, mysteriously, double quotes do not wor

[PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Daniel Santos
OK, how's this one? * doc/install.texi: Modify to add more details on running selected tests. Thanks, Daniel Signed-off-by: Daniel Santos --- gcc/doc/install.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 7

Re: Remove the frame size argument from function_prologue/epilogue

2017-08-22 Thread Mike Stump
On Aug 21, 2017, at 4:12 AM, Richard Sandiford wrote: > > Later patches will add support for frame sizes that are a run-time > invariant but not a compile-time constant. I'm assuming dwarf and C++ exceptions will remain working. :-)

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Mike Stump
On Aug 22, 2017, at 10:44 AM, Daniel Santos wrote: > > OK, how's this one? Ok.

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Daniel Santos
On 08/22/2017 12:32 PM, Mike Stump wrote: > On Aug 22, 2017, at 10:32 AM, Daniel Santos wrote: >>> I would suggest "escaped or quoted." >>> The whole argument to RUNTESTFLAGS can be quoted in either single >>> or double quotes and, AFAICT, so can the space-separated test >>> names within it. >> W

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Daniel Santos
On 08/22/2017 12:32 PM, Mike Stump wrote: > On Aug 22, 2017, at 10:32 AM, Daniel Santos wrote: >>> I would suggest "escaped or quoted." >>> The whole argument to RUNTESTFLAGS can be quoted in either single >>> or double quotes and, AFAICT, so can the space-separated test >>> names within it. >> W

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Daniel Santos
OK, the problem is at line 4014 of gcc/Makefile.in: $(MAKE) TESTSUITEDIR="$(TESTSUITEDIR)" RUNTESTFLAGS="$(RUNTESTFLAGS)" \ check-parallel-$* \ Even worse, one can inject arbitrary shell commands here, not that I can think of a scenario where it would be an actual security

[PATCH, rs6000] (v2) Testcase coverage for vec_perm built-ins

2017-08-22 Thread Will Schmidt
Hi, [PATCH, rs6000] (v2) Testcase coverage for vec_perm built-ins Add some Testcase coverage for the vector permute intrinsics. (v2) Revisited and reworked all of the requires statements throughout this batch. Everything specifies -maltivec except the double and long long tests, which require

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

2017-08-22 Thread Mike Stump
On Aug 22, 2017, at 11:53 AM, Daniel Santos wrote: > > OK, the problem is at line 4014 of gcc/Makefile.in: > > $(MAKE) TESTSUITEDIR="$(TESTSUITEDIR)" > RUNTESTFLAGS="$(RUNTESTFLAGS)" \ >check-parallel-$* \ So, this is typical of sh scripting. Most kids don't quote and know

[PATCH] [i386] PR 81850 Don't ignore -mabi=sysv on Cygwin/MinGW

2017-08-22 Thread Daniel Santos
> Please add UNKNOWN_ABI to the enum and initialize -mabi in i386.opt to > UNKNOWN_ABI. It would seem to me that UNSPECIFIED_ABI would be a better value name. Also, I don't really understand what opts_set and opts are, except that I had guessed opts_set is what the user asked for (or didn't ask f

Re: [PATCH] [i386] PR 81850 Don't ignore -mabi=sysv on Cygwin/MinGW

2017-08-22 Thread Uros Bizjak
On Tue, Aug 22, 2017 at 9:47 PM, Daniel Santos wrote: >> Please add UNKNOWN_ABI to the enum and initialize -mabi in i386.opt to >> UNKNOWN_ABI. > > It would seem to me that UNSPECIFIED_ABI would be a better value name. > > Also, I don't really understand what opts_set and opts are, except that I h

Re: Statement Frontier Notes, Location Views, and Inlined Entry Point Markers

2017-08-22 Thread Alexandre Oliva
On Aug 21, 2017, Richard Biener wrote: > On Fri, Aug 18, 2017 at 11:20 PM, Alexandre Oliva wrote: >> Besides implementing these new features, the patch contains multiple >> fixes for -fcompare-debug errors detected at various optimization >> levels, arising mainly from the introduction of begin

Re: [PATCH, rs6000] (v2) Testcase coverage for vec_perm built-ins

2017-08-22 Thread Segher Boessenkool
Hi! On Tue, Aug 22, 2017 at 02:03:03PM -0500, Will Schmidt wrote: > (v2) Revisited and reworked all of the requires statements > throughout this batch. Everything specifies -maltivec except > the double and long long tests, which require vsx. > > (re-) Tested across power platforms. OK for tru

[PATCH v4 0/4] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f

2017-08-22 Thread Daniel Santos
I had to fix a few things for x32 compatibility and I this is ready now. H.J. tested on machine with avx512 (including x32) and I've tested both native x32 and normal x86_64 with m64, m32 and mx32 and all is well. I've made more changes to the tests so I'm just submitting a version 2 of the whole

Re: Statement Frontier Notes, Location Views, and Inlined Entry Point Markers

2017-08-22 Thread Alexandre Oliva
On Aug 21, 2017, Richard Biener wrote: > +gno-statement-frontiers > +Common Driver RejectNegative Var(debug_nonbind_markers_p, 0) Init(2) > +Don't enforce progressive recommended breakpoint locations. > + > +gstatement-frontiers > +Common Driver RejectNegative Var(debug_nonbind_markers_p, 1) > +E

[PATCH 1/4] [i386] Correct comments, add assertions to sp_valid_at and fp_valid_at

2017-08-22 Thread Daniel Santos
When we realign the stack frame (without DRAP), there may be a range of CFA offsets that should never be touched because they are alignment padding and any reference to them is almost certainly an error. Previously, only the offset of where the realigned stack frame starts was recorded and checked

[PATCH 2/4] [i386] Modify ix86_compute_frame_layout

2017-08-22 Thread Daniel Santos
These changes affect how the stack frame is calculated from the region starting at frame.reg_save_offset until frame.frame_pointer_offset, which includes either the stub save area or the (inline) SSE register save area and the va_args register save area. The calculation used when not realigning th

[PATCH 3/4] [i386] Modify SP realignment in ix86_expand_prologue, et. al.

2017-08-22 Thread Daniel Santos
My first version of this patch inited m->fs.sp_realigned_fp_last with the value of m->fs.sp_offset prior to performing the stack realignment. I had forgotten, however, that when we're saving GP regs using MOV that we delay SP modification as long as possible so that the value of m->fs.sp_offset at

[PATCH 4/4] [i386, testsuite] Add tests, fix bug in check_avx2_hw_available

2017-08-22 Thread Daniel Santos
Changes to lib/target-supports.exp and documentation: * Add effective-targets avx512f and avx512f_runtime (needed for new tests). * Corrects bug in check_avx2_hw_available. * Adds documentation for effective-targets avx2, avx2_runtime (both missing), avx512f and avx512f_runtime. The following

Re: [PATCH] [i386] PR 81850 Don't ignore -mabi=sysv on Cygwin/MinGW

2017-08-22 Thread JonY
On 08/22/2017 06:32 AM, Uros Bizjak wrote: > On Tue, Aug 22, 2017 at 4:10 AM, Daniel Santos > wrote: > >> This is a problem that occured because of this code in >> ix86_option_override_internal: >> >> if (!opts_set->x_ix86_abi) >> opts->x_ix86_abi = DEFAULT_ABI; >> >> I tested this along w

Re: [PATCH 5/3] C++ bits to improve detection of attribute conflicts (PR 81544)

2017-08-22 Thread Jason Merrill
The C and C++ front ends already have a diagnose_mismatched_attributes function, which seems like the natural place to add more conflict checking. Jason

[libcc1] Improve detection of triplet on compiler names

2017-08-22 Thread Sergio Durigan Junior
Hi there, This is a series of two patches, one for GDB and one for GCC, which aims to improve the detection and handling of triplets present on compiler names. The motivation for this series was mostly the fact that GDB's "compile" command is broken on Debian unstable, as can be seen here:

[PATCH 2/2] [GDB] Add trailing dash on triplet regexp

2017-08-22 Thread Sergio Durigan Junior
This is the GDB patch. It is very simple, and just a necessary adjustment needed because of the modifications made in the "make_regexp" functions on libcc1. Now, GDB will provide a full regexp for triplet names, including the trailing dash ("-"). Therefore, we will have a regexp that truly match

[PATCH 1/2] [GCC] Improve regexp handling on libc[cp]1::compiler_triplet_regexp::find

2017-08-22 Thread Sergio Durigan Junior
This is the GCC patch. It adjusts the behaviour of make_regexp in order to not add the "-" at the end of the triplet regexp. This is now GDB's responsibility. It also improves the 'find' methods of both libcc1::compiler_triplet_regexp and libcp1::compiler_triplet_regexp classes by implementing a

Re: [PATCH] RTEMS: Add GCC Runtime Library Exception

2017-08-22 Thread Sebastian Huber
Hello Jeff, On 03/08/17 07:11, Sebastian Huber wrote: On 02/08/17 21:30, Jeff Law wrote: On 07/24/2017 12:03 AM, Sebastian Huber wrote: gcc/ PR libgcc/61152 * aarch64/rtems.h: Add GCC Runtime Library Exception. Format changes. * arm/rtems.h: Likewise. * bfin/rtems.h: Like

Re: [PATCH] [i386] PR 81850 Don't ignore -mabi=sysv on Cygwin/MinGW

2017-08-22 Thread Daniel Santos
On 08/22/2017 03:00 PM, Uros Bizjak wrote: > On Tue, Aug 22, 2017 at 9:47 PM, Daniel Santos > wrote: >>> Please add UNKNOWN_ABI to the enum and initialize -mabi in i386.opt to >>> UNKNOWN_ABI. >> It would seem to me that UNSPECIFIED_ABI would be a better value name. >> >> Also, I don't really und

Re: [PATCH] [i386] PR 81850 Don't ignore -mabi=sysv on Cygwin/MinGW

2017-08-22 Thread Uros Bizjak
On Wed, Aug 23, 2017 at 7:23 AM, Daniel Santos wrote: > On 08/22/2017 03:00 PM, Uros Bizjak wrote: >> On Tue, Aug 22, 2017 at 9:47 PM, Daniel Santos >> wrote: Please add UNKNOWN_ABI to the enum and initialize -mabi in i386.opt to UNKNOWN_ABI. >>> It would seem to me that UNSPECIFIED_AB