On 08/22/2017 06:32 AM, Uros Bizjak wrote: > On Tue, Aug 22, 2017 at 4:10 AM, Daniel Santos <daniel.san...@pobox.com> > wrote: > >> This is a problem that occured because of this code in >> ix86_option_override_internal: >> >> if (!opts_set->x_ix86_abi) >> opts->x_ix86_abi = DEFAULT_ABI; >> >> I tested this along with my other patches. OK for trunk? >> >> * config/i386/i386-opts.h (enum calling_abi): Modify so that no legal >> values are equivalent to zero. > > Please add UNKNOWN_ABI to the enum and initialize -mabi in i386.opt to > UNKNOWN_ABI. > > Then change the above condition to > > if (opts_set->x_ix86_abi == UNKNOWN_ABI) > > We can't just init -mabi to DEFAULT_ABI, sinde this is selected at > runtime. Maybe a comment should be added for UNKNOWN_ABI, that it is > overriden in ix86_option_override_internal. > > Uros.
This sounds sensible if there was ever a time some new ABI is added for x86.
signature.asc
Description: OpenPGP digital signature
