Re: [PATCH 0/5] Fix handling of word subregs of wide registers

2014-09-22 Thread Richard Sandiford
Jeff Law writes: > On 09/19/14 01:23, Richard Sandiford wrote: >> Jeff Law writes: >>> On 09/18/14 04:07, Richard Sandiford wrote: This series is a cleaned-up version of: https://gcc.gnu.org/ml/gcc/2014-03/msg00163.html The underlying problem is that the semantics o

Re: [PATCH 4/5] Generalise invalid_mode_change_p

2014-09-22 Thread Richard Sandiford
Jeff Law writes: > On 09/18/14 04:25, Richard Sandiford wrote: >> This is the main patch for the bug. We should treat a register as invalid >> for a mode change if simplify_subreg_regno cannot provide a new register >> number for the result. We should treat a class as invalid for a mode change >

Re: Speedup int_bit_from_pos

2014-09-22 Thread Richard Biener
On Sun, 21 Sep 2014, Jan Hubicka wrote: > > > > Please omit static from inline functions. > > Yep, I suppose we want to drop static in all inlines? I can make patch for > that. > > > > Also one notable difference with your patches is that the fits hwi is now > > not tested on the result but o

Re: [BUILDROBOT] genrecog fix uncovers problem in bfin.md (was: [Patch] Teach genrecog/genoutput that scratch registers require write constraint modifiers)

2014-09-22 Thread James Greenhalgh
On Sat, Sep 20, 2014 at 08:40:01PM +0100, Jan-Benedict Glaw wrote: > Hi! > > On Thu, 2014-09-18 11:19:21 +0100, James Greenhalgh > wrote: > > As discussed in https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01334.html > > The construct > > > > (clobber (match_scratch 0 "r")) > > > > is invalid

Re: [PATCH][match-and-simplify] User defined predicates

2014-09-22 Thread Richard Biener
On Tue, 16 Sep 2014, Marc Glisse wrote: > On Tue, 16 Sep 2014, Richard Biener wrote: > > > The following adds the ability to write predicates using patterns > > with an example following negate_expr_p which already has a > > use in comparison folding (via its if c-expr). > > > > The syntax is as

Re: Stream ODR types

2014-09-22 Thread Richard Biener
On Wed, 17 Sep 2014, Jan Hubicka wrote: > Hi, > this patch renames types reported by Wodr during LTO bootstrap. > > Bootrapping/regtesting in progress, OK if it passes? > > Honza > > * tree-ssa-ccp.c (prop_value_d): Rename to ... > (ccp_prop_value_t): ... this one to avoid ODR viola

Re: [PATCH] Extended if-conversion for loops marked with pragma omp simd.

2014-09-22 Thread Yuri Rumyantsev
Richard, here is reduced patch (part.1) which was reduced almost twice. Let's me also answer on your comments. 1. I really use edge field 'aux' to keep predicate for critical edges. My previous code was not correct and now it looks like: if (EDGE_COUNT (b->succs) == 1 || EDGE_COUNT (e->dest->p

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-22 Thread Nathan Sidwell
On 09/21/14 18:58, Xinliang David Li wrote: the intent is that that points to the gcov_info object of the object file containing the live version of the function. I couldn't quite get this to work though -- it involves emitting a function's gcov_fn_info decl in the same comdat group as the func

Re: ptx preliminary address space fixes [4/4]

2014-09-22 Thread Richard Biener
On Wed, Sep 17, 2014 at 10:15 PM, Bernd Schmidt wrote: > On 09/11/2014 01:41 PM, Richard Biener wrote: >> >> On Thu, Sep 11, 2014 at 12:12 PM, Bernd Schmidt >> wrote: >>> >>> This one isn't a wrong-code issue, just a missed optimization. The >>> strlen >>> optimizations need to be made to look t

Re: ptx preliminary rtl patches [3/4]

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 8:57 PM, Bernd Schmidt wrote: > On 09/12/2014 10:04 AM, Richard Biener wrote: >> >> On Thu, Sep 11, 2014 at 6:36 PM, Bernd Schmidt >> wrote: >>> >>> I strongly disagree. It's the same as for any other integer - there's one >>> sign bit, and since there aren't any other bit

Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 10:38 PM, Jeff Law wrote: > On 09/18/14 13:01, Bernd Schmidt wrote: >> >> This fixes an issue on ptx where we fail to output a declaration for a >> variable. The testcase is c-torture/compile/pr34856.c, and the cause of >> the problem is that the variable g is never inserte

Re: [PATCH] PR63300 'const volatile' sometimes stripped in debug info.

2014-09-22 Thread Andreas Arnez
On Sat, Sep 20 2014, Mark Wielaard wrote: > When adding DW_TAG_restrict_type I made a mistake when updating the > code that handled types with multiple modifiers. This patch fixes it > by putting the logic for finding the "sub-qualified" type in a separate > function and fall back to adding the mo

Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 10:58 AM, Richard Biener wrote: > On Thu, Sep 18, 2014 at 10:38 PM, Jeff Law wrote: >> On 09/18/14 13:01, Bernd Schmidt wrote: >>> >>> This fixes an issue on ptx where we fail to output a declaration for a >>> variable. The testcase is c-torture/compile/pr34856.c, and the

Re: [PATCH 0/5] Fix handling of word subregs of wide registers

2014-09-22 Thread Andrew Pinski
On Thu, Sep 18, 2014 at 3:07 AM, Richard Sandiford wrote: > This series is a cleaned-up version of: > > https://gcc.gnu.org/ml/gcc/2014-03/msg00163.html > > The underlying problem is that the semantics of subregs depend on the > word size. You can't have a subreg for byte 2 of a 4-byte word,

Re: [BUILDROBOT] genrecog fix uncovers problem in bfin.md (was: [Patch] Teach genrecog/genoutput that scratch registers require write constraint modifiers)

2014-09-22 Thread Jan-Benedict Glaw
On Mon, 2014-09-22 08:58:34 +0100, James Greenhalgh wrote: > On Sat, Sep 20, 2014 at 08:40:01PM +0100, Jan-Benedict Glaw wrote: > > My build robot shows a new build error, which I guess is > > caused/uncovered by your genrecog change on bfin-elf (see eg. build > > http://toolchain.lug-owl.de/buil

Re: Fix ICE with ODR mering and variable sized types

2014-09-22 Thread Richard Biener
On Fri, Sep 19, 2014 at 8:55 PM, Jan Hubicka wrote: > Hi, > this patch fixes ICE by avoiding mangling of types with variadic size (those > are > not really supported). Bootstrapped/regtested x86_64-linux, tested with > libreoffice, > comitted. Hmm, but how do global vars end up having variadic

Re: Small fix for walking constructors

2014-09-22 Thread Bernd Schmidt
On 09/22/2014 11:00 AM, Richard Biener wrote: It seems to me that walk_stmt_load_store_addr_ops is called on bogus input. The function is supposed to be called on GIMPLE stmts and in GIMPLE stmts CONSTRUCTORs may _not_ have conversions in their elements. Please revert if you have applied alread

Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 11:00 AM, Richard Biener wrote: > On Mon, Sep 22, 2014 at 10:58 AM, Richard Biener > wrote: >> On Thu, Sep 18, 2014 at 10:38 PM, Jeff Law wrote: >>> On 09/18/14 13:01, Bernd Schmidt wrote: This fixes an issue on ptx where we fail to output a declaration for a >>

Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 11:52 AM, Bernd Schmidt wrote: > On 09/22/2014 11:00 AM, Richard Biener wrote: >>> >>> It seems to me that walk_stmt_load_store_addr_ops is called on >>> bogus input. The function is supposed to be called on GIMPLE >>> stmts and in GIMPLE stmts CONSTRUCTORs may _not_ have

Re: [Patch bfin] Fixup use of constraints in define_split

2014-09-22 Thread Bernd Schmidt
On 09/19/2014 11:32 PM, James Greenhalgh wrote: As with the earlier patch for sh ( https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01627.html ), this fixes the fallout caused by https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01615.html. These are build failures, and the fixes are "obvious", but I d

Re: [PATCH] gcc-gdb-test.exp: Handle old GDB "short int" and "long int" types.

2014-09-22 Thread Jakub Jelinek
On Sat, Sep 20, 2014 at 11:21:25PM +0200, Mark Wielaard wrote: > Old GDB might show short and long as short int and long int. This made > gcc.dg/guality/const-volatile.c ans restrict.c fail on older GDBs. > According to the patch that changed this in newer versions of GDB > this was a bug: https:/

Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

2014-09-22 Thread Jiong Wang
On 19/09/14 17:19, Jeff Law wrote: On 09/19/14 10:02, Jiong Wang wrote: On 19/09/14 16:49, Jeff Law wrote: Probably. Though I'd be a bit concerned with next_block->next_bb. Wouldn't it be safer to stash away the relevant basic block prior to the call to split_edge, then use that saved copy.

Re: [PATCH] Improve prepare_shrink_wrap to sink more instructions

2014-09-22 Thread Jiong Wang
On 19/09/14 21:43, Jeff Law wrote: On 09/15/14 08:33, Jiong Wang wrote: Jeff, thanks, I partially understand your meaning here. take the function "ira_implicitly_set_insn_hard_regs" in ira-lives.c for example, when generating address rtl, gcc will automatically generate "const" op

Re: [PATCH] remove duplicated lines in gcc/fortran/resolve.c

2014-09-22 Thread Dominique d'Humières
Le 21 sept. 2014 à 10:44, FX a écrit : >> AFAICT the lines 11200-11222 in gcc/fortran/resolve.c are a copy of >> the lines 11176-11198. > > The duplicates were introduced by revision 126468, an unrelated patch, after > the original commit of the code as 126466. It looks like a svn/patch mishap

Re: [PATCH 2/14][Vectorizer] Make REDUC_xxx_EXPR tree codes produce a scalar result

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 1:50 PM, Alan Lawrence wrote: > This fixes PR/61114 by redefining the REDUC_{MIN,MAX,PLUS}_EXPR tree codes. > > These are presently documented as producing a vector with the result in > element 0, and this is inconsistent with their use in tree-vect-loop.c > (which on bigen

[committed] Fix -fcompare-debug issue in simd clone creation (PR debug/63328)

2014-09-22 Thread Jakub Jelinek
Hi! Obviously, it is a bad idea to emit gimple assign stmts for temporaries needed by debug stmts, we have to emit debug temporaries instead, otherwise we generate different code between -g0 and -g. Tested on x86_64-linux, committed to trunk/4.9. 2014-09-22 Jakub Jelinek PR debug/6332

Re: [PATCH 3/14] Add new optabs for reducing vectors to scalars

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 1:54 PM, Alan Lawrence wrote: > These match their corresponding tree codes, by taking a vector and returning > a scalar; this is more architecturally neutral than the (somewhat loosely > defined) previous optab that took a vector and returned a vector with the > result in t

Re: [PATCH 7/14][Testsuite] Add tests of reductions using whole-vector-shifts (multiplication)

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 2:19 PM, Alan Lawrence wrote: > For reduction operations (e.g. multiply) that don't have such a tree code > ,or where the target platform doesn't define an optab handler for the tree > code, we can perform the reduction using a series of log(N) shifts (where N > = #elements

Re: [PATCH 8/14][Testsuite] Add tests of reductions using whole-vector-shifts (ior)

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 2:25 PM, Alan Lawrence wrote: > These are like the previous patch, but using | rather than * - I was unable > to get the previous test to pass on PowerPC and MIPS. > > I note there is no inherent vector operation here - a bitwise OR across a > word, and a "reduction via shi

RE: [PATCH 0/5] Fix handling of word subregs of wide registers

2014-09-22 Thread Ajit Kumar Agarwal
-Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Richard Sandiford Sent: Monday, September 22, 2014 12:54 PM To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 0/5] Fix handling of word subregs of wide registers Jeff La

Re: [PATCH 9/14] Enforce whole-vector-shifts to always be by a whole number of elements

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 2:27 PM, Alan Lawrence wrote: > The VEC_RSHIFT_EXPR is only ever used by the vectorizer in tree-vect-loop.c > (vect_create_epilog_for_reduction), to shift the vector by a whole number of > elements. The tree code allows more general shifts but only for integral > types. Thi

Re: [PATCH 13/14][AArch64_be] Fix vec_shr pattern to correctly implement endianness-neutral optab

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 2:45 PM, Alan Lawrence wrote: > The previous patch broke aarch64_be by redefining VEC_RSHIFT_EXPR / > vec_shr_optab to always shift the vector towards gcc's element 0. This fixes > aarch64_be to do that. > > check-gcc on aarch64-none-elf (no changes) and aarch64_be-none-elf

Re: [PATCH 11/14] Remove VEC_LSHIFT_EXPR and vec_shl_optab

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 2:35 PM, Alan Lawrence wrote: > The VEC_LSHIFT_EXPR tree code, and the corresponding vec_shl_optab, seem to > have been added for completeness, providing a counterpart to VEC_RSHIFT_EXPR > and vec_shr_optab. However, whereas VEC_RSHIFT_EXPRs are generated (only) by > the ve

Re: [PATCH 14/14][Vectorizer] Tidy up vect_create_epilog / use_scalar_result

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 2:48 PM, Alan Lawrence wrote: > Following earlier patches, vect_create_epilog_for_reduction contains exactly > one case where extract_scalar_result==true. Hence, move the code 'if > (extract_scalar_result)' there, and tidy-up/remove some variables. > > bootstrapped on x86_6

Re: [PATCH 12/14][Vectorizer] Redefine VEC_RSHIFT_EXPR and vec_shr_optab as endianness-neutral

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 2:42 PM, Alan Lawrence wrote: > The direction of VEC_RSHIFT_EXPR has been endian-dependent, contrary to the > general principles of tree. This patch updates fold-const and the vectorizer > (the only place where such expressions are created), such that > VEC_RSHIFT_EXPR alwa

Re: Fix i386 FP_TRAPPING_EXCEPTIONS

2014-09-22 Thread Joseph S. Myers
On Fri, 19 Sep 2014, Joseph S. Myers wrote: > On Thu, 18 Sep 2014, Joseph S. Myers wrote: > > > On Thu, 18 Sep 2014, Uros Bizjak wrote: > > > > > OK for mainline and release branches. > > > > I've omitted ia64 from the targets in the testcase in the release branch > > version, given the lack o

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-22 Thread Alan Lawrence
Well, I haven't looked into this in detail: I've gone only as far as * swapping emit-rtl.o between 'good' compiles (svn r214042) and 'bad' compiles (r214043), finding that the critical difference is in the emit-rtl.o generated by r214043; *looking at the relocations in the 'bad' emit_rtl.o,

[AArch64] Re: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

2014-09-22 Thread Alan Lawrence
Ok thanks Jeff. In that case I think I should draw this to the attention of the AArch64 maintainers to check the testsuite updates are OK before I commit...? Methinks it may be possible to get further, or at least increase our confidence, if I "mock" out try_widen_shift_mode, and/or try injecti

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 1:10 PM, Alan Lawrence wrote: > Well, I haven't looked into this in detail: I've gone only as far as > * swapping emit-rtl.o between 'good' compiles (svn r214042) and 'bad' > compiles (r214043), finding that the critical difference is in the > emit-rtl.o generated by r214

Re: [PATCH 0/14+2][Vectorizer] Made reductions endianness-neutral, fixes PR/61114

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 1:41 PM, Alan Lawrence wrote: > The end goal here is to remove this code from tree-vect-loop.c > (vect_create_epilog_for_reduction): > > if (BYTES_BIG_ENDIAN) > bitpos = size_binop (MULT_EXPR, > bitsize_int (TYPE_VECTOR_SUBPARTS (v

Re: [PATCH 0/5] Fix handling of word subregs of wide registers

2014-09-22 Thread Richard Sandiford
Ajit Kumar Agarwal writes: > Jeff Law writes: >> On 09/19/14 01:23, Richard Sandiford wrote: >>> Jeff Law writes: On 09/18/14 04:07, Richard Sandiford wrote: > This series is a cleaned-up version of: > > https://gcc.gnu.org/ml/gcc/2014-03/msg00163.html > > The unde

Re: [PATCH 0/14+2][Vectorizer] Made reductions endianness-neutral, fixes PR/61114

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 1:21 PM, Richard Biener wrote: > On Thu, Sep 18, 2014 at 1:41 PM, Alan Lawrence wrote: >> The end goal here is to remove this code from tree-vect-loop.c >> (vect_create_epilog_for_reduction): >> >> if (BYTES_BIG_ENDIAN) >> bitpos = size_binop (MULT_EXPR, >>

Re: [PATCH 0/5] Fix handling of word subregs of wide registers

2014-09-22 Thread Richard Sandiford
Andrew Pinski writes: > On Thu, Sep 18, 2014 at 3:07 AM, Richard Sandiford > wrote: >> This series is a cleaned-up version of: >> >> https://gcc.gnu.org/ml/gcc/2014-03/msg00163.html >> >> The underlying problem is that the semantics of subregs depend on the >> word size. You can't have a sub

Re: [PATCH] Fix ubsan ICE on invalid (PR sanitizer/61272)

2014-09-22 Thread Marek Polacek
On Wed, May 21, 2014 at 08:58:57PM +0200, Jakub Jelinek wrote: > On Wed, May 21, 2014 at 08:46:22PM +0200, Marek Polacek wrote: > > 2014-05-21 Marek Polacek > > > > PR sanitizer/61272 > > * ubsan.c (is_ubsan_builtin_p): Turn assert into a condition. > > > > * g++.dg/ubsan/pr61272.C

RE: [PATCH 0/5] Fix handling of word subregs of wide registers

2014-09-22 Thread Ajit Kumar Agarwal
-Original Message- From: Richard Sandiford [mailto:richard.sandif...@arm.com] Sent: Monday, September 22, 2014 4:56 PM To: Ajit Kumar Agarwal Cc: Jeff Law; gcc-patches@gcc.gnu.org Subject: Re: [PATCH 0/5] Fix handling of word subregs of wide registers Ajit Kumar Agarwal writes: > Jeff

[PATCH] msp430: inhibit automatic link of -lnosys in absence of -msim

2014-09-22 Thread Peter A. Bigot
Based on discussion on the mspgcc-users mailing list[1], this patch changes msp430 to not automatically apply -lnosys when -msim is absent, as this prevents a user from supplying a custom system interface. The existing behavior providing the CIO alternative can be obtained by explicitly linking -l

[PATCH] Fix missing gimplification of vector constructors

2014-09-22 Thread Richard Biener
The following fixes non-GIMPLE constructors slipping through the gimplifier. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-09-22 Richard Biener * gimplify.c (gimplify_init_constructor): Do not leave non-GIMPLE vector constructors around.

Re: [PATCH 2/14][Vectorizer] Make REDUC_xxx_EXPR tree codes produce a scalar result

2014-09-22 Thread Alan Lawrence
Richard Biener wrote: Huh. Does that ever happen? Please use a NOP_EXPR instead of a VIEW_CONVERT_EXPR. Yes, the testcase is gcc.target/i386/pr51235.c which performs black magic*** with void *. (This testcase otherwise fails the verify_gimple_assign_unary check in tree-cfg.c .) However,

Re: [PATCH 3/14] Add new optabs for reducing vectors to scalars

2014-09-22 Thread Alan Lawrence
Richard Biener wrote: scalar_reduc_to_vector misses a comment. Ok to reuse the comment in optabs.h in optabs.c also? I wonder if at the end we wouldn't transition all backends and then renaming reduc_*_scal_optab back to reduc_*_optab makes sense. Yes, that sounds like a plan, the _scal is

Re: [PATCH 12/14][Vectorizer] Redefine VEC_RSHIFT_EXPR and vec_shr_optab as endianness-neutral

2014-09-22 Thread Bill Schmidt
On Thu, 2014-09-18 at 09:12 -0400, David Edelsohn wrote: > On Thu, Sep 18, 2014 at 8:42 AM, Alan Lawrence wrote: > > The direction of VEC_RSHIFT_EXPR has been endian-dependent, contrary to the > > general principles of tree. This patch updates fold-const and the vectorizer > > (the only place wher

[AArch64] Auto-generate the "BUILTIN_" macros for aarch64-builtins.c

2014-09-22 Thread James Greenhalgh
On Thu, Sep 18, 2014 at 11:12:15AM +0100, Richard Earnshaw wrote: > On 18/09/14 10:53, James Greenhalgh wrote: > > +$(srcdir)/config/aarch64/aarch64-builtin-iterators.h: > > $(srcdir)/config/aarch64/geniterators.sh \ > > + $(srcdir)/config/aarch64/iterators.md > > + $(SHELL) $(srcdir)/con

[patch] Implement move semantics for iostreams

2014-09-22 Thread Jonathan Wakely
This adds move and swap functions to the iostream classes. Although this is a pretty large patch, it's a pure addition that only affects C++11 mode, and should have no effect on existing code because it won't be moving or swapping streams. I wanted to use C++14's std::exchange so I added std::__

Re: [PATCH 3/14] Add new optabs for reducing vectors to scalars

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 3:26 PM, Alan Lawrence wrote: > Richard Biener wrote: >> >> >> scalar_reduc_to_vector misses a comment. > > > Ok to reuse the comment in optabs.h in optabs.c also? Sure. >> I wonder if at the end we wouldn't transition all backends and then >> renaming reduc_*_scal_optab

Re: FW: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

2014-09-22 Thread Thomas Schwinge
Hi! On Tue, 27 Aug 2013 21:30:49 +, "Iyer, Balaji V" wrote: > --- /dev/null > +++ gcc/testsuite/c-c++-common/cilk-plus/CK/spawning_arg.c > @@ -0,0 +1,37 @@ > +/* { dg-do run { target { i?86-*-* x86_64-*-* arm*-*-* } } } */ > +/* { dg-options "-fcilkplus" } */ > +/* { dg-options "-lcilkrts"

Re: [debug-early] Allow checking of DECL_ABSTRACT in decl_ultimate_origin

2014-09-22 Thread Michael Matz
Hi, On Fri, 19 Sep 2014, Aldy Hernandez wrote: > Michael, I really don't understand the need for this change in your original > patch. I don't know if this was a temporary testing change or what. I'm pretty sure it was temporary testing, when I still was finding my way through dwarf2out limita

[PATCH IRA] update_equiv_regs fails to set EQUIV reg-note for pseudo with more than one definition

2014-09-22 Thread Felix Yang
Hi, I find that update_equiv_regs in ira.c sets the wrong EQUIV reg-note for pseudo with more than one definiton in certain situation. Here is a simplified RTL snippet after this function finishs handling: (insn 77 37 78 2 (set (reg:SI 171) (const_int 0 [0])) ticket151.c:33 52 {

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

2014-09-22 Thread Michael Eager
On 09/21/14 21:10, Chen Gang wrote: On 9/22/14 2:09, Michael Eager wrote: Generally, you should use "gcc" to link programs, not "ld". gcc is a driver which will select the appropriate libraries and support routines (such as crt0.o, which contains _start) and pass them to the linker. OK, tha

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

2014-09-22 Thread Michael Eager
On 09/21/14 20:55, Chen Gang wrote: On 9/22/14 2:03, Michael Eager wrote: On 09/20/14 23:24, Chen Gang wrote: And it seems, we also need 'LinkScr.ld' for ldscript, could you share it to me, thanks. set_board_info ldscript "-T/home/eager/Xilinx/dg/microblaze_0/LinkScr.ld" Hi Chen -- Th

Re: Move dwarf2 frame tables to read-only section for AIX

2014-09-22 Thread Joseph S. Myers
On Mon, 22 Sep 2014, Andrew Dixie wrote: > I altered the dwarf2 frame and exception table generation so the > decision on whether to use a read-only or read-write section is an > independent decision from how the frame tables are registered. > I renamed EH_FRAME_IN_DATA_SECTION to EH_FRAME_THROUGH

[PING] [PATCH] Add direct support for Linux kernel __fentry__ patching

2014-09-22 Thread Andi Kleen
Andi Kleen writes: Ping! > Andi Kleen writes: > > Ping! > >> From: Andi Kleen >> >> The Linux kernel dynamically patches in __fentry__ calls in and >> out at runtime. This allows using function tracing for debugging >> in production kernels without (significant) performance penalty. >> >> For

[patch] Fix std::try_lock behaviour

2014-09-22 Thread Jonathan Wakely
When I fixed std::try_lock a few years ago I misread the spec, exceptions should not be caught and turned into a return value. Tested x86_64-linux, committed to trunk. commit 5effca670aa009c60e31b639604da4d00f388038 Author: Jonathan Wakely Date: Thu Sep 18 16:15:54 2014 +0100 * include/

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-22 Thread Teresa Johnson
On Mon, Sep 22, 2014 at 1:36 AM, Nathan Sidwell wrote: > On 09/21/14 18:58, Xinliang David Li wrote: > >>> the intent is that that points to the gcov_info object of the object file >>> containing the live version of the function. I couldn't quite get this >>> to >>> work though -- it involves emi

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Jason Merrill
On 09/12/2014 08:04 PM, Jakub Jelinek wrote: I've been worried about the quick cases where parallelization is not beneficial, like make check-gcc \ RUNTESTFLAGS=dg.exp=pr60123.c or similar, but one doesn't usually pass -jN in that case. I have -jN in my $MAKEFLAGS, so I've been running into thi

[patch] Update C++11 library status docs

2014-09-22 Thread Jonathan Wakely
This documents some more C++11 features as incomplete and notes that iostreams are movable now. Committed to trunk. commit 8de61687f31c20aec35c02393c4fbb44ddcc0cbb Author: Jonathan Wakely Date: Mon Sep 22 15:57:28 2014 +0100 * doc/xml/manual/status_cxx2011.xml: Update C++11 status.

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Jakub Jelinek
On Mon, Sep 22, 2014 at 11:21:14AM -0400, Jason Merrill wrote: > On 09/12/2014 08:04 PM, Jakub Jelinek wrote: > >I've been worried about the quick cases where > >parallelization is not beneficial, like make check-gcc \ > >RUNTESTFLAGS=dg.exp=pr60123.c or similar, but one doesn't usually pass -jN >

Re: [PATCH, i386, Pointer Bounds Checker 32/x] Pointer Bounds Checker hooks for i386 target

2014-09-22 Thread Ilya Enkovich
On 19 Sep 18:21, Uros Bizjak wrote: > On Fri, Sep 19, 2014 at 2:53 PM, Ilya Enkovich wrote: > > >> > This patch adds i386 target hooks for Pointer Bounds Checker. > > > New version with fixes and better documentation for ix86_load_bounds and > > ix86_store_bounds is below. > > > +/* Expand pas

Re: [PATCH, i386, Pointer Bounds Checker 34/x] Vararg functions support

2014-09-22 Thread Ilya Enkovich
On 21 Sep 18:08, Uros Bizjak wrote: > Hello! > > > This patch introduces initialization of incoming bounds for vararg function > > on i386 target. > > > > Bootstrapped and tested on linux-x86_64. > > > > Thanks, > > Ilya > > -- > > gcc/ > > > > 2014-06-11 Ilya Enkovich > > > > * config

Re: Fix ICE with ODR mering and variable sized types

2014-09-22 Thread Jan Hubicka
> On Fri, Sep 19, 2014 at 8:55 PM, Jan Hubicka wrote: > > Hi, > > this patch fixes ICE by avoiding mangling of types with variadic size > > (those are > > not really supported). Bootstrapped/regtested x86_64-linux, tested with > > libreoffice, > > comitted. > > Hmm, but how do global vars end

Re: [PATCH, i386, Pointer Bounds Checker 2/x] Intel Memory Protection Extensions (MPX) instructions support

2014-09-22 Thread Ilya Enkovich
On 17 Sep 12:17, Ilya Enkovich wrote: > On 19 May 11:23, Jeff Law wrote: > > On 05/19/14 02:19, Ilya Enkovich wrote: > > >On 16 May 13:39, Jeff Law wrote: > > >>On 04/16/14 05:35, Ilya Enkovich wrote: > > >>>Hi, > > >>> > > >>>This patch introduces Intel MPX bound registers and instructions. It >

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Jason Merrill
On 09/22/2014 11:26 AM, Jakub Jelinek wrote: On Mon, Sep 22, 2014 at 11:21:14AM -0400, Jason Merrill wrote: If I say 'rgt dg.exp=var-templ1.C' the actual test results are lost in the explosion of shell verbosity. Could we add some '@'s to more of the rules, perhaps? I've been considering that

Re: [debug-early] Allow checking of DECL_ABSTRACT in decl_ultimate_origin

2014-09-22 Thread Aldy Hernandez
On 09/22/14 08:17, Michael Matz wrote: Hi, On Fri, 19 Sep 2014, Aldy Hernandez wrote: Michael, I really don't understand the need for this change in your original patch. I don't know if this was a temporary testing change or what. I'm pretty sure it was temporary testing, when I still was f

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Segher Boessenkool
On Mon, Sep 22, 2014 at 05:26:04PM +0200, Jakub Jelinek wrote: > I've been considering that too, but not sure what info people find valuable > and what they don't. The ten million "Running blablablalba.exp ..." messages on a very parallel run aren't helpful in my opinion. There might be more but

Re: [PATCH] msp430: inhibit automatic link of -lnosys in absence of -msim

2014-09-22 Thread Nicholas Clifton
Hi Peter, > gcc/ChangeLog > 2014-09-22 Peter A. Bigot > >* config/msp430/msp430.h: Remove automatic -lnosys when -msim absent. Approved and applied. Cheers Nick

[PATCH][AArch64] LR register not used in leaf functions

2014-09-22 Thread Kugan
AArch64 has the same issue ARM had where the LR register was not used in leaf functions. This was reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42017. In AArch64, this test-case need to be added with more live ranges for the need for the LR_REGNUM. i.e test-case in the PR needs additiona

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Jakub Jelinek
On Mon, Sep 22, 2014 at 10:44:06AM -0500, Segher Boessenkool wrote: > On Mon, Sep 22, 2014 at 05:26:04PM +0200, Jakub Jelinek wrote: > > I've been considering that too, but not sure what info people find valuable > > and what they don't. > > The ten million "Running blablablalba.exp ..." messages

Re: Speedup int_bit_from_pos

2014-09-22 Thread Jan Hubicka
> On Sun, 21 Sep 2014, Jan Hubicka wrote: > > > > > > > Please omit static from inline functions. > > > > Yep, I suppose we want to drop static in all inlines? I can make patch for > > that. > > > > > > Also one notable difference with your patches is that the fits hwi is now > > > not tested

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

2014-09-22 Thread Chen Gang
On 09/22/2014 10:45 PM, Michael Eager wrote: > On 09/21/14 21:10, Chen Gang wrote: >> On 9/22/14 2:09, Michael Eager wrote: >>> >>> Generally, you should use "gcc" to link programs, not "ld". gcc is >>> a driver which will select the appropriate libraries and support routines >>> (such as crt0.o,

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Jakub Jelinek
On Mon, Sep 22, 2014 at 11:43:35AM -0400, Jason Merrill wrote: > On 09/22/2014 11:26 AM, Jakub Jelinek wrote: > >On Mon, Sep 22, 2014 at 11:21:14AM -0400, Jason Merrill wrote: > >>If I say 'rgt dg.exp=var-templ1.C' the actual test results are lost in the > >>explosion of shell verbosity. Could we

Re: [PATCH][AArch64] LR register not used in leaf functions

2014-09-22 Thread Jiong Wang
On 22/09/14 16:43, Kugan wrote: AArch64 has the same issue ARM had where the LR register was not used in leaf functions. This was reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42017. In AArch64, this test-case need to be added with more live ranges for the need for the LR_REGNUM. i.e

Re: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern'

2014-09-22 Thread Chen Gang
On 09/22/2014 10:46 PM, Michael Eager wrote: > On 09/21/14 20:55, Chen Gang wrote: >> >> >> On 9/22/14 2:03, Michael Eager wrote: >>> On 09/20/14 23:24, Chen Gang wrote: And it seems, we also need 'LinkScr.ld' for ldscript, could you share it to me, thanks. set_board_info ld

[jit] Improvements to documentation

2014-09-22 Thread David Malcolm
Committed to branch dmalcolm/jit As before, an HTML version of the docs can be seen at: https://dmalcolm.fedorapeople.org/gcc/libgccjit-api-docs/index.html with the bulk of the changes occurring to: https://dmalcolm.fedorapeople.org/gcc/libgccjit-api-docs/intro/tutorial03.html gcc/jit/ChangeLo

Re: [AArch64] Auto-generate the "BUILTIN_" macros for aarch64-builtins.c

2014-09-22 Thread Richard Earnshaw
On 22/09/14 14:30, James Greenhalgh wrote: > > On Thu, Sep 18, 2014 at 11:12:15AM +0100, Richard Earnshaw wrote: >> On 18/09/14 10:53, James Greenhalgh wrote: >>> +$(srcdir)/config/aarch64/aarch64-builtin-iterators.h: >>> $(srcdir)/config/aarch64/geniterators.sh \ >>> + $(srcdir)/config/aarch

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Segher Boessenkool
On Mon, Sep 22, 2014 at 05:49:12PM +0200, Jakub Jelinek wrote: > On Mon, Sep 22, 2014 at 10:44:06AM -0500, Segher Boessenkool wrote: > > On Mon, Sep 22, 2014 at 05:26:04PM +0200, Jakub Jelinek wrote: > > > I've been considering that too, but not sure what info people find > > > valuable > > > and

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Jason Merrill
On 09/22/2014 11:58 AM, Jakub Jelinek wrote: LGTM (though, supposedly we want similar change in libstdc++-v3/testsuite/Makefile.am). Or, if people would really like to see the commands, we could print them just once, using e.g. -$(if $(check_p_subno),@)(rootme= ... (then e.g. check-parall

Re: [PATCH] gcc parallel make check

2014-09-22 Thread Jakub Jelinek
On Mon, Sep 22, 2014 at 12:21:08PM -0400, Jason Merrill wrote: > On 09/22/2014 11:58 AM, Jakub Jelinek wrote: > >LGTM (though, supposedly we want similar change in > >libstdc++-v3/testsuite/Makefile.am). > >Or, if people would really like to see the commands, we could print them > >just once, using

[patch] moving macro definitions to defaults.h

2014-09-22 Thread Andrew MacLeod
After being reminded of the tm.h issues brought up last november (here: https://gcc.gnu.org/ml/gcc-patches/2013-11/msg01731.html ), I started looking back into it. The general summary is the any header file which has a conditional on a target macro could be affected by include file reorderin

Re: Fix ICE with ODR mering and variable sized types

2014-09-22 Thread Jason Merrill
On 09/22/2014 11:37 AM, Jan Hubicka wrote: Variadic types indeed can not appear in global declarations, so I think it is safe to ignore them. Agreed. Jason

Re: [PATCH 4/5] Generalise invalid_mode_change_p

2014-09-22 Thread Jeff Law
On 09/22/14 01:34, Richard Sandiford wrote: Jeff Law writes: On 09/18/14 04:25, Richard Sandiford wrote: This is the main patch for the bug. We should treat a register as invalid for a mode change if simplify_subreg_regno cannot provide a new register number for the result. We should treat a

C++ PATCH for variable template diagnostics

2014-09-22 Thread Jason Merrill
This patch fixes two issues with variable templates: 1) -Wunused was warning about a variable template specialization when leaving the template specialization scope, and 2) The diagnostic referring to the specialization wasn't showing the template arguments. Tested x86_64-pc-linux-gnu, applyi

[patch] Fix specializations of std::uses_allocator in and

2014-09-22 Thread Jonathan Wakely
Include missing header, and add tests. Tested x86_64-linux, committed to trunk. commit a0ffb1d4d0bf78be525c7546665ef7002b66b13e Author: Jonathan Wakely Date: Mon Sep 22 16:42:51 2014 +0100 Include in and . * include/bits/stl_queue.h: Include missing header. * include/bits

Re: [patch] moving macro definitions to defaults.h

2014-09-22 Thread David Malcolm
On Mon, 2014-09-22 at 12:26 -0400, Andrew MacLeod wrote: > After being reminded of the tm.h issues brought up last november (here: > https://gcc.gnu.org/ml/gcc-patches/2013-11/msg01731.html ), I started > looking back into it. > > The general summary is the any header file which has a condition

Re: [AArch64] Re: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

2014-09-22 Thread Jeff Law
On 09/22/14 05:16, Alan Lawrence wrote: Ok thanks Jeff. In that case I think I should draw this to the attention of the AArch64 maintainers to check the testsuite updates are OK before I commit...? Can't hurt. Methinks it may be possible to get further, or at least increase our confidence, if

Re: [patch] moving macro definitions to defaults.h

2014-09-22 Thread Joseph S. Myers
On Mon, 22 Sep 2014, Andrew MacLeod wrote: > Josephs solution was to identify these and instead put a default definition in > default.h ... then change all the uses to #if instead.. ie, > #if BLAH > > This way we can ensure that the definition has been seen and it will be a > compile error if no

Re: [patch] moving macro definitions to defaults.h

2014-09-22 Thread Joseph S. Myers
On Mon, 22 Sep 2014, David Malcolm wrote: > There appears to be a particular implicit order in which headers must be > included. I notice that e.g. tm.h has: > > #ifndef GCC_TM_H > #define GCC_TM_H > > so if we're going with this "no header file includes any other header > file" model, woul

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-09-22 Thread Andrew Pinski
On Mon, Sep 22, 2014 at 4:10 AM, Alan Lawrence wrote: > Well, I haven't looked into this in detail: I've gone only as far as > * swapping emit-rtl.o between 'good' compiles (svn r214042) and 'bad' > compiles (r214043), finding that the critical difference is in the > emit-rtl.o generated by r214

Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

2014-09-22 Thread Jeff Law
On 09/22/14 04:24, Jiong Wang wrote: Great. Can you send an updated patchkit for review. patch attached. please review, thanks. gcc/ * shrink-wrap.c (move_insn_for_shrink_wrap): Initialize the live-in of new created BB as the intersection of live-in from "old_dest" and live-out from "bb". L

Re: Speedup int_bit_from_pos

2014-09-22 Thread Jan Hubicka
> > On Sun, 21 Sep 2014, Jan Hubicka wrote: > > > > > > > > > > Please omit static from inline functions. > > > > > > Yep, I suppose we want to drop static in all inlines? I can make patch > > > for that. > > > > > > > > Also one notable difference with your patches is that the fits hwi is >

Re: [PATCH] Improve prepare_shrink_wrap to sink more instructions

2014-09-22 Thread Jeff Law
On 09/22/14 04:29, Jiong Wang wrote: On 19/09/14 21:43, Jeff Law wrote: On 09/15/14 08:33, Jiong Wang wrote: Jeff, thanks, I partially understand your meaning here. take the function "ira_implicitly_set_insn_hard_regs" in ira-lives.c for example, when generating address rtl, gcc

Re: Speedup int_bit_from_pos

2014-09-22 Thread Mike Stump
On Sep 22, 2014, at 8:51 AM, Jan Hubicka wrote: >> On Sun, 21 Sep 2014, Jan Hubicka wrote: >> Please omit static from inline functions. >>> >>> Yep, I suppose we want to drop static in all inlines? I can make patch for >>> that. Also one notable difference with your patche

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-22 Thread Xinliang David Li
On Mon, Sep 22, 2014 at 1:36 AM, Nathan Sidwell wrote: > On 09/21/14 18:58, Xinliang David Li wrote: > >>> the intent is that that points to the gcov_info object of the object file >>> containing the live version of the function. I couldn't quite get this >>> to >>> work though -- it involves emi

  1   2   >