On Sun, 21 Sep 2014, Jan Hubicka wrote:

> > 
> > Please omit static from inline functions.
> 
> Yep, I suppose we want to drop static in all inlines? I can make patch for 
> that.
> > 
> > Also one notable difference with your patches is that the fits hwi is now 
> > not tested on the result but on the result input which, multiplied by 8, 
> > might not fit a hwi now.  So please use wide-ints here (the to_offset 
> > flavor).
> 
> The function must always suceed (so user promise it will fit in HWI) and for
> performance reasons I would rather not go into wide int by defualt, but I can
> do that with checking enabled.

wide-int should be fast enough, please use it.

Richard.

Reply via email to