[PATCH] Fix ICE in rtl-optimization/PR61220, PR61225

2014-05-20 Thread Zhenqiang Chen
Hi, The patch fix ICE issue triggered by shrink-wrapping enhancement. Bootstrap and no make check regression on X86-64. OK for trunk? Thanks! -Zhenqiang 2014-05-20 Zhenqiang Chen PR rtl-optimization/61220 Part of PR rtl-optimization/61225 * shrink-wrap.c (move_insn

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-20 Thread Bin.Cheng
On Tue, May 20, 2014 at 1:30 AM, Jeff Law wrote: > On 05/19/14 00:38, Bin.Cheng wrote: >> >> On Sat, May 17, 2014 at 12:32 AM, Jeff Law wrote: >>> >>> On 05/16/14 04:07, Bin.Cheng wrote: >>> >>> >>> >>> But can't you go through movXX to generate either the simple insn on the >>> ARM >>> or the PA

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-20 Thread Bin.Cheng
On Tue, May 20, 2014 at 5:02 AM, Mike Stump wrote: > On May 19, 2014, at 10:30 AM, Jeff Law wrote: >>> Yes, I think it's more than upsizing the mode. There is another >>> example from one of x86's candidate peephole patch at >>> https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00467.html >>> >>> Th

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-20 Thread Mikael Pettersson
Richard Biener writes: > > The following is my current idea on progressing on the HOST_WIDE_INT > removal ... > And HOST_WIDEST_FAST_INT for which > I don't have a very good suggestion other than either keeping > it, unconditionally using 'long' (thus simply remove > use_long_long_for_wides

Re: [PATCH] Fix ARM NAN fraction bits

2014-05-20 Thread Richard Biener
On Tue, 20 May 2014, Maciej W. Rozycki wrote: > Ian, > > On Sat, 17 May 2014, Richard Biener wrote: > > > On May 17, 2014 12:22:23 AM CEST, "Maciej W. Rozycki" > > wrote: > > >On Fri, 16 May 2014, Joseph S. Myers wrote: > > > > > >> > 2014-05-16 Maciej W. Rozycki > > >> > > > >> >P

Re: [PATCH] Fix PR61221

2014-05-20 Thread Richard Biener
On Mon, 19 May 2014, Richard Biener wrote: > On May 19, 2014 6:57:52 PM CEST, Jeff Law wrote: > >On 05/19/14 06:54, Richard Biener wrote: > >> > >> In this PR we run into the issue that releasing SSA names from > >> FRE/PRE elimination corrupts the VN lattice and thus the VN lookup > >> we perfor

RFA: cache enabled attribute by insn code

2014-05-20 Thread Richard Sandiford
get_attr_enabled was showing up high in a -O0 compile of fold-const.ii. At the moment, extract_insn calls this function for every alternative on each extraction, which can be expensive for instructions like moves that have many alternatives. The attribute is only supposed to depend on the insn cod

Don't dump low gimple functions in gimple dump

2014-05-20 Thread Tom de Vries
Honza, Consider this program: ... int main(void) { #pragma omp parallel { extern void foo(void); foo (); } return 0; } ... When compiling this program with -fopenmp, the ompexp pass splits off a new function called main._omp_fn.0 containing the call to foo. The new function is then

Re: RFA: cache enabled attribute by insn code

2014-05-20 Thread Richard Sandiford
Richard Sandiford writes: > get_attr_enabled was showing up high in a -O0 compile of fold-const.ii. > At the moment, extract_insn calls this function for every alternative > on each extraction, which can be expensive for instructions like > moves that have many alternatives. > > The attribute is o

RFA: cache recog_op_alt by insn code

2014-05-20 Thread Richard Sandiford
Following on from (and depending on) the last patch, process_constraints also shows up high in the profile. This patch caches the recog_op_alt information by insn code too. It also shrinks the size of the structure from 1 pointer + 5 ints to 1 pointer + 2 ints: - no target should have more than

Re: [PATCH] testsuite: Register loaded libs

2014-05-20 Thread Chung-Ju Wu
2014-05-09 16:36 GMT+08:00 Sebastian Huber : > On 2014-04-28 18:24, Mike Stump wrote: >> On Apr 28, 2014, at 12:32 AM, Sebastian >> Huber wrote: >>> >>> >I would like to add tests for C/C++ compatibility of atomic operations. >>> > >>> >http://gcc.gnu.org/ml/gcc/2014-04/msg00267.html >>> > >>> >Th

Re: [C++ Patch] PR 58664

2014-05-20 Thread Paolo Carlini
Hi, On 05/20/2014 04:50 AM, Jason Merrill wrote: On 05/19/2014 06:43 PM, Paolo Carlini wrote: if (unqualified_id) - error ("field %qD has incomplete type %qT", - unqualified_id, type); + cxx_incomplete_type_error (unqualified_id, type); else

[backport,avr,47] Apply fix for PR60991

2014-05-20 Thread Georg-Johann Lay
Backportet the fix for PR60991 also to 4.7 so that the issue can be closed: http://gcc.gnu.org/r210635 Johann gcc/ 2014-05-20 Senthil Kumar Selvaraj Backport from mainline r210325 2014-05-12 Senthil Kumar Selvaraj PR target/60991 * config/avr/avr.c (avr_

Re: [PATCH] Fix PR54733 Optimize endian independent load/store

2014-05-20 Thread Richard Biener
On Tue, May 20, 2014 at 4:46 AM, Thomas Preud'homme wrote: >> From: Richard Biener [mailto:richard.guent...@gmail.com] >> >> Agreed, but I am happy with doing that as a followup. Btw, >> a very simple one would be to reject unaligned >> SLOW_UNALIGNED_ACCESS (TYPE_MODE (load_type), align). >> [of

Re: [patch ping] libstdc++ testsuite cxxflags

2014-05-20 Thread Jonathan Wakely
On 19/05/14 14:57 -0600, Sandra Loosemore wrote: On 05/17/2014 04:07 AM, Jonathan Wakely wrote: On 17 May 2014 10:50, Jonathan Wakely wrote: On 17 May 2014 01:16, Sandra Loosemore wrote: It appears that this patch from last fall never got reviewed. https://gcc.gnu.org/ml/gcc-patches/2013-10/m

Commit: MSP430: Fix gcc.c-torture/execute/20050826-2.c

2014-05-20 Thread Nick Clifton
Hi Guys I am checking in the patch below to fix a failure in the GCC testsuite for the MSP430. The problem was that PSI mode values only occupy 1 hard register whereas SI mode values occupy 2 registers. This meant that when gcc generated: (set (reg:SI r7) (zero_extend:SI (reg:PSI r7

Re: RFA: speeding up dg-extract-results.sh

2014-05-20 Thread Richard Sandiford
Charles Baylis writes: > On 19 May 2014 19:07, Richard Sandiford wrote: >> >> Sorry for the breakage. I wanted to make the script as picky as I could >> get away with though, so that results aren't lost accidentally. >> >> Could you try the attached? > > That works for me. Thanks. I also teste

RE: [PATCH] Fix PR54733 Optimize endian independent load/store

2014-05-20 Thread Thomas Preud'homme
> From: Richard Biener [mailto:richard.guent...@gmail.com] > > It may do three aligned loads, char, short, char and combine them > while doing an unaligned int load may end up being slower. Though > very probable the RTL expansion machinery for unaligned loads > is way more clever to emit an opti

RE: [PATCH, AArch64] Fix macro in vdup_lane_2 test case

2014-05-20 Thread Ian Bolton
> From: Marcus Shawcroft [mailto:marcus.shawcr...@gmail.com] > Sent: 19 May 2014 11:45 > To: Ian Bolton > Cc: gcc-patches > Subject: Re: [PATCH, AArch64] Fix macro in vdup_lane_2 test case > > On 8 May 2014 18:41, Ian Bolton wrote: > > > gcc/testsuite > > * gcc.target/aarch64/vdup_lane_2

Re: [patch] Fix over-optimization of calls to pure function

2014-05-20 Thread Eric Botcazou
> Can't I have sometihng like > > loop (i as iterator) >begin > I := F(0); >exception > when E => N := N + 1; >end; > > here I would expect PRE to discover I as loop invariant that will cause > exception to be called just once, not at every iteration of loop? Yet the follo

Re: Eliminate write-only variables

2014-05-20 Thread Richard Biener
On Tue, May 20, 2014 at 6:29 AM, Jan Hubicka wrote: >> On 05/18/2014 08:45 PM, Sandra Loosemore wrote: >> >On 05/18/2014 02:59 PM, Jan Hubicka wrote: >> >>For cases like local-statics-7 your approach can be "saved" by adding >> >>simple IPA analysis >> >>to look for static vars that are used only

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-20 Thread Eric Botcazou
> The following is my current idea on progressing on the HOST_WIDE_INT > removal > > 1) https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00381.html (ping) > > 2) make sure [u]int64_t is available and use that to define HOST_WIDE_INT > > 3) s/HOST_WIDE_INT/int64_t/ (same for unsigned HOST_WIDE_INT)

Re: [patch] Fix over-optimization of calls to pure function

2014-05-20 Thread Eric Botcazou
> DOM bits are good. Richi wants the "redundant" test to be kept around, > so OK with that change. Thanks. The test is more duplicated than redundant so I'll remove it anyway. -- Eric Botcazou

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-20 Thread Richard Biener
On Tue, 20 May 2014, Eric Botcazou wrote: > > The following is my current idea on progressing on the HOST_WIDE_INT > > removal > > > > 1) https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00381.html (ping) > > > > 2) make sure [u]int64_t is available and use that to define HOST_WIDE_INT > > > > 3)

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-20 Thread Eric Botcazou
> Same as for going C++. Not to the same extent, this will be worse because done en masse throughout the code instead of gradually. > Make the code base easier to understand for newcomers. It's also a > documentation improvement (you see what a HOST_WIDE_INT really is), > alongside with [u]int6

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-20 Thread Richard Biener
On Tue, 20 May 2014, Eric Botcazou wrote: > > Same as for going C++. > > Not to the same extent, this will be worse because done en masse throughout > the code instead of gradually. Like the gimple -> gimple * change pending or the various gimple -> gswitch,glabel,etc. stuff? It's on a similar

Re: add dbgcnt and opt-info support for devirtualization

2014-05-20 Thread Richard Biener
On Mon, May 19, 2014 at 5:24 PM, Xinliang David Li wrote: > Sorry about it. Here is the patch. There is one remaining case where > cgraph_dump_file and dump_enable_p are checked separately -- > cgraph_dump_file is set up differently from 'dump_file'. But there you check with an else if, so if yo

Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.

2014-05-20 Thread Kirill Yukhin
Hello, On 19 May 09:58, H.J. Lu wrote: > On Mon, May 19, 2014 at 9:45 AM, Uros Bizjak wrote: > > On Mon, May 19, 2014 at 6:42 PM, H.J. Lu wrote: > > > Uros, > I am looking into libreoffice size and the data alignment seems to make > huge > difference. Data section has grown f

[PATCH][match-and-simplify] Reject outermost captures

2014-05-20 Thread Richard Biener
We can't really code-generate those (and thus such patterns are simply skipped during code-gen ...). Reject them early. Committed to the branch. Richard. 2014-05-20 Richard Biener * genmatch.c (parse_match_and_simplify): Reject outermost expressions that are captured or not

Re: [PATCH] [PING^2] Fix for PR libstdc++/60758

2014-05-20 Thread Richard Earnshaw
On 16/05/14 14:56, Alexey Merzlyakov wrote: > On 07.05.2014 13:28, Ramana Radhakrishnan wrote: >> On 05/07/14 09:19, Yury Gribov wrote: >>> Original Message >>> Subject: [PING] [PATCH] Fix for PR libstdc++/60758 >>> Date: Thu, 17 Apr 2014 17:48:12 +0400 >>> From: Alexey Merzlyakov

Re: [PATCH] Fix ARM NAN fraction bits

2014-05-20 Thread Richard Earnshaw
On 20/05/14 08:57, Richard Biener wrote: > On Tue, 20 May 2014, Maciej W. Rozycki wrote: > >> Ian, >> >> On Sat, 17 May 2014, Richard Biener wrote: >> >>> On May 17, 2014 12:22:23 AM CEST, "Maciej W. Rozycki" >>> wrote: On Fri, 16 May 2014, Joseph S. Myers wrote: >> 2014-05-16 Mac

Re: [C++ Patch] PR 58664

2014-05-20 Thread Jason Merrill
OK. Jason

[build, doc, testsuite] Centralise clearing hardware capabilities with Sun ld

2014-05-20 Thread Rainer Orth
Rainer Orth writes: > Prompted by the recent failures of c-c++-common/gomp/pr60823-2.c on > Solaris/x86 with Sun as > > http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00943.html > > I've reworked the clearing of hardware capabilities via linker maps for > Sun ld, which is currently replicated

[PATCH][match-and-simplify] Provide parsing error locations

2014-05-20 Thread Richard Biener
This adds $subject. Committed to branch. Richard. 2014-05-20 Richard Biener * genmatch.c (error_cb, fatal_at): New functions. (expect, parse_expr, parse_op, parse_match_and_simplify, main): Provide error locations. Index: gcc/genmatch.c =

Re: [PATCH][ARM] Adjust arith_shiftsi for ARMv8-style

2014-05-20 Thread Richard Earnshaw
On 15/05/14 09:47, Kyrill Tkachov wrote: > Hi all, > > Shifted arithmetic operations can never be encoded in 16-bits in and > therefore > can not appear in Thumb2 IT blocks under ARMv8-A rules (and the -mrestrict-it > rules). This patch adjusts the relevant pattern for that purpose. > > Tested

Re: [PATCH] [PING^2] Fix for PR libstdc++/60758

2014-05-20 Thread Alexey Merzlyakov
On 20.05.2014 16:25, Richard Earnshaw wrote: On 16/05/14 14:56, Alexey Merzlyakov wrote: On 07.05.2014 13:28, Ramana Radhakrishnan wrote: On 05/07/14 09:19, Yury Gribov wrote: Original Message Subject: [PING] [PATCH] Fix for PR libstdc++/60758 Date: Thu, 17 Apr 2014 17:48:12

Re: [PATCH] [PING^2] Fix for PR libstdc++/60758

2014-05-20 Thread Ramana Radhakrishnan
The following PR is opened for this problem: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61223 Thumb1 failure was also detected and reported in pr60758. I've proposed a thumb1 bugfix there. Regtest for the fix currently is in progress. Patches must be proposed on gcc-patches and / or in thi

PR 61210: recursive template substitution depending on system compiler

2014-05-20 Thread Richard Sandiford
PR 61210 is about a case where a templated wi:: function had "x | y" and where both "x" and "y" needed temporary variables. The recursive instantation of x and y were done as two arguments to the same function call, which meant that the order of instantiation depended on the host compiler. The ui

Re: [PATCH] [PING^2] Fix for PR libstdc++/60758

2014-05-20 Thread Richard Earnshaw
On 20/05/14 14:12, Ramana Radhakrishnan wrote: > >> >> The following PR is opened for this problem: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61223 >> >> Thumb1 failure was also detected and reported in pr60758. >> I've proposed a thumb1 bugfix there. Regtest for the fix currently is in >> p

[Ping] [C++ Patch] PR 60373

2014-05-20 Thread Paolo Carlini
Hi, On 05/13/2014 02:19 AM, Paolo Carlini wrote: Hi, in this issue Marc noticed that the warning for ignored attribute visibility is truncated when the previous declaration belongs to a system header. Luckily the problem can be neatly fixed because it's just a consequence of not using warnin

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Teresa Johnson
On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li wrote: > Why duplicating the merger functions in dyn-ipa.c? Should those in > libgcov-merge.c be reused? The merger functions in libgcov-merge.c use a macro to either read the counter to merge from a buffer in memory (when IN_GCOV_TOOL) or from

[PATCH] Tidy SCCVN dump

2014-05-20 Thread Richard Biener
This makes the dumps easier to follow. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-05-20 Richard Biener * tree-ssa-sccvn.c (process_scc): Dump SCC here, when iterating, (extract_and_process_scc_for_name): not here. (cond_dom_wa

Re: PR 61210: recursive template substitution depending on system compiler

2014-05-20 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 60373

2014-05-20 Thread Jason Merrill
OK. Jason

RE: [PATCH, PR60189, Cilk+] Fix for ICE with incorrect Cilk_sync usage

2014-05-20 Thread Zamyatin, Igor
Please look then on the following patch. Regtested successfully on x86_64. Is it ok for trunk and 4.9? gcc/cp/ChangeLog: 2014-05-20 Igor Zamyatin PR c/60189 * parser.c (cp_parser_postfix_expression): Move handling of cilk_sync from here to... (cp_parser_statement): ...here. Make sure only s

[PATCH, ira] Fix for PR61241

2014-05-20 Thread 马江
Hi,all There are some small problems that block the ira to make the best choice, as PR61241 shows. This patch fix PR61241. I have done "make bootstrap" and "make check" on x86, nothing changed after the patch. Is the patch OK for trunk? Thanks Ma Jiang 2014-05-20 Ma Jiang PR rtl-opti

[PATCH, PR61191, Cilk+] Fix ICE on syntax error

2014-05-20 Thread Zamyatin, Igor
Hi all! The following patch fixes the ICE for the cilk code with syntax error. Regtested on x86_64. Ok for trunk and 4.9? Thanks, Igor gcc/c/ChangeLog: 2014-05-20  Igor Zamyatin  * c-array-notation.c (fix_builtin_array_notation_fn): Check invalid  function parameters. diff --git a/gcc/c/

Re: patch to fix PR60969

2014-05-20 Thread Vladimir Makarov
On 05/19/2014 05:37 PM, James Greenhalgh wrote: > On Fri, May 16, 2014 at 06:49:45PM +0100, Vladimir Makarov wrote: >>The following patch fixes >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60969 >> >> The patch was bootstrapped and tested on x86/x86-64. >> >> Committed as rev. 210519 to g

Re: RFA: cache enabled attribute by insn code

2014-05-20 Thread Mike Stump
On May 20, 2014, at 1:17 AM, Richard Sandiford wrote: >> The patch gives a consistent compile-time improvement of about ~3.5% >> on the -O0 fold-const.ii test case. 3.5 alone is really nice and 3.5 on top of 3.5 is amazing.

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-20 Thread Jason Merrill
On 05/20/2014 02:55 AM, Mark Wielaard wrote: On Mon, May 19, 2014 at 04:50:35PM -0400, Jason Merrill wrote: On 05/13/2014 03:21 AM, Mark Wielaard wrote: So the debugger doesn't have to guess the properties of the enum's underlying base type, like size, encoding and signedness. Well, the enum

Re: [C++ Patch/RFC] PR 58753 & 58930

2014-05-20 Thread Paolo Carlini
Hi, On 05/19/2014 08:28 PM, Jason Merrill wrote: How about doing digest_init in get_nsdmi, so that the conversion is also exposed to walk_field_subobs? Thus, good news: something as simple as the below passes testing, works for the 2 bugs and for c++/58704 too. Thus, what else? Personally, I'm

[patch] libstdc++/61011 fix --disable-libstdcxx in top-level configure

2014-05-20 Thread Jonathan Wakely
The first part of this patch fixes the PR, we should be adding target-libstdc++-v3 to noconfigdirs, not libstdc++-v3. The second part disables the target libs that can't be bootstrapped without libstdc++. libcilkrts and libsanitizer use lots of std:: stuff. libitm only uses std::atomic, but in a

Re: [patch] libstdc++/61011 fix --disable-libstdcxx in top-level configure

2014-05-20 Thread Jakub Jelinek
On Tue, May 20, 2014 at 03:53:14PM +0100, Jonathan Wakely wrote: > The first part of this patch fixes the PR, we should be adding > target-libstdc++-v3 to noconfigdirs, not libstdc++-v3. > > The second part disables the target libs that can't be bootstrapped > without libstdc++. > > libcilkrts an

Re: [patch] libstdc++/61011 fix --disable-libstdcxx in top-level configure

2014-05-20 Thread Jonathan Wakely
On 20/05/14 15:53 +0100, Jonathan Wakely wrote: The first part of this patch fixes the PR, we should be adding target-libstdc++-v3 to noconfigdirs, not libstdc++-v3. The second part disables the target libs that can't be bootstrapped without libstdc++. libcilkrts and libsanitizer use lots of st

Re: [C++ Patch/RFC] PR 58753 & 58930

2014-05-20 Thread Jason Merrill
On 05/20/2014 10:50 AM, Paolo Carlini wrote: + if (TREE_TYPE (init) != type) + { + if (BRACE_ENCLOSED_INITIALIZER_P (init) + && CP_AGGREGATE_TYPE_P (type)) + init = reshape_init (type, init, tf_warning_or_error); + init = digest_init (type, init, t

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-20 Thread Joseph S. Myers
On Tue, 20 May 2014, Eric Botcazou wrote: > > Make the code base easier to understand for newcomers. It's also a > > documentation improvement (you see what a HOST_WIDE_INT really is), > > alongside with [u]int64_t being less to type ... > > I personally find the abstraction and the separation w

Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.

2014-05-20 Thread H.J. Lu
On Tue, May 20, 2014 at 5:00 AM, Kirill Yukhin wrote: > Hello, > On 19 May 09:58, H.J. Lu wrote: >> On Mon, May 19, 2014 at 9:45 AM, Uros Bizjak wrote: >> > On Mon, May 19, 2014 at 6:42 PM, H.J. Lu wrote: >> > >> Uros, >> I am looking into libreoffice size and the data alignment seems

Re: [build, doc, testsuite] Centralise clearing hardware capabilities with Sun ld

2014-05-20 Thread Mike Stump
On May 20, 2014, at 6:03 AM, Rainer Orth wrote: > The following patch implements what I've outlined there > Ok for mainline and 4.9 branch if those pass? For the test suite bits, Ok.

Re: [PATCH, PR61191, Cilk+] Fix ICE on syntax error

2014-05-20 Thread H.J. Lu
On Tue, May 20, 2014 at 7:31 AM, Zamyatin, Igor wrote: > Hi all! > > The following patch fixes the ICE for the cilk code with syntax error. > > Regtested on x86_64. > Ok for trunk and 4.9? > > Thanks, > Igor > > > gcc/c/ChangeLog: > > 2014-05-20 Igor Zamyatin > > * c-array-notation.c (fix_built

[Patch, ARM] Fix pr 61208

2014-05-20 Thread Richard Earnshaw
PR 61208 is a wrong code bug in Thumb2 where we can generate out of range branches due to incorrect instruction size calculations. It's mostly gone latent on 4.9 and trunk (though could still happen at -O0 where splitting is done during final instruction generation). Complicating things slightly

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Xinliang David Li
On Tue, May 20, 2014 at 6:32 AM, Teresa Johnson wrote: > On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li > wrote: >> Why duplicating the merger functions in dyn-ipa.c? Should those in >> libgcov-merge.c be reused? > > The merger functions in libgcov-merge.c use a macro to either read the > c

[PATCH] Regression fix for PR target/61223

2014-05-20 Thread Alexey Merzlyakov
Hi all, This is a fix for thumb1 build fail on trunk appeared since rev.210515(pr60758). On thumb1 targets the LR can not be used as argument of POP instruction. To keep a support of __cxa_end_cleanup backtracing on thumb1 we can make additional register operations before push/pop. But I guess

Re: [PATCH] [PING^2] Fix for PR libstdc++/60758

2014-05-20 Thread Alexey Merzlyakov
On 20.05.2014 17:16, Richard Earnshaw wrote: On 20/05/14 14:12, Ramana Radhakrishnan wrote: The following PR is opened for this problem: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61223 Thumb1 failure was also detected and reported in pr60758. I've proposed a thumb1 bugfix there. Regtest for

Re: [C++ Patch/RFC] PR 58753 & 58930

2014-05-20 Thread Paolo Carlini
Hi, On 05/20/2014 05:08 PM, Jason Merrill wrote: On 05/20/2014 10:50 AM, Paolo Carlini wrote: + if (TREE_TYPE (init) != type) +{ + if (BRACE_ENCLOSED_INITIALIZER_P (init) + && CP_AGGREGATE_TYPE_P (type)) +init = reshape_init (type, init, tf_warning_or_error); +

Re: [PATCH] Regression fix for PR target/61223

2014-05-20 Thread Ramana Radhakrishnan
On 05/20/14 17:05, Alexey Merzlyakov wrote: Hi all, This is a fix for thumb1 build fail on trunk appeared since rev.210515(pr60758). On thumb1 targets the LR can not be used as argument of POP instruction. To keep a support of __cxa_end_cleanup backtracing on thumb1 we can make additional regis

Fix libgo build

2014-05-20 Thread Jan Hubicka
Hi, libgo currently does not build because of duplicated symbols. This is because of confusion in the output machinery, where comdat local is output as a global symbol. This is because of confusing use of DECL_ONE_ONLY. This bug seems to be there since introduction of comdat locals in gcc 4.9, but

Re: [PATCH, PR61191, Cilk+] Fix ICE on syntax error

2014-05-20 Thread Jeff Law
On 05/20/14 09:27, H.J. Lu wrote: On Tue, May 20, 2014 at 7:31 AM, Zamyatin, Igor wrote: Hi all! The following patch fixes the ICE for the cilk code with syntax error. Regtested on x86_64. Ok for trunk and 4.9? Thanks, Igor gcc/c/ChangeLog: 2014-05-20 Igor Zamyatin * c-array-notation.

Re: -fuse-caller-save - Collect register usage information

2014-05-20 Thread Eric Botcazou
> The test in get_call_reg_set_usage for flag_use_caller_save and the hook is > strictly speaking not necessary. But it's the interface function to retrieve > the collected register usage information, so it seems a good location to do > an early-out. I've left it in for now. But the test for targe

Re: [PATCH, PR60189, Cilk+] Fix for ICE with incorrect Cilk_sync usage

2014-05-20 Thread Jeff Law
On 05/20/14 08:10, Zamyatin, Igor wrote: Please look then on the following patch. Regtested successfully on x86_64. Is it ok for trunk and 4.9? gcc/cp/ChangeLog: 2014-05-20 Igor Zamyatin PR c/60189 * parser.c (cp_parser_postfix_expression): Move handling of cilk_sync from here to... (cp_pa

Re: [PATCH] Fix PR61221

2014-05-20 Thread Jeff Law
On 05/20/14 02:06, Richard Biener wrote: We're still going to have problems if SSA names are re-used (as even released SSA names have to remain valid lattice entries after this). But currently nothing will create new SSA names (fingers crossing) during eliminate. A followup patch of mine will

[PATCH v2] Replace C/C++ void_zero_node with a VOID_CST tree code

2014-05-20 Thread Richard Sandiford
This is an updated version of the patch to replace void_zero_node with void_node. The main controversial point/hack in the original was that it handled void_node in the gimplifier as a zero constant. Jason sent me a patch that traps the dummy object in the front end, meaning that it no longer esc

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-20 Thread Jeff Law
On 05/20/14 01:13, Bin.Cheng wrote: The idea being that common cases where a pair moves can be turned into a single wider move without having to write target code to make that happen much of the time. ie 2xQI->HI, 2xHI->SI, 2xSI->DI 2xSF->DF. For things outside those simple cases, fall back to

Commit: MSP430: Fix some gcc testsuite failures

2014-05-20 Thread Nick Clifton
Hi Guys, I am checking in the patch below (to both the mainline and the 4.9 branch) in order to fix some unexpected failures in the gcc testsuite with the msp430-elf toolchain. With this patch in place the following tests now pass: gcc.c-torture/execute/builtins/memcpy-chk.c gcc.

Re: [PATCH] Fix ICE in rtl-optimization/PR61220, PR61225

2014-05-20 Thread Jeff Law
On 05/20/14 01:11, Zhenqiang Chen wrote: Hi, The patch fix ICE issue triggered by shrink-wrapping enhancement. Bootstrap and no make check regression on X86-64. OK for trunk? Thanks! -Zhenqiang 2014-05-20 Zhenqiang Chen PR rtl-optimization/61220 Part of PR rtl-optimiza

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-20 Thread Wei Mi
On Tue, May 20, 2014 at 12:13 AM, Bin.Cheng wrote: > On Tue, May 20, 2014 at 1:30 AM, Jeff Law wrote: >> On 05/19/14 00:38, Bin.Cheng wrote: >>> >>> On Sat, May 17, 2014 at 12:32 AM, Jeff Law wrote: On 05/16/14 04:07, Bin.Cheng wrote: But can't you go through movXX

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-20 Thread Jeff Law
On 05/20/14 11:14, Wei Mi wrote: On Tue, May 20, 2014 at 12:13 AM, Bin.Cheng wrote: On Tue, May 20, 2014 at 1:30 AM, Jeff Law wrote: On 05/19/14 00:38, Bin.Cheng wrote: On Sat, May 17, 2014 at 12:32 AM, Jeff Law wrote: On 05/16/14 04:07, Bin.Cheng wrote: But can't you go through movXX

Re: [PATCH] Regression fix for PR target/61223

2014-05-20 Thread Yury Gribov
> For now, please revert your original patch Alex asked me to revert patch for him. Done in r210650. -Y

Re: [PATCH, sched] Cleanup and improve multipass_dfa_lookahead_guard

2014-05-20 Thread Jeff Law
On 05/19/14 22:27, Maxim Kuvyrkov wrote: Hi, This patch cleans up haifa-sched.c:choose_ready() function while allow more powerful customization by backends at the same time. The primary change is that targetm.sched.first_cycle_multipass_dfa_lookahead_guard hook is converted from returning a boo

Re: [PATCH v2] Replace C/C++ void_zero_node with a VOID_CST tree code

2014-05-20 Thread Jason Merrill
OK. I've committed my patch. Jason

Re: [PATCH, AArch64] Fix for PR61202

2014-05-20 Thread Carrot Wei
Hi James Thank you for pointing this out. In the new patch I removed the modification of vqdmulh_n_s32 and vqdmulhq_n_s32. Passed dejagnu testing on aarch64 qemu again. OK for trunk, 4.9 and 4.8? 2014-05-20 Guozhi Wei * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the la

Re: [C++ Patch/RFC] PR 58753 & 58930

2014-05-20 Thread Jason Merrill
OK. Jason

Re: RFA: cache enabled attribute by insn code

2014-05-20 Thread Jeff Law
On 05/20/14 02:16, Richard Sandiford wrote: get_attr_enabled was showing up high in a -O0 compile of fold-const.ii. At the moment, extract_insn calls this function for every alternative on each extraction, which can be expensive for instructions like moves that have many alternatives. The attrib

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-20 Thread Mark Wielaard
On Tue, May 20, 2014 at 10:43:22AM -0400, Jason Merrill wrote: > On 05/20/2014 02:55 AM, Mark Wielaard wrote: > >On Mon, May 19, 2014 at 04:50:35PM -0400, Jason Merrill wrote: > >>On 05/13/2014 03:21 AM, Mark Wielaard wrote: > >>>So the debugger doesn't have to guess the properties of the enum's >

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Teresa Johnson
On Tue, May 20, 2014 at 8:39 AM, Xinliang David Li wrote: > On Tue, May 20, 2014 at 6:32 AM, Teresa Johnson wrote: >> On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li >> wrote: >>> Why duplicating the merger functions in dyn-ipa.c? Should those in >>> libgcov-merge.c be reused? >> >> The mer

[PATCH] dump_case_nodes: Treat unsigned as unsigned, don't ICE

2014-05-20 Thread Segher Boessenkool
The current code converts every tree to signed hwi; this ICEs with values not representable as shwi, like 999ULL in pr34154.c (and if it didn't ICE, it would print the wrong value). This fixes it. Bootstrapped and tested on powerpc64-linux. Okay to apply? Segher 2014-05-20 S

Re: RFA: cache recog_op_alt by insn code

2014-05-20 Thread Jeff Law
On 05/20/14 02:19, Richard Sandiford wrote: Following on from (and depending on) the last patch, process_constraints also shows up high in the profile. This patch caches the recog_op_alt information by insn code too. It also shrinks the size of the structure from 1 pointer + 5 ints to 1 pointer

Re: [PATCH] Fix PR61221

2014-05-20 Thread Richard Biener
On May 20, 2014 6:47:44 PM CEST, Jeff Law wrote: >On 05/20/14 02:06, Richard Biener wrote: >> >> We're still going to have problems if SSA names are re-used >> (as even released SSA names have to remain valid lattice >> entries after this). But currently nothing will create new >> SSA names (fing

Re: [PATCH] Fix PR61221

2014-05-20 Thread Jeff Law
On 05/20/14 12:13, Richard Biener wrote: I think it's still important for things like keeping SSA names densely allocated and for reuse on SSA rewrite of virtual operands for example. So I'm thinking of an explicit stop-/restart-reuse interface. Fair enough. WRT dense allocation, we could proba

[PATCH, rs6000] Fix HTM __builtin_ttest rtl expansion

2014-05-20 Thread Peter Bergner
The following patch fixes a semi-latent bug for the HTM pattern used with the __builtin_ttest() builtin. This is supposed to expand to a tabortwci. instruction which sets cr0 and then some code that copies the cr0 value into a gpr and then shifts and masks it into the lowest 2 bits in the gpr. Wi

Re: [patch] libstdc++/61143 make unordered containers usable after move

2014-05-20 Thread Jonathan Wakely
On 19/05/14 22:27 +0200, François Dumont wrote: On 15/05/2014 22:52, Jonathan Wakely wrote: Does this get initialized in the constructors? Would it make sense to give it an initializer? __bucket_type_M_single_bucket = nullptr; This bucket is replacing those normally allocated a

Re: [patch ping] libstdc++ testsuite cxxflags

2014-05-20 Thread Cesar Philippidis
On 05/20/2014 02:11 AM, Jonathan Wakely wrote: > On 19/05/14 14:57 -0600, Sandra Loosemore wrote: >> On 05/17/2014 04:07 AM, Jonathan Wakely wrote: >>> On 17 May 2014 10:50, Jonathan Wakely wrote: On 17 May 2014 01:16, Sandra Loosemore wrote: > It appears that this patch from last fall nev

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-20 Thread Jason Merrill
On 05/20/2014 01:51 PM, Mark Wielaard wrote: The DWARF part isn't what this patch is blocked on. That has already been discussed on the DWARF standard list, coordinated with the gdb hackers and approved some months ago. Fair enough. The part that hasn't been reviewed and approved yet is the f

Add flag to optionally ignore ELF interposition

2014-05-20 Thread Jan Hubicka
Hi, as disucssed some time ago, our assumption that every symbol of shared library can be interposed at runtime is expensive and prevents a lot of useful optimizations, including inlining or IPA propagation. While this is useful feature, it is rather incommon to use it for bigger C++ projects, l

Re: add dbgcnt and opt-info support for devirtualization

2014-05-20 Thread Xinliang David Li
On Tue, May 20, 2014 at 4:32 AM, Richard Biener wrote: > On Mon, May 19, 2014 at 5:24 PM, Xinliang David Li wrote: >> Sorry about it. Here is the patch. There is one remaining case where >> cgraph_dump_file and dump_enable_p are checked separately -- >> cgraph_dump_file is set up differently fro

Re: [PATCH] Implement -fsanitize=float-cast-overflow (take 2)

2014-05-20 Thread Marek Polacek
Thanks for all your help. This is updated patch which: * uses mix/min handling that Jakub kindly wrote, * limited a test to ilp32 || lp64 + used sse2_runtime (but it's likely I screwed it up as usually), * adds a testcase for (unsigned) __int128, * adds testcases for C and C++ bit-fields, * mak

Re: [PATCH, rs6000] Fix HTM __builtin_ttest rtl expansion

2014-05-20 Thread David Edelsohn
On Tue, May 20, 2014 at 3:28 PM, Peter Bergner wrote: > The following patch fixes a semi-latent bug for the HTM pattern used with > the __builtin_ttest() builtin. This is supposed to expand to a tabortwci. > instruction which sets cr0 and then some code that copies the cr0 value > into a gpr and

Re: [patch] libstdc++/61143 make unordered containers usable after move

2014-05-20 Thread François Dumont
On 20/05/2014 21:36, Jonathan Wakely wrote: OK. My sketch above avoided calling _M_moved_from() more than once per object, but the compiler should be able to optimise your version to avoid multiple calls anyway. Here is the new patch limited to what I really want to commit this time. Great.

Re: [PATCH] dump_case_nodes: Treat unsigned as unsigned, don't ICE

2014-05-20 Thread Mike Stump
On May 20, 2014, at 10:58 AM, Segher Boessenkool wrote: > The current code converts every tree to signed hwi; this ICEs with > values not representable as shwi, like 999ULL Looks nice to me… Looks like the type of change I would have done for wide-int, if I had tripped on this.

Re: [PATCH, PR C++/61038] - g++ -E is unusable with UDL strings

2014-05-20 Thread Jason Merrill
On 05/13/2014 08:59 PM, Ed Smith-Rowland wrote: + escape_it = escape_it || cpp_userdef_string_p (token->type) + || cpp_userdef_char_p (token->type); Let's add the new cases to the previous statement instead of a new one. OK with that change. Jason

[msp430] fix addneghi and add split

2014-05-20 Thread DJ Delorie
Minor bugfixes. Committed to head and 4.9 branch. * config/msp430/msp430.md (split): Don't allow subregs when splitting SImode adds. (andneghi): Fix subtraction logic. * config/msp430/predicates.md (msp430_nonsubreg_or_imm_operand): New. Index: config/msp430/pred

  1   2   >