On 05/20/14 17:05, Alexey Merzlyakov wrote:
Hi all,
This is a fix for thumb1 build fail on trunk appeared since
rev.210515(pr60758).
On thumb1 targets the LR can not be used as argument of POP instruction.
To keep a support of __cxa_end_cleanup backtracing on thumb1
we can make additional register operations before push/pop.
But I guess, this will have a negative effect on __cxa_end_cleanup
performance.
So, I propose to preserve __cxa_end_cleanup backtracing on thumb2
architectures and revert it on thumb1.
Regtest was finished with no regressions on C/C++ arm-linux-gnueabi(sf).
For now, please revert your original patch and one of Richard or me will
try to look at it in the morning. The thumb1 case is slightly more
complicated than this.
I don't like this approach as you are introducing the problem again in
ARM state and leaving the problem as is for Thumb1.
regards
Ramana
Best regards,
Merzlyakov Alexey
