Re: [libitm] Link with -litm and -pthread

2012-02-14 Thread Eric Botcazou
> It broke all targets that don't implement threads and as such > don't support -pthread. And you need to gate *all* tm-related > tests on something like check_effective_target_pthread. The question is, how is libitm supposed to work on these systems? The configure.ac file contains: # Check to

Re: trans-mem: virtual ops for gimple_transaction

2012-02-14 Thread Richard Guenther
On Mon, 13 Feb 2012, Richard Henderson wrote: > On 02/13/2012 01:35 AM, Richard Guenther wrote: > > On Fri, 10 Feb 2012, Richard Henderson wrote: > > > >> On 02/10/2012 01:44 AM, Richard Guenther wrote: > >>> What is the reason to keep a GIMPLE_TRANSACTION stmt after > >>> TM lowering and not low

C++ PATCH for c++/39055 (accepts-valid with 'this' in default argument)

2012-02-14 Thread Jason Merrill
This is a regression since 3.3; discussion at the C++ meeting last week concluded both that yes, this is ill-formed, and we think it should be ill-formed. Tested x86_64-pc-linux-gnu, applying to trunk. commit 399365c251914176b5b34076e5a7b4658c06e917 Author: Jason Merrill Date: Fri Feb 10 22:

Re: [PATCH] Fix up vectorizer cost model use of uninitialized value (PR tree-optimization/52210)

2012-02-14 Thread Richard Guenther
On Mon, 13 Feb 2012, Jakub Jelinek wrote: > Hi! > > The PR50912 changed vect_get_and_check_slp_defs dt from > array into scalar, which fails when calling vect_model_simple_cost > which looks at two array members. I believe even 4.6 checked just > the first operand, as it called it when processin

Re: [libitm] Add SPARC bits

2012-02-14 Thread Eric Botcazou
> I think you really need to put the proper value into the %fp register > atomically here. > > If an interrupt comes in before you STACK_BIAS adjust the %fp, a > debugger or similar could see a corrupt frame pointer. OK, I'm going to make the change. -- Eric Botcazou

Re: [libitm] Add SPARC bits

2012-02-14 Thread Eric Botcazou
> We probably want to do some nop'ish thing here which will yield the > cpu thread on Niagara cpus, I'd recommend something along the lines of > "rd %ccr, %g0" or "rd %y, %g0" I'm going for the former, thanks. -- Eric Botcazou

Re: [PATCH] Prefer reg as first operand in commutative operator

2012-02-14 Thread Jakub Jelinek
On Tue, Feb 14, 2012 at 07:27:21AM +, Paulo J. Matos wrote: > case RTX_OBJ: >/* Complex expressions should be the first, so decrease priority > of objects. Prefer pointer objects over non pointer objects. */ > - if ((REG_P (op) && REG_POINTER (op)) > - || (ME

Patch ping

2012-02-14 Thread Jakub Jelinek
Hi! I'd like to ping two patches: - http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01335.html PR debug/51950P2 -gdwarf-4 -fdebug-types-section cloning bug - http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00496.html PR middle-end/51929 P1 cgraph verification failure with same body a

Re: [PING] New port resubmission for TILEPro and TILE-Gx

2012-02-14 Thread Walter Lee
On 2/13/2012 6:30 PM, Mike Stump wrote: > On Feb 13, 2012, at 1:43 PM, Walter Lee wrote: >> Thanks for the review. Do I have permission to commit, > > Yes, you do. Richard can approve this, and when he says, Ok., you're good to > go. > >> or is there anything else I need to do? > > Nope. (As

Re: [C++ Patch] PR 51494 (and 52183)

2012-02-14 Thread Paolo Carlini
Hi, This patch fixes this particular bug, but there are some issues. First, non_static_member_function_p only checks the first function in the overload set, which may not be representative of all of them. It really shouldn't look through OVERLOADs, we need to defer this decision until build_

[Patch, Fortran] PR 52196 add -Wrealloc-lhs(-all)

2012-02-14 Thread Tobias Burnus
Hi all, in order to gain an overview for our code whether the recent RESHAPE (and friends) bug affects us and to determine for which assignment a reallocation happens, useful to mitigate performance issues, I added -Wrealloc-lhs and -Wrealloc-lhs-all. The flag -Wrealloc-lhs is the more usefu

Re: [libitm] Link with -litm and -pthread

2012-02-14 Thread Hans-Peter Nilsson
On Tue, 14 Feb 2012, Eric Botcazou wrote: > > It broke all targets that don't implement threads and as such > > don't support -pthread. And you need to gate *all* tm-related > > tests on something like check_effective_target_pthread. > > The question is, how is libitm supposed to work on these sys

Re: [RFC, 4.8] Magic matching for flags clobbering and setting

2012-02-14 Thread Paolo Bonzini
On 02/14/2012 12:52 AM, Steven Bosscher wrote: Other than that: To convert a port, there is still a lot of work to be done to define and handle the various CC modes properly (well, not for the pdp11, because it writes out >1 insn for most define_insns), but it is great not having to define all th

Re: [patch] libitm: Fix race condition in dispatch choice at transaction begin.

2012-02-14 Thread Torvald Riegel
On Mon, 2012-02-13 at 15:12 -0800, Richard Henderson wrote: > On 02/13/2012 03:03 PM, Torvald Riegel wrote: > > -// The default TM method used when starting a new transaction. > > -static GTM::abi_dispatch* default_dispatch = 0; > > +// The default TM method used when starting a new transaction. I

Re: [patch] libitm: Add multi-lock, write-through TM method.

2012-02-14 Thread Torvald Riegel
On Mon, 2012-02-13 at 14:50 -0800, Richard Henderson wrote: > On 02/13/2012 01:47 PM, Torvald Riegel wrote: > > + // Location-to-orec mapping. Stripes of 16B mapped to 2^19 orecs. > > + static const gtm_word L2O_ORECS = 1 << 19; > > + static const gtm_word L2O_SHIFT = 4; > > Is it just easier

Re: [PATCH] Prefer reg as first operand in commutative operator

2012-02-14 Thread Paolo Bonzini
On 02/14/2012 10:52 AM, Jakub Jelinek wrote: >/* Complex expressions should be the first, so decrease priority > of objects. Prefer pointer objects over non pointer objects. */ > - if ((REG_P (op) && REG_POINTER (op)) > -|| (MEM_P (op) && MEM_POINTER (op))) > - retur

Re: libgo patch committed: Update to weekly.2011-12-22

2012-02-14 Thread Rainer Orth
Ian Lance Taylor writes: >> Most of them are like >> >> Start pollServer: epoll_ctl: Bad file descriptor >> panic: runtime error: invalid memory address or nil pointer dereference >> FAIL: net > > That sort of problem should be fixed now, by > > http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00110.

Re: [PATCH] Prefer reg as first operand in commutative operator

2012-02-14 Thread Paulo J. Matos
On 14/02/12 09:52, Jakub Jelinek wrote: On Tue, Feb 14, 2012 at 07:27:21AM +, Paulo J. Matos wrote: case RTX_OBJ: /* Complex expressions should be the first, so decrease priority of objects. Prefer pointer objects over non pointer objects. */ - if ((REG_P (op)

Re: [PATCH] Prefer reg as first operand in commutative operator

2012-02-14 Thread Paulo J. Matos
On 14/02/12 13:46, Paolo Bonzini wrote: On 02/14/2012 10:52 AM, Jakub Jelinek wrote: > /* Complex expressions should be the first, so decrease priority > of objects. Prefer pointer objects over non pointer objects. */ > - if ((REG_P (op) && REG_POINTER (op)) > - || (MEM_P (op) && MEM_POINTER (op

Re: [PATCH] Prefer reg as first operand in commutative operator

2012-02-14 Thread Jakub Jelinek
On Tue, Feb 14, 2012 at 02:05:30PM +, Paulo J. Matos wrote: > >I think the register allocator will generate good code using % if you > >make your predicate nonimmediate_operand in operand 1: > > > >(define_insn "iorqi3" > >[(set (match_operand:QI 0 "register_operand" "=c") > >(ior:QI (match_ope

Re: [PATCH] Prefer reg as first operand in commutative operator

2012-02-14 Thread Paulo J. Matos
On 14/02/12 14:10, Jakub Jelinek wrote: It doesn't allow that, because the condition on the insn then fails, as neither operand 1 nor operand 2 is register_operand. Jakub Oh!!! I incorrectly read the instruction as I had initially tried it and I knew it was failing, however, I didn

[PATCH] Fix PR52244 (and 51528 for real)

2012-02-14 Thread Richard Guenther
This fixes the issue that SRA creates access replacements that cannot represent all values that can be represented with the storage of the access. The simple thing to do is to create an access replacement with a type that covers the whole access. Of course there is the catch that we cannot do th

[PATCH, testsuite]: Fix gcc.dg/lower-subreg-1.c failure

2012-02-14 Thread Uros Bizjak
Hello! 2012-02-14 Uros Bizjak * gcc.dg/lower-subreg-1.c: Fix and simplify target selector. Tested on x86_64-pc-linux-gnu {,-m32}, committed to mainline SVN. Uros. Index: gcc.dg/lower-subreg-1.c === --- gcc.dg/lower-subre

Re: [libitm] Link with -litm and -pthread

2012-02-14 Thread Andreas Krebbel
On 02/11/2012 03:14 PM, Eric Botcazou wrote: > Hi, > > this completes the half-implemented linking scheme of libitm and makes it > mimic > that of libgomp entirely. We need the -pthread thing on Solaris 8. > > Tested on SPARC/Solaris 8 & 9 and i586/Linux, OK for the mainline? > > > 2012-02-1

[PATCH] Reserve upper bits of memory model for future use

2012-02-14 Thread Andrew MacLeod
This patch just modifies the documention to indicate that the upper bits of the memory model parameter are reserved for future use. (We're already looking at using it for HLE hints) I've already made a change on the wiki page. Ok for mainline? Andrew * extend.texi: Reserve upper bits

Re: [libitm] Link with -litm and -pthread

2012-02-14 Thread Iain Sandoe
On 14 Feb 2012, at 16:08, Andreas Krebbel wrote: On 02/11/2012 03:14 PM, Eric Botcazou wrote: Hi, this completes the half-implemented linking scheme of libitm and makes it mimic that of libgomp entirely. We need the -pthread thing on Solaris 8. Tested on SPARC/Solaris 8 & 9 and i586/Linu

Re: [PATCH] Reserve upper bits of memory model for future use

2012-02-14 Thread Jakub Jelinek
On Tue, Feb 14, 2012 at 11:23:58AM -0500, Andrew MacLeod wrote: > This patch just modifies the documention to indicate that the upper > bits of the memory model parameter are reserved for future use. > (We're already looking at using it for HLE hints) > > I've already made a change on the wiki pag

Re: PATCH: Add capability to contrib/compare_tests to handle directories

2012-02-14 Thread Quentin Neill
On Sat, Feb 11, 2012 at 8:13 AM, Mike Stump wrote: > On Nov 4, 2011, at 8:23 PM, Quentin Neill wrote: >> My scenario about "ANY test results changed" is what I added with -strict. >> This patch concatenates the common .sum files before comparing. > > So, how exactly does this work for you: > > +  

Re: PATCH: Add capability to contrib/compare_tests to handle directories

2012-02-14 Thread Quentin Neill
On Tue, Feb 14, 2012 at 10:39 AM, Quentin Neill wrote: > On Sat, Feb 11, 2012 at 8:13 AM, Mike Stump wrote: >> On Nov 4, 2011, at 8:23 PM, Quentin Neill wrote: >>> My scenario about "ANY test results changed" is what I added with -strict. >>> This patch concatenates the common .sum files before c

PR middle-end/52141: ICE due to asm statement

2012-02-14 Thread Aldy Hernandez
I swear, these inline asms in transactions are going to be the death of me. In the attached testcase diagnose_tm_blocks() and lower_tm() do not recognize the GIMPLE_ASM because early inlining has not yet run, so there is nothing to see. However, by the time we run the IPA TM pass, the assembl

[PATCH][ARM,ifcvt] Improve use of conditional execution in thumb mode.

2012-02-14 Thread Andrew Stubbs
Hi all, I've discovered that GCC does not use ARM conditional execution for 16-bit Thumb opcodes in many cases. It's fine for individual instructions, but if-conversion of basic blocks with more than one instruction fails. E.g. int foo (int a, int b) { if (a != b) { a = a << b;

[PATCH?, 4.7 regression] Crash in ira-costs.c with -fschedule-insns -fsched-pressure -fdump-rtl-sched1

2012-02-14 Thread Ulrich Weigand
Hello, compiling anything, even just an empty function, with -fschedule-insns -fsched-pressure -fdump-rtl-sched1 causes the compiler to crash: Program received signal SIGSEGV, Segmentation fault. 0x0840d9e0 in REG_N_REFS (regno=58) at ../../gcc-head/gcc/regs.h:75 75return regstat_n_sets

[lra] a patch to fix some x86-64 SPECFP2000 regressions

2012-02-14 Thread Vladimir Makarov
The following patch fixes some x86-64 SPECFP2000 regressions. The wrong choosing register class for split pseudos resulted in wrong assignments to reload pseudos afterwards. The patch was successfully bootstrapped on x86/x86-64. Committed as rev. 184215. 2012-02-14 Vladimir Makarov

Re: [PATCH][ARM,ifcvt] Improve use of conditional execution in thumb mode.

2012-02-14 Thread Richard Earnshaw
On 14/02/12 16:53, Andrew Stubbs wrote: > Hi all, > > I've discovered that GCC does not use ARM conditional execution for > 16-bit Thumb opcodes in many cases. It's fine for individual > instructions, but if-conversion of basic blocks with more than one > instruction fails. > > E.g. > > int >

RE: [Patch,AVR]: Built-in for non-contiguous port layouts

2012-02-14 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay > Sent: Monday, February 13, 2012 9:01 AM > To: gcc-patches@gcc.gnu.org > Cc: Weddington, Eric; Denis Chertykov > Subject: [Patch,AVR]: Built-in for non-contiguous port layouts > > This patch set removes __builtin_avr_map8 __builtin_avr_map1

Re: [PATCH][ARM,ifcvt] Improve use of conditional execution in thumb mode.

2012-02-14 Thread Richard Earnshaw
On 14/02/12 17:30, Richard Earnshaw wrote: > On 14/02/12 16:53, Andrew Stubbs wrote: >> Hi all, >> >> I've discovered that GCC does not use ARM conditional execution for >> 16-bit Thumb opcodes in many cases. It's fine for individual >> instructions, but if-conversion of basic blocks with more than

[wwwdocs] add information on TILE-Gx/TILEPro ports

2012-02-14 Thread Walter Lee
This patch adds information on the Tile-Gx/TILEPro ports to wwwdocs. Ok to commit? (assuming I have commit rights which I have not tried.) Thanks, Walter Index: backends.html === RCS file: /cvs/gcc/wwwdocs/htdocs/backends.html,v re

Re: PR middle-end/52141: ICE due to asm statement

2012-02-14 Thread Richard Henderson
On 02/14/2012 08:46 AM, Aldy Hernandez wrote: > The call to ipa_tm_diagnose_tm_safe() does nothing because there are no > longer any calls in the function, since the function call has been inlined: > > f () > { > : > __asm__ __volatile__(""); > return; > > } > > Perhaps we could issue the e

Re: [Patch,AVR]: Built-in for non-contiguous port layouts

2012-02-14 Thread Georg-Johann Lay
Weddington, Eric wrote: > >> >> This patch set removes __builtin_avr_map8 __builtin_avr_map16 >> built-ins and implements a built-in __builtin_avr_insert_bits instead. >> > > In your avr_fold_builtin function you have switch (fcode) with only one > case (and a "default" that just breaks). Are you

Re: [PATCH] Reserve upper bits of memory model for future use

2012-02-14 Thread Andrew MacLeod
On 02/14/2012 11:28 AM, Jakub Jelinek wrote: On Tue, Feb 14, 2012 at 11:23:58AM -0500, Andrew MacLeod wrote: This patch just modifies the documention to indicate that the upper bits of the memory model parameter are reserved for future use. (We're already looking at using it for HLE hints) I've

Re: [PATCH][ARM] Improve use of conditional execution in thumb mode.

2012-02-14 Thread Andrew Stubbs
On Tue 14 Feb 2012 17:35:36 GMT, Richard Earnshaw wrote: Bernds checked in a patch last year (or maybe even before that) to make the selection of flags clobbered insns run very late (certainly after condexec had run), so I'm not sure why you're not seeing this. Hm, you mentioned some peepholes.

Re: [PATCH][ARM] Improve use of conditional execution in thumb mode.

2012-02-14 Thread Andrew Stubbs
And again with the attachment. On Tue 14 Feb 2012 18:00:57 GMT, Andrew Stubbs wrote: On Tue 14 Feb 2012 17:35:36 GMT, Richard Earnshaw wrote: Bernds checked in a patch last year (or maybe even before that) to make the selection of flags clobbered insns run very late (certainly after condexec ha

libgo patch committed: Fix hash function for big-endian 32bit systems

2012-02-14 Thread Ian Lance Taylor
This libgo patch fixes the identity hash function for big-endian 32-bit systems. Before this patch the hash code for a 32-bit value always turned out to be zero on a big-endian 32-bit system. This patch fixes the problem. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed

PR middle-end/52142: disallow inlining of certain TM_pure functions

2012-02-14 Thread Aldy Hernandez
Here we inline a transaction_pure function into a non transaction_pure function, but end up instrumenting all the memory operations in the tm_pure function regardless. As discussed in the PR, we should've disallowed inlining of TM_pure functions into non TM_pure functions. We are currently on

Go testsuite patch committed: Don't optimize generated files

2012-02-14 Thread Ian Lance Taylor
This patch to the Go testsuite drivers disables optimizations when compiling the generated files produced for the 64bit and index tests. These generated files are large, and optimizing them can cause testsuite timeouts on slow systems. Optimizing the code is not essential for the tests, and the te

Re: [PATCH, libitm]: GTM_longjmp: Jump indirect from memory address

2012-02-14 Thread Richard Henderson
On 02/13/2012 11:54 PM, Uros Bizjak wrote: > movq48(%rsi), %r15 > - movq56(%rsi), %rdx > movl%edi, %eax > + cfi_offset(%rip, 56) > cfi_def_cfa(%rcx, 0) > - cfi_register(%rip, %rdx) > movq%rcx, %rsp > - jmp *%rdx > + jmp *56(%rsi)

Re: PR middle-end/52142: disallow inlining of certain TM_pure functions

2012-02-14 Thread Richard Henderson
On 02/14/2012 10:04 AM, Aldy Hernandez wrote: > PR middle-end/52142 > * ipa-inline.c (can_inline_edge_p): Do not inline tm_pure > functions into non-tm_pure functions. Ok. r~

Re: [PATCH, libitm]: GTM_longjmp: Jump indirect from memory address

2012-02-14 Thread Uros Bizjak
On Tue, Feb 14, 2012 at 7:07 PM, Richard Henderson wrote: > On 02/13/2012 11:54 PM, Uros Bizjak wrote: >>       movq    48(%rsi), %r15 >> -     movq    56(%rsi), %rdx >>       movl    %edi, %eax >> +     cfi_offset(%rip, 56) >>       cfi_def_cfa(%rcx, 0) >> -     cfi_register(%rip, %rdx) >>      

Re: [PATCH][ARM] Improve use of conditional execution in thumb mode.

2012-02-14 Thread Richard Earnshaw
On 14/02/12 18:01, Andrew Stubbs wrote: > And again with the attachment. > > On Tue 14 Feb 2012 18:00:57 GMT, Andrew Stubbs wrote: >> On Tue 14 Feb 2012 17:35:36 GMT, Richard Earnshaw wrote: Bernds checked in a patch last year (or maybe even before that) to make the selection of flags cl

Re: PR middle-end/52142: disallow inlining of certain TM_pure functions

2012-02-14 Thread Torvald Riegel
On Tue, 2012-02-14 at 12:04 -0600, Aldy Hernandez wrote: > Here we inline a transaction_pure function into a non transaction_pure > function, but end up instrumenting all the memory operations in the > tm_pure function regardless. > > As discussed in the PR, we should've disallowed inlining of T

Re: [PATCH] Fix -gdwarf-4 -fdebug-types-section cloning (PR debug/51950)

2012-02-14 Thread Jason Merrill
OK. Jason

[Patch,AVR] Add xmega support

2012-02-14 Thread Georg-Johann Lay
This patch adds support for xmega cores and does the following: * Add architectures avrxmega2/4/5/6/7 to avr-devices.c * Add some xmega MCUs to avr-mcus.def * Add new function avr.c:avr_out_movhi_mr_r_xmega that works similar to out_movhi_mr_r except that the low byte is output first. Ration

Go patch committed: Fix gccgo cross-install name

2012-02-14 Thread Ian Lance Taylor
PR 48411 points out that when cross-compiling gccgo is being installed under the name $(TARGET)-$(TARGET)-gccgo. This patch fixes it by making it behave like cp/Make-lang.in. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2012-02-14 Ian Lance Taylor PR go/484

Re: [patch] libitm: Fix race condition in dispatch choice at transaction begin.

2012-02-14 Thread Richard Henderson
[ bkoz, see below ] On 02/14/2012 04:48 AM, Torvald Riegel wrote: > BTW, why can we assume that the dispatch objects are initialized before > we run any transactions (e.g., from within a constructor of another > static object)? Or is this the library initialization problem that we > still have t

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-14 Thread Jason Merrill
On 02/10/2012 06:25 AM, Jakub Jelinek wrote: PR middle-end/51929 * cgraphunit.c (verify_edge_corresponds_to_fndecl): If node is a same_body_alias, also test whether e->callee isn't a former or current clone of the decl this is a same body alias of. Do we want a s

[C++ PATCH] Fix ICE with asm goto in template (PR c++/52247)

2012-02-14 Thread Jakub Jelinek
Hi! We weren't transforming the asm goto LABEL_DECLs at all, while when in LABEL_EXPR or in goto stmt they are remapped. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-02-14 Jakub Jelinek PR c++/52247 * pt.c (tsubst_copy_asm_operands):

[google]Emit GNU-stack note for arm targets by default (issue5649090)

2012-02-14 Thread Jing Yu
arm-eabi toolchain needs GNU-stack note for security purpose. Will Keep this patch in google branches. OK for google/main? I would like to port this patch to google/gcc-4_6, google/gcc-4_6-mobile, google/gcc-4_6_2-moible. 2012-02-14 Jing Yu Google ref 42402-p2 * config/arm/arm.

libgo patch committed: Change Dup2 to only return an error

2012-02-14 Thread Ian Lance Taylor
In the master Go library the syscall.Dup2 function was changed to only return an error, rather than returning both the new file descriptor and and an error (when there is no error the new file descriptor is always the second argument anyhow). This patch makes the same change to libgo. Bootstrappe

Re: [google]Emit GNU-stack note for arm targets by default (issue5649090)

2012-02-14 Thread Xinliang David Li
ok. On Tue, Feb 14, 2012 at 11:34 AM, Jing Yu wrote: > arm-eabi toolchain needs GNU-stack note for security purpose. > Will Keep this patch in google branches. > > OK for google/main? > I would like to port this patch to google/gcc-4_6, google/gcc-4_6-mobile, > google/gcc-4_6_2-moible. > > 2012-0

libgo patch committed: Don't put .gox files in version-specific dirs

2012-02-14 Thread Ian Lance Taylor
The .gox files are always put in directories whose names include the gcc version number and the target name. This is because the .gox files are version specific and not backward compatible. PR 48410 points out that when using the --enable-version-specific-runtime-libs configure option, this cause

Re: PR middle-end/52142: disallow inlining of certain TM_pure functions

2012-02-14 Thread Richard Henderson
On 02/14/2012 10:39 AM, Torvald Riegel wrote: > Will it inline transaction_pure into transaction_callable too? That > would not be good if we actually instrument the transaction_callable. No, it restricts pure into pure and into nothing else. > Inlining transaction_pure into completely nontransa

RE: [Patch,AVR]: Built-in for non-contiguous port layouts

2012-02-14 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay > Sent: Tuesday, February 14, 2012 10:52 AM > To: Weddington, Eric > Cc: gcc-patches@gcc.gnu.org; Denis Chertykov > Subject: Re: [Patch,AVR]: Built-in for non-contiguous port layouts > > Weddington, Eric wrote: > > > >> > >> This patch set rem

RE: [Patch,AVR] Add xmega support

2012-02-14 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay > Sent: Tuesday, February 14, 2012 11:52 AM > To: gcc-patches@gcc.gnu.org > Cc: Weddington, Eric; Denis Chertykov; Anatoly Sokolov > Subject: [Patch,AVR] Add xmega support > > This patch adds support for xmega cores and does the following: P

Re: [C++ PATCH] Fix ICE with asm goto in template (PR c++/52247)

2012-02-14 Thread Jason Merrill
OK. Jason

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-14 Thread Jakub Jelinek
On Tue, Feb 14, 2012 at 11:12:31AM -0800, Jason Merrill wrote: > On 02/10/2012 06:25 AM, Jakub Jelinek wrote: > > PR middle-end/51929 > > * cgraphunit.c (verify_edge_corresponds_to_fndecl): If node is > > a same_body_alias, also test whether e->callee isn't a former > > or current c

Re: [PATCH, libitm]: GTM_longjmp: Jump indirect from memory address

2012-02-14 Thread Richard Henderson
On 02/14/2012 10:26 AM, Uros Bizjak wrote: > #ifdef __x86_64__ > + cfi_def_cfa(%rsi, 0) > movq(%rsi), %rcx > movq8(%rsi), %rbx > movq16(%rsi), %rbp > @@ -119,20 +120,21 @@ > movq32(%rsi), %r13 > movq40(%rsi), %r14 > movq48(%rsi), %r15

Patch: fix std::unordered_map (et al) pretty printer

2012-02-14 Thread Tom Tromey
Jakub mentioned a while back that the std::unordered_map pretty printer in libstdc++ was not working properly. This patch fixes the problems with this printer (and other printers using Tr1HashtableIterator). The problem was incorrect iteration of the hash table; I think all the nodes in the hash

Re: Patch: fix std::unordered_map (et al) pretty printer

2012-02-14 Thread Jonathan Wakely
On 14 February 2012 20:16, Tom Tromey wrote: > > Ok? OK, thanks!

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-14 Thread Jason Merrill
On 02/14/2012 11:49 AM, Jakub Jelinek wrote: Do we want a similar change to the use of former_clone_of in cgraph_update_edges_for_call_stmt_node? I don't think so. Then let's say the patch is OK tomorrow unless Jan objects today. Jason

Re: [Patch,AVR] Add xmega support

2012-02-14 Thread Georg-Johann Lay
Weddington, Eric schrieb: This patch adds support for xmega cores and does the following: Please commit. And thanks! :-) Eric As I wrote, the device <-> core assignments are the same as in ./gas/config/tc-avr.c: http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-avr.c?rev=1.79&co

libgo patch committed: Permit building without libffi

2012-02-14 Thread Ian Lance Taylor
This patch to libgo permits building libgo when using --without-libffi. This is mainly to aid porting. The resulting libgo has some limitations. Finalizers use libffi, and finalizers are used to arrange for the garbage collector to close open files when they are garbage collected. So using libgo

[patch] fix grammar in docs ("searched in" -> "searched for in")

2012-02-14 Thread Jonathan Wakely
* doc/install.texi (Prerequisites): Fix grammar. (Configuration): Likewise. This fixes two cases of "X searched in Y" which should be "X is searched for in Y" - committed as obvious. commit 5f7985d4dc30590112f07a896783202a7257b168 Author: Jonathan Wakely Date: Tue Feb 14 20:49:16

Fix testsuite regressions with -fgnu-tm

2012-02-14 Thread Hans-Peter Nilsson
> From: Hans-Peter Nilsson > Date: Tue, 14 Feb 2012 03:30:44 +0100 > you need to gate *all* tm-related > tests on something like check_effective_target_pthread. Like this, tested cris-elf, fixes the regressions, does the same as -fopenmp. Ok? gcc/testsuite: * lib/target-supports.exp (

Re: Fix testsuite regressions with -fgnu-tm

2012-02-14 Thread Richard Henderson
On 02/14/2012 01:10 PM, Hans-Peter Nilsson wrote: > Like this, tested cris-elf, fixes the regressions, does the same > as -fopenmp. > > Ok? > > gcc/testsuite: > > * lib/target-supports.exp (check_effective_target_fgnu_tm): New > proc. > * gfortran.dg/trans-mem-skel.f90: Gate te

Re: [Patch,AVR] Add xmega support

2012-02-14 Thread Richard Henderson
On 02/14/2012 10:52 AM, Georg-Johann Lay wrote: > It might be easier for the compiler if crucial SFRs are not modelled by > MEM but as REG instead, but for that change I don't know enough > about debugging formats and impact on gdb. > > Maybe Richard can comment on that? It's almost certainly goi

[patch] clean up pdp11.md a bit

2012-02-14 Thread Steven Bosscher
Hello, Just a few cleanups for things I noticed last weekend. * Constraints on define_expand are never used, remove them (most other ports do not have constraints on define_expands either) * Some patterns have no name, makes debugging a bit harder * The divmodhi4 expander has been commented out s

Re: [PATCH] Reserve upper bits of memory model for future use

2012-02-14 Thread Richard Henderson
On 02/14/2012 09:52 AM, Andrew MacLeod wrote: > On 02/14/2012 11:28 AM, Jakub Jelinek wrote: >> On Tue, Feb 14, 2012 at 11:23:58AM -0500, Andrew MacLeod wrote: >>> This patch just modifies the documention to indicate that the upper >>> bits of the memory model parameter are reserved for future use.

Re: [wwwdocs] update gcc-4.7/changes.html

2012-02-14 Thread Jonathan Wakely
On 12 February 2012 21:55, Jonathan Wakely wrote: > On 12 February 2012 18:25, Gerald Pfeifer wrote: >> On Wed, 8 Feb 2012, Jonathan Wakely wrote: >>> Add note on thread improvements to libstdc++ changes. >> >> Nice.  I have a hunch that many will be interested to learn which >> targets are now ben

Re: [patch] clean up pdp11.md a bit

2012-02-14 Thread Richard Henderson
On 02/14/2012 02:08 PM, Steven Bosscher wrote: > OK for trunk? This can wait for stage1. > +;; On PDP-11, DIV always produces a quotient and a remainder. But CSE > +;; cannot optimize the divmods away because the SET_DESTs are SUBREGs. > +; > ;(define_expand "divmodhi4" > ; [(parallel [(set (

Re: Fix testsuite regressions with -fgnu-tm

2012-02-14 Thread Eric Botcazou
> Like this, tested cris-elf, fixes the regressions, does the same > as -fopenmp. Thanks for fixing this. -- Eric Botcazou

Re: [libitm] Link with -litm and -pthread

2012-02-14 Thread Eric Botcazou
> I see several new fails on s390x with that patch (r184174): People should realize that -fgnu-tm doesn't really work if libitm hasn't been ported to the architecture, for example s390/s390x. My understanding is that Hans-Peter's patch should have taken care of this now. -- Eric Botcazou

New German PO file for 'gcc' (version 4.7-b20120128)

2012-02-14 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/gcc/de.po (This file, 'gcc-4.7-b20120128.de.po', h

Re: [patch] clean up pdp11.md a bit

2012-02-14 Thread Steven Bosscher
On Tue, Feb 14, 2012 at 11:51 PM, Richard Henderson wrote: > On 02/14/2012 02:08 PM, Steven Bosscher wrote: >> OK for trunk? > > This can wait for stage1. > >> +;; On PDP-11, DIV always produces a quotient and a remainder.  But CSE >> +;; cannot optimize the divmods away because the SET_DESTs are

Backported 6 patches to 4.6 branch

2012-02-14 Thread Jakub Jelinek
Hi! Further backported patches, bootstrapped/regtested on x86_64-linux and i686-linux, committed to 4.6 branch. It has been a while since 4.6.2 has been released, are there any blockers that should be resolved before 4.6.3-rc1? Jakub 2012-02-14 Jakub Jelinek PR bootstrap/5196

[v3] disable failing test on cygwin

2012-02-14 Thread Jonathan Wakely
The native_handle typesize test fails on cygwin, as with other targets where the assumption about sizes doesn't hold. Tested x86_64-linux, committed to trunk. commit 26b8bf489b27e7399305a19384c1cac4829b1a9f Author: Jonathan Wakely Date: Tue Feb 14 22:50:40 2012 + * 30_threads/threa

Re: [patch] clean up pdp11.md a bit

2012-02-14 Thread Richard Henderson
On 02/14/2012 03:41 PM, Steven Bosscher wrote: > Not sure why this was changed. What I'd like to do, is remove the > divhi3 and movhi3 define_expand and define_insn, and just keep > divmodhi4. You point to s390. I suppose you mean the divmoddi4 > expander there? Yes. Naturally the TImode stuff be

Re: [PATCH] Fix PR52178

2012-02-14 Thread Eric Botcazou
> This fixes PR52178, the failure to bootstrap Ada with LTO (well, > until you hit the next problem). A self-referential DECL_QUALIFIER > makes us think that a QUAL_UNION_TYPE type is of variable-size which > makes us stream that type locally, wrecking type merging and later > ICEing in the type v

Re: Backported 6 patches to 4.6 branch

2012-02-14 Thread Eric Botcazou
> Further backported patches, bootstrapped/regtested on x86_64-linux and > i686-linux, committed to 4.6 branch. It has been a while since 4.6.2 > has been released, are there any blockers that should be resolved before > 4.6.3-rc1? PR target/51921 (the pending patch is under PR target/52205). La

C6X: Fix floating point scheduling scheduling bug

2012-02-14 Thread Bernd Schmidt
We have code in the backend to predicate instructions with long delays while scheduling, so that they can be placed in jump delay slots. For example, [a1] b label nop 3 ldw *a2, a0 ;; this insn is from the basic block after the branch nop ;; branch occurs here is not safe even if

Re: [PR52001] too many cse reverse equiv exprs (take2)

2012-02-14 Thread Alexandre Oliva
On Feb 13, 2012, Richard Sandiford wrote: > does this avoid the kind of memrefs_conflict_p cycle I was seeing in: I don't know that it does, I'd missed that bit. If you still have a preprocessed testcase, I'd be glad to give it a quick try. Failing that, I can try a build on my yeeloong, but..

Re: [PR52001] too many cse reverse equiv exprs (take2)

2012-02-14 Thread Alexandre Oliva
On Feb 13, 2012, Jakub Jelinek wrote: > I'm not convinced you want the >> + /* Keep VALUE equivalences around. */ >> + for (l = v->locs; l; l = l->next) >> +if (GET_CODE (l->loc) == VALUE) >> + return true; > hunk in invariant_p, Yeah, maybe “invariant_p” is a misnomer. The thinking

C++ PATCH to warn about ignored attributes

2012-02-14 Thread Jason Merrill
While looking at PR 51930, I discovered that we were silently ignoring attributes on explicit instantiations; this patch warns about this. This isn't exactly a regression, but the submitter ran into it as a result of a behavior change in 4.7, and the patch is extremely safe, so I think it shoul

Re: PATCH: Add capability to contrib/compare_tests to handle directories

2012-02-14 Thread Mike Stump
On Feb 14, 2012, at 8:39 AM, Quentin Neill wrote: > Thanks for the fix. This seemed familiar, and upon review it looks > like I never committed this fix: > http://gcc.gnu.org/ml/gcc-patches/2011-11/msg01194.html Ah, ok, let's go with your version, it is much better. Thanks.

Re: Backported 6 patches to 4.6 branch

2012-02-14 Thread Kenny Simpson
Are any other recent trunk fixes to be backported - like the wrong-code bugs: PR tree-optimization/50444, PR tree-optimization/51528, or PR tree-optimization/46886 ? thanks, -Kenny

Re: [patch] [4.6] Backport strict-volatile-bitfields fix PR51200

2012-02-14 Thread Ye Joey
Ping^2 On Mon, Jan 16, 2012 at 11:21 AM, Ye Joey wrote: > Ping > > On Tue, Dec 27, 2011 at 10:19 AM, Ye Joey wrote: >> Fix PR51200. Backport trunk 182545, 182649, 182685 to 4.6. >> >> OK to 4.6? >> >> - Joey >> >>        2011-12-20  Bernd Schmidt   >> >>        PR middle-end/51200 >>        * ex