> -----Original Message----- > From: Georg-Johann Lay > Sent: Monday, February 13, 2012 9:01 AM > To: gcc-patches@gcc.gnu.org > Cc: Weddington, Eric; Denis Chertykov > Subject: [Patch,AVR]: Built-in for non-contiguous port layouts > > This patch set removes __builtin_avr_map8 __builtin_avr_map16 built-ins and > implements a built-in __builtin_avr_insert_bits instead. >
Hi Johann, I'm just now starting to review this patch, but I have a quick question... In your avr_fold_builtin function you have switch (fcode) with only one case (and a "default" that just breaks). Are you planning to add more cases in the near future? If not, wouldn't it be better to just make it an 'if' statement? Thanks, Eric
