Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts

2011-04-12 Thread Richard Guenther
On Tue, Apr 12, 2011 at 4:16 PM, Nathan Froyd wrote: > It's a shame more passes don't make use of the statistics_* > infrastructure.  This patch is a step towards rectifying that and adds > statistics_counter_event calls to passes mentioned in $SUBJECT. > postreload-gcse already tracked the stats

[9/9] Testsuite: Replace vect_strided with vect_stridedN

2011-04-12 Thread Richard Sandiford
This patch replaces the general vect_strided target selector with a group of vect_stridedN selectors, one for each tested stride factor N. Also, some tests used vect_interleave && vect_extract_even_odd for strided accesses. The two conditions used to be equivalent, but aren't after this series fo

Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts

2011-04-12 Thread Nathan Froyd
On Tue, Apr 12, 2011 at 04:27:01PM +0200, Richard Guenther wrote: > On Tue, Apr 12, 2011 at 4:16 PM, Nathan Froyd > wrote: > > It's a shame more passes don't make use of the statistics_* > > infrastructure.  This patch is a step towards rectifying that and adds > > statistics_counter_event calls

[10/9] Add tests for stride-3 accesses

2011-04-12 Thread Richard Sandiford
This patch adds a test for stride-3 accesses. I didn't add any particularly complicated cases because I think the testsuite already covers the interaction between the strided loads & stores and other operations pretty well. Let me know if there's something I should add though. Tested on x86_64-l

Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts

2011-04-12 Thread Richard Guenther
On Tue, Apr 12, 2011 at 4:32 PM, Nathan Froyd wrote: > On Tue, Apr 12, 2011 at 04:27:01PM +0200, Richard Guenther wrote: >> On Tue, Apr 12, 2011 at 4:16 PM, Nathan Froyd >> wrote: >> > It's a shame more passes don't make use of the statistics_* >> > infrastructure.  This patch is a step towards

Re: [2/9] Reindent parts of vectorizable_load and vectorizable_store

2011-04-12 Thread Richard Sandiford
Richard Guenther writes: > On Tue, Apr 12, 2011 at 3:28 PM, Richard Sandiford > wrote: >> This patch just reindents part of vectorizable_load and vectorizable_store >> so that the main diff is easier to read.  It also CSEs the element type, >> which seemed better than breaking the long lines. >>

Re: [PATCH 1/6] Linemap infrastructure for virtual locations

2011-04-12 Thread Dodji Seketeli
Hello, Sorry for getting back to this just now, and thank you very much for the review. Please find below my reply to your comments. Tom Tromey writes: > Dodji>expanded_location xloc; > Dodji>if (loc <= BUILTINS_LOCATION) > Dodji> -{ > Dodji> - xloc.file = loc == UNKNOWN_LOCAT

Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts

2011-04-12 Thread Nathan Froyd
On Tue, Apr 12, 2011 at 04:37:42PM +0200, Richard Guenther wrote: > On Tue, Apr 12, 2011 at 4:32 PM, Nathan Froyd > wrote: > > Thanks.  I may go twiddle that patch to do something similar to mine and > > submit that.  Do you use your patch for checking that the same set of > > optimizations get p

Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts

2011-04-12 Thread Richard Guenther
On Tue, Apr 12, 2011 at 4:51 PM, Nathan Froyd wrote: > On Tue, Apr 12, 2011 at 04:37:42PM +0200, Richard Guenther wrote: >> On Tue, Apr 12, 2011 at 4:32 PM, Nathan Froyd >> wrote: >> > Thanks.  I may go twiddle that patch to do something similar to mine and >> > submit that.  Do you use your pat

Re: Recording predicate information in all rtl gen* programs

2011-04-12 Thread Richard Sandiford
"H.J. Lu" writes: > I think your patch caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48573 Sorry, this didn't show up on pure x86_64. It was caused by the optabs.c patch rather than this one. I've reverted it for now. One fix would be: /* If the operand is a memory, try forcing th

Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts

2011-04-12 Thread Steven Bosscher
On Tue, Apr 12, 2011 at 4:37 PM, Richard Guenther wrote: > Yes, I used it exactly for that.  And also to verify that passes don't > do anything if replicated (well, for those that shouldn't at least). What about passes that undo the work of previous patches -- and then followed by a patch that re

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/11 02:45, Steven Bosscher wrote: > On Tue, Apr 12, 2011 at 9:01 AM, Jakub Jelinek wrote: >> On Tue, Apr 12, 2011 at 08:33:56AM +0200, Steven Bosscher wrote: >>> I think all these comments from you "old guys" ;-) are more >>> discouraging than

Re: [patch] ping1 unbreak bootstrap on FreeBSD ppc

2011-04-12 Thread Joern Rennecke
2011-03-12 Andreas Tobler * config/rs6000/freebsd.h: (RELOCATABLE_NEEDS_FIXUP): Define in terms of target_flags_explicit. Adjust copyright year. * config.gcc: Add FreeBSD PowerPC soft-float libgcc bits. * config/rs6000/t-freebsd: New file. Add override fo

Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts

2011-04-12 Thread Nathan Froyd
On Tue, Apr 12, 2011 at 04:54:43PM +0200, Richard Guenther wrote: > On Tue, Apr 12, 2011 at 4:51 PM, Nathan Froyd > wrote: > > True, but maybe those testcases should be adjusted--per-pass flags, > > rather than blindly assuming -O2 includes them.  And it's not clear to > > It's easier to add thi

Re: [patch] ping1 unbreak bootstrap on FreeBSD ppc

2011-04-12 Thread Andreas Tobler
On 12.04.11 17:06, Joern Rennecke wrote: 2011-03-12 Andreas Tobler * config/rs6000/freebsd.h: (RELOCATABLE_NEEDS_FIXUP): Define in terms of target_flags_explicit. Adjust copyright year. * config.gcc: Add FreeBSD PowerPC soft-float libgcc bits. * config/rs6

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/11 05:54, Bernd Schmidt wrote: > On 04/11/2011 10:03 PM, Jeff Law wrote: >> One of the fundamental problems you have to watch out for when dealing >> with scratch objects is how to handle the case when you belatedly >> realize you want the obj

Re: [PATCH] Fix ICE with C compound literals (PR c/48517)

2011-04-12 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/11/11 13:52, Jakub Jelinek wrote: > Hi! > > On the following testcase build_unary_op ICEs, because > the element type of the array variable (which is TREE_READONLY) > unexpectedly is not TYPE_READONLY. > The problem seems to come from store_init

Re: Fix PR47976

2011-04-12 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/07/11 04:47, Bernd Schmidt wrote: > PR47976 is a followup to PR47166; the patch there caused this problem. > > The problem occurs in reload. There are two autoinc addresses which > inherit from one another, and we delete an insn that is necessar

Added myself to MAINTAINERS (write after approval)

2011-04-12 Thread Yufeng Zhang
Changelog: 2011-04-12 Yufeng Zhang * MAINTAINERS (Write After Approval): Add myself. Regards, Yufeng ZhangIndex: MAINTAINERS === --- MAINTAINERS (revision 172321) +++ MAINTAINERS (working copy) @@ -510,6 +510,7 @@ Joey Y

Re: proposed patch -- remove superflous lines

2011-04-12 Thread Joseph S. Myers
On Tue, 12 Apr 2011, Axel Freyn wrote: > Hi, > > as that's the first time I propose a patch for gcc: sorry for all formal > mistakes (and please tell me what I should do differently ...) > > Those lines were introduced in svn:164531 (22. Sep. 2010), but in > svn:166534 (10. Nov. 2010) the part w

[C++ PATCH] Handle correctly ARRAY_REFs from STRING_CST for wchar_t/char{16,32}_t (PR c++/48570)

2011-04-12 Thread Jakub Jelinek
Hi! As the testcase below shows, cxx_eval_array_reference only works properly if ary is CONSTRUCTOR or narrow STRING_CST, if it is wchar_t/char16_t/char32_t string literal, it still reads a single byte from the string as if it was a char string. The following patch fixes that, bootstrapped/regtes

[PATCH] Don't update_cfg_for_uncondjump for noop non-jump moves

2011-04-12 Thread Jakub Jelinek
On Tue, Apr 12, 2011 at 09:18:01AM +0200, Eric Botcazou wrote: > > The propagate_for_debug change alone could fix it, we should never > > fall through into next basic block. We are unforuntately not deleting > > just jumps (which ought to appear at the end of bbs), but also > > any other noop move

Re: [PATCH] Don't update_cfg_for_uncondjump for noop non-jump moves

2011-04-12 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/11 11:08, Jakub Jelinek wrote: > On Tue, Apr 12, 2011 at 09:18:01AM +0200, Eric Botcazou wrote: >>> The propagate_for_debug change alone could fix it, we should never >>> fall through into next basic block. We are unforuntately not deleting >

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Mike Stump
On Apr 12, 2011, at 4:46 AM, Laurynas Biveinis wrote: >> So what's the plan for the case where you need to change the lifetime of >> an object? > > Copying it. Frankly at the moment I don't how much trouble does deep > copying from scratch to function entails, The code to copy isn't too hard and

Re: [PATCH] Don't update_cfg_for_uncondjump for noop non-jump moves

2011-04-12 Thread Eric Botcazou
> Looks good to me, but please wait for Eric to chime in since you've been > discussing it with him already. Fine with me as well. -- Eric Botcazou

Re: Reintroduce -mflat option on SPARC

2011-04-12 Thread Eric Botcazou
> This patch reintroduce the -mflat option on SPARC. The -mfalt option was > deprecated in february 2004 with GCC 3.4.6. Now, with the support of > LEON processor on GCC, this option has found a new interest. Just a couple of remarks: - the epilogue isn't fully RTL-ized, - delay slot filling for

Re: [patch i386 mingw g++.dg gcc.dg]: Set -mms-bitfields as default for native windows targets

2011-04-12 Thread Richard Henderson
On 04/12/2011 05:47 AM, Kai Tietz wrote: > ChangeLog gcc/ > > * config/i386/mingw32.h (TARGET_SUBTARGET_DEFAULT): Add > MASK_MS_BITFIELD_LAYOUT bit. > > ChangeLog gcc/testsuite > > * g++.dg/ext/bitfield2.C: Add for i?86/x86_64-*-mingw* > targets the additional -mno-ms-bit

ObjC: avoid creating temporary nodes just to compare method signatures

2011-04-12 Thread Nicola Pero
This patch fixes another inefficiency in the Objective-C compiler. When it was comparing method signatures, it would copy all the argument types into some temporary node chains, and then compare these copies. The copies are then thrown away. It all seems really pointless (since you can just acce

Re: Convert legacy m68k options to .opt aliases

2011-04-12 Thread Gunther Nikl
Joseph S. Myers wrote: > On Thu, 7 Apr 2011, Gunther Nikl wrote: > >>> an alias for -mcpu=68332 rather than -mcpu=cpu32, to match the old >>> code in m68k_handle_option.) This significantly simplifies the >>> multilibs code in t-mlibs, since it no longer needs to handle those >>> old-style option

Re: [Patch, libfortran] Don't define _GNU_SOURCE in AM_CPPFLAGS

2011-04-12 Thread Janne Blomqvist
On Tue, Apr 12, 2011 at 09:31, Ralf Wildenhues wrote: > Hi Janne, > > * Janne Blomqvist wrote on Mon, Apr 11, 2011 at 10:34:58PM CEST: >> the attached patch removes the definition of _GNU_SOURCE from >> AM_CPPFLAGS. This is not needed anymore since nowadays we're calling >> AC_USE_SYSTEM_EXTENSION

ObjC: get rid of temporary tree list when compiling a method

2011-04-12 Thread Nicola Pero
This fixes another small inefficiency in the Objective-C compiler. When a method invocation is found, and the parser calls objc_build_method_expr() to compile it, it used to invoke it as in objc_build_message_expr (build_tree_list (rec, args)); this (trivial) patch removes the need to create t

Don't use linux.h for non-Linux targets

2011-04-12 Thread Joseph S. Myers
This patch stops targets not using the Linux kernel from using linux*.h config headers. gnu-user.h has TARGET_C99_FUNCTIONS and TARGET_HAS_SINCOS added (defined to 1, overridden in linux.h) so that the non-Linux targets do not need to have any libc-choice-related definitions from linux.h and confi

Re: ObjC: avoid creating temporary nodes just to compare method signatures

2011-04-12 Thread Mike Stump
On Apr 12, 2011, at 11:04 AM, Nicola Pero wrote: > This patch fixes another inefficiency in the Objective-C compiler. > Ok to commit ? Ok.

Re: ObjC: get rid of temporary tree list when compiling a method

2011-04-12 Thread Mike Stump
On Apr 12, 2011, at 11:37 AM, Nicola Pero wrote: > This fixes another small inefficiency in the Objective-C compiler. > > It's more about cleaning up the codebase and migrating it from Lisp to C. You do know that we are reimplementing gcc in lisp, right? ^L It's a joke, just a joke. > Ok to

Go patch committed: Call cgraph_get_node

2011-04-12 Thread Ian Lance Taylor
This patch to the Go frontend brings it up to date with Martin's change to the cgraph code. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r cc9719612058 go/gogo-tree.cc --- a/go/gogo-tree.cc Thu Apr 07 10:07:32 2011 -0700 +++ b/go/gogo-tree.cc T

[Patch, libfortran] Type cleanup

2011-04-12 Thread Janne Blomqvist
Hi, the attached patch does a bit of janitorial type cleanup for the library. It replaces the use of ssize_t with ptrdiff_t or index_type where appropriate; this is entirely for documentation purposes, as on all targets we support ssize_t == ptrdiff_t. ssize_t is a POSIX type used in the IO funct

Re: [patch i386 mingw g++.dg gcc.dg]: Set -mms-bitfields as default for native windows targets

2011-04-12 Thread Kai Tietz
2011/4/12 Richard Henderson : > On 04/12/2011 05:47 AM, Kai Tietz wrote: >> ChangeLog gcc/ >> >>       * config/i386/mingw32.h (TARGET_SUBTARGET_DEFAULT): Add >>       MASK_MS_BITFIELD_LAYOUT bit. >> >> ChangeLog gcc/testsuite >> >>       * g++.dg/ext/bitfield2.C: Add for i?86/x86_64-*-mingw* >>  

Re: [patch] Split Parse Timevar (issue4378056)

2011-04-12 Thread Diego Novillo
On Tue, Apr 12, 2011 at 14:49, Lawrence Crowl wrote: > This patch provides more finer, more precise compile time information. > I sent an advisory mail some time ago, and it was good then.  Please > confirm for trunk. The patch looks fine to me, but of course it's Jason the one you need an OK fro

Re: [Patch, libfortran] Type cleanup

2011-04-12 Thread Thomas Koenig
Hi Janne, the attached patch does a bit of janitorial type cleanup for the library. It replaces the use of ssize_t with ptrdiff_t or index_type where appropriate; this is entirely for documentation purposes, as on all targets we support ssize_t == ptrdiff_t. ssize_t is a POSIX type used in the

ObjC: another tiny performance tidyup

2011-04-12 Thread Nicola Pero
This saves a few thousands strlen() calls per compilation by reusing the length of selector strings instead of calculating it again. Ok to commit ? Thanks PS: I'll come back to hashtables later, as they do deserve some discussion. I want to get all the other obvious tiny changes in first. Inde

Re: [testsuite] fix to gcc.target/arm/pr43698.c

2011-04-12 Thread Janis Johnson
On 04/08/2011 04:37 PM, Mike Stump wrote: > On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote: >> Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails >> execution for multilibs whose hardware or simulator doesn't support that >> architecture. > > Ideally, I'd like target people to weigh

[pph] Add debugging for namespace_decl (issue4368079)

2011-04-12 Thread Diego Novillo
This patch adds some debugging support for printing namespace_decls and their associated binding level. Committed to pph branch. 2011-04-12 Diego Novillo * cp-tree.h (print_namespace): Declare. * name-lookup.c (print_namespace): New. * parser.c (cp_debug_print_contex

[pph] Pickle some more language-dependent fields (issue4389050)

2011-04-12 Thread Diego Novillo
In reconstructing pph images, I found some more language-specific fields that we were not pickling. There's a few more that I will be sending shortly. Tested on x86_64. Committed to pph. 2011-04-12 Diego Novillo * pph-streamer-in.c (pph_stream_unpack_value_fields): Unpack

[pph] Reconstruct a header file from a pph image (issue4392047)

2011-04-12 Thread Diego Novillo
This patch, together with the others I sent today, allows us to reconstruct all the symbols and types stored inside a pph image. This is not all we need, but it allows me to get basic declarations and types reconstructed from pph images. This causes ~57 failures in pph.exp. The more problematic

Re: [testsuite] fix to gcc.target/arm/pr43698.c

2011-04-12 Thread Ramana Radhakrishnan
On 12 April 2011 20:16, Janis Johnson wrote: > On 04/08/2011 04:37 PM, Mike Stump wrote: >> On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote: >>> Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails >>> execution for multilibs whose hardware or simulator doesn't support that >>> archite

Re: [testsuite] fix to gcc.target/arm/sync-1.c

2011-04-12 Thread Ramana Radhakrishnan
On 8 April 2011 16:08, Janis Johnson wrote: > Test gcc.target/arm/sync-1.c specifies -march=armv7-a and fails > execution for multilibs whose hardware or simulator doesn't support that > architecture.  The test uses __sync_fetch_and_add, which GCC doesn't > support for all arm targets.  Using the

Re: ObjC: another tiny performance tidyup

2011-04-12 Thread Mike Stump
On Apr 12, 2011, at 12:12 PM, Nicola Pero wrote: > This saves a few thousands strlen() calls per compilation by reusing > the length of selector strings instead of calculating it again. > > Ok to commit ? Ok.

[pph/libcpp] Allow include callback to not read the file (issue4388057)

2011-04-12 Thread Diego Novillo
During pph processing, when we find an included file that we are going to instantiate from an image, we don't want libcpp to stack and read it. I've implemented this by allowing the 'include' callback to return a boolean value. If it returns true, then we call _cpp_stack_include. Otherwise, the

Fix PR47612

2011-04-12 Thread Bernd Schmidt
This fixes a problem on cc0 machines where we split a sequence of insns at a point where we shouldn't - between a cc0 setter and a cc0 user. The fix is simple enough; just make sure not to pick a cc0 setter as the end of such a sequence. The patch below was regression tested on m68k-rtems4.11 by J

Re: Convert legacy m68k options to .opt aliases

2011-04-12 Thread Joseph S. Myers
On Tue, 12 Apr 2011, Gunther Nikl wrote: > I was under the impression that the used (bin-)utils had to offer > required target support (instructions, directives, object file format) > to be usable with GCC. AFAICT newer binutils versions (in my case And command-line options. > >2.9.1) configured

[PATCH, rs6000 committed] Fix PowerPC bootstrap

2011-04-12 Thread Pat Haugen
Discussed the following with Martin on irc to bring rs6000 target up to date with his changes to the cgraph code. Bootstrap/regtest on powerpc64-linux. Committed as obvious. -Pat 2011-04-12 Pat Haugen * config/rs6000/rs6000.c (call_ABI_of_interest): Call cgraph_get_create_

[wwwdocs] Remove XHTML logo from footer and save space

2011-04-12 Thread Gerald Pfeifer
This was inspired by Mike, though he probably doesn't know it. :-) Remove the XHTML button from the standard footer and merge the Last Modified line with the first line, saving a fair amount of space. For those inclined, the dot at the end of the first line still links to the validator. :-) Live

[pph] Test PPH include at global scope. (issue4399041)

2011-04-12 Thread Lawrence Crowl
Add a test to ensure that PPH files are #included at global scope. Initially, this test is XFAIL, as it's a low priority error. Index: gcc/testsuite/ChangeLog.pph 2011-04-12 Lawrence Crowl * g++.dg/pph/y2smother.cc: New. Index: gcc/testsuite/g++.dg/pph/y2smother.cc =

Re: [testsuite] fix to gcc.target/arm/pr43698.c

2011-04-12 Thread Ramana Radhakrishnan
On 12/04/11 20:16, Janis Johnson wrote: On 04/08/2011 04:37 PM, Mike Stump wrote: On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote: Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails execution for multilibs whose hardware or simulator doesn't support that architecture. Ideally, I

Re: [build] Avoid ld -v error message with Sun ld on SPARC

2011-04-12 Thread David Miller
From: Rainer Orth Date: Tue, 12 Apr 2011 15:00:53 +0200 > On Solaris 10, as assembles the test just fine, but ld cannot deal with > gas 2.21 output: > > ld: fatal: relocation error: R_SPARC_GOTDATA_HIX22: file gotdata.o: symbol > : offset 0xff370163 is non-aligned > ld: fatal: relocation error:

[google/integration] Enable lightweight debug checks (issue4402041)

2011-04-12 Thread Paul Pluzhnikov
This patch adds lightweight debug checks (if enabled by macros). To be applied only to google/integration branch. Tested by bootstrapping and running "make check". 2011-04-12 Paul Pluzhnikov * libstdc++-v3/include/ext/vstring.h: Enable debug checks when __google_stl_debug_st

Re: [C++ PATCH] Handle correctly ARRAY_REFs from STRING_CST for wchar_t/char{16,32}_t (PR c++/48570)

2011-04-12 Thread Jason Merrill
On 04/12/2011 01:06 PM, Jakub Jelinek wrote: +: (unsigned)TREE_STRING_LENGTH (ary) + * (TYPE_PRECISION (TREE_TYPE (TREE_TYPE (ary))) + / TYPE_PRECISION (char_type_node))); Don't you mean / instead of * here? Let's also calculate the size of the element once rather

Fix 20020425-1.c

2011-04-12 Thread Mike Stump
This fixes 20020425-1.c when the compiler under test is built with -O0 and we're on a machine with an 8 meg stack. Ok? 2011-04-12 Mike Stump * c-typeck.c (c_finish_if_stmt): Fold result. * fold-const.c (fold_ternary_loc): Handle an empty else. This fixes 20020425-1.c so that

Re: Fix PR47612

2011-04-12 Thread Michael Matz
Hi, On Tue, 12 Apr 2011, Bernd Schmidt wrote: > This fixes a problem on cc0 machines where we split a sequence of insns > at a point where we shouldn't - between a cc0 setter and a cc0 user. > > The fix is simple enough; just make sure not to pick a cc0 setter as the > end of such a sequence. Th

Re: Fix PR47612

2011-04-12 Thread Bernd Schmidt
On 04/13/2011 01:45 AM, Michael Matz wrote: > And is there any chance to transform this: > > +#ifdef HAVE_cc0 > + if (!sets_cc0_p (insn)) > +#endif > + max_to = insn; > > into this: > > + if (!sets_cc0_p (insn)) > max_to = insn; > > ? Yes, that implies mak

Re: Add debugging functions for cp_parser (issue4389045)

2011-04-12 Thread crowl
One oddity, otherwise LGTM. http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c File gcc/cp/parser.c (right): http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375 gcc/cp/parser.c:375: if (flag) This code will never print "false", so why have it? http://codereview.ap

Re: [wwwdocs] Remove XHTML logo from footer and save space

2011-04-12 Thread Mike Stump
On Apr 12, 2011, at 2:23 PM, Gerald Pfeifer wrote: > This was inspired by Mike, though he probably doesn't know it. :-) I recall the conversation... :-) Arguably, having a pre-commit hook would be even more whiz-bang.

Re: [pph] Pickle some more language-dependent fields (issue4389050)

2011-04-12 Thread Lawrence Crowl
LGTM On 4/12/11, Diego Novillo wrote: > > In reconstructing pph images, I found some more language-specific > fields that we were not pickling. There's a few more that I will be > sending shortly. > > Tested on x86_64. Committed to pph. > > > 2011-04-12 Diego Novillo > > * pph-streamer

Re: [pph] Reconstruct a header file from a pph image (issue4392047)

2011-04-12 Thread Lawrence Crowl
LGTM On 4/12/11, Diego Novillo wrote: > > This patch, together with the others I sent today, allows us to > reconstruct all the symbols and types stored inside a pph image. This > is not all we need, but it allows me to get basic declarations and > types reconstructed from pph images. > > This c

Re: [google/integration] Enable lightweight debug checks (issue4402041)

2011-04-12 Thread Diego Novillo
On Tue, Apr 12, 2011 at 18:56, Paul Pluzhnikov wrote: > This patch adds lightweight debug checks (if enabled by macros). > > To be applied only to google/integration branch. > > Tested by bootstrapping and running "make check". > > > 2011-04-12  Paul Pluzhnikov   > >        * libstdc++-v3/include/

Re: [pph/libcpp] Allow include callback to not read the file (issue4388057)

2011-04-12 Thread Lawrence Crowl
This change is not source compatible with existing code using the callbacks (which may not be in the gcc svn). Perhaps a new callback is needed? On 4/12/11, Diego Novillo wrote: > > During pph processing, when we find an included file that we are going > to instantiate from an image, we don't wa

Re: [pph/libcpp] Allow include callback to not read the file (issue4388057)

2011-04-12 Thread Diego Novillo
On Tue, Apr 12, 2011 at 20:41, Lawrence Crowl wrote: > This change is not source compatible with existing code using > the callbacks (which may not be in the gcc svn).  Perhaps a new > callback is needed? Well, it only changes the return value for the callback. Existing users do not really need

Re: Add debugging functions for cp_parser (issue4389045)

2011-04-12 Thread Diego Novillo
On Tue, Apr 12, 2011 at 20:02, wrote: > One oddity, otherwise LGTM. > > > http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c > File gcc/cp/parser.c (right): > > http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375 > gcc/cp/parser.c:375: if (flag) > This code will neve

Re: [PATCH, rs6000 committed] Fix PowerPC bootstrap

2011-04-12 Thread Alan Modra
On Tue, Apr 12, 2011 at 04:00:45PM -0500, Pat Haugen wrote: > --- gcc/config/rs6000/rs6000.c (revision 172327) > +++ gcc/config/rs6000/rs6000.c (working copy) > @@ -7976,7 +7976,7 @@ call_ABI_of_interest (tree fndecl) > return true; > >/* Interesting functions that we are emittin

Re: [PATCH][RFC] Make called function type explicit, make function pointer type conversions useless

2011-04-12 Thread H.J. Lu
On Fri, Apr 8, 2011 at 8:49 AM, Richard Guenther wrote: > > This is the "real" fix for PR46076 that I wanted to persue.  Make > function pointer type conversions useless as to more aggressively > be able to turn indirect into direct calls.  This requires that we > preserve the original type signat

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-04-12 Thread Nathan Froyd
On Thu, Mar 10, 2011 at 11:23:10PM -0500, Nathan Froyd wrote: > Now that we have a structure where not every node might include > TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said > accessors that the argument is properly typed. This requires a number > of changes: http://gcc.g

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-04-12 Thread Diego Novillo
On Tue, Apr 12, 2011 at 22:43, Nathan Froyd wrote: > On Thu, Mar 10, 2011 at 11:23:10PM -0500, Nathan Froyd wrote: >> Now that we have a structure where not every node might include >> TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said >> accessors that the argument is properly t

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-04-12 Thread Ian Lance Taylor
Nathan Froyd writes: > On Thu, Mar 10, 2011 at 11:23:10PM -0500, Nathan Froyd wrote: >> Now that we have a structure where not every node might include >> TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said >> accessors that the argument is properly typed. This requires a number

[google/integration] Enable lightweight debug checks (issue4408041)

2011-04-12 Thread Paul Pluzhnikov
This patch adds lightweight debug checks (if enabled by macros). To be applied only to google/integration branch. Tested by bootstrapping and running "make check". 2011-04-12 Paul Pluzhnikov * libstdc++-v3/include/bits/stl_algo.h: Add comparator debug checks when __google_st

Re: License on gcov-io.c

2011-04-12 Thread Jakub Jelinek
On Wed, Apr 06, 2011 at 04:08:38PM +, Joseph S. Myers wrote: > RMS approved relicensing gcov-io.c, so I've applied this patch to trunk, > 4.6 and 4.5 branch to add the license exception. Perhaps someone with a > 4.4 branch checkout could apply it there as well? Done. > 2011-04-06 Joseph M

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Jakub Jelinek
On Tue, Apr 12, 2011 at 08:33:56AM +0200, Steven Bosscher wrote: > I think all these comments from you "old guys" ;-) are more > discouraging than fair. What Laurynas and Bernd have done, is nothing It is IMHO completely fair to point that the risks this brings in a huge maintainance nightmare are

Re: [PATCH] Fix combiner ICEs after my recent patch (PR rtl-optimization/48549)

2011-04-12 Thread Eric Botcazou
> The propagate_for_debug change alone could fix it, we should never > fall through into next basic block. We are unforuntately not deleting > just jumps (which ought to appear at the end of bbs), but also > any other noop moves, which I think is unintentional, we have > delete_noop_moves that sho

hello

2011-04-12 Thread Vasilis Liaskovitis
hello good news for you thousands of new original products here take a look , it is the best place for Chrisama gift . i had bought some from them , and i like much so i tell you good luck

[Patch ARM] Fix PR48090

2011-04-12 Thread Ramana Radhakrishnan
Hi, This should fix PR48090 and should be applied to all release branches. The first alternative doesn't need an early clobber since it is tied to operand 0 - the second alternative however does need one. This is a bug that manifests itself with a particular set of command line options and it

Re: [PATCH] Fix combiner ICEs after my recent patch (PR rtl-optimization/48549)

2011-04-12 Thread Jakub Jelinek
On Tue, Apr 12, 2011 at 09:18:01AM +0200, Eric Botcazou wrote: > > With the second patch, bootstrap succeeded even with gcc_assert (at_end); > > in update_cfg_for_uncondjump, so either it is always at the end, or at > > least very often, thus perhaps with the second patch being applied > > in combi

Re: [PATCH] Fix combiner ICEs after my recent patch (PR rtl-optimization/48549)

2011-04-12 Thread Eric Botcazou
> That is because propagate_for_debug stops at the insn before last, doesn't > process last any longer. So, if there is a DEBUG_INSN right before the > jump being deleted, and it has been propagated into, after the jump is > deleted and retry is done at i2 earlier, following propagate_for_debug >

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Steven Bosscher
On Tue, Apr 12, 2011 at 9:01 AM, Jakub Jelinek wrote: > On Tue, Apr 12, 2011 at 08:33:56AM +0200, Steven Bosscher wrote: >> I think all these comments from you "old guys" ;-) are more >> discouraging than fair. What Laurynas and Bernd have done, is nothing > > It is IMHO completely fair to point t

[v3] libstdc++/48566

2011-04-12 Thread Paolo Carlini
Hi, tested x86_64-linux, committed mainline and 4_6-branch. Paolo. /// 2011-04-12 Allan McRae PR libstdc++/48566 * testsuite/tr1/6_containers/unordered_map/requirements/ iterator_null_neg.cc: Include . * testsuite/tr1/6_containers/unordered_se

Re: [PATCH][ARM] Thumb2 constant loading optimization

2011-04-12 Thread Andrew Stubbs
Ping. On 08/12/10 13:00, Andrew Stubbs wrote: Here is a patch I'd like reviewed for mainline GCC post 4.6. I don't think it's suitable for stage 3. At present, the support for constant loading via immediate operands (as opposed to constant pools) is not well tuned for Thumb2. There are a few se

Re: [Patch ARM] Fix PR48090

2011-04-12 Thread Richard Earnshaw
On Tue, 2011-04-12 at 09:05 +0100, Ramana Radhakrishnan wrote: > Hi, > > This should fix PR48090 and should be applied to all release branches. > The first alternative doesn't need an early clobber since it is tied to > operand 0 - the second alternative however does need one. This is a bug >

Re: [PATCH][ARM] Thumb2 constant loading optimization

2011-04-12 Thread Richard Earnshaw
On Wed, 2010-12-08 at 13:00 +, Andrew Stubbs wrote: > Here is a patch I'd like reviewed for mainline GCC post 4.6. I don't > think it's suitable for stage 3. > > At present, the support for constant loading via immediate operands (as > opposed to constant pools) is not well tuned for Thumb2

Re: [PATCH][ARM] Thumb2 constant loading optimization

2011-04-12 Thread Andrew Stubbs
[Ignoring the other issues for now ...] On 12/04/11 11:02, Richard Earnshaw wrote: Also, your change to use a double-letter sequence beginning with 'j' means any hand-written inline assembly code using a single 'j' will break (that's a backwards compatibility issue for users); is there really no

Ping for cannot_force_const_mem & LEGITIMATE_CONSTANT_P changes

2011-04-12 Thread Richard Sandiford
Ping for these two changes: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00194.html http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00195.html They just add a mode argument to TARGET_CANNOT_FORCE_CONST_MEM and LEGITIMATE_CONSTANT_P (turning the latter into a hook). This is directly needed fo

[v3] Fix libstdc++/48476

2011-04-12 Thread Paolo Carlini
Hi, barring issues over the next days, will go in 4_6-branch too. Tested x86_64-linux, committed to mainline. Paolo. 2011-04-12 Takaya Saito PR libstdc++/48476 * include/std/tuple (_Tuple_impl<>::_Tuple_impl(_Tuple_impl<>&&), _Tuple_impl<>:

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Mike Stump
On Apr 12, 2011, at 1:45 AM, Steven Bosscher wrote: > On Tue, Apr 12, 2011 at 9:01 AM, Jakub Jelinek wrote: >> On Tue, Apr 12, 2011 at 08:33:56AM +0200, Steven Bosscher wrote: >>> I think all these comments from you "old guys" ;-) are more >>> discouraging than fair. What Laurynas and Bernd have d

Re: [PATCH][RFC] Make called function type explicit, make function pointer type conversions useless

2011-04-12 Thread Richard Guenther
On Mon, 11 Apr 2011, Diego Novillo wrote: > On Fri, Apr 8, 2011 at 11:49, Richard Guenther wrote: > > > I'll leave this for comments over the weekend, and if there are none > > will go ahead and check this in early next week. > > The approach looks fine to me. Thanks. I have now applied this

Ping: Some remodelling of the ARM vld and vst patterns

2011-04-12 Thread Richard Sandiford
Ping for this change to the NEON vldN and vstN patterns: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01996.html Thanks, Richard

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Steven Bosscher
On Tue, Apr 12, 2011 at 12:44 PM, Mike Stump wrote: >>   - If objects stored in PCH have pointers pointing outside of >> PCH-able/GC-managed memory, these become wild pointers on PCH read even with >> GTY((skip)) applied properly. However, not all GTY((skip)) pointers point >> outside of PCH-ab

Re: [PATCH] Fix combiner ICEs after my recent patch (PR rtl-optimization/48549)

2011-04-12 Thread Jakub Jelinek
On Tue, Apr 12, 2011 at 10:29:57AM +0200, Eric Botcazou wrote: > > 2011-04-12 Jakub Jelinek > > > > PR rtl-optimization/48549 > > * combine.c (propagate_for_debug): Also stop after BB_END of > > this_basic_block. Process LAST and just stop processing after it. > > (combine_instr

Commit: V850: Fix generation of callt helper functions for interrupt handlers

2011-04-12 Thread Nick Clifton
Hi Guys, I am applying the patch below to the 4.6 branch and mainline sources. It fixes a problem with the V850 backend where it would generate a CALLT instruction for a V850 variant which does not support it, when gcc was compiling an interrupt handler. Cheers Nick gcc/ChangeLog 2011-

Re: Ping: Some remodelling of the ARM vld and vst patterns

2011-04-12 Thread Nick Clifton
Hi Richard, > gcc/ >* config/arm/arm.c (arm_print_operand): Use MEM_SIZE to get the >size of a '%A' memory reference. >(T_DREG, T_QREG): New neon_builtin_type_bits. >(arm_init_neon_builtins): Assert that the load and store operands >are neon_struct_operands. >(locate_neon_

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Laurynas Biveinis
> So what's the plan for the case where you need to change the lifetime of > an object? Copying it. Frankly at the moment I don't how much trouble does deep copying from scratch to function entails, as mentioned in your other e-mail. ATM I am working at separating permanent from function. If it tu

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Laurynas Biveinis
[Resending with the correct Mike's address, sorry for the spam] > So what's the plan for the case where you need to change the lifetime of > an object? Copying it. Frankly at the moment I don't how much trouble does deep copying from scratch to function entails, as mentioned in your other e-mail.

Re: Implement stack arrays even for unknown sizes

2011-04-12 Thread Michael Matz
Hello, On Mon, 11 Apr 2011, Steven Bosscher wrote: > > Try this patch.  I've verified that capacita and nf work with it and > > -march=native -ffast-math -funroll-loops -fstack-arrays -O3 .  In fact all > > of polyhedron works for me on these flags.  (I've set a ulimit -s of > > 512MB, but I don'

Re: [gc-improv] Permanent vs function RTL obstack fix

2011-04-12 Thread Bernd Schmidt
On 04/11/2011 10:03 PM, Jeff Law wrote: > One of the fundamental problems you have to watch out for when dealing > with scratch objects is how to handle the case when you belatedly > realize you want the object to have a longer lifetime. Historically, our problems with obstacks were a consequence

  1   2   >