Re: [PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Jim Meyering
Janne Blomqvist wrote: ... >> Hi Janne, >> >> These requested changes are in addition to (and independent of) >> the changes that I've already posted here. > > Yes, it was perhaps a bit unreasonable to ask you to fix this. OTOH > with your changes gfc_free() was just a wrapper around free() and > s

Re: [PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Janne Blomqvist
On Tue, Mar 15, 2011 at 12:02, Jim Meyering wrote: > Janne Blomqvist wrote: >> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: >>> Relative to v2, I've added libgo/ to the list of exempt directories and >>> added >>> this recently discussed gfc_free patch, at the request of Tobias Burnus. >>>

Re: [PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Jim Meyering
Jakub Jelinek wrote: > On Tue, Mar 15, 2011 at 11:02:38AM +0100, Jim Meyering wrote: >> > Instead of "please let us know", maybe recommend using >> > __builtin_expect instead? E.g. something like >> > >> > if (__builtin_expect (ptr != NULL, 0)) >> > free (ptr); >> >> Good idea. Thanks. >> Thou

Re: [PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Jakub Jelinek
On Tue, Mar 15, 2011 at 11:02:38AM +0100, Jim Meyering wrote: > > Instead of "please let us know", maybe recommend using > > __builtin_expect instead? E.g. something like > > > > if (__builtin_expect (ptr != NULL, 0)) > > free (ptr); > > Good idea. Thanks. > Though how about avoiding the doub