On Tue, Mar 15, 2011 at 12:02, Jim Meyering <j...@meyering.net> wrote: > Janne Blomqvist wrote: >> On Tue, Mar 8, 2011 at 19:53, Jim Meyering <j...@meyering.net> wrote: >>> Relative to v2, I've added libgo/ to the list of exempt directories and >>> added >>> this recently discussed gfc_free patch, at the request of Tobias Burnus. >>> Also, I corrected an error in fortran's ChangeLog and removed all >>> whitespace changes from all ChangeLog files. >> >> The libgfortran changes are Ok for 4.7. >> >> For the gfortran frontend (gcc/fortran/*) I'd prefer if you'd >> >> - Replace all calls to "gfc_free (x)" with "free (x)". >> - Remove the gfc_free() function and prototype. >> - Remove the free() macro which currently prevents calling free() directly. > > Hi Janne, > > These requested changes are in addition to (and independent of) > the changes that I've already posted here.
Yes, it was perhaps a bit unreasonable to ask you to fix this. OTOH with your changes gfc_free() was just a wrapper around free() and should thus be removed as unnecessary. Also, I believe this "proper" fix is more in the spirit of the request by Tobias and the message he linked to discussing the removal of gfc_free(). > The first cset below > does your #2 and #3, and the second does #1. I separate them for > review because #1 is completely mechanical, while the others > are manual. You may prefer to combine them before pushing, for > bisection. Let me know if you'd prefer I submit in that form. All 3 changesets are ok for 4.7. I think it's fine to commit them separately if you prefer. If so, preferably in the order #3, #1, #2 in order to keep every revision buildable. Thanks for working on this! -- Janne Blomqvist
