Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-07 Thread Jakub Jelinek
On Tue, Feb 06, 2018 at 11:14:08AM +, Tsimbalist, Igor V wrote: > Coincidentally, I have worked on the same patch. Please look at the patch, I > uploaded it to the bug. The main differences are > > - updated the output messages to be more informative; > - updated the tests and add couple of

Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Paolo Carlini
Hi, On 07/02/2018 01:02, Tsimbalist, Igor V wrote: The issue is known and is covered by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84248. The patch has been posted https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00276.html Ok, thanks, I missed the above. Paolo.

RE: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Tsimbalist, Igor V
> -Original Message- > From: Paolo Carlini [mailto:paolo.carl...@oracle.com] > Sent: Wednesday, February 7, 2018 12:46 AM > To: Tsimbalist, Igor V ; gcc- > patc...@gcc.gnu.org > Cc: Nick Clifton ; hjl.to...@gmail.com; Uros Bizjak > > Subject: Re: PR 84154: Fix ch

Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Paolo Carlini
Hi, on a rather old x86_64-linux machine GCC doesn't build anymore with r257414: libtool: compile:  /xxx/Gcc/svn-dirs/trunk-build/./gcc/xg++ -B/xxx/Gcc/svn-dirs/trunk-build/./gcc/ -nostdinc++ -nostdinc++ -I/xxx/Gcc/svn-dirs/trunk-build/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-g

RE: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Tsimbalist, Igor V
> -Original Message- > From: Rainer Orth [mailto:r...@cebitec.uni-bielefeld.de] > Sent: Tuesday, February 6, 2018 11:50 PM > To: Tsimbalist, Igor V > Cc: gcc-patches@gcc.gnu.org; Nick Clifton ; > hjl.to...@gmail.com; Uros Bizjak > Subject: Re: PR 84154: Fix check

Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Rainer Orth
Hi Igor, > Here is the updated patch. Please note the subject should say PR 84145. the two new testcases FAIL on all non-x86 targets (I've seen that on sparc-sun-solaris2.11, there's a gcc-testresults posting for powerpc64le-unknown-linux-gnu, and PR testsuite/84243 reports it for aarch64-none-li

Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Uros Bizjak
Subject: Re: PR 84154: Fix checking -mibt and -mshstk options for control >> flow protection >> >> Hi Igor, >> >> >> Attached is a potential patch for PR 84145: >> >> >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84145 >> >&

RE: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Tsimbalist, Igor V
> -Original Message- > From: Nick Clifton [mailto:ni...@redhat.com] > Sent: Tuesday, February 6, 2018 1:16 PM > To: Tsimbalist, Igor V ; hjl.to...@gmail.com > Cc: gcc-patches@gcc.gnu.org > Subject: Re: PR 84154: Fix checking -mibt and -mshstk options for control > fl

Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Nick Clifton
Hi Igor, >> Attached is a potential patch for PR 84145: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84145 > Coincidentally, I have worked on the same patch. Great minds, etc :-) > Please look at the patch, I uploaded it to the bug. The main differences are > > - updated the output mes

RE: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Tsimbalist, Igor V
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Nick Clifton > Sent: Monday, February 5, 2018 4:15 PM > To: hjl.to...@gmail.com > Cc: gcc-patches@gcc.gnu.org > Subject: RFA: PR 84154: Fix checking -mib

RFA: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-05 Thread Nick Clifton
Hi H.J. Attached is a potential patch for PR 84145: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84145 The problem was that the code to check that the --mibt and/or -mshstk options have been correctly enabled for control flow protection did not take into account that the wrong option m