> -----Original Message----- > From: Rainer Orth [mailto:r...@cebitec.uni-bielefeld.de] > Sent: Tuesday, February 6, 2018 11:50 PM > To: Tsimbalist, Igor V <igor.v.tsimbal...@intel.com> > Cc: gcc-patches@gcc.gnu.org; Nick Clifton <ni...@redhat.com>; > hjl.to...@gmail.com; Uros Bizjak <ubiz...@gmail.com> > Subject: Re: PR 84154: Fix checking -mibt and -mshstk options for control > flow protection > > Hi Igor, > > > Here is the updated patch. Please note the subject should say PR 84145. > > the two new testcases FAIL on all non-x86 targets (I've seen that on > sparc-sun-solaris2.11, there's a gcc-testresults posting for > powerpc64le-unknown-linux-gnu, and PR testsuite/84243 reports it for > aarch64-none-linux-gnu: > > +FAIL: c-c++-common/fcf-protection-6.c -std=gnu++11 (test for errors, > line ) > +FAIL: c-c++-common/fcf-protection-6.c -std=gnu++11 (test for excess > errors) > +FAIL: c-c++-common/fcf-protection-6.c -std=gnu++14 (test for errors, > line ) > +FAIL: c-c++-common/fcf-protection-6.c -std=gnu++14 (test for excess > errors) > +FAIL: c-c++-common/fcf-protection-6.c -std=gnu++98 (test for errors, > line ) > +FAIL: c-c++-common/fcf-protection-6.c -std=gnu++98 (test for excess > errors) > > Excess errors: > xg++: error: unrecognized command line option '-mshstk' > > +FAIL: c-c++-common/fcf-protection-7.c -std=gnu++11 (test for errors, > line ) > +FAIL: c-c++-common/fcf-protection-7.c -std=gnu++11 (test for excess > errors) > +FAIL: c-c++-common/fcf-protection-7.c -std=gnu++14 (test for errors, > line ) > +FAIL: c-c++-common/fcf-protection-7.c -std=gnu++14 (test for excess > errors) > +FAIL: c-c++-common/fcf-protection-7.c -std=gnu++98 (test for errors, > line ) > +FAIL: c-c++-common/fcf-protection-7.c -std=gnu++98 (test for excess > errors) > > Excess errors: > xg++: error: unrecognized command line option '-mibt' > > I think the right way to handle that is to pass -mshstk resp. -mibt on > x86 only. The following patch does this; tested with the appropriate > runtest invocation on i386-pc-solaris2.11 and sparc-sun-solaris2.11. > > Ok for mainline?
Agree with the fix. Thanks for taking care of this issue. Igor > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2018-02-06 Rainer Orth <r...@cebitec.uni-bielefeld.de> > > PR testsuite/84243 > * c-c++-common/fcf-protection-6.c: Only pass -mshstk on x86 > targets. > * c-c++-common/fcf-protection-7.c: Likewise for -mibt.
