On Tue, Feb 6, 2018 at 3:08 PM, Tsimbalist, Igor V <igor.v.tsimbal...@intel.com> wrote: >> -----Original Message----- >> From: Nick Clifton [mailto:ni...@redhat.com] >> Sent: Tuesday, February 6, 2018 1:16 PM >> To: Tsimbalist, Igor V <igor.v.tsimbal...@intel.com>; hjl.to...@gmail.com >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: PR 84154: Fix checking -mibt and -mshstk options for control >> flow protection >> >> Hi Igor, >> >> >> Attached is a potential patch for PR 84145: >> >> >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84145 >> >> > Coincidentally, I have worked on the same patch. >> >> Great minds, etc :-) >> >> > Please look at the patch, I uploaded it to the bug. The main differences >> > are >> > >> > - updated the output messages to be more informative; >> > - updated the tests and add couple of new tests to check the messages; >> > - fixed a typo in the doc file related to fcf-protection; >> > >> > I am ok with the changes in i386.c but would like to update the messages. >> Could you incorporate my changes and proceed? Or would you like me to >> finish the fix? >> >> If you are happy to finish the fix then please do so. Your fix is >> more thorough than mine, so I am happy to see it go on. Although >> I should say that I am not an x86 maintainer, so I cannot approve >> it. > > Here is the updated patch. Please note the subject should say PR 84145. > > Ok for trunk?
LGTM. Thanks, Uros.
