Re: [patch] PR51347 alias problem

2011-12-12 Thread Aldy Hernandez
This is not correct. First, _ITM_getTMCloneOrIrrevocable should never appear in a __transaction_atomic (_ITM_getTMClone is ok). But the problem here is that it fails to detect the clone because of the alias. This is why we end up with a call to _ITM_getTMCloneOrIrrevocable. Ah, I see. Please

Re: [patch] PR51347 alias problem

2011-12-12 Thread Patrick Marlier
On 12/12/2011 11:19 AM, Aldy Hernandez wrote: Yes the testcase attached in the PR works for me but I can't change the status because I am not the reporter (nor admin). I will close it. Ok thanks. However, the testcase I have added g++.dg/tm/ctor-used.C fails. I can fill another PR but I f

Re: [patch] PR51347 alias problem

2011-12-12 Thread Aldy Hernandez
Yes the testcase attached in the PR works for me but I can't change the status because I am not the reporter (nor admin). I will close it. However, the testcase I have added g++.dg/tm/ctor-used.C fails. I can fill another PR but I found this problem thanks to the PR testcase. If you mean t

Re: [patch] PR51347 alias problem

2011-12-11 Thread Patrick Marlier
On 12/11/2011 09:11 AM, Aldy Hernandez wrote: On 12/10/11 17:13, Patrick Marlier wrote: On 12/10/2011 02:16 PM, Aldy Hernandez wrote: Using the parent node for aliases (as in your patch) makes sense, but I don't see tree_function_versioning() segfaulting as you claim. What I see is estimate_fun

Re: [patch] PR51347 alias problem

2011-12-11 Thread Aldy Hernandez
On 12/10/11 17:13, Patrick Marlier wrote: On 12/10/2011 02:16 PM, Aldy Hernandez wrote: Using the parent node for aliases (as in your patch) makes sense, but I don't see tree_function_versioning() segfaulting as you claim. What I see is estimate_function_body_sizes() Humm you are seeing this I

Re: [patch] PR51347 alias problem

2011-12-10 Thread Patrick Marlier
On 12/10/2011 02:16 PM, Aldy Hernandez wrote: Using the parent node for aliases (as in your patch) makes sense, but I don't see tree_function_versioning() segfaulting as you claim. What I see is estimate_function_body_sizes() Humm you are seeing this I guess: http://gcc.gnu.org/ml/gcc-patches/

Re: [patch] PR51347 alias problem

2011-12-10 Thread Patrick Marlier
On 12/10/2011 02:16 PM, Aldy Hernandez wrote: Using the parent node for aliases (as in your patch) makes sense, but I don't see tree_function_versioning() segfaulting as you claim. What I see is estimate_function_body_sizes() failing because it is trying to analyze an edge that doesn't exist her

Re: [patch] PR51347 alias problem

2011-12-10 Thread Aldy Hernandez
On 12/02/11 19:26, Patrick Marlier wrote: Hi, PR51347 shows up a problem due to the TM IPA rework. tree_function_versioning segfault because the cfg of old_decl (alias) is NULL. Indeed, an alias can get called but tm cg data are in the parent of the alias. [Richard, this one's for you :-)].

[patch] PR51347 alias problem

2011-12-02 Thread Patrick Marlier
Hi, PR51347 shows up a problem due to the TM IPA rework. tree_function_versioning segfault because the cfg of old_decl (alias) is NULL. Indeed, an alias can get called but tm cg data are in the parent of the alias. Bootstrapped and regtested. Thanks, Patrick. ChangeLog 2011-12-02 Patrick