Re: [patch, libgomp] Enable OpenACC GCN testing

2021-06-08 Thread Thomas Schwinge
Hi! On 2019-11-14T16:36:38+, Andrew Stubbs wrote: > This patch adds some necessary bits to enable OpenACC testings for > amdgcn offloading. > --- a/libgomp/testsuite/lib/libgomp.exp > +++ b/libgomp/testsuite/lib/libgomp.exp > +# Return 1 if at least one AMD GCN board is present, and the AMD

Re: [patch, libgomp] Enable OpenACC GCN testing

2019-12-03 Thread Thomas Schwinge
Hi! On 2019-12-03T12:56:49+, Andrew Stubbs wrote: > On 02/12/2019 14:19, Thomas Schwinge wrote: >> Generally, I'm in favor if you'd consider such a thing (that in principle >> is just a copy/adapt of the existing cases) as obvious to commit (even >> more so with your "amdgcn port" maintainer

Re: [patch, libgomp] Enable OpenACC GCN testing

2019-12-03 Thread Andrew Stubbs
On 02/12/2019 14:19, Thomas Schwinge wrote: Generally, I'm in favor if you'd consider such a thing (that in principle is just a copy/adapt of the existing cases) as obvious to commit (even more so with your "amdgcn port" maintainer hat on), especially so given that this has been/is blocking you,

Host/device shared memory (was: [patch, libgomp] Enable OpenACC GCN testing)

2019-12-02 Thread Thomas Schwinge
Hi! On 2019-11-15T13:43:04+0100, Jakub Jelinek wrote: > On Fri, Nov 15, 2019 at 12:38:06PM +, Andrew Stubbs wrote: >> On 15/11/2019 12:21, Jakub Jelinek wrote: >> > I'm surprised by the set acc_mem_shared 0, I thought gcn is a shared memory >> > offloading target. >> >> APUs, such as Carizzo

Re: [patch, libgomp] Enable OpenACC GCN testing

2019-12-02 Thread Thomas Schwinge
Hi Andrew! Sorry for the delay. On 2019-11-14T16:36:38+, Andrew Stubbs wrote: > This patch adds some necessary bits to enable OpenACC testings for > amdgcn offloading. Generally, I'm in favor if you'd consider such a thing (that in principle is just a copy/adapt of the existing cases) as o

Re: [patch, libgomp] Enable OpenACC GCN testing

2019-11-15 Thread Andrew Stubbs
On 15/11/2019 12:43, Jakub Jelinek wrote: APUs, such as Carizzo are shared memory. DGPUs, such as Fiji and Vega, have their own memory. A DGPU can access host memory, provided that it has been set up just so, but that is very slow, and I don't know of a way to do that without still having to copy

Re: [patch, libgomp] Enable OpenACC GCN testing

2019-11-15 Thread Jakub Jelinek
On Fri, Nov 15, 2019 at 12:38:06PM +, Andrew Stubbs wrote: > On 15/11/2019 12:21, Jakub Jelinek wrote: > > On Thu, Nov 14, 2019 at 04:36:38PM +, Andrew Stubbs wrote: > > > This patch adds some necessary bits to enable OpenACC testings for amdgcn > > > offloading. > > > > > > The two "check

Re: [patch, libgomp] Enable OpenACC GCN testing

2019-11-15 Thread Andrew Stubbs
On 15/11/2019 12:21, Jakub Jelinek wrote: On Thu, Nov 14, 2019 at 04:36:38PM +, Andrew Stubbs wrote: This patch adds some necessary bits to enable OpenACC testings for amdgcn offloading. The two "check_effective" procedures are not actually needed yet, but later patches to test cases will u

Re: [patch, libgomp] Enable OpenACC GCN testing

2019-11-15 Thread Jakub Jelinek
On Thu, Nov 14, 2019 at 04:36:38PM +, Andrew Stubbs wrote: > This patch adds some necessary bits to enable OpenACC testings for amdgcn > offloading. > > The two "check_effective" procedures are not actually needed yet, but later > patches to test cases will use them. > > OK to commit? I'm su

[patch, libgomp] Enable OpenACC GCN testing

2019-11-14 Thread Andrew Stubbs
Hi, This patch adds some necessary bits to enable OpenACC testings for amdgcn offloading. The two "check_effective" procedures are not actually needed yet, but later patches to test cases will use them. OK to commit? Thanks Andrew Enable OpenACC GCN testing. 2019-11-14 Andrew Stubbs