On 15/11/2019 12:21, Jakub Jelinek wrote:
On Thu, Nov 14, 2019 at 04:36:38PM +0000, Andrew Stubbs wrote:
This patch adds some necessary bits to enable OpenACC testings for amdgcn
offloading.
The two "check_effective" procedures are not actually needed yet, but later
patches to test cases will use them.
OK to commit?
I'm surprised by the set acc_mem_shared 0, I thought gcn is a shared memory
offloading target.
APUs, such as Carizzo are shared memory. DGPUs, such as Fiji and Vega,
have their own memory. A DGPU can access host memory, provided that it
has been set up just so, but that is very slow, and I don't know of a
way to do that without still having to copy the program data into that
special region.
The patch is OpenACC only and what do I know about OpenACC? ;)
If Thomas is ok with it, the patch is good for trunk.
Thanks anyway.
Andrew
