On Thu, Nov 14, 2019 at 04:36:38PM +0000, Andrew Stubbs wrote:
> This patch adds some necessary bits to enable OpenACC testings for amdgcn
> offloading.
> 
> The two "check_effective" procedures are not actually needed yet, but later
> patches to test cases will use them.
> 
> OK to commit?

I'm surprised by the set acc_mem_shared 0, I thought gcn is a shared memory
offloading target.

The patch is OpenACC only and what do I know about OpenACC? ;)
If Thomas is ok with it, the patch is good for trunk.

> 2019-11-14  Andrew Stubbs  <a...@codesourcery.com>
> 
>       libgomp/
>       * testsuite/lib/libgomp.exp (offload_target_to_openacc_device_type):
>       Recognize amdgcn.
>       (check_effective_target_openacc_amdgcn_accel_present): New proc.
>       (check_effective_target_openacc_amdgcn_accel_selected): New proc.
>       * testsuite/libgomp.oacc-c++/c++.exp: Set acc_mem_shared for amdgcn.
>       * testsuite/libgomp.oacc-c/c.exp: Likewise.
>       * testsuite/libgomp.oacc-fortran/fortran.exp: Likewise.

        Jakub

Reply via email to